2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
require 'lib/gitlab/cycle_analytics/shared_stage_spec'
|
|
|
|
|
|
|
|
describe Gitlab::CycleAnalytics::ReviewStage do
|
|
|
|
let(:stage_name) { :review }
|
2019-09-04 21:01:54 +05:30
|
|
|
let(:project) { create(:project) }
|
2019-10-12 21:52:04 +05:30
|
|
|
let(:issue_1) { create(:issue, project: project, created_at: 90.minutes.ago) }
|
|
|
|
let(:issue_2) { create(:issue, project: project, created_at: 60.minutes.ago) }
|
|
|
|
let(:issue_3) { create(:issue, project: project, created_at: 60.minutes.ago) }
|
|
|
|
let(:mr_1) { create(:merge_request, :closed, source_project: project, created_at: 60.minutes.ago) }
|
|
|
|
let(:mr_2) { create(:merge_request, :closed, source_project: project, created_at: 40.minutes.ago, source_branch: 'A') }
|
|
|
|
let(:mr_3) { create(:merge_request, source_project: project, created_at: 10.minutes.ago, source_branch: 'B') }
|
2019-09-04 21:01:54 +05:30
|
|
|
let!(:mr_4) { create(:merge_request, source_project: project, created_at: 10.minutes.ago, source_branch: 'C') }
|
2019-10-12 21:52:04 +05:30
|
|
|
let(:stage) { described_class.new(options: { from: 2.days.ago, current_user: project.creator, project: project }) }
|
2019-09-04 21:01:54 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
mr_1.metrics.update!(merged_at: 30.minutes.ago)
|
|
|
|
mr_2.metrics.update!(merged_at: 10.minutes.ago)
|
|
|
|
|
|
|
|
create(:merge_requests_closing_issues, merge_request: mr_1, issue: issue_1)
|
|
|
|
create(:merge_requests_closing_issues, merge_request: mr_2, issue: issue_2)
|
|
|
|
create(:merge_requests_closing_issues, merge_request: mr_3, issue: issue_3)
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
|
|
|
|
it_behaves_like 'base stage'
|
2019-09-04 21:01:54 +05:30
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
describe '#project_median' do
|
2019-09-04 21:01:54 +05:30
|
|
|
around do |example|
|
|
|
|
Timecop.freeze { example.run }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'counts median from issues with metrics' do
|
2019-10-12 21:52:04 +05:30
|
|
|
expect(stage.project_median).to eq(ISSUES_MEDIAN)
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#events' do
|
2019-10-12 21:52:04 +05:30
|
|
|
subject { stage.events }
|
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
it 'exposes merge requests that close issues' do
|
2019-10-12 21:52:04 +05:30
|
|
|
expect(subject.count).to eq(2)
|
|
|
|
expect(subject.map { |event| event[:title] }).to contain_exactly(mr_1.title, mr_2.title)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when group is given' do
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:project_2) { create(:project, group: group) }
|
|
|
|
let(:project_3) { create(:project, group: group) }
|
|
|
|
let(:issue_2_1) { create(:issue, project: project_2, created_at: 90.minutes.ago) }
|
|
|
|
let(:issue_2_2) { create(:issue, project: project_3, created_at: 60.minutes.ago) }
|
|
|
|
let(:issue_2_3) { create(:issue, project: project_2, created_at: 60.minutes.ago) }
|
|
|
|
let(:mr_2_1) { create(:merge_request, :closed, source_project: project_2, created_at: 60.minutes.ago) }
|
|
|
|
let(:mr_2_2) { create(:merge_request, :closed, source_project: project_3, created_at: 40.minutes.ago, source_branch: 'A') }
|
|
|
|
let(:mr_2_3) { create(:merge_request, source_project: project_2, created_at: 10.minutes.ago, source_branch: 'B') }
|
|
|
|
let!(:mr_2_4) { create(:merge_request, source_project: project_3, created_at: 10.minutes.ago, source_branch: 'C') }
|
|
|
|
let(:stage) { described_class.new(options: { from: 2.days.ago, current_user: user, group: group }) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
mr_2_1.metrics.update!(merged_at: 30.minutes.ago)
|
|
|
|
mr_2_2.metrics.update!(merged_at: 10.minutes.ago)
|
|
|
|
|
|
|
|
create(:merge_requests_closing_issues, merge_request: mr_2_1, issue: issue_2_1)
|
|
|
|
create(:merge_requests_closing_issues, merge_request: mr_2_2, issue: issue_2_2)
|
|
|
|
create(:merge_requests_closing_issues, merge_request: mr_2_3, issue: issue_2_3)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#group_median' do
|
|
|
|
around do |example|
|
|
|
|
Timecop.freeze { example.run }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'counts median from issues with metrics' do
|
|
|
|
expect(stage.group_median).to eq(ISSUES_MEDIAN)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#events' do
|
|
|
|
subject { stage.events }
|
2019-09-04 21:01:54 +05:30
|
|
|
|
2019-10-12 21:52:04 +05:30
|
|
|
it 'exposes merge requests that close issues' do
|
|
|
|
expect(subject.count).to eq(2)
|
|
|
|
expect(subject.map { |event| event[:title] }).to contain_exactly(mr_2_1.title, mr_2_2.title)
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
end
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|