debian-mirror-gitlab/spec/lib/gitlab/ci/config_spec.rb

580 lines
14 KiB
Ruby
Raw Normal View History

2019-10-12 21:52:04 +05:30
# frozen_string_literal: true
2018-12-13 13:39:08 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Gitlab::Ci::Config do
2019-06-05 12:25:43 +05:30
include StubRequests
2020-04-08 14:13:33 +05:30
let_it_be(:user) { create(:user) }
2019-02-15 15:39:39 +05:30
2019-12-21 20:55:43 +05:30
before do
2020-01-01 13:55:28 +05:30
allow_next_instance_of(Gitlab::Ci::Config::External::Context) do |instance|
allow(instance).to receive(:check_execution_time!)
end
2019-12-21 20:55:43 +05:30
end
let(:config) do
2019-02-15 15:39:39 +05:30
described_class.new(yml, project: nil, sha: nil, user: nil)
end
context 'when config is valid' do
let(:yml) do
<<-EOS
2020-04-22 19:07:51 +05:30
image: ruby:2.7
rspec:
script:
- gem install rspec
- rspec
EOS
end
describe '#to_hash' do
it 'returns hash created from string' do
hash = {
2020-04-22 19:07:51 +05:30
image: 'ruby:2.7',
rspec: {
script: ['gem install rspec',
'rspec']
}
}
expect(config.to_hash).to eq hash
end
describe '#valid?' do
it 'is valid' do
expect(config).to be_valid
end
it 'has no errors' do
expect(config.errors).to be_empty
end
end
end
2019-12-21 20:55:43 +05:30
describe '#stages' do
subject(:subject) { config.stages }
context 'with default stages' do
let(:default_stages) do
%w[.pre build test deploy .post]
end
it { is_expected.to eq default_stages }
end
context 'with custom stages' do
let(:yml) do
<<-EOS
stages:
- stage1
- stage2
job1:
stage: stage1
script:
- ls
EOS
end
it { is_expected.to eq %w[.pre stage1 stage2 .post] }
end
end
2016-08-24 12:49:21 +05:30
end
2018-11-20 20:47:30 +05:30
context 'when using extendable hash' do
let(:yml) do
<<-EOS
2020-04-22 19:07:51 +05:30
image: ruby:2.7
2018-11-20 20:47:30 +05:30
rspec:
script: rspec
test:
extends: rspec
image: ruby:alpine
EOS
end
it 'correctly extends the hash' do
hash = {
2020-04-22 19:07:51 +05:30
image: 'ruby:2.7',
2018-11-20 20:47:30 +05:30
rspec: { script: 'rspec' },
test: {
extends: 'rspec',
image: 'ruby:alpine',
script: 'rspec'
}
}
expect(config).to be_valid
expect(config.to_hash).to eq hash
end
end
2016-08-24 12:49:21 +05:30
context 'when config is invalid' do
context 'when yml is incorrect' do
let(:yml) { '// invalid' }
2016-08-24 12:49:21 +05:30
describe '.new' do
it 'raises error' do
expect { config }.to raise_error(
2018-11-20 20:47:30 +05:30
described_class::ConfigError,
2016-08-24 12:49:21 +05:30
/Invalid configuration format/
)
end
end
2016-08-24 12:49:21 +05:30
end
2019-07-07 11:18:12 +05:30
context 'when yml is too big' do
let(:yml) do
<<~YAML
--- &1
- hi
- *1
YAML
end
describe '.new' do
it 'raises error' do
2020-01-01 13:55:28 +05:30
expect(Gitlab::ErrorTracking).to receive(:track_and_raise_for_dev_exception)
2019-07-07 11:18:12 +05:30
expect { config }.to raise_error(
described_class::ConfigError,
/The parsed YAML is too big/
)
end
end
end
2016-08-24 12:49:21 +05:30
context 'when config logic is incorrect' do
let(:yml) { 'before_script: "ls"' }
2016-08-24 12:49:21 +05:30
describe '#valid?' do
it 'is not valid' do
expect(config).not_to be_valid
end
it 'has errors' do
expect(config.errors).not_to be_empty
end
end
2016-08-24 12:49:21 +05:30
describe '#errors' do
it 'returns an array of strings' do
expect(config.errors).to all(be_an_instance_of(String))
end
end
end
2018-11-20 20:47:30 +05:30
context 'when invalid extended hash has been provided' do
let(:yml) do
<<-EOS
test:
extends: test
script: rspec
EOS
end
it 'raises an error' do
expect { config }.to raise_error(
described_class::ConfigError, /circular dependency detected/
)
end
end
2019-07-07 11:18:12 +05:30
context 'when ports have been set' do
context 'in the main image' do
let(:yml) do
<<-EOS
image:
2020-04-22 19:07:51 +05:30
name: ruby:2.7
2019-07-07 11:18:12 +05:30
ports:
- 80
EOS
end
it 'raises an error' do
expect(config.errors).to include("image config contains disallowed keys: ports")
end
end
context 'in the job image' do
let(:yml) do
<<-EOS
2020-04-22 19:07:51 +05:30
image: ruby:2.7
2019-07-07 11:18:12 +05:30
test:
script: rspec
image:
2020-04-22 19:07:51 +05:30
name: ruby:2.7
2019-07-07 11:18:12 +05:30
ports:
- 80
EOS
end
it 'raises an error' do
expect(config.errors).to include("jobs:test:image config contains disallowed keys: ports")
end
end
context 'in the services' do
let(:yml) do
<<-EOS
2020-04-22 19:07:51 +05:30
image: ruby:2.7
2019-07-07 11:18:12 +05:30
test:
script: rspec
2020-04-22 19:07:51 +05:30
image: ruby:2.7
2019-07-07 11:18:12 +05:30
services:
- name: test
alias: test
ports:
- 80
EOS
end
it 'raises an error' do
expect(config.errors).to include("jobs:test:services:service config contains disallowed keys: ports")
end
end
end
end
2018-12-05 23:21:45 +05:30
context "when using 'include' directive" do
let(:project) { create(:project, :repository) }
2019-12-04 20:38:33 +05:30
let(:remote_location) { 'https://gitlab.com/gitlab-org/gitlab-foss/blob/1234/.gitlab-ci-1.yml' }
2018-12-05 23:21:45 +05:30
let(:local_location) { 'spec/fixtures/gitlab/ci/external_files/.gitlab-ci-template-1.yml' }
let(:remote_file_content) do
<<~HEREDOC
variables:
POSTGRES_USER: user
POSTGRES_PASSWORD: testing-password
POSTGRES_ENABLED: "true"
POSTGRES_DB: $CI_ENVIRONMENT_SLUG
HEREDOC
end
let(:local_file_content) do
File.read(Rails.root.join(local_location))
end
let(:gitlab_ci_yml) do
<<~HEREDOC
include:
- #{local_location}
- #{remote_location}
2020-04-22 19:07:51 +05:30
image: ruby:2.7
2018-12-05 23:21:45 +05:30
HEREDOC
end
let(:config) do
2019-02-15 15:39:39 +05:30
described_class.new(gitlab_ci_yml, project: project, sha: '12345', user: user)
2018-12-05 23:21:45 +05:30
end
before do
2019-06-05 12:25:43 +05:30
stub_full_request(remote_location).to_return(body: remote_file_content)
2018-12-05 23:21:45 +05:30
allow(project.repository)
.to receive(:blob_data_at).and_return(local_file_content)
end
context "when gitlab_ci_yml has valid 'include' defined" do
2019-07-07 11:18:12 +05:30
it 'returns a composed hash' do
2018-12-05 23:21:45 +05:30
before_script_values = [
"apt-get update -qq && apt-get install -y -qq sqlite3 libsqlite3-dev nodejs", "ruby -v",
"which ruby",
"bundle install --jobs $(nproc) \"${FLAGS[@]}\""
]
variables = {
POSTGRES_USER: "user",
POSTGRES_PASSWORD: "testing-password",
POSTGRES_ENABLED: "true",
POSTGRES_DB: "$CI_ENVIRONMENT_SLUG"
}
composed_hash = {
before_script: before_script_values,
2020-04-22 19:07:51 +05:30
image: "ruby:2.7",
2018-12-05 23:21:45 +05:30
rspec: { script: ["bundle exec rspec"] },
variables: variables
}
expect(config.to_hash).to eq(composed_hash)
end
end
2019-03-02 22:35:43 +05:30
context "when gitlab_ci.yml has invalid 'include' defined" do
2018-12-05 23:21:45 +05:30
let(:gitlab_ci_yml) do
<<~HEREDOC
include: invalid
HEREDOC
end
2020-11-24 15:15:51 +05:30
it 'raises ConfigError' do
2018-12-05 23:21:45 +05:30
expect { config }.to raise_error(
2018-12-13 13:39:08 +05:30
described_class::ConfigError,
"Included file `invalid` does not have YAML extension!"
2018-12-05 23:21:45 +05:30
)
end
end
2019-03-02 22:35:43 +05:30
context "when gitlab_ci.yml has ambigious 'include' defined" do
2019-02-15 15:39:39 +05:30
let(:gitlab_ci_yml) do
<<~HEREDOC
include:
remote: http://url
local: /local/file.yml
HEREDOC
end
2020-11-24 15:15:51 +05:30
it 'raises ConfigError' do
2019-02-15 15:39:39 +05:30
expect { config }.to raise_error(
described_class::ConfigError,
'Include `{"remote":"http://url","local":"/local/file.yml"}` needs to match exactly one accessor!'
)
end
end
2019-12-21 20:55:43 +05:30
context "when it takes too long to evaluate includes" do
before do
2020-01-01 13:55:28 +05:30
allow_next_instance_of(Gitlab::Ci::Config::External::Context) do |instance|
allow(instance).to receive(:check_execution_time!).and_call_original
allow(instance).to receive(:set_deadline).with(described_class::TIMEOUT_SECONDS).and_call_original
allow(instance).to receive(:execution_expired?).and_return(true)
end
2019-12-21 20:55:43 +05:30
end
it 'raises error TimeoutError' do
2020-01-01 13:55:28 +05:30
expect(Gitlab::ErrorTracking).to receive(:track_and_raise_for_dev_exception)
2019-12-21 20:55:43 +05:30
expect { config }.to raise_error(
described_class::ConfigError,
'Resolving config took longer than expected'
)
end
end
2018-12-05 23:21:45 +05:30
describe 'external file version' do
context 'when external local file SHA is defined' do
it 'is using a defined value' do
expect(project.repository).to receive(:blob_data_at)
.with('eeff1122', local_location)
2019-02-15 15:39:39 +05:30
described_class.new(gitlab_ci_yml, project: project, sha: 'eeff1122', user: user)
2018-12-05 23:21:45 +05:30
end
end
context 'when external local file SHA is not defined' do
it 'is using latest SHA on the default branch' do
expect(project.repository).to receive(:root_ref_sha)
2019-02-15 15:39:39 +05:30
described_class.new(gitlab_ci_yml, project: project, sha: nil, user: user)
2018-12-05 23:21:45 +05:30
end
end
end
context "when both external files and gitlab_ci.yml defined the same key" do
let(:gitlab_ci_yml) do
<<~HEREDOC
include:
- #{remote_location}
2020-04-22 19:07:51 +05:30
image: ruby:2.7
2018-12-05 23:21:45 +05:30
HEREDOC
end
let(:remote_file_content) do
<<~HEREDOC
image: php:5-fpm-alpine
HEREDOC
end
2019-07-07 11:18:12 +05:30
it 'takes precedence' do
2020-04-22 19:07:51 +05:30
expect(config.to_hash).to eq({ image: 'ruby:2.7' })
2018-12-05 23:21:45 +05:30
end
end
context "when both external files and gitlab_ci.yml define a dictionary of distinct variables" do
let(:remote_file_content) do
<<~HEREDOC
variables:
A: 'alpha'
B: 'beta'
HEREDOC
end
let(:gitlab_ci_yml) do
<<~HEREDOC
include:
- #{remote_location}
variables:
C: 'gamma'
D: 'delta'
HEREDOC
end
2019-07-07 11:18:12 +05:30
it 'merges the variables dictionaries' do
2018-12-05 23:21:45 +05:30
expect(config.to_hash).to eq({ variables: { A: 'alpha', B: 'beta', C: 'gamma', D: 'delta' } })
end
end
context "when both external files and gitlab_ci.yml define a dictionary of overlapping variables" do
let(:remote_file_content) do
<<~HEREDOC
variables:
A: 'alpha'
B: 'beta'
C: 'omnicron'
HEREDOC
end
let(:gitlab_ci_yml) do
<<~HEREDOC
include:
- #{remote_location}
variables:
C: 'gamma'
D: 'delta'
HEREDOC
end
it 'later declarations should take precedence' do
expect(config.to_hash).to eq({ variables: { A: 'alpha', B: 'beta', C: 'gamma', D: 'delta' } })
end
end
context 'when both external files and gitlab_ci.yml define a job' do
let(:remote_file_content) do
<<~HEREDOC
job1:
script:
- echo 'hello from remote file'
HEREDOC
end
let(:gitlab_ci_yml) do
<<~HEREDOC
include:
- #{remote_location}
job1:
variables:
VARIABLE_DEFINED_IN_MAIN_FILE: 'some value'
HEREDOC
end
it 'merges the jobs' do
expect(config.to_hash).to eq({
job1: {
script: ["echo 'hello from remote file'"],
variables: {
VARIABLE_DEFINED_IN_MAIN_FILE: 'some value'
}
}
})
end
context 'when the script key is in both' do
let(:gitlab_ci_yml) do
<<~HEREDOC
include:
- #{remote_location}
job1:
script:
- echo 'hello from main file'
variables:
VARIABLE_DEFINED_IN_MAIN_FILE: 'some value'
HEREDOC
end
it 'uses the script from the gitlab_ci.yml' do
expect(config.to_hash).to eq({
job1: {
script: ["echo 'hello from main file'"],
variables: {
VARIABLE_DEFINED_IN_MAIN_FILE: 'some value'
}
}
})
end
end
end
2020-04-08 14:13:33 +05:30
context 'when including file from artifact' do
let(:config) do
described_class.new(
gitlab_ci_yml,
project: nil,
sha: nil,
user: nil,
parent_pipeline: parent_pipeline)
end
let(:gitlab_ci_yml) do
<<~HEREDOC
include:
- artifact: generated.yml
job: rspec
HEREDOC
end
let(:parent_pipeline) { nil }
context 'when used in the context of a child pipeline' do
# This job has ci_build_artifacts.zip artifact archive which
# contains generated.yml
let!(:job) { create(:ci_build, :artifacts, name: 'rspec', pipeline: parent_pipeline) }
let(:parent_pipeline) { create(:ci_pipeline) }
it 'returns valid config' do
expect(config).to be_valid
end
context 'when job key is missing' do
let(:gitlab_ci_yml) do
<<~HEREDOC
include:
- artifact: generated.yml
HEREDOC
end
it 'raises an error' do
expect { config }.to raise_error(
described_class::ConfigError,
'Job must be provided when including configs from artifacts'
)
end
end
context 'when artifact key is missing' do
let(:gitlab_ci_yml) do
<<~HEREDOC
include:
- job: rspec
HEREDOC
end
it 'raises an error' do
expect { config }.to raise_error(
described_class::ConfigError,
/needs to match exactly one accessor!/
)
end
end
end
it 'disallows the use in parent pipelines' do
expect { config }.to raise_error(
described_class::ConfigError,
'Including configs from artifacts is only allowed when triggering child pipelines'
)
end
end
2018-12-05 23:21:45 +05:30
end
end