debian-mirror-gitlab/doc/development/geo/framework.md

1047 lines
33 KiB
Markdown
Raw Normal View History

2021-01-03 14:25:43 +05:30
---
stage: Enablement
group: Geo
2021-02-22 17:27:13 +05:30
info: To determine the technical writer assigned to the Stage/Group associated with this page, see https://about.gitlab.com/handbook/engineering/ux/technical-writing/#assignments
2021-01-03 14:25:43 +05:30
---
2021-01-29 00:20:46 +05:30
# Geo self-service framework
2020-03-13 15:44:24 +05:30
2021-02-22 17:27:13 +05:30
NOTE:
2021-01-29 00:20:46 +05:30
This document is subject to change as we continue to implement and iterate on the framework.
Follow the progress in the [epic](https://gitlab.com/groups/gitlab-org/-/epics/2161).
If you need to replicate a new data type, reach out to the Geo
2020-03-13 15:44:24 +05:30
team to discuss the options. You can contact them in `#g_geo` on Slack
or mention `@geo-team` in the issue or merge request.
Geo provides an API to make it possible to easily replicate data types
across Geo nodes. This API is presented as a Ruby Domain-Specific
Language (DSL) and aims to make it possible to replicate data with
minimal effort of the engineer who created a data type.
## Nomenclature
Before digging into the API, developers need to know some Geo-specific
2021-01-29 00:20:46 +05:30
naming conventions:
2020-03-13 15:44:24 +05:30
2021-01-29 00:20:46 +05:30
- **Model**:
A model is an Active Model, which is how it is known in the entire
2020-03-13 15:44:24 +05:30
Rails codebase. It usually is tied to a database table. From Geo
perspective, a model can have one or more resources.
2021-01-29 00:20:46 +05:30
- **Resource**:
A resource is a piece of data that belongs to a model and is
2020-03-13 15:44:24 +05:30
produced by a GitLab feature. It is persisted using a storage
2021-01-29 00:20:46 +05:30
mechanism. By default, a resource is not a Geo replicable.
2020-03-13 15:44:24 +05:30
2021-01-29 00:20:46 +05:30
- **Data type**:
Data type is how a resource is stored. Each resource should
2020-03-13 15:44:24 +05:30
fit in one of the data types Geo supports:
2021-01-29 00:20:46 +05:30
- Git repository
- Blob
- Database
For more detail, see [Data types](../../administration/geo/replication/datatypes.md).
2020-03-13 15:44:24 +05:30
2021-01-29 00:20:46 +05:30
- **Geo Replicable**:
A Replicable is a resource Geo wants to sync across Geo nodes. There
2020-03-13 15:44:24 +05:30
is a limited set of supported data types of replicables. The effort
required to implement replication of a resource that belongs to one
of the known data types is minimal.
2021-01-29 00:20:46 +05:30
- **Geo Replicator**:
A Geo Replicator is the object that knows how to replicate a
2020-03-13 15:44:24 +05:30
replicable. It's responsible for:
2021-01-29 00:20:46 +05:30
- Firing events (producer)
- Consuming events (consumer)
It's tied to the Geo Replicable data type. All replicators have a
2020-03-13 15:44:24 +05:30
common interface that can be used to process (that is, produce and
consume) events. It takes care of the communication between the
primary node (where events are produced) and the secondary node
(where events are consumed). The engineer who wants to incorporate
Geo in their feature will use the API of replicators to make this
happen.
2021-01-29 00:20:46 +05:30
- **Geo Domain-Specific Language**:
The syntactic sugar that allows engineers to easily specify which
2020-03-13 15:44:24 +05:30
resources should be replicated and how.
## Geo Domain-Specific Language
### The replicator
First of all, you need to write a replicator. The replicators live in
[`ee/app/replicators/geo`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/app/replicators/geo).
For each resource that needs to be replicated, there should be a
separate replicator specified, even if multiple resources are tied to
the same model.
For example, the following replicator replicates a package file:
```ruby
module Geo
class PackageFileReplicator < Gitlab::Geo::Replicator
# Include one of the strategies your resource needs
include ::Geo::BlobReplicatorStrategy
# Specify the CarrierWave uploader needed by the used strategy
def carrierwave_uploader
model_record.file
end
# Specify the model this replicator belongs to
2020-05-24 23:13:21 +05:30
def self.model
2020-03-13 15:44:24 +05:30
::Packages::PackageFile
end
2020-10-24 23:57:45 +05:30
# The feature flag follows the format `geo_#{replicable_name}_replication`,
# so here it would be `geo_package_file_replication`
def self.replication_enabled_by_default?
false
end
2020-03-13 15:44:24 +05:30
end
end
```
The class name should be unique. It also is tightly coupled to the
table name for the registry, so for this example the registry table
will be `package_file_registry`.
For the different data types Geo supports there are different
strategies to include. Pick one that fits your needs.
### Linking to a model
To tie this replicator to the model, you need to add the following to
the model code:
```ruby
class Packages::PackageFile < ApplicationRecord
include ::Gitlab::Geo::ReplicableModel
with_replicator Geo::PackageFileReplicator
end
```
### API
When this is set in place, it's easy to access the replicator through
the model:
```ruby
2020-11-24 15:15:51 +05:30
package_file = Packages::PackageFile.find(4) # just a random ID as example
2020-03-13 15:44:24 +05:30
replicator = package_file.replicator
```
Or get the model back from the replicator:
```ruby
replicator.model_record
=> <Packages::PackageFile id:4>
```
The replicator can be used to generate events, for example in
2021-01-29 00:20:46 +05:30
`ActiveRecord` hooks:
2020-03-13 15:44:24 +05:30
```ruby
after_create_commit -> { replicator.publish_created_event }
```
#### Library
The framework behind all this is located in
[`ee/lib/gitlab/geo/`](https://gitlab.com/gitlab-org/gitlab/-/tree/master/ee/lib/gitlab/geo).
2020-04-08 14:13:33 +05:30
## Existing Replicator Strategies
Before writing a new kind of Replicator Strategy, check below to see if your
resource can already be handled by one of the existing strategies. Consult with
the Geo team if you are unsure.
### Blob Replicator Strategy
Models that use
[CarrierWave's](https://github.com/carrierwaveuploader/carrierwave) `Uploader::Base`
can be easily supported by Geo with the `Geo::BlobReplicatorStrategy` module.
First, each file should have its own primary ID and model. Geo strongly
recommends treating *every single file* as a first-class citizen, because in
our experience this greatly simplifies tracking replication and verification
state.
For example, to add support for files referenced by a `Widget` model with a
`widgets` table, you would perform the following steps:
2020-05-24 23:13:21 +05:30
#### Replication
2020-04-08 14:13:33 +05:30
1. Include `Gitlab::Geo::ReplicableModel` in the `Widget` class, and specify
the Replicator class `with_replicator Geo::WidgetReplicator`.
At this point the `Widget` class should look like this:
```ruby
# frozen_string_literal: true
class Widget < ApplicationRecord
include ::Gitlab::Geo::ReplicableModel
with_replicator Geo::WidgetReplicator
mount_uploader :file, WidgetUploader
2021-01-03 14:25:43 +05:30
# @param primary_key_in [Range, Widget] arg to pass to primary_key_in scope
# @return [ActiveRecord::Relation<Widget>] everything that should be synced to this node, restricted by primary key
def self.replicables_for_current_secondary(primary_key_in)
2020-07-28 23:09:34 +05:30
# Should be implemented. The idea of the method is to restrict
# the set of synced items depending on synchronization settings
end
2020-04-08 14:13:33 +05:30
...
end
```
2021-01-29 00:20:46 +05:30
If there is a common constraint for records to be available for replication,
make sure to also overwrite the `available_replicables` scope.
2020-04-08 14:13:33 +05:30
1. Create `ee/app/replicators/geo/widget_replicator.rb`. Implement the
2021-01-29 00:20:46 +05:30
`#carrierwave_uploader` method which should return a `CarrierWave::Uploader`,
and implement the class method `.model` to return the `Widget` class:
2020-04-08 14:13:33 +05:30
```ruby
# frozen_string_literal: true
module Geo
class WidgetReplicator < Gitlab::Geo::Replicator
include ::Geo::BlobReplicatorStrategy
2020-07-28 23:09:34 +05:30
def self.model
::Widget
2020-04-08 14:13:33 +05:30
end
2020-07-28 23:09:34 +05:30
def carrierwave_uploader
model_record.file
2020-04-08 14:13:33 +05:30
end
2020-10-24 23:57:45 +05:30
# The feature flag follows the format `geo_#{replicable_name}_replication`,
# so here it would be `geo_widget_replication`
def self.replication_enabled_by_default?
false
end
2020-04-08 14:13:33 +05:30
end
end
```
2020-10-24 23:57:45 +05:30
1. Add this replicator class to the method `replicator_classes` in
2021-01-29 00:20:46 +05:30
`ee/lib/gitlab/geo.rb`:
2020-10-24 23:57:45 +05:30
```ruby
2020-11-24 15:15:51 +05:30
REPLICATOR_CLASSES = [
::Geo::PackageFileReplicator,
::Geo::WidgetReplicator
]
2020-10-24 23:57:45 +05:30
end
```
2020-04-08 14:13:33 +05:30
1. Create `ee/spec/replicators/geo/widget_replicator_spec.rb` and perform
2021-01-29 00:20:46 +05:30
the necessary setup to define the `model_record` variable for the shared
examples:
2020-04-08 14:13:33 +05:30
```ruby
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Geo::WidgetReplicator do
2020-04-08 14:13:33 +05:30
let(:model_record) { build(:widget) }
it_behaves_like 'a blob replicator'
end
```
2020-10-24 23:57:45 +05:30
1. Create the `widget_registry` table, with columns ordered according to [our guidelines](../ordering_table_columns.md) so Geo secondaries can track the sync and
verification state of each Widget's file. This migration belongs in `ee/db/geo/migrate`:
2020-04-08 14:13:33 +05:30
```ruby
# frozen_string_literal: true
2020-05-24 23:13:21 +05:30
class CreateWidgetRegistry < ActiveRecord::Migration[6.0]
2020-10-24 23:57:45 +05:30
include Gitlab::Database::MigrationHelpers
2020-04-08 14:13:33 +05:30
DOWNTIME = false
2020-07-28 23:09:34 +05:30
disable_ddl_transaction!
def up
unless table_exists?(:widget_registry)
ActiveRecord::Base.transaction do
create_table :widget_registry, id: :bigserial, force: :cascade do |t|
2021-03-11 19:13:27 +05:30
t.bigint :widget_id, null: false
t.datetime_with_timezone :created_at, null: false
t.datetime_with_timezone :last_synced_at
t.datetime_with_timezone :retry_at
t.datetime_with_timezone :verified_at
t.datetime_with_timezone :verification_started_at
t.datetime_with_timezone :verification_retry_at
2020-07-28 23:09:34 +05:30
t.integer :state, default: 0, null: false, limit: 2
2021-03-11 19:13:27 +05:30
t.integer :verification_state, default: 0, null: false, limit: 2
2020-07-28 23:09:34 +05:30
t.integer :retry_count, default: 0, limit: 2
2021-03-11 19:13:27 +05:30
t.integer :verification_retry_count, default: 0, limit: 2
t.boolean :checksum_mismatch
t.binary :verification_checksum
t.binary :verification_checksum_mismatched
t.string :verification_failure, limit: 255
2020-10-24 23:57:45 +05:30
t.text :last_sync_failure
2020-07-28 23:09:34 +05:30
2021-03-08 18:12:59 +05:30
t.index :widget_id, name: :index_widget_registry_on_widget_id, unique: true
2020-07-28 23:09:34 +05:30
t.index :retry_at
t.index :state
2021-03-11 19:13:27 +05:30
# To optimize performance of WidgetRegistry.verification_failed_batch
t.index :verification_retry_at, name: :widget_registry_failed_verification, order: "NULLS FIRST", where: "((state = 2) AND (verification_state = 3))"
# To optimize performance of WidgetRegistry.needs_verification_count
t.index :verification_state, name: :widget_registry_needs_verification, where: "((state = 2) AND (verification_state = ANY (ARRAY[0, 3])))"
# To optimize performance of WidgetRegistry.verification_pending_batch
t.index :verified_at, name: :widget_registry_pending_verification, order: "NULLS FIRST", where: "((state = 2) AND (verification_state = 0))"
2020-07-28 23:09:34 +05:30
end
end
2020-04-08 14:13:33 +05:30
end
2020-07-28 23:09:34 +05:30
add_text_limit :widget_registry, :last_sync_failure, 255
end
def down
drop_table :widget_registry
2020-04-08 14:13:33 +05:30
end
end
```
1. Create `ee/app/models/geo/widget_registry.rb`:
```ruby
# frozen_string_literal: true
class Geo::WidgetRegistry < Geo::BaseRegistry
2020-07-28 23:09:34 +05:30
include Geo::ReplicableRegistry
2021-03-11 19:13:27 +05:30
# TODO: Include VerificationState in VerifiableRegistry
# https://gitlab.com/gitlab-org/gitlab/-/issues/298811
include ::Gitlab::Geo::VerificationState
include ::Geo::VerifiableRegistry
2020-04-08 14:13:33 +05:30
2020-07-28 23:09:34 +05:30
MODEL_CLASS = ::Widget
2020-06-23 00:09:42 +05:30
MODEL_FOREIGN_KEY = :widget_id
2020-04-08 14:13:33 +05:30
belongs_to :widget, class_name: 'Widget'
end
```
2020-07-28 23:09:34 +05:30
1. Update `REGISTRY_CLASSES` in `ee/app/workers/geo/secondary/registry_consistency_worker.rb`.
2020-10-24 23:57:45 +05:30
1. Add `widget_registry` to `ActiveSupport::Inflector.inflections` in `config/initializers_before_autoloader/000_inflections.rb`.
2020-04-08 14:13:33 +05:30
1. Create `ee/spec/factories/geo/widget_registry.rb`:
```ruby
# frozen_string_literal: true
FactoryBot.define do
2020-07-28 23:09:34 +05:30
factory :geo_widget_registry, class: 'Geo::WidgetRegistry' do
2020-04-08 14:13:33 +05:30
widget
state { Geo::WidgetRegistry.state_value(:pending) }
trait :synced do
state { Geo::WidgetRegistry.state_value(:synced) }
last_synced_at { 5.days.ago }
end
trait :failed do
state { Geo::WidgetRegistry.state_value(:failed) }
last_synced_at { 1.day.ago }
retry_count { 2 }
last_sync_failure { 'Random error' }
end
trait :started do
state { Geo::WidgetRegistry.state_value(:started) }
last_synced_at { 1.day.ago }
retry_count { 0 }
end
end
end
```
2020-05-24 23:13:21 +05:30
1. Create `ee/spec/models/geo/widget_registry_spec.rb`:
2020-04-08 14:13:33 +05:30
```ruby
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Geo::WidgetRegistry, :geo, type: :model do
let_it_be(:registry) { create(:geo_widget_registry) }
2020-04-08 14:13:33 +05:30
specify 'factory is valid' do
expect(registry).to be_valid
end
2020-06-23 00:09:42 +05:30
include_examples 'a Geo framework registry'
2021-03-11 19:13:27 +05:30
include_examples 'a Geo verifiable registry'
2020-07-28 23:09:34 +05:30
describe '.find_registry_differences' do
... # To be implemented
end
2020-04-08 14:13:33 +05:30
end
```
2021-01-29 00:20:46 +05:30
Widgets should now be replicated by Geo.
2020-05-24 23:13:21 +05:30
#### Verification
2020-10-24 23:57:45 +05:30
There are two ways to add verification related fields so that the Geo primary
2021-01-29 00:20:46 +05:30
can track verification state.
2020-10-24 23:57:45 +05:30
##### Option 1: Add verification state fields to the existing `widgets` table itself
1. Add a migration to add columns ordered according to [our guidelines](../ordering_table_columns.md)
2021-01-29 00:20:46 +05:30
for verification state to the widgets table:
2020-05-24 23:13:21 +05:30
```ruby
# frozen_string_literal: true
class AddVerificationStateToWidgets < ActiveRecord::Migration[6.0]
DOWNTIME = false
def change
2020-10-24 23:57:45 +05:30
change_table(:widgets) do |t|
2021-02-22 17:27:13 +05:30
t.integer :verification_state, default: 0, limit: 2, null: false
t.column :verification_started_at, :datetime_with_timezone
2020-10-24 23:57:45 +05:30
t.integer :verification_retry_count, limit: 2
t.column :verification_retry_at, :datetime_with_timezone
t.column :verified_at, :datetime_with_timezone
t.binary :verification_checksum, using: 'verification_checksum::bytea'
# rubocop:disable Migration/AddLimitToTextColumns
t.text :verification_failure
# rubocop:enable Migration/AddLimitToTextColumns
end
end
end
```
1. Adding a `text` column also [requires](../database/strings_and_the_text_data_type.md#add-a-text-column-to-an-existing-table)
setting a limit:
```ruby
# frozen_string_literal: true
class AddVerificationFailureLimitToWidgets < ActiveRecord::Migration[6.0]
2020-11-24 15:15:51 +05:30
include Gitlab::Database::MigrationHelpers
2020-10-24 23:57:45 +05:30
DOWNTIME = false
disable_ddl_transaction!
2020-11-24 15:15:51 +05:30
CONSTRAINT_NAME = 'widget_verification_failure_text_limit'
def up
add_text_limit :widget, :verification_failure, 255, constraint_name: CONSTRAINT_NAME
end
def down
remove_check_constraint(:widget, CONSTRAINT_NAME)
2020-05-24 23:13:21 +05:30
end
end
```
2021-02-22 17:27:13 +05:30
1. Add indexes on verification fields to ensure verification can be performed efficiently:
Some or all of these indexes can be omitted if the table is guaranteed to be small. Ask a database expert if you are unsure.
2020-05-24 23:13:21 +05:30
```ruby
# frozen_string_literal: true
2021-02-22 17:27:13 +05:30
class AddVerificationIndexesToWidgets < ActiveRecord::Migration[6.0]
2020-05-24 23:13:21 +05:30
include Gitlab::Database::MigrationHelpers
DOWNTIME = false
2021-02-22 17:27:13 +05:30
VERIFICATION_STATE_INDEX_NAME = "index_widgets_verification_state"
PENDING_VERIFICATION_INDEX_NAME = "index_widgets_pending_verification"
FAILED_VERIFICATION_INDEX_NAME = "index_widgets_failed_verification"
NEEDS_VERIFICATION_INDEX_NAME = "index_widgets_needs_verification"
2020-05-24 23:13:21 +05:30
disable_ddl_transaction!
def up
2021-02-22 17:27:13 +05:30
add_concurrent_index :widgets, :verification_state, name: VERIFICATION_STATE_INDEX_NAME
add_concurrent_index :widgets, :verified_at, where: "(verification_state = 0)", order: { verified_at: 'ASC NULLS FIRST' }, name: PENDING_VERIFICATION_INDEX_NAME
add_concurrent_index :widgets, :verification_retry_at, where: "(verification_state = 3)", order: { verification_retry_at: 'ASC NULLS FIRST' }, name: FAILED_VERIFICATION_INDEX_NAME
add_concurrent_index :widgets, :verification_state, where: "(verification_state = 0 OR verification_state = 3)", name: NEEDS_VERIFICATION_INDEX_NAME
2020-05-24 23:13:21 +05:30
end
def down
2021-02-22 17:27:13 +05:30
remove_concurrent_index_by_name :widgets, VERIFICATION_STATE_INDEX_NAME
remove_concurrent_index_by_name :widgets, PENDING_VERIFICATION_INDEX_NAME
remove_concurrent_index_by_name :widgets, FAILED_VERIFICATION_INDEX_NAME
remove_concurrent_index_by_name :widgets, NEEDS_VERIFICATION_INDEX_NAME
2020-05-24 23:13:21 +05:30
end
end
```
2021-02-22 17:27:13 +05:30
1. Add the `Gitlab::Geo::VerificationState` concern to the `widget` model if it is not already included in `Gitlab::Geo::ReplicableModel`:
```ruby
class Widget < ApplicationRecord
...
include ::Gitlab::Geo::VerificationState
...
end
```
2020-10-24 23:57:45 +05:30
##### Option 2: Create a separate `widget_states` table with verification state fields
2021-02-22 17:27:13 +05:30
1. Create a `widget_states` table and add an index on `verification_state` to ensure verification can be performed efficiently. Order the columns according to [the guidelines](../ordering_table_columns.md):
2020-10-24 23:57:45 +05:30
```ruby
# frozen_string_literal: true
class CreateWidgetStates < ActiveRecord::Migration[6.0]
include Gitlab::Database::MigrationHelpers
DOWNTIME = false
disable_ddl_transaction!
def up
unless table_exists?(:widget_states)
with_lock_retries do
create_table :widget_states, id: false do |t|
t.references :widget, primary_key: true, null: false, foreign_key: { on_delete: :cascade }
2021-02-22 17:27:13 +05:30
t.integer :verification_state, default: 0, limit: 2, null: false
t.column :verification_started_at, :datetime_with_timezone
2020-10-24 23:57:45 +05:30
t.datetime_with_timezone :verification_retry_at
t.datetime_with_timezone :verified_at
t.integer :verification_retry_count, limit: 2
t.binary :verification_checksum, using: 'verification_checksum::bytea'
t.text :verification_failure
2021-02-22 17:27:13 +05:30
t.index :verification_state, name: "index_widget_states_on_verification_state"
2020-10-24 23:57:45 +05:30
end
end
end
add_text_limit :widget_states, :verification_failure, 255
end
def down
drop_table :widget_states
end
end
```
2021-02-22 17:27:13 +05:30
1. Add the following lines to the `widget_state.rb` model:
```ruby
class WidgetState < ApplicationRecord
...
self.primary_key = :widget_id
include ::Gitlab::Geo::VerificationState
belongs_to :widget, inverse_of: :widget_state
...
end
```
2020-10-24 23:57:45 +05:30
1. Add the following lines to the `widget` model:
```ruby
class Widget < ApplicationRecord
...
has_one :widget_state, inverse_of: :widget
delegate :verification_retry_at, :verification_retry_at=,
:verified_at, :verified_at=,
:verification_checksum, :verification_checksum=,
:verification_failure, :verification_failure=,
:verification_retry_count, :verification_retry_count=,
to: :widget_state
...
end
```
2020-07-28 23:09:34 +05:30
To do: Add verification on secondaries. This should be done as part of
[Geo: Self Service Framework - First Implementation for Package File verification](https://gitlab.com/groups/gitlab-org/-/epics/1817)
2021-01-29 00:20:46 +05:30
Widgets should now be verified by Geo.
2020-07-28 23:09:34 +05:30
#### Metrics
Metrics are gathered by `Geo::MetricsUpdateWorker`, persisted in
2021-01-29 00:20:46 +05:30
`GeoNodeStatus` for display in the UI, and sent to Prometheus:
2020-07-28 23:09:34 +05:30
2020-11-24 15:15:51 +05:30
1. Add fields `widgets_count`, `widgets_checksummed_count`,
`widgets_checksum_failed_count`, `widgets_synced_count`,
`widgets_failed_count`, and `widgets_registry_count` to
`GET /geo_nodes/status` example response in
2020-07-28 23:09:34 +05:30
`doc/api/geo_nodes.md`.
2020-11-24 15:15:51 +05:30
1. Add the same fields to `GET /geo_nodes/status` example response in
`ee/spec/fixtures/api/schemas/public_api/v4/geo_node_status.json`.
1. Add fields `geo_widgets`, `geo_widgets_checksummed`,
`geo_widgets_checksum_failed`, `geo_widgets_synced`,
`geo_widgets_failed`, and `geo_widgets_registry` to
`Sidekiq metrics` table in
`doc/administration/monitoring/prometheus/gitlab_metrics.md`.
1. Add the following to the parameterized table in
`ee/spec/models/geo_node_status_spec.rb`:
2020-07-28 23:09:34 +05:30
```ruby
2020-11-24 15:15:51 +05:30
Geo::WidgetReplicator | :widget | :geo_widget_registry
2020-07-28 23:09:34 +05:30
```
2020-11-24 15:15:51 +05:30
1. Add the following to `spec/factories/widgets.rb`:
2020-05-24 23:13:21 +05:30
```ruby
2021-02-22 17:27:13 +05:30
trait(:verification_succeeded) do
2020-11-24 15:15:51 +05:30
with_file
verification_checksum { 'abc' }
2021-02-22 17:27:13 +05:30
verification_state { Widget.verification_state_value(:verification_succeeded) }
2020-07-28 23:09:34 +05:30
end
2020-05-24 23:13:21 +05:30
2021-02-22 17:27:13 +05:30
trait(:verification_failed) do
2020-11-24 15:15:51 +05:30
with_file
verification_failure { 'Could not calculate the checksum' }
2021-02-22 17:27:13 +05:30
verification_state { Widget.verification_state_value(:verification_failed) }
2020-11-24 15:15:51 +05:30
end
2020-07-28 23:09:34 +05:30
```
2021-01-29 00:20:46 +05:30
1. Make sure the factory also allows setting a `project` attribute. If the model
does not have a direct relation to a project, you can use a `transient`
attribute. Check out `spec/factories/merge_request_diffs.rb` for an example.
2020-07-28 23:09:34 +05:30
Widget replication and verification metrics should now be available in the API,
2021-01-29 00:20:46 +05:30
the Admin Area UI, and Prometheus.
2020-05-24 23:13:21 +05:30
#### GraphQL API
1. Add a new field to `GeoNodeType` in
`ee/app/graphql/types/geo/geo_node_type.rb`:
```ruby
field :widget_registries, ::Types::Geo::WidgetRegistryType.connection_type,
null: true,
resolver: ::Resolvers::Geo::WidgetRegistriesResolver,
description: 'Find widget registries on this Geo node',
2020-11-24 15:15:51 +05:30
feature_flag: :geo_widget_replication
2020-05-24 23:13:21 +05:30
```
1. Add the new `widget_registries` field name to the `expected_fields` array in
`ee/spec/graphql/types/geo/geo_node_type_spec.rb`.
1. Create `ee/app/graphql/resolvers/geo/widget_registries_resolver.rb`:
```ruby
# frozen_string_literal: true
module Resolvers
module Geo
class WidgetRegistriesResolver < BaseResolver
include RegistriesResolver
end
end
end
```
1. Create `ee/spec/graphql/resolvers/geo/widget_registries_resolver_spec.rb`:
```ruby
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Resolvers::Geo::WidgetRegistriesResolver do
it_behaves_like 'a Geo registries resolver', :geo_widget_registry
2020-05-24 23:13:21 +05:30
end
```
1. Create `ee/app/finders/geo/widget_registry_finder.rb`:
```ruby
# frozen_string_literal: true
module Geo
class WidgetRegistryFinder
include FrameworkRegistryFinder
end
end
```
1. Create `ee/spec/finders/geo/widget_registry_finder_spec.rb`:
```ruby
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Geo::WidgetRegistryFinder do
it_behaves_like 'a framework registry finder', :geo_widget_registry
2020-05-24 23:13:21 +05:30
end
```
2020-06-23 00:09:42 +05:30
1. Create `ee/app/graphql/types/geo/widget_registry_type.rb`:
2020-05-24 23:13:21 +05:30
```ruby
# frozen_string_literal: true
module Types
module Geo
# rubocop:disable Graphql/AuthorizeTypes because it is included
class WidgetRegistryType < BaseObject
include ::Types::Geo::RegistryType
graphql_name 'WidgetRegistry'
2021-01-03 14:25:43 +05:30
description 'Represents the Geo sync and verification state of a widget'
2020-05-24 23:13:21 +05:30
field :widget_id, GraphQL::ID_TYPE, null: false, description: 'ID of the Widget'
end
end
end
```
1. Create `ee/spec/graphql/types/geo/widget_registry_type_spec.rb`:
```ruby
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe GitlabSchema.types['WidgetRegistry'] do
2020-05-24 23:13:21 +05:30
it_behaves_like 'a Geo registry type'
it 'has the expected fields (other than those included in RegistryType)' do
expected_fields = %i[widget_id]
expect(described_class).to have_graphql_fields(*expected_fields).at_least
end
end
```
1. Add integration tests for providing Widget registry data to the frontend via
the GraphQL API, by duplicating and modifying the following shared examples
in `ee/spec/requests/api/graphql/geo/registries_spec.rb`:
```ruby
it_behaves_like 'gets registries for', {
field_name: 'widgetRegistries',
registry_class_name: 'WidgetRegistry',
2020-07-28 23:09:34 +05:30
registry_factory: :geo_widget_registry,
2020-05-24 23:13:21 +05:30
registry_foreign_key_field_name: 'widgetId'
}
```
2021-01-03 14:25:43 +05:30
1. Update the GraphQL reference documentation:
```shell
bundle exec rake gitlab:graphql:compile_docs
```
2020-05-24 23:13:21 +05:30
Individual widget synchronization and verification data should now be available
2021-01-29 00:20:46 +05:30
via the GraphQL API.
2020-05-24 23:13:21 +05:30
2021-01-29 00:20:46 +05:30
Make sure to replicate the "update" events. Geo Framework does not currently support
replicating "update" events because all entities added to the framework, by this time,
are immutable. If this is the case
for the entity you're going to add, follow <https://gitlab.com/gitlab-org/gitlab/-/issues/118743>
and <https://gitlab.com/gitlab-org/gitlab/-/issues/118745> as examples to add the new event type.
Also, remove this notice when you've added it.
2020-07-28 23:09:34 +05:30
2020-05-24 23:13:21 +05:30
#### Admin UI
To do: This should be done as part of
[Geo: Implement frontend for Self-Service Framework replicables](https://gitlab.com/groups/gitlab-org/-/epics/2525)
Widget sync and verification data (aggregate and individual) should now be
2021-01-29 00:20:46 +05:30
available in the Admin UI.
2021-01-03 14:25:43 +05:30
#### Releasing the feature
2021-03-08 18:12:59 +05:30
1. In `ee/config/feature_flags/development/geo_widget_replication.yml`, set `default_enabled: true`
2021-01-03 14:25:43 +05:30
1. In `ee/app/replicators/geo/widget_replicator.rb`, delete the `self.replication_enabled_by_default?` method:
```ruby
module Geo
class WidgetReplicator < Gitlab::Geo::Replicator
...
# REMOVE THIS METHOD
def self.replication_enabled_by_default?
false
end
# REMOVE THIS METHOD
...
end
end
```
1. In `ee/app/graphql/types/geo/geo_node_type.rb`, remove the `feature_flag` option for the released type:
```ruby
field :widget_registries, ::Types::Geo::WidgetRegistryType.connection_type,
null: true,
resolver: ::Resolvers::Geo::WidgetRegistriesResolver,
description: 'Find widget registries on this Geo node',
feature_flag: :geo_widget_replication # REMOVE THIS LINE
```
2021-03-08 18:12:59 +05:30
### Repository Replicator Strategy
Models that refer to any repository on the disk
can be easily supported by Geo with the `Geo::RepositoryReplicatorStrategy` module.
For example, to add support for files referenced by a `Gizmos` model with a
`gizmos` table, you would perform the following steps.
#### Replication
1. Include `Gitlab::Geo::ReplicableModel` in the `Gizmo` class, and specify
the Replicator class `with_replicator Geo::GizmoReplicator`.
At this point the `Gizmo` class should look like this:
```ruby
# frozen_string_literal: true
class Gizmo < ApplicationRecord
include ::Gitlab::Geo::ReplicableModel
with_replicator Geo::GizmoReplicator
# @param primary_key_in [Range, Gizmo] arg to pass to primary_key_in scope
# @return [ActiveRecord::Relation<Gizmo>] everything that should be synced to this node, restricted by primary key
def self.replicables_for_current_secondary(primary_key_in)
# Should be implemented. The idea of the method is to restrict
# the set of synced items depending on synchronization settings
end
# Geo checks this method in FrameworkRepositorySyncService to avoid
# snapshotting repositories using object pools
def pool_repository
nil
end
...
end
```
Pay some attention to method `pool_repository`. Not every repository type uses
repository pooling. As Geo prefers to use repository snapshotting, it can lead to data loss.
Make sure to overwrite `pool_repository` so it returns nil for repositories that do not
have pools.
If there is a common constraint for records to be available for replication,
make sure to also overwrite the `available_replicables` scope.
1. Create `ee/app/replicators/geo/gizmo_replicator.rb`. Implement the
`#repository` method which should return a `<Repository>` instance,
and implement the class method `.model` to return the `Gizmo` class:
```ruby
# frozen_string_literal: true
module Geo
class GizmoReplicator < Gitlab::Geo::Replicator
include ::Geo::RepositoryReplicatorStrategy
def self.model
::Gizmo
end
def repository
model_record.repository
end
def self.git_access_class
::Gitlab::GitAccessGizmo
end
# The feature flag follows the format `geo_#{replicable_name}_replication`,
# so here it would be `geo_gizmo_replication`
def self.replication_enabled_by_default?
false
end
end
end
```
1. Generate the feature flag definition file by running the feature flag command
and running through the steps:
```shell
bin/feature-flag --ee geo_gizmo_replication --type development --group 'group::geo'
```
1. Make sure Geo push events are created. Usually it needs some
change in the `app/workers/post_receive.rb` file. Example:
```ruby
def replicate_gizmo_changes(gizmo)
if ::Gitlab::Geo.primary?
gizmo.replicator.handle_after_update if gizmo
end
end
```
See `app/workers/post_receive.rb` for more examples.
1. Make sure the repository removal is also handled. You may need to add something
like the following in the destroy service of the repository:
```ruby
gizmo.replicator.handle_after_destroy if gizmo.repository
```
1. Add this replicator class to the method `replicator_classes` in
`ee/lib/gitlab/geo.rb`:
```ruby
REPLICATOR_CLASSES = [
...
::Geo::PackageFileReplicator,
::Geo::GizmoReplicator
]
end
```
1. Create `ee/spec/replicators/geo/gizmo_replicator_spec.rb` and perform
the necessary setup to define the `model_record` variable for the shared
examples:
```ruby
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Geo::GizmoReplicator do
let(:model_record) { build(:gizmo) }
include_examples 'a repository replicator'
end
```
1. Create the `gizmo_registry` table, with columns ordered according to [our guidelines](../ordering_table_columns.md) so Geo secondaries can track the sync and
verification state of each Gizmo. This migration belongs in `ee/db/geo/migrate`:
```ruby
# frozen_string_literal: true
class CreateGizmoRegistry < ActiveRecord::Migration[6.0]
include Gitlab::Database::MigrationHelpers
DOWNTIME = false
disable_ddl_transaction!
def up
create_table :gizmo_registry, id: :bigserial, force: :cascade do |t|
t.datetime_with_timezone :retry_at
t.datetime_with_timezone :last_synced_at
t.datetime_with_timezone :created_at, null: false
t.bigint :gizmo_id, null: false
t.integer :state, default: 0, null: false, limit: 2
t.integer :retry_count, default: 0, limit: 2
t.text :last_sync_failure
t.boolean :force_to_redownload
t.boolean :missing_on_primary
t.index :gizmo_id, name: :index_gizmo_registry_on_gizmo_id, unique: true
t.index :retry_at
t.index :state
end
add_text_limit :gizmo_registry, :last_sync_failure, 255
end
def down
drop_table :gizmo_registry
end
end
```
1. Create `ee/app/models/geo/gizmo_registry.rb`:
```ruby
# frozen_string_literal: true
class Geo::GizmoRegistry < Geo::BaseRegistry
include Geo::ReplicableRegistry
MODEL_CLASS = ::Gizmo
MODEL_FOREIGN_KEY = :gizmo_id
belongs_to :gizmo, class_name: 'Gizmo'
end
```
1. Update `REGISTRY_CLASSES` in `ee/app/workers/geo/secondary/registry_consistency_worker.rb`.
1. Add `gizmo_registry` to `ActiveSupport::Inflector.inflections` in `config/initializers_before_autoloader/000_inflections.rb`.
1. Create `ee/spec/factories/geo/gizmo_registry.rb`:
```ruby
# frozen_string_literal: true
FactoryBot.define do
factory :geo_gizmo_registry, class: 'Geo::GizmoRegistry' do
gizmo
state { Geo::GizmoRegistry.state_value(:pending) }
trait :synced do
state { Geo::GizmoRegistry.state_value(:synced) }
last_synced_at { 5.days.ago }
end
trait :failed do
state { Geo::GizmoRegistry.state_value(:failed) }
last_synced_at { 1.day.ago }
retry_count { 2 }
last_sync_failure { 'Random error' }
end
trait :started do
state { Geo::GizmoRegistry.state_value(:started) }
last_synced_at { 1.day.ago }
retry_count { 0 }
end
end
end
```
1. Create `ee/spec/models/geo/gizmo_registry_spec.rb`:
```ruby
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Geo::GizmoRegistry, :geo, type: :model do
let_it_be(:registry) { create(:geo_gizmo_registry) }
specify 'factory is valid' do
expect(registry).to be_valid
end
include_examples 'a Geo framework registry'
end
```
1. Make sure the newly added repository type can be accessed by a secondary.
You may need to make some changes to one of the Git access classes.
Gizmos should now be replicated by Geo.
#### Metrics
You need to make the same changes as for Blob Replicator Strategy.
You need to make the same changes for the [metrics as in the Blob Replicator Strategy](#metrics).
#### GraphQL API
You need to make the same changes for the GraphQL API [as in the Blob Replicator Strategy](#graphql-api).
#### Releasing the feature
You need to make the same changes for [releasing the feature as in the Blob Replicator Strategy](#releasing-the-feature).