2019-12-04 20:38:33 +05:30
# frozen_string_literal: true
2018-11-18 11:00:15 +05:30
# rubocop:disable Style/SignalException
require 'yaml'
2020-06-23 00:09:42 +05:30
SEE_DOC = " See the [changelog documentation](https://docs.gitlab.com/ee/development/changelog.html). "
2018-11-18 11:00:15 +05:30
2020-06-23 00:09:42 +05:30
SUGGEST_MR_COMMENT = << ~ SUGGEST_COMMENT
` ` ` suggestion
merge_request : %< mr_iid > s
` ` `
#{SEE_DOC}
SUGGEST_COMMENT
2020-04-22 19:07:51 +05:30
def check_changelog_yaml ( path )
2020-06-23 00:09:42 +05:30
raw_file = File . read ( path )
yaml = YAML . safe_load ( raw_file )
2018-11-18 11:00:15 +05:30
fail " `title` should be set, in #{ gitlab . html_link ( path ) } ! #{ SEE_DOC } " if yaml [ " title " ] . nil?
fail " `type` should be set, in #{ gitlab . html_link ( path ) } ! #{ SEE_DOC } " if yaml [ " type " ] . nil?
2020-07-28 23:09:34 +05:30
return if helper . security_mr?
cherry_pick_against_stable_branch = helper . cherry_pick_mr? && helper . stable_branch?
if yaml [ " merge_request " ] . nil?
2020-06-23 00:09:42 +05:30
mr_line = raw_file . lines . find_index ( " merge_request: \n " )
if mr_line
markdown ( format ( SUGGEST_MR_COMMENT , mr_iid : gitlab . mr_json [ " iid " ] ) , file : path , line : mr_line . succ )
else
message " Consider setting `merge_request` to #{ gitlab . mr_json [ " iid " ] } in #{ gitlab . html_link ( path ) } . #{ SEE_DOC } "
end
2020-07-28 23:09:34 +05:30
elsif yaml [ " merge_request " ] != gitlab . mr_json [ " iid " ] && ! cherry_pick_against_stable_branch
2018-11-18 11:00:15 +05:30
fail " Merge request ID was not set to #{ gitlab . mr_json [ " iid " ] } ! #{ SEE_DOC } "
end
2021-03-11 19:13:27 +05:30
rescue Psych :: Exception
2018-11-18 11:00:15 +05:30
# YAML could not be parsed, fail the build.
fail " #{ gitlab . html_link ( path ) } isn't valid YAML! #{ SEE_DOC } "
rescue StandardError = > e
2020-07-28 23:09:34 +05:30
warn " There was a problem trying to check the Changelog. Exception: #{ e . class . name } - #{ e . message } "
2018-11-18 11:00:15 +05:30
end
2020-04-22 19:07:51 +05:30
def check_changelog_path ( path )
ee_changes = helper . all_ee_changes . dup
ee_changes . delete ( path )
2021-02-22 17:27:13 +05:30
if ee_changes . any? && ! changelog . ee_changelog? && ! changelog . db_changes?
2020-04-22 19:07:51 +05:30
warn " This MR has a Changelog file outside `ee/`, but code changes in `ee/`. Consider moving the Changelog file into `ee/`. "
end
if ee_changes . empty? && changelog . ee_changelog?
warn " This MR has a Changelog file in `ee/`, but no code changes in `ee/`. Consider moving the Changelog file outside `ee/`. "
end
2021-02-22 17:27:13 +05:30
if ee_changes . any? && changelog . ee_changelog? && changelog . db_changes?
warn " This MR has a Changelog file inside `ee/`, but there are database changes which [requires](https://docs.gitlab.com/ee/development/changelog.html # what-warrants-a-changelog-entry) the Changelog placement to be outside of `ee/`. Consider moving the Changelog file outside `ee/`. "
end
2020-04-22 19:07:51 +05:30
end
2018-11-18 11:00:15 +05:30
if git . modified_files . include? ( " CHANGELOG.md " )
2020-11-24 15:15:51 +05:30
fail changelog . modified_text
2018-11-18 11:00:15 +05:30
end
2020-01-01 13:55:28 +05:30
changelog_found = changelog . found
2020-04-22 19:07:51 +05:30
if changelog_found
check_changelog_yaml ( changelog_found )
check_changelog_path ( changelog_found )
2020-11-24 15:15:51 +05:30
elsif changelog . required?
fail changelog . required_text
elsif changelog . optional?
message changelog . optional_text
2018-11-18 11:00:15 +05:30
end