debian-mirror-gitlab/spec/requests/jwt_controller_spec.rb

161 lines
5.6 KiB
Ruby
Raw Normal View History

2016-06-02 11:05:42 +05:30
require 'spec_helper'
describe JwtController do
let(:service) { double(execute: {}) }
let(:service_class) { double(new: service) }
let(:service_name) { 'test' }
let(:parameters) { { service: service_name } }
2017-09-10 17:25:29 +05:30
before do
stub_const('JwtController::SERVICES', service_name => service_class)
end
2016-06-02 11:05:42 +05:30
context 'existing service' do
2019-02-15 15:39:39 +05:30
subject! { get '/jwt/auth', params: parameters }
2016-06-02 11:05:42 +05:30
2018-03-17 18:26:18 +05:30
it { expect(response).to have_gitlab_http_status(200) }
2016-06-02 11:05:42 +05:30
context 'returning custom http code' do
let(:service) { double(execute: { http_status: 505 }) }
2018-03-17 18:26:18 +05:30
it { expect(response).to have_gitlab_http_status(505) }
2016-06-02 11:05:42 +05:30
end
end
2016-11-24 13:41:30 +05:30
context 'when using authenticated request' do
2016-06-02 11:05:42 +05:30
context 'using CI token' do
2016-09-29 09:46:39 +05:30
let(:build) { create(:ci_build, :running) }
let(:project) { build.project }
let(:headers) { { authorization: credentials('gitlab-ci-token', build.token) } }
2016-06-02 11:05:42 +05:30
context 'project with enabled CI' do
2019-02-15 15:39:39 +05:30
subject! { get '/jwt/auth', params: parameters, headers: headers }
2016-06-02 11:05:42 +05:30
2019-02-15 15:39:39 +05:30
it { expect(service_class).to have_received(:new).with(project, nil, ActionController::Parameters.new(parameters).permit!) }
2016-06-02 11:05:42 +05:30
end
context 'project with disabled CI' do
2016-09-29 09:46:39 +05:30
before do
project.project_feature.update_attribute(:builds_access_level, ProjectFeature::DISABLED)
end
2019-02-15 15:39:39 +05:30
subject! { get '/jwt/auth', params: parameters, headers: headers }
2016-06-02 11:05:42 +05:30
2018-03-17 18:26:18 +05:30
it { expect(response).to have_gitlab_http_status(401) }
2016-06-02 11:05:42 +05:30
end
2017-09-10 17:25:29 +05:30
context 'using personal access tokens' do
let(:user) { create(:user) }
let(:pat) { create(:personal_access_token, user: user, scopes: ['read_registry']) }
let(:headers) { { authorization: credentials('personal_access_token', pat.token) } }
2018-03-17 18:26:18 +05:30
before do
stub_container_registry_config(enabled: true)
end
2019-02-15 15:39:39 +05:30
subject! { get '/jwt/auth', params: parameters, headers: headers }
2017-09-10 17:25:29 +05:30
it 'authenticates correctly' do
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
2019-02-15 15:39:39 +05:30
expect(service_class).to have_received(:new).with(nil, user, ActionController::Parameters.new(parameters).permit!)
2017-09-10 17:25:29 +05:30
end
end
2016-06-02 11:05:42 +05:30
end
context 'using User login' do
let(:user) { create(:user) }
2016-09-29 09:46:39 +05:30
let(:headers) { { authorization: credentials(user.username, user.password) } }
2016-06-02 11:05:42 +05:30
2019-02-15 15:39:39 +05:30
subject! { get '/jwt/auth', params: parameters, headers: headers }
2016-06-02 11:05:42 +05:30
2019-02-15 15:39:39 +05:30
it { expect(service_class).to have_received(:new).with(nil, user, ActionController::Parameters.new(parameters).permit!) }
2016-09-29 09:46:39 +05:30
2018-11-18 11:00:15 +05:30
context 'when passing a flat array of scopes' do
# We use this trick to make rails to generate a query_string:
# scope=scope1&scope=scope2
# It works because :scope and 'scope' are the same as string, but different objects
let(:parameters) do
{
:service => service_name,
:scope => 'scope1',
'scope' => 'scope2'
}
end
let(:service_parameters) do
2019-02-15 15:39:39 +05:30
ActionController::Parameters.new({ service: service_name, scopes: %w(scope1 scope2) }).permit!
2018-11-18 11:00:15 +05:30
end
it { expect(service_class).to have_received(:new).with(nil, user, service_parameters) }
end
2016-09-29 09:46:39 +05:30
context 'when user has 2FA enabled' do
let(:user) { create(:user, :two_factor) }
context 'without personal token' do
it 'rejects the authorization attempt' do
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(401)
2017-09-10 17:25:29 +05:30
expect(response.body).to include('You must use a personal access token with \'api\' scope for Git over HTTP')
2016-09-29 09:46:39 +05:30
end
end
context 'with personal token' do
let(:access_token) { create(:personal_access_token, user: user) }
let(:headers) { { authorization: credentials(user.username, access_token.token) } }
2016-11-24 13:41:30 +05:30
it 'accepts the authorization attempt' do
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
2016-09-29 09:46:39 +05:30
end
end
end
2016-06-02 11:05:42 +05:30
end
context 'using invalid login' do
let(:headers) { { authorization: credentials('invalid', 'password') } }
2017-09-10 17:25:29 +05:30
context 'when internal auth is enabled' do
it 'rejects the authorization attempt' do
2019-02-15 15:39:39 +05:30
get '/jwt/auth', params: parameters, headers: headers
2017-09-10 17:25:29 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(401)
2017-09-10 17:25:29 +05:30
expect(response.body).not_to include('You must use a personal access token with \'api\' scope for Git over HTTP')
end
end
2016-06-02 11:05:42 +05:30
2017-09-10 17:25:29 +05:30
context 'when internal auth is disabled' do
it 'rejects the authorization attempt with personal access token message' do
2018-03-17 18:26:18 +05:30
allow_any_instance_of(ApplicationSetting).to receive(:password_authentication_enabled_for_git?) { false }
2019-02-15 15:39:39 +05:30
get '/jwt/auth', params: parameters, headers: headers
2017-09-10 17:25:29 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(401)
2017-09-10 17:25:29 +05:30
expect(response.body).to include('You must use a personal access token with \'api\' scope for Git over HTTP')
end
end
2016-06-02 11:05:42 +05:30
end
end
2016-11-24 13:41:30 +05:30
context 'when using unauthenticated request' do
it 'accepts the authorization attempt' do
2019-02-15 15:39:39 +05:30
get '/jwt/auth', params: parameters
2016-11-24 13:41:30 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
2016-11-24 13:41:30 +05:30
end
it 'allows read access' do
expect(service).to receive(:execute).with(authentication_abilities: Gitlab::Auth.read_authentication_abilities)
2019-02-15 15:39:39 +05:30
get '/jwt/auth', params: parameters
2016-11-24 13:41:30 +05:30
end
end
2016-06-02 11:05:42 +05:30
context 'unknown service' do
2019-02-15 15:39:39 +05:30
subject! { get '/jwt/auth', params: { service: 'unknown' } }
2016-06-02 11:05:42 +05:30
2018-03-17 18:26:18 +05:30
it { expect(response).to have_gitlab_http_status(404) }
2016-06-02 11:05:42 +05:30
end
def credentials(login, password)
ActionController::HttpAuthentication::Basic.encode_credentials(login, password)
end
end