debian-mirror-gitlab/spec/services/notification_service_spec.rb

1229 lines
42 KiB
Ruby
Raw Normal View History

2014-09-02 18:07:02 +05:30
require 'spec_helper'
2015-12-23 02:04:40 +05:30
describe NotificationService, services: true do
2014-09-02 18:07:02 +05:30
let(:notification) { NotificationService.new }
2015-12-23 02:04:40 +05:30
around(:each) do |example|
perform_enqueued_jobs do
example.run
end
end
2016-09-13 17:45:13 +05:30
shared_examples 'notifications for new mentions' do
def send_notifications(*new_mentions)
reset_delivered_emails!
notification.send(notification_method, mentionable, new_mentions, @u_disabled)
end
it 'sends no emails when no new mentions are present' do
send_notifications
expect(ActionMailer::Base.deliveries).to be_empty
end
it 'emails new mentions with a watch level higher than participant' do
send_notifications(@u_watcher, @u_participant_mentioned, @u_custom_global)
should_only_email(@u_watcher, @u_participant_mentioned, @u_custom_global)
end
it 'does not email new mentions with a watch level equal to or less than participant' do
send_notifications(@u_participating, @u_mentioned)
expect(ActionMailer::Base.deliveries).to be_empty
end
end
2014-09-02 18:07:02 +05:30
describe 'Keys' do
2016-06-02 11:05:42 +05:30
describe '#new_key' do
2014-09-02 18:07:02 +05:30
let!(:key) { create(:personal_key) }
2015-04-26 12:48:37 +05:30
it { expect(notification.new_key(key)).to be_truthy }
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
it 'sends email to key owner' do
2015-12-23 02:04:40 +05:30
expect{ notification.new_key(key) }.to change{ ActionMailer::Base.deliveries.size }.by(1)
2014-09-02 18:07:02 +05:30
end
end
end
describe 'Email' do
2016-06-02 11:05:42 +05:30
describe '#new_email' do
2014-09-02 18:07:02 +05:30
let!(:email) { create(:email) }
2015-04-26 12:48:37 +05:30
it { expect(notification.new_email(email)).to be_truthy }
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
it 'sends email to email owner' do
2015-12-23 02:04:40 +05:30
expect{ notification.new_email(email) }.to change{ ActionMailer::Base.deliveries.size }.by(1)
2014-09-02 18:07:02 +05:30
end
end
end
describe 'Notes' do
context 'issue note' do
2015-09-25 12:07:36 +05:30
let(:project) { create(:empty_project, :private) }
2015-09-11 14:41:01 +05:30
let(:issue) { create(:issue, project: project, assignee: create(:user)) }
2014-09-02 18:07:02 +05:30
let(:mentioned_issue) { create(:issue, assignee: issue.assignee) }
2015-09-25 12:07:36 +05:30
let(:note) { create(:note_on_issue, noteable: issue, project_id: issue.project_id, note: '@mention referenced, @outsider also') }
2014-09-02 18:07:02 +05:30
before do
build_team(note.project)
2015-09-25 12:07:36 +05:30
project.team << [issue.author, :master]
project.team << [issue.assignee, :master]
project.team << [note.author, :master]
2015-12-23 02:04:40 +05:30
create(:note_on_issue, noteable: issue, project_id: issue.project_id, note: '@subscribed_participant cc this guy')
2016-06-22 15:30:34 +05:30
update_custom_notification(:new_note, @u_guest_custom, project)
update_custom_notification(:new_note, @u_custom_global)
2014-09-02 18:07:02 +05:30
end
2016-08-24 12:49:21 +05:30
describe '#new_note' do
2014-09-02 18:07:02 +05:30
it do
2015-04-26 12:48:37 +05:30
add_users_with_subscription(note.project, issue)
# Ensure create SentNotification by noteable = issue 6 times, not noteable = note
2016-06-22 15:30:34 +05:30
expect(SentNotification).to receive(:record).with(issue, any_args).exactly(8).times
2015-12-23 02:04:40 +05:30
ActionMailer::Base.deliveries.clear
2015-04-26 12:48:37 +05:30
2014-09-02 18:07:02 +05:30
notification.new_note(note)
2015-12-23 02:04:40 +05:30
should_email(@u_watcher)
should_email(note.noteable.author)
should_email(note.noteable.assignee)
2016-06-22 15:30:34 +05:30
should_email(@u_custom_global)
2015-12-23 02:04:40 +05:30
should_email(@u_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2015-12-23 02:04:40 +05:30
should_email(@subscribed_participant)
2016-06-22 15:30:34 +05:30
should_not_email(@u_guest_custom)
2016-06-02 11:05:42 +05:30
should_not_email(@u_guest_watcher)
2015-12-23 02:04:40 +05:30
should_not_email(note.author)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@unsubscriber)
should_not_email(@u_outsider_mentioned)
should_not_email(@u_lazy_participant)
2014-09-02 18:07:02 +05:30
end
it 'filters out "mentioned in" notes' do
2015-09-11 14:41:01 +05:30
mentioned_note = SystemNoteService.cross_reference(mentioned_issue, issue, issue.author)
2014-09-02 18:07:02 +05:30
2015-04-26 12:48:37 +05:30
expect(Notify).not_to receive(:note_issue_email)
2014-09-02 18:07:02 +05:30
notification.new_note(mentioned_note)
end
context 'participating' do
context 'by note' do
before do
ActionMailer::Base.deliveries.clear
note.author = @u_lazy_participant
note.save
notification.new_note(note)
end
it { should_not_email(@u_lazy_participant) }
end
end
2014-09-02 18:07:02 +05:30
end
describe 'new note on issue in project that belongs to a group' do
let(:group) { create(:group) }
before do
note.project.namespace_id = group.id
2015-04-26 12:48:37 +05:30
note.project.group.add_user(@u_watcher, GroupMember::MASTER)
2016-06-22 15:30:34 +05:30
note.project.group.add_user(@u_custom_global, GroupMember::MASTER)
2014-09-02 18:07:02 +05:30
note.project.save
2016-06-02 11:05:42 +05:30
@u_watcher.notification_settings_for(note.project).participating!
@u_watcher.notification_settings_for(note.project.group).global!
2016-06-22 15:30:34 +05:30
update_custom_notification(:new_note, @u_custom_global)
2015-12-23 02:04:40 +05:30
ActionMailer::Base.deliveries.clear
2014-09-02 18:07:02 +05:30
end
it do
notification.new_note(note)
2015-12-23 02:04:40 +05:30
should_email(note.noteable.author)
should_email(note.noteable.assignee)
should_email(@u_mentioned)
2016-06-22 15:30:34 +05:30
should_email(@u_custom_global)
should_not_email(@u_guest_custom)
2016-06-02 11:05:42 +05:30
should_not_email(@u_guest_watcher)
2015-12-23 02:04:40 +05:30
should_not_email(@u_watcher)
should_not_email(note.author)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
2015-12-23 02:04:40 +05:30
end
2014-09-02 18:07:02 +05:30
end
end
2016-06-02 11:05:42 +05:30
context 'confidential issue note' do
let(:project) { create(:empty_project, :public) }
let(:author) { create(:user) }
let(:assignee) { create(:user) }
let(:non_member) { create(:user) }
let(:member) { create(:user) }
let(:guest) { create(:user) }
2016-06-02 11:05:42 +05:30
let(:admin) { create(:admin) }
let(:confidential_issue) { create(:issue, :confidential, project: project, author: author, assignee: assignee) }
let(:note) { create(:note_on_issue, noteable: confidential_issue, project: project, note: "#{author.to_reference} #{assignee.to_reference} #{non_member.to_reference} #{member.to_reference} #{admin.to_reference}") }
2016-06-22 15:30:34 +05:30
let(:guest_watcher) { create_user_with_notification(:watch, "guest-watcher-confidential") }
2016-06-02 11:05:42 +05:30
it 'filters out users that can not read the issue' do
project.team << [member, :developer]
project.team << [guest, :guest]
2016-06-02 11:05:42 +05:30
expect(SentNotification).to receive(:record).with(confidential_issue, any_args).exactly(4).times
ActionMailer::Base.deliveries.clear
notification.new_note(note)
should_not_email(non_member)
should_not_email(guest)
2016-06-22 15:30:34 +05:30
should_not_email(guest_watcher)
2016-06-02 11:05:42 +05:30
should_email(author)
should_email(assignee)
should_email(member)
should_email(admin)
end
end
2014-09-02 18:07:02 +05:30
context 'issue note mention' do
2015-09-11 14:41:01 +05:30
let(:project) { create(:empty_project, :public) }
let(:issue) { create(:issue, project: project, assignee: create(:user)) }
2014-09-02 18:07:02 +05:30
let(:mentioned_issue) { create(:issue, assignee: issue.assignee) }
let(:note) { create(:note_on_issue, noteable: issue, project_id: issue.project_id, note: '@all mentioned') }
before do
build_team(note.project)
note.project.team << [note.author, :master]
2015-12-23 02:04:40 +05:30
ActionMailer::Base.deliveries.clear
2014-09-02 18:07:02 +05:30
end
2016-06-02 11:05:42 +05:30
describe '#new_note' do
it 'notifies the team members' do
2015-12-23 02:04:40 +05:30
notification.new_note(note)
2014-09-02 18:07:02 +05:30
# Notify all team members
note.project.team.members.each do |member|
# User with disabled notification should not be notified
next if member.id == @u_disabled.id
# Author should not be notified
next if member.id == note.author.id
2015-12-23 02:04:40 +05:30
should_email(member)
2014-09-02 18:07:02 +05:30
end
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2015-12-23 02:04:40 +05:30
should_email(note.noteable.author)
should_email(note.noteable.assignee)
should_not_email(note.author)
should_email(@u_mentioned)
should_not_email(@u_disabled)
should_email(@u_not_mentioned)
2014-09-02 18:07:02 +05:30
end
it 'filters out "mentioned in" notes' do
2015-09-11 14:41:01 +05:30
mentioned_note = SystemNoteService.cross_reference(mentioned_issue, issue, issue.author)
2014-09-02 18:07:02 +05:30
2015-04-26 12:48:37 +05:30
expect(Notify).not_to receive(:note_issue_email)
2014-09-02 18:07:02 +05:30
notification.new_note(mentioned_note)
end
end
end
2016-06-02 11:05:42 +05:30
context 'project snippet note' do
let(:project) { create(:empty_project, :public) }
let(:snippet) { create(:project_snippet, project: project, author: create(:user)) }
let(:note) { create(:note_on_project_snippet, noteable: snippet, project_id: snippet.project.id, note: '@all mentioned') }
before do
build_team(note.project)
note.project.team << [note.author, :master]
ActionMailer::Base.deliveries.clear
end
describe '#new_note' do
it 'notifies the team members' do
notification.new_note(note)
# Notify all team members
note.project.team.members.each do |member|
# User with disabled notification should not be notified
next if member.id == @u_disabled.id
# Author should not be notified
next if member.id == note.author.id
should_email(member)
end
2016-06-22 15:30:34 +05:30
# it emails custom global users on mention
should_email(@u_custom_global)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
should_email(note.noteable.author)
should_not_email(note.author)
should_email(@u_mentioned)
should_not_email(@u_disabled)
should_email(@u_not_mentioned)
end
end
end
2014-09-02 18:07:02 +05:30
context 'commit note' do
2015-09-11 14:41:01 +05:30
let(:project) { create(:project, :public) }
let(:note) { create(:note_on_commit, project: project) }
2014-09-02 18:07:02 +05:30
before do
build_team(note.project)
2015-12-23 02:04:40 +05:30
ActionMailer::Base.deliveries.clear
2015-09-11 14:41:01 +05:30
allow_any_instance_of(Commit).to receive(:author).and_return(@u_committer)
2016-06-22 15:30:34 +05:30
update_custom_notification(:new_note, @u_guest_custom, project)
update_custom_notification(:new_note, @u_custom_global)
2014-09-02 18:07:02 +05:30
end
2016-06-02 11:05:42 +05:30
describe '#new_note, #perform_enqueued_jobs' do
2014-09-02 18:07:02 +05:30
it do
notification.new_note(note)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_custom_global)
should_email(@u_guest_custom)
2015-12-23 02:04:40 +05:30
should_email(@u_committer)
should_email(@u_watcher)
should_not_email(@u_mentioned)
should_not_email(note.author)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
2014-09-02 18:07:02 +05:30
end
it do
note.update_attribute(:note, '@mention referenced')
notification.new_note(note)
2015-12-23 02:04:40 +05:30
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2015-12-23 02:04:40 +05:30
should_email(@u_committer)
should_email(@u_watcher)
should_email(@u_mentioned)
should_not_email(note.author)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
2014-09-02 18:07:02 +05:30
end
2015-04-26 12:48:37 +05:30
it do
@u_committer = create_global_setting_for(@u_committer, :mention)
2015-04-26 12:48:37 +05:30
notification.new_note(note)
2015-12-23 02:04:40 +05:30
should_not_email(@u_committer)
2014-09-02 18:07:02 +05:30
end
end
end
2016-08-24 12:49:21 +05:30
context "merge request diff note" do
let(:project) { create(:project) }
let(:user) { create(:user) }
let(:merge_request) { create(:merge_request, source_project: project, assignee: user) }
let(:note) { create(:diff_note_on_merge_request, project: project, noteable: merge_request) }
before do
build_team(note.project)
project.team << [merge_request.author, :master]
project.team << [merge_request.assignee, :master]
end
describe '#new_note' do
it "records sent notifications" do
# Ensure create SentNotification by noteable = merge_request 6 times, not noteable = note
expect(SentNotification).to receive(:record_note).with(note, any_args).exactly(4).times.and_call_original
notification.new_note(note)
expect(SentNotification.last.position).to eq(note.position)
end
end
end
2014-09-02 18:07:02 +05:30
end
describe 'Issues' do
2015-09-11 14:41:01 +05:30
let(:project) { create(:empty_project, :public) }
let(:issue) { create :issue, project: project, assignee: create(:user), description: 'cc @participant' }
2014-09-02 18:07:02 +05:30
before do
build_team(issue.project)
2015-04-26 12:48:37 +05:30
add_users_with_subscription(issue.project, issue)
2015-12-23 02:04:40 +05:30
ActionMailer::Base.deliveries.clear
2016-06-22 15:30:34 +05:30
update_custom_notification(:new_issue, @u_guest_custom, project)
update_custom_notification(:new_issue, @u_custom_global)
2014-09-02 18:07:02 +05:30
end
2016-06-02 11:05:42 +05:30
describe '#new_issue' do
2014-09-02 18:07:02 +05:30
it do
notification.new_issue(issue, @u_disabled)
2015-12-23 02:04:40 +05:30
should_email(issue.assignee)
should_email(@u_watcher)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_guest_custom)
should_email(@u_custom_global)
2015-12-23 02:04:40 +05:30
should_email(@u_participant_mentioned)
should_not_email(@u_mentioned)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
2014-09-02 18:07:02 +05:30
end
2015-04-26 12:48:37 +05:30
it do
create_global_setting_for(issue.assignee, :mention)
2015-04-26 12:48:37 +05:30
notification.new_issue(issue, @u_disabled)
2014-09-02 18:07:02 +05:30
2015-12-23 02:04:40 +05:30
should_not_email(issue.assignee)
2014-09-02 18:07:02 +05:30
end
2016-06-02 11:05:42 +05:30
it "emails subscribers of the issue's labels" do
subscriber = create(:user)
label = create(:label, issues: [issue])
label.toggle_subscription(subscriber)
notification.new_issue(issue, @u_disabled)
should_email(subscriber)
end
context 'confidential issues' do
let(:author) { create(:user) }
let(:assignee) { create(:user) }
let(:non_member) { create(:user) }
let(:member) { create(:user) }
let(:guest) { create(:user) }
2016-06-02 11:05:42 +05:30
let(:admin) { create(:admin) }
let(:confidential_issue) { create(:issue, :confidential, project: project, title: 'Confidential issue', author: author, assignee: assignee) }
it "emails subscribers of the issue's labels that can read the issue" do
project.team << [member, :developer]
project.team << [guest, :guest]
2016-06-02 11:05:42 +05:30
label = create(:label, issues: [confidential_issue])
label.toggle_subscription(non_member)
label.toggle_subscription(author)
label.toggle_subscription(assignee)
label.toggle_subscription(member)
label.toggle_subscription(guest)
2016-06-02 11:05:42 +05:30
label.toggle_subscription(admin)
ActionMailer::Base.deliveries.clear
notification.new_issue(confidential_issue, @u_disabled)
2016-06-22 15:30:34 +05:30
should_not_email(@u_guest_watcher)
2016-06-02 11:05:42 +05:30
should_not_email(non_member)
should_not_email(author)
should_not_email(guest)
2016-06-02 11:05:42 +05:30
should_email(assignee)
should_email(member)
should_email(admin)
end
end
2014-09-02 18:07:02 +05:30
end
2016-09-13 17:45:13 +05:30
describe '#new_mentions_in_issue' do
let(:notification_method) { :new_mentions_in_issue }
let(:mentionable) { issue }
include_examples 'notifications for new mentions'
end
2016-06-02 11:05:42 +05:30
describe '#reassigned_issue' do
2016-06-22 15:30:34 +05:30
before do
update_custom_notification(:reassign_issue, @u_guest_custom, project)
update_custom_notification(:reassign_issue, @u_custom_global)
end
2016-01-29 22:53:50 +05:30
it 'emails new assignee' do
2014-09-02 18:07:02 +05:30
notification.reassigned_issue(issue, @u_disabled)
2015-12-23 02:04:40 +05:30
should_email(issue.assignee)
should_email(@u_watcher)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_guest_custom)
should_email(@u_custom_global)
2015-12-23 02:04:40 +05:30
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
2014-09-02 18:07:02 +05:30
end
2016-01-29 22:53:50 +05:30
it 'emails previous assignee even if he has the "on mention" notif level' do
issue.update_attribute(:assignee, @u_mentioned)
issue.update_attributes(assignee: @u_watcher)
notification.reassigned_issue(issue, @u_disabled)
should_email(@u_mentioned)
should_email(@u_watcher)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_guest_custom)
2016-01-29 22:53:50 +05:30
should_email(@u_participant_mentioned)
should_email(@subscriber)
2016-06-22 15:30:34 +05:30
should_email(@u_custom_global)
2016-01-29 22:53:50 +05:30
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
2016-01-29 22:53:50 +05:30
end
it 'emails new assignee even if he has the "on mention" notif level' do
issue.update_attributes(assignee: @u_mentioned)
notification.reassigned_issue(issue, @u_disabled)
expect(issue.assignee).to be @u_mentioned
should_email(issue.assignee)
should_email(@u_watcher)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_guest_custom)
2016-01-29 22:53:50 +05:30
should_email(@u_participant_mentioned)
should_email(@subscriber)
2016-06-22 15:30:34 +05:30
should_email(@u_custom_global)
2016-01-29 22:53:50 +05:30
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
2016-01-29 22:53:50 +05:30
end
it 'emails new assignee' do
issue.update_attribute(:assignee, @u_mentioned)
notification.reassigned_issue(issue, @u_disabled)
expect(issue.assignee).to be @u_mentioned
should_email(issue.assignee)
should_email(@u_watcher)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_guest_custom)
2016-01-29 22:53:50 +05:30
should_email(@u_participant_mentioned)
should_email(@subscriber)
2016-06-22 15:30:34 +05:30
should_email(@u_custom_global)
2016-01-29 22:53:50 +05:30
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
2016-01-29 22:53:50 +05:30
end
it 'does not email new assignee if they are the current user' do
issue.update_attribute(:assignee, @u_mentioned)
notification.reassigned_issue(issue, @u_mentioned)
expect(issue.assignee).to be @u_mentioned
should_email(@u_watcher)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_guest_custom)
2016-01-29 22:53:50 +05:30
should_email(@u_participant_mentioned)
should_email(@subscriber)
2016-06-22 15:30:34 +05:30
should_email(@u_custom_global)
2016-01-29 22:53:50 +05:30
should_not_email(issue.assignee)
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
end
context 'participating' do
context 'by assignee' do
before do
issue.update_attribute(:assignee, @u_lazy_participant)
notification.reassigned_issue(issue, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
context 'by note' do
let!(:note) { create(:note_on_issue, noteable: issue, project_id: issue.project_id, note: 'anything', author: @u_lazy_participant) }
before { notification.reassigned_issue(issue, @u_disabled) }
it { should_email(@u_lazy_participant) }
end
context 'by author' do
before do
issue.author = @u_lazy_participant
notification.reassigned_issue(issue, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
2016-01-29 22:53:50 +05:30
end
2014-09-02 18:07:02 +05:30
end
2016-06-02 11:05:42 +05:30
describe '#relabeled_issue' do
let(:label) { create(:label, issues: [issue]) }
let(:label2) { create(:label) }
let!(:subscriber_to_label) { create(:user).tap { |u| label.toggle_subscription(u) } }
let!(:subscriber_to_label2) { create(:user).tap { |u| label2.toggle_subscription(u) } }
it "emails subscribers of the issue's added labels only" do
notification.relabeled_issue(issue, [label2], @u_disabled)
should_not_email(subscriber_to_label)
should_email(subscriber_to_label2)
end
it "doesn't send email to anyone but subscribers of the given labels" do
notification.relabeled_issue(issue, [label2], @u_disabled)
should_not_email(issue.assignee)
should_not_email(issue.author)
should_not_email(@u_watcher)
should_not_email(@u_guest_watcher)
should_not_email(@u_participant_mentioned)
should_not_email(@subscriber)
should_not_email(@watcher_and_subscriber)
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(subscriber_to_label)
should_email(subscriber_to_label2)
end
context 'confidential issues' do
let(:author) { create(:user) }
let(:assignee) { create(:user) }
let(:non_member) { create(:user) }
let(:member) { create(:user) }
let(:guest) { create(:user) }
2016-06-02 11:05:42 +05:30
let(:admin) { create(:admin) }
let(:confidential_issue) { create(:issue, :confidential, project: project, title: 'Confidential issue', author: author, assignee: assignee) }
let!(:label_1) { create(:label, issues: [confidential_issue]) }
let!(:label_2) { create(:label) }
it "emails subscribers of the issue's labels that can read the issue" do
project.team << [member, :developer]
project.team << [guest, :guest]
2016-06-02 11:05:42 +05:30
label_2.toggle_subscription(non_member)
label_2.toggle_subscription(author)
label_2.toggle_subscription(assignee)
label_2.toggle_subscription(member)
label_2.toggle_subscription(guest)
2016-06-02 11:05:42 +05:30
label_2.toggle_subscription(admin)
ActionMailer::Base.deliveries.clear
notification.relabeled_issue(confidential_issue, [label_2], @u_disabled)
should_not_email(non_member)
should_not_email(guest)
2016-06-02 11:05:42 +05:30
should_email(author)
should_email(assignee)
should_email(member)
should_email(admin)
end
end
end
describe '#close_issue' do
2016-06-22 15:30:34 +05:30
before do
update_custom_notification(:close_issue, @u_guest_custom, project)
update_custom_notification(:close_issue, @u_custom_global)
end
2016-09-13 17:45:13 +05:30
it 'sends email to issue assignee and issue author' do
2014-09-02 18:07:02 +05:30
notification.close_issue(issue, @u_disabled)
2015-12-23 02:04:40 +05:30
should_email(issue.assignee)
should_email(issue.author)
should_email(@u_watcher)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_guest_custom)
should_email(@u_custom_global)
2015-12-23 02:04:40 +05:30
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2015-12-23 02:04:40 +05:30
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
end
context 'participating' do
context 'by assignee' do
before do
issue.update_attribute(:assignee, @u_lazy_participant)
notification.close_issue(issue, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
context 'by note' do
let!(:note) { create(:note_on_issue, noteable: issue, project_id: issue.project_id, note: 'anything', author: @u_lazy_participant) }
before { notification.close_issue(issue, @u_disabled) }
it { should_email(@u_lazy_participant) }
end
context 'by author' do
before do
issue.author = @u_lazy_participant
notification.close_issue(issue, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
2014-09-02 18:07:02 +05:30
end
end
2016-06-02 11:05:42 +05:30
describe '#reopen_issue' do
2016-06-22 15:30:34 +05:30
before do
update_custom_notification(:reopen_issue, @u_guest_custom, project)
update_custom_notification(:reopen_issue, @u_custom_global)
end
2016-09-13 17:45:13 +05:30
it 'sends email to issue assignee and issue author' do
2014-09-02 18:07:02 +05:30
notification.reopen_issue(issue, @u_disabled)
2015-12-23 02:04:40 +05:30
should_email(issue.assignee)
should_email(issue.author)
should_email(@u_watcher)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_guest_custom)
should_email(@u_custom_global)
2015-12-23 02:04:40 +05:30
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2015-12-23 02:04:40 +05:30
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_lazy_participant)
end
context 'participating' do
context 'by assignee' do
before do
issue.update_attribute(:assignee, @u_lazy_participant)
notification.reopen_issue(issue, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
context 'by note' do
let!(:note) { create(:note_on_issue, noteable: issue, project_id: issue.project_id, note: 'anything', author: @u_lazy_participant) }
before { notification.reopen_issue(issue, @u_disabled) }
it { should_email(@u_lazy_participant) }
end
context 'by author' do
before do
issue.author = @u_lazy_participant
notification.reopen_issue(issue, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
2014-09-02 18:07:02 +05:30
end
end
end
describe 'Merge Requests' do
2015-09-11 14:41:01 +05:30
let(:project) { create(:project, :public) }
let(:merge_request) { create :merge_request, source_project: project, assignee: create(:user), description: 'cc @participant' }
2014-09-02 18:07:02 +05:30
before do
build_team(merge_request.target_project)
2015-04-26 12:48:37 +05:30
add_users_with_subscription(merge_request.target_project, merge_request)
2016-09-13 17:45:13 +05:30
update_custom_notification(:new_merge_request, @u_guest_custom, project)
update_custom_notification(:new_merge_request, @u_custom_global)
2015-12-23 02:04:40 +05:30
ActionMailer::Base.deliveries.clear
2014-09-02 18:07:02 +05:30
end
2016-06-02 11:05:42 +05:30
describe '#new_merge_request' do
2016-06-22 15:30:34 +05:30
before do
update_custom_notification(:new_merge_request, @u_guest_custom, project)
update_custom_notification(:new_merge_request, @u_custom_global)
end
2014-09-02 18:07:02 +05:30
it do
notification.new_merge_request(merge_request, @u_disabled)
2015-12-23 02:04:40 +05:30
should_email(merge_request.assignee)
should_email(@u_watcher)
should_email(@watcher_and_subscriber)
2015-12-23 02:04:40 +05:30
should_email(@u_participant_mentioned)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_guest_custom)
should_email(@u_custom_global)
2015-12-23 02:04:40 +05:30
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
2014-09-02 18:07:02 +05:30
end
2016-06-02 11:05:42 +05:30
it "emails subscribers of the merge request's labels" do
subscriber = create(:user)
label = create(:label, merge_requests: [merge_request])
label.toggle_subscription(subscriber)
notification.new_merge_request(merge_request, @u_disabled)
should_email(subscriber)
end
context 'participating' do
context 'by assignee' do
before do
merge_request.update_attribute(:assignee, @u_lazy_participant)
notification.new_merge_request(merge_request, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
context 'by note' do
let!(:note) { create(:note_on_issue, noteable: merge_request, project_id: project.id, note: 'anything', author: @u_lazy_participant) }
before { notification.new_merge_request(merge_request, @u_disabled) }
it { should_email(@u_lazy_participant) }
end
context 'by author' do
before do
merge_request.author = @u_lazy_participant
merge_request.save
notification.new_merge_request(merge_request, @u_disabled)
end
it { should_not_email(@u_lazy_participant) }
end
end
2014-09-02 18:07:02 +05:30
end
2016-09-13 17:45:13 +05:30
describe '#new_mentions_in_merge_request' do
let(:notification_method) { :new_mentions_in_merge_request }
let(:mentionable) { merge_request }
include_examples 'notifications for new mentions'
end
2016-06-02 11:05:42 +05:30
describe '#reassigned_merge_request' do
2016-06-22 15:30:34 +05:30
before do
update_custom_notification(:reassign_merge_request, @u_guest_custom, project)
update_custom_notification(:reassign_merge_request, @u_custom_global)
end
2014-09-02 18:07:02 +05:30
it do
notification.reassigned_merge_request(merge_request, merge_request.author)
2015-12-23 02:04:40 +05:30
should_email(merge_request.assignee)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_guest_custom)
should_email(@u_custom_global)
2015-12-23 02:04:40 +05:30
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
end
context 'participating' do
context 'by assignee' do
before do
merge_request.update_attribute(:assignee, @u_lazy_participant)
notification.reassigned_merge_request(merge_request, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
context 'by note' do
let!(:note) { create(:note_on_issue, noteable: merge_request, project_id: project.id, note: 'anything', author: @u_lazy_participant) }
before { notification.reassigned_merge_request(merge_request, @u_disabled) }
it { should_email(@u_lazy_participant) }
end
context 'by author' do
before do
merge_request.author = @u_lazy_participant
merge_request.save
notification.reassigned_merge_request(merge_request, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
2014-09-02 18:07:02 +05:30
end
end
2016-06-02 11:05:42 +05:30
describe '#relabel_merge_request' do
let(:label) { create(:label, merge_requests: [merge_request]) }
let(:label2) { create(:label) }
let!(:subscriber_to_label) { create(:user).tap { |u| label.toggle_subscription(u) } }
let!(:subscriber_to_label2) { create(:user).tap { |u| label2.toggle_subscription(u) } }
it "emails subscribers of the merge request's added labels only" do
notification.relabeled_merge_request(merge_request, [label2], @u_disabled)
should_not_email(subscriber_to_label)
should_email(subscriber_to_label2)
end
it "doesn't send email to anyone but subscribers of the given labels" do
notification.relabeled_merge_request(merge_request, [label2], @u_disabled)
should_not_email(merge_request.assignee)
should_not_email(merge_request.author)
should_not_email(@u_watcher)
should_not_email(@u_participant_mentioned)
should_not_email(@subscriber)
should_not_email(@watcher_and_subscriber)
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_lazy_participant)
2016-06-02 11:05:42 +05:30
should_not_email(subscriber_to_label)
should_email(subscriber_to_label2)
end
end
describe '#closed_merge_request' do
2016-06-22 15:30:34 +05:30
before do
update_custom_notification(:close_merge_request, @u_guest_custom, project)
update_custom_notification(:close_merge_request, @u_custom_global)
end
2014-09-02 18:07:02 +05:30
it do
notification.close_mr(merge_request, @u_disabled)
2015-12-23 02:04:40 +05:30
should_email(merge_request.assignee)
should_email(@u_watcher)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_guest_custom)
should_email(@u_custom_global)
2015-12-23 02:04:40 +05:30
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2015-12-23 02:04:40 +05:30
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
end
context 'participating' do
context 'by assignee' do
before do
merge_request.update_attribute(:assignee, @u_lazy_participant)
notification.close_mr(merge_request, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
context 'by note' do
let!(:note) { create(:note_on_issue, noteable: merge_request, project_id: project.id, note: 'anything', author: @u_lazy_participant) }
before { notification.close_mr(merge_request, @u_disabled) }
it { should_email(@u_lazy_participant) }
end
context 'by author' do
before do
merge_request.author = @u_lazy_participant
merge_request.save
notification.close_mr(merge_request, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
2014-09-02 18:07:02 +05:30
end
end
2016-06-02 11:05:42 +05:30
describe '#merged_merge_request' do
2016-06-22 15:30:34 +05:30
before do
update_custom_notification(:merge_merge_request, @u_guest_custom, project)
update_custom_notification(:merge_merge_request, @u_custom_global)
end
2014-09-02 18:07:02 +05:30
it do
notification.merge_mr(merge_request, @u_disabled)
2015-12-23 02:04:40 +05:30
should_email(merge_request.assignee)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_custom_global)
should_email(@u_guest_custom)
2015-12-23 02:04:40 +05:30
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
end
context 'participating' do
context 'by assignee' do
before do
merge_request.update_attribute(:assignee, @u_lazy_participant)
notification.merge_mr(merge_request, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
context 'by note' do
let!(:note) { create(:note_on_issue, noteable: merge_request, project_id: project.id, note: 'anything', author: @u_lazy_participant) }
before { notification.merge_mr(merge_request, @u_disabled) }
it { should_email(@u_lazy_participant) }
end
context 'by author' do
before do
merge_request.author = @u_lazy_participant
merge_request.save
notification.merge_mr(merge_request, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
2014-09-02 18:07:02 +05:30
end
end
2016-06-02 11:05:42 +05:30
describe '#reopen_merge_request' do
2016-06-22 15:30:34 +05:30
before do
update_custom_notification(:reopen_merge_request, @u_guest_custom, project)
update_custom_notification(:reopen_merge_request, @u_custom_global)
end
2014-09-02 18:07:02 +05:30
it do
notification.reopen_mr(merge_request, @u_disabled)
2015-12-23 02:04:40 +05:30
should_email(merge_request.assignee)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
2016-06-02 11:05:42 +05:30
should_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_email(@u_guest_custom)
should_email(@u_custom_global)
2015-12-23 02:04:40 +05:30
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
end
context 'participating' do
context 'by assignee' do
before do
merge_request.update_attribute(:assignee, @u_lazy_participant)
notification.reopen_mr(merge_request, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
context 'by note' do
let!(:note) { create(:note_on_issue, noteable: merge_request, project_id: project.id, note: 'anything', author: @u_lazy_participant) }
before { notification.reopen_mr(merge_request, @u_disabled) }
it { should_email(@u_lazy_participant) }
end
context 'by author' do
before do
merge_request.author = @u_lazy_participant
merge_request.save
notification.reopen_mr(merge_request, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
2014-09-02 18:07:02 +05:30
end
end
2016-09-13 17:45:13 +05:30
describe "#resolve_all_discussions" do
it do
notification.resolve_all_discussions(merge_request, @u_disabled)
should_email(merge_request.assignee)
should_email(@u_watcher)
should_email(@u_participant_mentioned)
should_email(@subscriber)
should_email(@watcher_and_subscriber)
should_email(@u_guest_watcher)
should_not_email(@unsubscriber)
should_not_email(@u_participating)
should_not_email(@u_disabled)
should_not_email(@u_lazy_participant)
end
context 'participating' do
context 'by assignee' do
before do
merge_request.update_attribute(:assignee, @u_lazy_participant)
notification.resolve_all_discussions(merge_request, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
context 'by note' do
let!(:note) { create(:note_on_issue, noteable: merge_request, project_id: project.id, note: 'anything', author: @u_lazy_participant) }
before { notification.resolve_all_discussions(merge_request, @u_disabled) }
it { should_email(@u_lazy_participant) }
end
context 'by author' do
before do
merge_request.author = @u_lazy_participant
merge_request.save
notification.resolve_all_discussions(merge_request, @u_disabled)
end
it { should_email(@u_lazy_participant) }
end
end
end
2014-09-02 18:07:02 +05:30
end
describe 'Projects' do
let(:project) { create :project }
before do
build_team(project)
2015-12-23 02:04:40 +05:30
ActionMailer::Base.deliveries.clear
2014-09-02 18:07:02 +05:30
end
2016-06-02 11:05:42 +05:30
describe '#project_was_moved' do
2014-09-02 18:07:02 +05:30
it do
2015-10-24 18:46:33 +05:30
notification.project_was_moved(project, "gitlab/gitlab")
2014-09-02 18:07:02 +05:30
2015-12-23 02:04:40 +05:30
should_email(@u_watcher)
should_email(@u_participating)
should_email(@u_lazy_participant)
2016-06-22 15:30:34 +05:30
should_email(@u_custom_global)
2016-06-02 11:05:42 +05:30
should_not_email(@u_guest_watcher)
2016-06-22 15:30:34 +05:30
should_not_email(@u_guest_custom)
2015-12-23 02:04:40 +05:30
should_not_email(@u_disabled)
2014-09-02 18:07:02 +05:30
end
end
end
2016-09-13 17:45:13 +05:30
describe 'GroupMember' do
describe '#decline_group_invite' do
let(:creator) { create(:user) }
let(:group) { create(:group) }
let(:member) { create(:user) }
before(:each) do
group.add_owner(creator)
group.add_developer(member, creator)
end
it do
group_member = group.members.first
expect do
notification.decline_group_invite(group_member)
end.to change { ActionMailer::Base.deliveries.size }.by(1)
end
end
end
describe 'ProjectMember' do
describe '#decline_group_invite' do
let(:project) { create(:project) }
let(:member) { create(:user) }
before(:each) do
project.team << [member, :developer, project.owner]
end
it do
project_member = project.members.first
expect do
notification.decline_project_invite(project_member)
end.to change { ActionMailer::Base.deliveries.size }.by(1)
end
end
end
2014-09-02 18:07:02 +05:30
def build_team(project)
@u_watcher = create_global_setting_for(create(:user), :watch)
@u_participating = create_global_setting_for(create(:user), :participating)
@u_participant_mentioned = create_global_setting_for(create(:user, username: 'participant'), :participating)
@u_disabled = create_global_setting_for(create(:user), :disabled)
@u_mentioned = create_global_setting_for(create(:user, username: 'mention'), :mention)
@u_committer = create(:user, username: 'committer')
@u_not_mentioned = create_global_setting_for(create(:user, username: 'regular'), :participating)
@u_outsider_mentioned = create(:user, username: 'outsider')
2016-06-22 15:30:34 +05:30
@u_custom_global = create_global_setting_for(create(:user, username: 'custom_global'), :custom)
# User to be participant by default
# This user does not contain any record in notification settings table
# It should be treated with a :participating notification_level
@u_lazy_participant = create(:user, username: 'lazy-participant')
2014-09-02 18:07:02 +05:30
2016-06-22 15:30:34 +05:30
@u_guest_watcher = create_user_with_notification(:watch, 'guest_watching')
@u_guest_custom = create_user_with_notification(:custom, 'guest_custom')
2016-06-02 11:05:42 +05:30
2014-09-02 18:07:02 +05:30
project.team << [@u_watcher, :master]
project.team << [@u_participating, :master]
2015-09-25 12:07:36 +05:30
project.team << [@u_participant_mentioned, :master]
2014-09-02 18:07:02 +05:30
project.team << [@u_disabled, :master]
project.team << [@u_mentioned, :master]
project.team << [@u_committer, :master]
2015-09-25 12:07:36 +05:30
project.team << [@u_not_mentioned, :master]
project.team << [@u_lazy_participant, :master]
2016-06-22 15:30:34 +05:30
project.team << [@u_custom_global, :master]
end
def create_global_setting_for(user, level)
setting = user.global_notification_setting
setting.level = level
setting.save
user
2014-09-02 18:07:02 +05:30
end
2015-04-26 12:48:37 +05:30
2016-06-22 15:30:34 +05:30
def create_user_with_notification(level, username)
user = create(:user, username: username)
setting = user.notification_settings_for(project)
setting.level = level
setting.save
user
end
# Create custom notifications
# When resource is nil it means global notification
def update_custom_notification(event, user, resource = nil)
setting = user.notification_settings_for(resource)
setting.events[event] = true
2016-06-02 11:05:42 +05:30
setting.save
end
2015-04-26 12:48:37 +05:30
def add_users_with_subscription(project, issuable)
@subscriber = create :user
@unsubscriber = create :user
@subscribed_participant = create_global_setting_for(create(:user, username: 'subscribed_participant'), :participating)
@watcher_and_subscriber = create_global_setting_for(create(:user), :watch)
2015-04-26 12:48:37 +05:30
2015-12-23 02:04:40 +05:30
project.team << [@subscribed_participant, :master]
2015-04-26 12:48:37 +05:30
project.team << [@subscriber, :master]
project.team << [@unsubscriber, :master]
project.team << [@watcher_and_subscriber, :master]
2015-04-26 12:48:37 +05:30
issuable.subscriptions.create(user: @subscriber, subscribed: true)
2015-12-23 02:04:40 +05:30
issuable.subscriptions.create(user: @subscribed_participant, subscribed: true)
2015-04-26 12:48:37 +05:30
issuable.subscriptions.create(user: @unsubscriber, subscribed: false)
# Make the watcher a subscriber to detect dupes
issuable.subscriptions.create(user: @watcher_and_subscriber, subscribed: true)
2015-04-26 12:48:37 +05:30
end
2014-09-02 18:07:02 +05:30
end