2019-02-15 15:39:39 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Projects::Operations::UpdateService do
|
|
|
|
set(:user) { create(:user) }
|
|
|
|
set(:project) { create(:project) }
|
|
|
|
|
|
|
|
let(:result) { subject.execute }
|
|
|
|
|
|
|
|
subject { described_class.new(project, user, params) }
|
|
|
|
|
|
|
|
describe '#execute' do
|
2019-07-31 22:56:46 +05:30
|
|
|
context 'metrics dashboard setting' do
|
|
|
|
let(:params) do
|
|
|
|
{
|
|
|
|
metrics_setting_attributes: {
|
|
|
|
external_dashboard_url: 'http://gitlab.com'
|
|
|
|
}
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without existing metrics dashboard setting' do
|
|
|
|
it 'creates a setting' do
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
|
|
|
|
|
|
expect(project.reload.metrics_setting.external_dashboard_url).to eq(
|
|
|
|
'http://gitlab.com'
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with existing metrics dashboard setting' do
|
|
|
|
before do
|
|
|
|
create(:project_metrics_setting, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates the settings' do
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
|
|
|
|
|
|
expect(project.reload.metrics_setting.external_dashboard_url).to eq(
|
|
|
|
'http://gitlab.com'
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with blank external_dashboard_url in params' do
|
|
|
|
let(:params) do
|
|
|
|
{
|
|
|
|
metrics_setting_attributes: {
|
|
|
|
external_dashboard_url: ''
|
|
|
|
}
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'destroys the metrics_setting entry in DB' do
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
|
|
|
|
|
|
expect(project.reload.metrics_setting).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
context 'error tracking' do
|
|
|
|
context 'with existing error tracking setting' do
|
|
|
|
let(:params) do
|
|
|
|
{
|
|
|
|
error_tracking_setting_attributes: {
|
|
|
|
enabled: false,
|
2019-07-07 11:18:12 +05:30
|
|
|
api_host: 'http://gitlab.com/',
|
|
|
|
token: 'token',
|
|
|
|
project: {
|
|
|
|
slug: 'project',
|
|
|
|
name: 'Project',
|
|
|
|
organization_slug: 'org',
|
|
|
|
organization_name: 'Org'
|
|
|
|
}
|
2019-02-15 15:39:39 +05:30
|
|
|
}
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
create(:project_error_tracking_setting, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates the settings' do
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
|
|
|
|
|
|
project.reload
|
|
|
|
expect(project.error_tracking_setting).not_to be_enabled
|
2019-07-07 11:18:12 +05:30
|
|
|
expect(project.error_tracking_setting.api_url).to eq(
|
|
|
|
'http://gitlab.com/api/0/projects/org/project/'
|
|
|
|
)
|
2019-02-15 15:39:39 +05:30
|
|
|
expect(project.error_tracking_setting.token).to eq('token')
|
2019-07-07 11:18:12 +05:30
|
|
|
expect(project.error_tracking_setting[:project_name]).to eq('Project')
|
|
|
|
expect(project.error_tracking_setting[:organization_name]).to eq('Org')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'disable error tracking' do
|
|
|
|
before do
|
|
|
|
params[:error_tracking_setting_attributes][:api_host] = ''
|
|
|
|
params[:error_tracking_setting_attributes][:enabled] = false
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'can set api_url to nil' do
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
|
|
|
|
|
|
project.reload
|
|
|
|
expect(project.error_tracking_setting).not_to be_enabled
|
|
|
|
expect(project.error_tracking_setting.api_url).to be_nil
|
|
|
|
expect(project.error_tracking_setting.token).to eq('token')
|
|
|
|
expect(project.error_tracking_setting[:project_name]).to eq('Project')
|
|
|
|
expect(project.error_tracking_setting[:organization_name]).to eq('Org')
|
|
|
|
end
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without an existing error tracking setting' do
|
|
|
|
let(:params) do
|
|
|
|
{
|
|
|
|
error_tracking_setting_attributes: {
|
|
|
|
enabled: true,
|
2019-07-07 11:18:12 +05:30
|
|
|
api_host: 'http://gitlab.com/',
|
|
|
|
token: 'token',
|
|
|
|
project: {
|
|
|
|
slug: 'project',
|
|
|
|
name: 'Project',
|
|
|
|
organization_slug: 'org',
|
|
|
|
organization_name: 'Org'
|
|
|
|
}
|
2019-02-15 15:39:39 +05:30
|
|
|
}
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates a setting' do
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
|
|
|
|
|
|
expect(project.error_tracking_setting).to be_enabled
|
2019-07-07 11:18:12 +05:30
|
|
|
expect(project.error_tracking_setting.api_url).to eq(
|
|
|
|
'http://gitlab.com/api/0/projects/org/project/'
|
|
|
|
)
|
2019-02-15 15:39:39 +05:30
|
|
|
expect(project.error_tracking_setting.token).to eq('token')
|
2019-07-07 11:18:12 +05:30
|
|
|
expect(project.error_tracking_setting[:project_name]).to eq('Project')
|
|
|
|
expect(project.error_tracking_setting[:organization_name]).to eq('Org')
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-10-31 01:37:42 +05:30
|
|
|
context 'with masked param token' do
|
|
|
|
let(:params) do
|
|
|
|
{
|
|
|
|
error_tracking_setting_attributes: {
|
|
|
|
enabled: false,
|
|
|
|
token: '*' * 8
|
|
|
|
}
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
create(:project_error_tracking_setting, project: project, token: 'token')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not update token' do
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
|
|
|
|
|
|
expect(project.error_tracking_setting.token).to eq('token')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
context 'with invalid parameters' do
|
|
|
|
let(:params) { {} }
|
|
|
|
|
|
|
|
let!(:error_tracking_setting) do
|
|
|
|
create(:project_error_tracking_setting, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does nothing' do
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
|
|
expect(project.reload.error_tracking_setting)
|
|
|
|
.to eq(error_tracking_setting)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with inappropriate params' do
|
|
|
|
let(:params) { { name: '' } }
|
|
|
|
|
|
|
|
let!(:original_name) { project.name }
|
|
|
|
|
|
|
|
it 'ignores params' do
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
|
|
expect(project.reload.name).to eq(original_name)
|
|
|
|
end
|
|
|
|
end
|
2019-12-21 20:55:43 +05:30
|
|
|
|
|
|
|
context 'grafana integration' do
|
|
|
|
let(:params) do
|
|
|
|
{
|
|
|
|
grafana_integration_attributes: {
|
|
|
|
grafana_url: 'http://new.grafana.com',
|
|
|
|
token: 'VerySecureToken='
|
|
|
|
}
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without existing grafana integration' do
|
|
|
|
it 'creates an integration' do
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
|
|
|
|
|
|
expected_attrs = params[:grafana_integration_attributes]
|
|
|
|
integration = project.reload.grafana_integration
|
|
|
|
|
|
|
|
expect(integration.grafana_url).to eq(expected_attrs[:grafana_url])
|
|
|
|
expect(integration.token).to eq(expected_attrs[:token])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with an existing grafana integration' do
|
|
|
|
before do
|
|
|
|
create(:grafana_integration, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates the settings' do
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
|
|
|
|
|
|
expected_attrs = params[:grafana_integration_attributes]
|
|
|
|
integration = project.reload.grafana_integration
|
|
|
|
|
|
|
|
expect(integration.grafana_url).to eq(expected_attrs[:grafana_url])
|
|
|
|
expect(integration.token).to eq(expected_attrs[:token])
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with all grafana attributes blank in params' do
|
|
|
|
let(:params) do
|
|
|
|
{
|
|
|
|
grafana_integration_attributes: {
|
|
|
|
grafana_url: '',
|
|
|
|
token: ''
|
|
|
|
}
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'destroys the metrics_setting entry in DB' do
|
|
|
|
expect(result[:status]).to eq(:success)
|
|
|
|
|
|
|
|
expect(project.reload.grafana_integration).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-02-15 15:39:39 +05:30
|
|
|
end
|
|
|
|
end
|