debian-mirror-gitlab/spec/services/projects/update_remote_mirror_service_spec.rb

160 lines
4.8 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2018-10-15 14:42:47 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Projects::UpdateRemoteMirrorService do
2020-11-24 15:15:51 +05:30
let_it_be(:project) { create(:project, :repository, lfs_enabled: true) }
let_it_be(:remote_project) { create(:forked_project_with_submodules) }
let_it_be(:remote_mirror) { create(:remote_mirror, project: project, enabled: true) }
2018-12-05 23:21:45 +05:30
let(:remote_name) { remote_mirror.remote_name }
2018-10-15 14:42:47 +05:30
2018-12-05 23:21:45 +05:30
subject(:service) { described_class.new(project, project.creator) }
2018-10-15 14:42:47 +05:30
2019-10-12 21:52:04 +05:30
describe '#execute' do
subject(:execute!) { service.execute(remote_mirror, 0) }
2018-10-15 14:42:47 +05:30
before do
2018-12-05 23:21:45 +05:30
project.repository.add_branch(project.owner, 'existing-branch', 'master')
2018-11-08 19:23:39 +05:30
2020-05-24 23:13:21 +05:30
allow(remote_mirror)
.to receive(:update_repository)
.and_return(double(divergent_refs: []))
2018-10-15 14:42:47 +05:30
end
2019-10-12 21:52:04 +05:30
it 'ensures the remote exists' do
2018-12-05 23:21:45 +05:30
expect(remote_mirror).to receive(:ensure_remote!)
2019-10-12 21:52:04 +05:30
execute!
2018-12-05 23:21:45 +05:30
end
2020-10-24 23:57:45 +05:30
it 'does not fetch the remote repository' do
# See https://gitlab.com/gitlab-org/gitaly/-/issues/2670
expect(project.repository).not_to receive(:fetch_remote)
2018-10-15 14:42:47 +05:30
2019-10-12 21:52:04 +05:30
execute!
2018-10-15 14:42:47 +05:30
end
2019-10-12 21:52:04 +05:30
it 'marks the mirror as started when beginning' do
expect(remote_mirror).to receive(:update_start!).and_call_original
execute!
end
it 'marks the mirror as successfully finished' do
result = execute!
2018-10-15 14:42:47 +05:30
expect(result[:status]).to eq(:success)
2019-10-12 21:52:04 +05:30
expect(remote_mirror).to be_finished
end
it 'marks the mirror as failed and raises the error when an unexpected error occurs' do
2020-10-24 23:57:45 +05:30
allow(remote_mirror).to receive(:update_repository).and_raise('Badly broken')
2019-10-12 21:52:04 +05:30
2020-05-24 23:13:21 +05:30
expect { execute! }.to raise_error(/Badly broken/)
2019-10-12 21:52:04 +05:30
expect(remote_mirror).to be_failed
expect(remote_mirror.last_error).to include('Badly broken')
end
2020-09-03 11:15:55 +05:30
context 'when the URL is blocked' do
before do
allow(Gitlab::UrlBlocker).to receive(:blocked_url?).and_return(true)
end
it 'fails and returns error status' do
expect(execute!).to eq(status: :error, message: 'The remote mirror URL is invalid.')
end
end
context "when given URLs containing escaped elements" do
2021-01-03 14:25:43 +05:30
it_behaves_like "URLs containing escaped elements return expected status" do
let(:result) { execute! }
2020-09-03 11:15:55 +05:30
before do
allow(remote_mirror).to receive(:url).and_return(url)
end
end
end
2019-10-12 21:52:04 +05:30
context 'when the update fails because of a `Gitlab::Git::CommandError`' do
before do
2020-10-24 23:57:45 +05:30
allow(remote_mirror).to receive(:update_repository)
.and_raise(Gitlab::Git::CommandError.new('update failed'))
2019-10-12 21:52:04 +05:30
end
it 'wraps `Gitlab::Git::CommandError`s in a service error' do
2020-10-24 23:57:45 +05:30
expect(execute!).to eq(status: :error, message: 'update failed')
2019-10-12 21:52:04 +05:30
end
it 'marks the mirror as to be retried' do
execute!
expect(remote_mirror).to be_to_retry
2020-10-24 23:57:45 +05:30
expect(remote_mirror.last_error).to include('update failed')
2019-10-12 21:52:04 +05:30
end
it "marks the mirror as failed after #{described_class::MAX_TRIES} tries" do
service.execute(remote_mirror, described_class::MAX_TRIES)
expect(remote_mirror).to be_failed
2020-10-24 23:57:45 +05:30
expect(remote_mirror.last_error).to include('update failed')
2019-10-12 21:52:04 +05:30
end
2018-10-15 14:42:47 +05:30
end
2020-05-24 23:13:21 +05:30
context 'when there are divergent refs' do
it 'marks the mirror as failed and sets an error message' do
response = double(divergent_refs: %w[refs/heads/master refs/heads/develop])
expect(remote_mirror).to receive(:update_repository).and_return(response)
2018-10-15 14:42:47 +05:30
2019-10-12 21:52:04 +05:30
execute!
2018-10-15 14:42:47 +05:30
2020-05-24 23:13:21 +05:30
expect(remote_mirror).to be_failed
expect(remote_mirror.last_error).to include("Some refs have diverged")
expect(remote_mirror.last_error).to include("refs/heads/master\n")
expect(remote_mirror.last_error).to include("refs/heads/develop")
2018-12-05 23:21:45 +05:30
end
2018-10-15 14:42:47 +05:30
end
2020-11-24 15:15:51 +05:30
context "sending lfs objects" do
let_it_be(:lfs_pointer) { create(:lfs_objects_project, project: project) }
before do
stub_lfs_setting(enabled: true)
end
2021-01-03 14:25:43 +05:30
it 'pushes LFS objects to a HTTP repository' do
expect_next_instance_of(Lfs::PushService) do |service|
expect(service).to receive(:execute)
2020-11-24 15:15:51 +05:30
end
2021-01-03 14:25:43 +05:30
execute!
end
2020-11-24 15:15:51 +05:30
2021-01-03 14:25:43 +05:30
it 'does nothing to an SSH repository' do
remote_mirror.update!(url: 'ssh://example.com')
2020-11-24 15:15:51 +05:30
2021-01-03 14:25:43 +05:30
expect_any_instance_of(Lfs::PushService).not_to receive(:execute)
2020-11-24 15:15:51 +05:30
2021-01-03 14:25:43 +05:30
execute!
end
2020-11-24 15:15:51 +05:30
2021-01-03 14:25:43 +05:30
it 'does nothing if LFS is disabled' do
expect(project).to receive(:lfs_enabled?) { false }
2020-11-24 15:15:51 +05:30
2021-01-03 14:25:43 +05:30
expect_any_instance_of(Lfs::PushService).not_to receive(:execute)
2020-11-24 15:15:51 +05:30
2021-01-03 14:25:43 +05:30
execute!
2020-11-24 15:15:51 +05:30
end
2021-01-03 14:25:43 +05:30
it 'does nothing if non-password auth is specified' do
remote_mirror.update!(auth_method: 'ssh_public_key')
2020-11-24 15:15:51 +05:30
2021-01-03 14:25:43 +05:30
expect_any_instance_of(Lfs::PushService).not_to receive(:execute)
2020-11-24 15:15:51 +05:30
2021-01-03 14:25:43 +05:30
execute!
2020-11-24 15:15:51 +05:30
end
end
2018-10-15 14:42:47 +05:30
end
end