debian-mirror-gitlab/spec/services/projects/transfer_service_spec.rb

550 lines
16 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2014-09-02 18:07:02 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Projects::TransferService do
2018-12-05 23:21:45 +05:30
include GitHelpers
2020-11-24 15:15:51 +05:30
let_it_be(:user) { create(:user) }
let_it_be(:group) { create(:group) }
2018-03-27 19:54:05 +05:30
let(:project) { create(:project, :repository, :legacy_storage, namespace: user.namespace) }
2014-09-02 18:07:02 +05:30
2020-05-24 23:13:21 +05:30
subject(:execute_transfer) { described_class.new(project, user).execute(group) }
2020-10-24 23:57:45 +05:30
context 'with npm packages' do
before do
group.add_owner(user)
end
subject(:transfer_service) { described_class.new(project, user) }
let!(:package) { create(:npm_package, project: project) }
context 'with a root namespace change' do
it 'does not allow the transfer' do
expect(transfer_service.execute(group)).to be false
expect(project.errors[:new_namespace]).to include("Root namespace can't be updated if project has NPM packages")
end
end
context 'without a root namespace change' do
let(:root) { create(:group) }
let(:group) { create(:group, parent: root) }
let(:other_group) { create(:group, parent: root) }
let(:project) { create(:project, :repository, namespace: group) }
before do
other_group.add_owner(user)
end
it 'does allow the transfer' do
expect(transfer_service.execute(other_group)).to be true
expect(project.errors[:new_namespace]).to be_empty
end
end
end
2014-09-02 18:07:02 +05:30
context 'namespace -> namespace' do
before do
2020-05-24 23:13:21 +05:30
allow_next_instance_of(Gitlab::UploadsTransfer) do |service|
allow(service).to receive(:move_project).and_return(true)
end
allow_next_instance_of(Gitlab::PagesTransfer) do |service|
allow(service).to receive(:move_project).and_return(true)
end
2014-09-02 18:07:02 +05:30
group.add_owner(user)
end
2020-05-24 23:13:21 +05:30
it 'updates the namespace' do
transfer_result = execute_transfer
expect(transfer_result).to be_truthy
expect(project.namespace).to eq(group)
end
2014-09-02 18:07:02 +05:30
end
2017-09-10 17:25:29 +05:30
context 'when transfer succeeds' do
before do
group.add_owner(user)
end
it 'sends notifications' do
expect_any_instance_of(NotificationService).to receive(:project_was_moved)
2020-05-24 23:13:21 +05:30
execute_transfer
2017-09-10 17:25:29 +05:30
end
2018-05-09 12:01:36 +05:30
it 'invalidates the user\'s personal_project_count cache' do
expect(user).to receive(:invalidate_personal_projects_count)
2020-05-24 23:13:21 +05:30
execute_transfer
2018-05-09 12:01:36 +05:30
end
2017-09-10 17:25:29 +05:30
it 'executes system hooks' do
2020-05-24 23:13:21 +05:30
expect_next_instance_of(described_class) do |service|
2017-09-10 17:25:29 +05:30
expect(service).to receive(:execute_system_hooks)
end
2020-05-24 23:13:21 +05:30
execute_transfer
2017-09-10 17:25:29 +05:30
end
2018-03-17 18:26:18 +05:30
2020-03-13 15:44:24 +05:30
it 'moves the disk path', :aggregate_failures do
2018-03-17 18:26:18 +05:30
old_path = project.repository.disk_path
old_full_path = project.repository.full_path
2020-05-24 23:13:21 +05:30
execute_transfer
2020-03-13 15:44:24 +05:30
project.reload_repository!
2018-03-17 18:26:18 +05:30
expect(project.repository.disk_path).not_to eq(old_path)
expect(project.repository.full_path).not_to eq(old_full_path)
expect(project.disk_path).not_to eq(old_path)
expect(project.disk_path).to start_with(group.path)
end
it 'updates project full path in .git/config' do
2020-05-24 23:13:21 +05:30
execute_transfer
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
expect(rugged_config['gitlab.fullpath']).to eq "#{group.full_path}/#{project.path}"
2018-03-17 18:26:18 +05:30
end
2019-02-15 15:39:39 +05:30
it 'updates storage location' do
2020-05-24 23:13:21 +05:30
execute_transfer
2019-02-15 15:39:39 +05:30
expect(project.project_repository).to have_attributes(
disk_path: "#{group.full_path}/#{project.path}",
shard_name: project.repository_storage
)
end
2017-09-10 17:25:29 +05:30
end
context 'when transfer fails' do
let!(:original_path) { project_path(project) }
def attempt_project_transfer(&block)
expect do
2020-05-24 23:13:21 +05:30
execute_transfer
2017-09-10 17:25:29 +05:30
end.to raise_error(ActiveRecord::ActiveRecordError)
end
before do
group.add_owner(user)
expect_any_instance_of(Labels::TransferService).to receive(:execute).and_raise(ActiveRecord::StatementInvalid, "PG ERROR")
end
def project_path(project)
2018-11-08 19:23:39 +05:30
Gitlab::GitalyClient::StorageSettings.allow_disk_access do
project.repository.path_to_repo
end
2017-09-10 17:25:29 +05:30
end
def current_path
project_path(project)
end
it 'rolls back repo location' do
attempt_project_transfer
2020-04-08 14:13:33 +05:30
expect(project.repository.raw.exists?).to be(true)
2017-09-10 17:25:29 +05:30
expect(original_path).to eq current_path
end
2018-03-17 18:26:18 +05:30
it 'rolls back project full path in .git/config' do
attempt_project_transfer
2018-11-08 19:23:39 +05:30
expect(rugged_config['gitlab.fullpath']).to eq project.full_path
2018-03-17 18:26:18 +05:30
end
2017-09-10 17:25:29 +05:30
it "doesn't send move notifications" do
expect_any_instance_of(NotificationService).not_to receive(:project_was_moved)
attempt_project_transfer
end
it "doesn't run system hooks" do
attempt_project_transfer do |service|
expect(service).not_to receive(:execute_system_hooks)
end
end
2019-02-15 15:39:39 +05:30
it 'does not update storage location' do
create(:project_repository, project: project)
attempt_project_transfer
expect(project.project_repository).to have_attributes(
disk_path: project.disk_path,
shard_name: project.repository_storage
)
end
2017-09-10 17:25:29 +05:30
end
2014-09-02 18:07:02 +05:30
context 'namespace -> no namespace' do
2020-05-24 23:13:21 +05:30
let(:group) { nil }
it 'does not allow the project transfer' do
transfer_result = execute_transfer
2014-09-02 18:07:02 +05:30
2020-05-24 23:13:21 +05:30
expect(transfer_result).to eq false
expect(project.namespace).to eq(user.namespace)
expect(project.errors.messages[:new_namespace].first).to eq 'Please select a new namespace for your project.'
end
2014-09-02 18:07:02 +05:30
end
2018-12-13 13:39:08 +05:30
context 'disallow transferring of project with tags' do
2017-08-17 22:00:37 +05:30
let(:container_repository) { create(:container_repository) }
2016-06-02 11:05:42 +05:30
before do
stub_container_registry_config(enabled: true)
2017-08-17 22:00:37 +05:30
stub_container_registry_tags(repository: :any, tags: ['tag'])
project.container_repositories << container_repository
2016-06-02 11:05:42 +05:30
end
2020-05-24 23:13:21 +05:30
it 'does not allow the project transfer' do
expect(execute_transfer).to eq false
end
2016-06-02 11:05:42 +05:30
end
2014-09-02 18:07:02 +05:30
context 'namespace -> not allowed namespace' do
2020-05-24 23:13:21 +05:30
it 'does not allow the project transfer' do
transfer_result = execute_transfer
2014-09-02 18:07:02 +05:30
2020-05-24 23:13:21 +05:30
expect(transfer_result).to eq false
expect(project.namespace).to eq(user.namespace)
end
2015-04-26 12:48:37 +05:30
end
2017-09-10 17:25:29 +05:30
context 'namespace which contains orphan repository with same projects path name' do
2020-04-08 14:13:33 +05:30
let(:fake_repo_path) { File.join(TestEnv.repos_path, group.full_path, "#{project.path}.git") }
2017-09-10 17:25:29 +05:30
before do
group.add_owner(user)
2018-03-17 18:26:18 +05:30
2020-04-08 14:13:33 +05:30
TestEnv.create_bare_repository(fake_repo_path)
2017-09-10 17:25:29 +05:30
end
after do
2020-04-08 14:13:33 +05:30
FileUtils.rm_rf(fake_repo_path)
2017-09-10 17:25:29 +05:30
end
2020-05-24 23:13:21 +05:30
it 'does not allow the project transfer' do
transfer_result = execute_transfer
expect(transfer_result).to eq false
expect(project.namespace).to eq(user.namespace)
expect(project.errors[:new_namespace]).to include('Cannot move project')
end
2017-09-10 17:25:29 +05:30
end
2018-11-20 20:47:30 +05:30
context 'target namespace containing the same project name' do
before do
group.add_owner(user)
2020-05-24 23:13:21 +05:30
create(:project, name: project.name, group: group, path: 'other')
end
2018-11-20 20:47:30 +05:30
2020-05-24 23:13:21 +05:30
it 'does not allow the project transfer' do
transfer_result = execute_transfer
2018-11-20 20:47:30 +05:30
2020-05-24 23:13:21 +05:30
expect(transfer_result).to eq false
expect(project.namespace).to eq(user.namespace)
expect(project.errors[:new_namespace]).to include('Project with same name or path in target namespace already exists')
2018-11-20 20:47:30 +05:30
end
end
context 'target namespace containing the same project path' do
before do
group.add_owner(user)
create(:project, name: 'other-name', path: project.path, group: group)
end
2020-05-24 23:13:21 +05:30
it 'does not allow the project transfer' do
transfer_result = execute_transfer
expect(transfer_result).to eq false
expect(project.namespace).to eq(user.namespace)
expect(project.errors[:new_namespace]).to include('Project with same name or path in target namespace already exists')
end
2018-11-20 20:47:30 +05:30
end
2019-10-31 01:37:42 +05:30
context 'target namespace allows developers to create projects' do
let(:group) { create(:group, project_creation_level: ::Gitlab::Access::DEVELOPER_MAINTAINER_PROJECT_ACCESS) }
context 'the user is a member of the target namespace with developer permissions' do
before do
group.add_developer(user)
end
it 'does not allow project transfer to the target namespace' do
2020-05-24 23:13:21 +05:30
transfer_result = execute_transfer
expect(transfer_result).to eq false
2019-10-31 01:37:42 +05:30
expect(project.namespace).to eq(user.namespace)
expect(project.errors[:new_namespace]).to include('Transfer failed, please contact an admin.')
end
end
end
2016-06-02 11:05:42 +05:30
context 'visibility level' do
2020-05-24 23:13:21 +05:30
let(:group) { create(:group, :internal) }
2016-06-02 11:05:42 +05:30
2017-09-10 17:25:29 +05:30
before do
2020-05-24 23:13:21 +05:30
group.add_owner(user)
2017-09-10 17:25:29 +05:30
end
2016-06-02 11:05:42 +05:30
context 'when namespace visibility level < project visibility level' do
2020-05-24 23:13:21 +05:30
let(:project) { create(:project, :public, :repository, namespace: user.namespace) }
2016-06-02 11:05:42 +05:30
2017-09-10 17:25:29 +05:30
before do
2020-05-24 23:13:21 +05:30
execute_transfer
2017-09-10 17:25:29 +05:30
end
2016-06-02 11:05:42 +05:30
2020-05-24 23:13:21 +05:30
it { expect(project.visibility_level).to eq(group.visibility_level) }
2016-06-02 11:05:42 +05:30
end
context 'when namespace visibility level > project visibility level' do
2020-05-24 23:13:21 +05:30
let(:project) { create(:project, :private, :repository, namespace: user.namespace) }
2016-06-02 11:05:42 +05:30
2017-09-10 17:25:29 +05:30
before do
2020-05-24 23:13:21 +05:30
execute_transfer
2017-09-10 17:25:29 +05:30
end
2016-06-02 11:05:42 +05:30
2020-05-24 23:13:21 +05:30
it { expect(project.visibility_level).to eq(Gitlab::VisibilityLevel::PRIVATE) }
2016-06-02 11:05:42 +05:30
end
end
2021-01-03 14:25:43 +05:30
context 'shared Runners group level configurations' do
using RSpec::Parameterized::TableSyntax
where(:project_shared_runners_enabled, :shared_runners_setting, :expected_shared_runners_enabled) do
true | 'disabled_and_unoverridable' | false
false | 'disabled_and_unoverridable' | false
true | 'disabled_with_override' | true
false | 'disabled_with_override' | false
true | 'enabled' | true
false | 'enabled' | false
end
with_them do
let(:project) { create(:project, :public, :repository, namespace: user.namespace, shared_runners_enabled: project_shared_runners_enabled) }
let(:group) { create(:group) }
before do
group.add_owner(user)
expect_next_found_instance_of(Group) do |group|
expect(group).to receive(:shared_runners_setting).and_return(shared_runners_setting)
end
execute_transfer
end
it 'updates shared runners based on the parent group' do
expect(project.shared_runners_enabled).to eq(expected_shared_runners_enabled)
end
end
end
2016-11-03 12:29:30 +05:30
context 'missing group labels applied to issues or merge requests' do
2019-12-04 20:38:33 +05:30
it 'delegates transfer to Labels::TransferService' do
2016-11-03 12:29:30 +05:30
group.add_owner(user)
2020-05-24 23:13:21 +05:30
expect_next_instance_of(Labels::TransferService, user, project.group, project) do |labels_transfer_service|
expect(labels_transfer_service).to receive(:execute).once.and_call_original
end
2016-11-03 12:29:30 +05:30
2020-05-24 23:13:21 +05:30
execute_transfer
2016-11-03 12:29:30 +05:30
end
end
2017-08-17 22:00:37 +05:30
2019-12-04 20:38:33 +05:30
context 'missing group milestones applied to issues or merge requests' do
it 'delegates transfer to Milestones::TransferService' do
group.add_owner(user)
2020-05-24 23:13:21 +05:30
expect_next_instance_of(Milestones::TransferService, user, project.group, project) do |milestones_transfer_service|
expect(milestones_transfer_service).to receive(:execute).once.and_call_original
end
2019-12-04 20:38:33 +05:30
2020-05-24 23:13:21 +05:30
execute_transfer
2019-12-04 20:38:33 +05:30
end
end
2018-03-17 18:26:18 +05:30
context 'when hashed storage in use' do
2020-05-24 23:13:21 +05:30
let!(:project) { create(:project, :repository, namespace: user.namespace) }
let!(:old_disk_path) { project.repository.disk_path }
2018-03-17 18:26:18 +05:30
before do
group.add_owner(user)
end
2020-03-13 15:44:24 +05:30
it 'does not move the disk path', :aggregate_failures do
2020-05-24 23:13:21 +05:30
new_full_path = "#{group.full_path}/#{project.path}"
2018-03-17 18:26:18 +05:30
2020-05-24 23:13:21 +05:30
execute_transfer
2018-03-17 18:26:18 +05:30
2020-05-24 23:13:21 +05:30
project.reload_repository!
expect(project.repository).to have_attributes(
2020-03-13 15:44:24 +05:30
disk_path: old_disk_path,
full_path: new_full_path
)
2020-05-24 23:13:21 +05:30
expect(project.disk_path).to eq(old_disk_path)
2020-03-13 15:44:24 +05:30
end
it 'does not move the disk path when the transfer fails', :aggregate_failures do
2020-05-24 23:13:21 +05:30
old_full_path = project.full_path
2020-03-13 15:44:24 +05:30
expect_next_instance_of(described_class) do |service|
allow(service).to receive(:execute_system_hooks).and_raise('foo')
end
2020-05-24 23:13:21 +05:30
expect { execute_transfer }.to raise_error('foo')
project.reload_repository!
2020-03-13 15:44:24 +05:30
2020-05-24 23:13:21 +05:30
expect(project.repository).to have_attributes(
2020-03-13 15:44:24 +05:30
disk_path: old_disk_path,
full_path: old_full_path
)
2020-05-24 23:13:21 +05:30
expect(project.disk_path).to eq(old_disk_path)
2018-03-17 18:26:18 +05:30
end
end
2017-08-17 22:00:37 +05:30
describe 'refreshing project authorizations' do
let(:group) { create(:group) }
let(:owner) { project.namespace.owner }
let(:group_member) { create(:user) }
before do
2018-11-18 11:00:15 +05:30
group.add_user(owner, GroupMember::MAINTAINER)
2017-08-17 22:00:37 +05:30
group.add_user(group_member, GroupMember::DEVELOPER)
end
it 'refreshes the permissions of the old and new namespace' do
2020-05-24 23:13:21 +05:30
execute_transfer
2017-08-17 22:00:37 +05:30
expect(group_member.authorized_projects).to include(project)
expect(owner.authorized_projects).to include(project)
end
it 'only schedules a single job for every user' do
2020-05-24 23:13:21 +05:30
expect_next_instance_of(UserProjectAccessChangedService, [owner.id, group_member.id]) do |service|
expect(service).to receive(:execute).once.and_call_original
end
execute_transfer
end
end
describe 'transferring a design repository' do
subject { described_class.new(project, user) }
before do
group.add_owner(user)
end
def design_repository
project.design_repository
end
it 'does not create a design repository' do
expect(subject.execute(group)).to be true
project.clear_memoization(:design_repository)
expect(design_repository.exists?).to be false
end
2017-08-17 22:00:37 +05:30
2020-05-24 23:13:21 +05:30
describe 'when the project has a design repository' do
let(:project_repo_path) { "#{project.path}#{::Gitlab::GlRepository::DESIGN.path_suffix}" }
let(:old_full_path) { "#{user.namespace.full_path}/#{project_repo_path}" }
let(:new_full_path) { "#{group.full_path}/#{project_repo_path}" }
context 'with legacy storage' do
let(:project) { create(:project, :repository, :legacy_storage, :design_repo, namespace: user.namespace) }
it 'moves the repository' do
expect(subject.execute(group)).to be true
project.clear_memoization(:design_repository)
expect(design_repository).to have_attributes(
disk_path: new_full_path,
full_path: new_full_path
)
end
it 'does not move the repository when an error occurs', :aggregate_failures do
allow(subject).to receive(:execute_system_hooks).and_raise('foo')
expect { subject.execute(group) }.to raise_error('foo')
project.clear_memoization(:design_repository)
expect(design_repository).to have_attributes(
disk_path: old_full_path,
full_path: old_full_path
)
end
end
context 'with hashed storage' do
let(:project) { create(:project, :repository, namespace: user.namespace) }
it 'does not move the repository' do
old_disk_path = design_repository.disk_path
expect(subject.execute(group)).to be true
project.clear_memoization(:design_repository)
expect(design_repository).to have_attributes(
disk_path: old_disk_path,
full_path: new_full_path
)
end
it 'does not move the repository when an error occurs' do
old_disk_path = design_repository.disk_path
allow(subject).to receive(:execute_system_hooks).and_raise('foo')
expect { subject.execute(group) }.to raise_error('foo')
project.clear_memoization(:design_repository)
expect(design_repository).to have_attributes(
disk_path: old_disk_path,
full_path: old_full_path
)
end
end
2017-08-17 22:00:37 +05:30
end
end
2018-11-08 19:23:39 +05:30
2020-11-24 15:15:51 +05:30
context 'moving pages' do
let_it_be(:project) { create(:project, namespace: user.namespace) }
before do
group.add_owner(user)
end
it 'schedules a job when pages are deployed' do
project.mark_pages_as_deployed
expect(PagesTransferWorker).to receive(:perform_async)
.with("move_project", [project.path, user.namespace.full_path, group.full_path])
execute_transfer
end
it 'does not schedule a job when no pages are deployed' do
expect(PagesTransferWorker).not_to receive(:perform_async)
execute_transfer
end
end
2018-11-08 19:23:39 +05:30
def rugged_config
2018-12-05 23:21:45 +05:30
rugged_repo(project.repository).config
2018-11-08 19:23:39 +05:30
end
2014-09-02 18:07:02 +05:30
end