2015-04-26 12:48:37 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Import::BitbucketController do
|
2015-09-11 14:41:01 +05:30
|
|
|
include ImportSpecHelper
|
|
|
|
|
2015-09-25 12:07:36 +05:30
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:token) { "asdasd12345" }
|
|
|
|
let(:secret) { "sekrettt" }
|
|
|
|
let(:access_params) { { bitbucket_access_token: token, bitbucket_access_token_secret: secret } }
|
|
|
|
|
|
|
|
def assign_session_tokens
|
|
|
|
session[:bitbucket_access_token] = token
|
|
|
|
session[:bitbucket_access_token_secret] = secret
|
|
|
|
end
|
2015-04-26 12:48:37 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
2015-09-11 14:41:01 +05:30
|
|
|
allow(controller).to receive(:bitbucket_import_enabled?).and_return(true)
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe "GET callback" do
|
|
|
|
before do
|
|
|
|
session[:oauth_request_token] = {}
|
|
|
|
end
|
2015-09-11 14:41:01 +05:30
|
|
|
|
2015-04-26 12:48:37 +05:30
|
|
|
it "updates access token" do
|
|
|
|
access_token = double(token: token, secret: secret)
|
2015-09-11 14:41:01 +05:30
|
|
|
allow_any_instance_of(Gitlab::BitbucketImport::Client).
|
|
|
|
to receive(:get_token).and_return(access_token)
|
|
|
|
stub_omniauth_provider('bitbucket')
|
2015-04-26 12:48:37 +05:30
|
|
|
|
|
|
|
get :callback
|
|
|
|
|
2015-09-25 12:07:36 +05:30
|
|
|
expect(session[:bitbucket_access_token]).to eq(token)
|
|
|
|
expect(session[:bitbucket_access_token_secret]).to eq(secret)
|
2015-04-26 12:48:37 +05:30
|
|
|
expect(controller).to redirect_to(status_import_bitbucket_url)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "GET status" do
|
|
|
|
before do
|
|
|
|
@repo = OpenStruct.new(slug: 'vim', owner: 'asd')
|
2015-09-25 12:07:36 +05:30
|
|
|
assign_session_tokens
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it "assigns variables" do
|
|
|
|
@project = create(:project, import_type: 'bitbucket', creator_id: user.id)
|
2015-09-11 14:41:01 +05:30
|
|
|
client = stub_client(projects: [@repo])
|
|
|
|
allow(client).to receive(:incompatible_projects).and_return([])
|
2015-04-26 12:48:37 +05:30
|
|
|
|
|
|
|
get :status
|
|
|
|
|
|
|
|
expect(assigns(:already_added_projects)).to eq([@project])
|
|
|
|
expect(assigns(:repos)).to eq([@repo])
|
2015-09-11 14:41:01 +05:30
|
|
|
expect(assigns(:incompatible_repos)).to eq([])
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it "does not show already added project" do
|
|
|
|
@project = create(:project, import_type: 'bitbucket', creator_id: user.id, import_source: 'asd/vim')
|
2015-09-11 14:41:01 +05:30
|
|
|
stub_client(projects: [@repo])
|
2015-04-26 12:48:37 +05:30
|
|
|
|
|
|
|
get :status
|
|
|
|
|
|
|
|
expect(assigns(:already_added_projects)).to eq([@project])
|
|
|
|
expect(assigns(:repos)).to eq([])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "POST create" do
|
|
|
|
let(:bitbucket_username) { user.username }
|
|
|
|
|
2015-09-11 14:41:01 +05:30
|
|
|
let(:bitbucket_user) do
|
|
|
|
{ user: { username: bitbucket_username } }.with_indifferent_access
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:bitbucket_repo) do
|
|
|
|
{ slug: "vim", owner: bitbucket_username }.with_indifferent_access
|
|
|
|
end
|
2015-04-26 12:48:37 +05:30
|
|
|
|
|
|
|
before do
|
|
|
|
allow(Gitlab::BitbucketImport::KeyAdder).
|
2015-09-25 12:07:36 +05:30
|
|
|
to receive(:new).with(bitbucket_repo, user, access_params).
|
2015-04-26 12:48:37 +05:30
|
|
|
and_return(double(execute: true))
|
|
|
|
|
2015-09-11 14:41:01 +05:30
|
|
|
stub_client(user: bitbucket_user, project: bitbucket_repo)
|
2015-09-25 12:07:36 +05:30
|
|
|
assign_session_tokens
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context "when the repository owner is the Bitbucket user" do
|
|
|
|
context "when the Bitbucket user and GitLab user's usernames match" do
|
|
|
|
it "takes the current user's namespace" do
|
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator).
|
2015-09-25 12:07:36 +05:30
|
|
|
to receive(:new).with(bitbucket_repo, user.namespace, user, access_params).
|
2015-04-26 12:48:37 +05:30
|
|
|
and_return(double(execute: true))
|
|
|
|
|
|
|
|
post :create, format: :js
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when the Bitbucket user and GitLab user's usernames don't match" do
|
|
|
|
let(:bitbucket_username) { "someone_else" }
|
|
|
|
|
|
|
|
it "takes the current user's namespace" do
|
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator).
|
2015-09-25 12:07:36 +05:30
|
|
|
to receive(:new).with(bitbucket_repo, user.namespace, user, access_params).
|
2015-04-26 12:48:37 +05:30
|
|
|
and_return(double(execute: true))
|
|
|
|
|
|
|
|
post :create, format: :js
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when the repository owner is not the Bitbucket user" do
|
|
|
|
let(:other_username) { "someone_else" }
|
|
|
|
|
|
|
|
before do
|
|
|
|
bitbucket_repo["owner"] = other_username
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when a namespace with the Bitbucket user's username already exists" do
|
|
|
|
let!(:existing_namespace) { create(:namespace, name: other_username, owner: user) }
|
|
|
|
|
|
|
|
context "when the namespace is owned by the GitLab user" do
|
|
|
|
it "takes the existing namespace" do
|
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator).
|
2015-09-25 12:07:36 +05:30
|
|
|
to receive(:new).with(bitbucket_repo, existing_namespace, user, access_params).
|
2015-04-26 12:48:37 +05:30
|
|
|
and_return(double(execute: true))
|
|
|
|
|
|
|
|
post :create, format: :js
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when the namespace is not owned by the GitLab user" do
|
|
|
|
before do
|
|
|
|
existing_namespace.owner = create(:user)
|
|
|
|
existing_namespace.save
|
|
|
|
end
|
|
|
|
|
|
|
|
it "doesn't create a project" do
|
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator).
|
|
|
|
not_to receive(:new)
|
|
|
|
|
|
|
|
post :create, format: :js
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when a namespace with the Bitbucket user's username doesn't exist" do
|
|
|
|
it "creates the namespace" do
|
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator).
|
|
|
|
to receive(:new).and_return(double(execute: true))
|
|
|
|
|
|
|
|
post :create, format: :js
|
|
|
|
|
|
|
|
expect(Namespace.where(name: other_username).first).not_to be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it "takes the new namespace" do
|
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator).
|
2015-09-25 12:07:36 +05:30
|
|
|
to receive(:new).with(bitbucket_repo, an_instance_of(Group), user, access_params).
|
2015-04-26 12:48:37 +05:30
|
|
|
and_return(double(execute: true))
|
|
|
|
|
|
|
|
post :create, format: :js
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|