debian-mirror-gitlab/spec/graphql/mutations/discussions/toggle_resolve_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

167 lines
5.5 KiB
Ruby
Raw Normal View History

2020-06-23 00:09:42 +05:30
# frozen_string_literal: true
require 'spec_helper'
RSpec.describe Mutations::Discussions::ToggleResolve do
2022-07-16 23:28:13 +05:30
include GraphqlHelpers
2020-06-23 00:09:42 +05:30
subject(:mutation) do
described_class.new(object: nil, context: { current_user: user }, field: nil)
end
2021-10-29 20:43:33 +05:30
let_it_be(:author) { create(:user) }
2020-06-23 00:09:42 +05:30
let_it_be(:project) { create(:project, :repository) }
describe '#resolve' do
subject do
2021-02-22 17:27:13 +05:30
mutation.resolve(id: id_arg, resolve: resolve_arg)
2020-06-23 00:09:42 +05:30
end
2022-07-16 23:28:13 +05:30
let(:id_arg) { global_id_of(discussion) }
2020-06-23 00:09:42 +05:30
let(:resolve_arg) { true }
let(:mutated_discussion) { subject[:discussion] }
let(:errors) { subject[:errors] }
shared_examples 'a working resolve method' do
context 'when the user does not have permission' do
let_it_be(:user) { create(:user) }
it 'raises an error if the resource is not accessible to the user' do
expect { subject }.to raise_error(
Gitlab::Graphql::Errors::ResourceNotAvailable,
2021-12-11 22:18:48 +05:30
Gitlab::Graphql::Authorize::AuthorizeResource::RESOURCE_ACCESS_ERROR
2020-06-23 00:09:42 +05:30
)
end
end
context 'when the user has permission' do
let_it_be(:user) { create(:user, developer_projects: [project]) }
context 'when discussion cannot be found' do
2022-07-16 23:28:13 +05:30
let(:id_arg) { global_id_of(id: non_existing_record_id, model_name: discussion.class.name) }
2020-06-23 00:09:42 +05:30
it 'raises an error' do
expect { subject }.to raise_error(
Gitlab::Graphql::Errors::ResourceNotAvailable,
2021-12-11 22:18:48 +05:30
Gitlab::Graphql::Authorize::AuthorizeResource::RESOURCE_ACCESS_ERROR
2020-06-23 00:09:42 +05:30
)
end
end
shared_examples 'returns a resolved discussion without errors' do
it 'returns a resolved discussion' do
expect(mutated_discussion).to be_resolved
end
it 'returns empty errors' do
expect(errors).to be_empty
end
end
shared_examples 'returns an unresolved discussion without errors' do
it 'returns an unresolved discussion' do
expect(mutated_discussion).not_to be_resolved
end
it 'returns empty errors' do
expect(errors).to be_empty
end
end
context 'when the `resolve` argument is true' do
include_examples 'returns a resolved discussion without errors'
context 'when the discussion is already resolved' do
before do
discussion.resolve!(user)
end
include_examples 'returns a resolved discussion without errors'
end
context 'when the service raises an `ActiveRecord::RecordNotSaved` error' do
before do
allow_next_instance_of(::Discussions::ResolveService) do |service|
allow(service).to receive(:execute).and_raise(ActiveRecord::RecordNotSaved)
end
end
it 'does not resolve the discussion' do
expect(mutated_discussion).not_to be_resolved
end
it 'returns errors' do
expect(errors).to contain_exactly('Discussion failed to be resolved')
end
end
end
context 'when the `resolve` argument is false' do
let(:resolve_arg) { false }
context 'when the discussion is resolved' do
before do
discussion.resolve!(user)
end
include_examples 'returns an unresolved discussion without errors'
context 'when the service raises an `ActiveRecord::RecordNotSaved` error' do
before do
allow_next_instance_of(discussion.class) do |instance|
allow(instance).to receive(:unresolve!).and_raise(ActiveRecord::RecordNotSaved)
end
end
it 'does not unresolve the discussion' do
expect(mutated_discussion).to be_resolved
end
it 'returns errors' do
expect(errors).to contain_exactly('Discussion failed to be unresolved')
end
end
end
context 'when the discussion is already unresolved' do
include_examples 'returns an unresolved discussion without errors'
end
end
end
2021-10-29 20:43:33 +05:30
context 'when user is the author and discussion is locked' do
let(:user) { author }
before do
issuable.update!(discussion_locked: true)
end
it 'raises an error' do
expect { mutation.resolve(id: id_arg, resolve: resolve_arg) }.to raise_error(
Gitlab::Graphql::Errors::ResourceNotAvailable,
"The resource that you are attempting to access does not exist or you don't have permission to perform this action"
)
end
end
2020-06-23 00:09:42 +05:30
end
context 'when discussion is on a merge request' do
2021-10-29 20:43:33 +05:30
let_it_be(:noteable) { create(:merge_request, source_project: project, author: author) }
2021-09-30 23:02:18 +05:30
2020-06-23 00:09:42 +05:30
let(:discussion) { create(:diff_note_on_merge_request, noteable: noteable, project: project).to_discussion }
2021-10-29 20:43:33 +05:30
let(:issuable) { noteable }
2020-06-23 00:09:42 +05:30
it_behaves_like 'a working resolve method'
end
context 'when discussion is on a design' do
2021-10-29 20:43:33 +05:30
let_it_be(:noteable) { create(:design, :with_file, issue: create(:issue, project: project, author: author)) }
2021-09-30 23:02:18 +05:30
2020-06-23 00:09:42 +05:30
let(:discussion) { create(:diff_note_on_design, noteable: noteable, project: project).to_discussion }
2021-10-29 20:43:33 +05:30
let(:issuable) { noteable.issue }
2020-06-23 00:09:42 +05:30
it_behaves_like 'a working resolve method'
end
end
end