debian-mirror-gitlab/spec/requests/api/jobs_spec.rb

1182 lines
37 KiB
Ruby
Raw Normal View History

2019-12-26 22:10:19 +05:30
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe API::Jobs do
2021-04-17 20:07:23 +05:30
include HttpBasicAuthHelpers
include DependencyProxyHelpers
2021-02-22 17:27:13 +05:30
using RSpec::Parameterized::TableSyntax
2018-05-09 12:01:36 +05:30
include HttpIOHelpers
2020-03-13 15:44:24 +05:30
let_it_be(:project, reload: true) do
2017-08-17 22:00:37 +05:30
create(:project, :repository, public_builds: false)
end
2020-03-13 15:44:24 +05:30
let_it_be(:pipeline, reload: true) do
2020-07-28 23:09:34 +05:30
create(:ci_pipeline, project: project,
sha: project.commit.id,
ref: project.default_branch)
2017-08-17 22:00:37 +05:30
end
let(:user) { create(:user) }
2016-04-02 18:10:28 +05:30
let(:api_user) { user }
2017-08-17 22:00:37 +05:30
let(:reporter) { create(:project_member, :reporter, project: project).user }
let(:guest) { create(:project_member, :guest, project: project).user }
2021-04-17 20:07:23 +05:30
let(:running_job) do
create(:ci_build, :running, project: project,
user: user,
pipeline: pipeline,
artifacts_expire_at: 1.day.since)
end
let!(:job) do
create(:ci_build, :success, :tags, pipeline: pipeline,
artifacts_expire_at: 1.day.since)
end
2017-08-17 22:00:37 +05:30
before do
project.add_developer(user)
end
2021-04-17 20:07:23 +05:30
shared_examples 'returns common pipeline data' do
it 'returns common pipeline data' do
expect(json_response['pipeline']).not_to be_empty
expect(json_response['pipeline']['id']).to eq jobx.pipeline.id
expect(json_response['pipeline']['project_id']).to eq jobx.pipeline.project_id
expect(json_response['pipeline']['ref']).to eq jobx.pipeline.ref
expect(json_response['pipeline']['sha']).to eq jobx.pipeline.sha
expect(json_response['pipeline']['status']).to eq jobx.pipeline.status
end
end
shared_examples 'returns common job data' do
it 'returns common job data' do
expect(response).to have_gitlab_http_status(:ok)
expect(json_response['id']).to eq(jobx.id)
expect(json_response['status']).to eq(jobx.status)
expect(json_response['stage']).to eq(jobx.stage)
expect(json_response['name']).to eq(jobx.name)
expect(json_response['ref']).to eq(jobx.ref)
expect(json_response['tag']).to eq(jobx.tag)
expect(json_response['coverage']).to eq(jobx.coverage)
expect(json_response['allow_failure']).to eq(jobx.allow_failure)
expect(Time.parse(json_response['created_at'])).to be_like_time(jobx.created_at)
expect(Time.parse(json_response['started_at'])).to be_like_time(jobx.started_at)
expect(Time.parse(json_response['artifacts_expire_at'])).to be_like_time(jobx.artifacts_expire_at)
expect(json_response['artifacts_file']).to be_nil
expect(json_response['artifacts']).to be_an Array
expect(json_response['artifacts']).to be_empty
expect(json_response['web_url']).to be_present
end
end
shared_examples 'returns unauthorized' do
it 'returns unauthorized' do
expect(response).to have_gitlab_http_status(:unauthorized)
end
end
describe 'GET /job' do
shared_context 'with auth headers' do
let(:headers_with_token) { header }
let(:params_with_token) { {} }
end
shared_context 'with auth params' do
let(:headers_with_token) { {} }
let(:params_with_token) { param }
end
shared_context 'without auth' do
let(:headers_with_token) { {} }
let(:params_with_token) { {} }
end
before do |example|
unless example.metadata[:skip_before_request]
get api('/job'), headers: headers_with_token, params: params_with_token
end
end
2021-04-29 21:17:54 +05:30
context 'when token is valid but not CI_JOB_TOKEN' do
let(:token) { create(:personal_access_token, user: user) }
include_context 'with auth headers' do
let(:header) { { 'Private-Token' => token.token } }
end
it 'returns not found' do
expect(response).to have_gitlab_http_status(:not_found)
end
end
2021-04-17 20:07:23 +05:30
context 'with job token authentication header' do
include_context 'with auth headers' do
let(:header) { { API::Helpers::Runner::JOB_TOKEN_HEADER => running_job.token } }
end
it_behaves_like 'returns common job data' do
let(:jobx) { running_job }
end
it 'returns specific job data' do
expect(json_response['finished_at']).to be_nil
end
it_behaves_like 'returns common pipeline data' do
let(:jobx) { running_job }
end
end
context 'with job token authentication params' do
include_context 'with auth params' do
let(:param) { { job_token: running_job.token } }
end
it_behaves_like 'returns common job data' do
let(:jobx) { running_job }
end
it 'returns specific job data' do
expect(json_response['finished_at']).to be_nil
end
it_behaves_like 'returns common pipeline data' do
let(:jobx) { running_job }
end
end
context 'with non running job' do
include_context 'with auth headers' do
let(:header) { { API::Helpers::Runner::JOB_TOKEN_HEADER => job.token } }
end
it_behaves_like 'returns unauthorized'
end
context 'with basic auth header' do
let(:personal_access_token) { create(:personal_access_token, user: user) }
let(:token) { personal_access_token.token}
include_context 'with auth headers' do
let(:header) { { Gitlab::Auth::AuthFinders::PRIVATE_TOKEN_HEADER => token } }
end
it 'does not return a job' do
expect(response).to have_gitlab_http_status(:not_found)
end
end
context 'without authentication' do
include_context 'without auth'
it_behaves_like 'returns unauthorized'
end
end
2017-08-17 22:00:37 +05:30
describe 'GET /projects/:id/jobs' do
2020-11-24 15:15:51 +05:30
let(:query) { {} }
2016-04-02 18:10:28 +05:30
2018-03-17 18:26:18 +05:30
before do |example|
unless example.metadata[:skip_before_request]
2019-02-15 15:39:39 +05:30
get api("/projects/#{project.id}/jobs", api_user), params: query
2018-03-17 18:26:18 +05:30
end
2016-09-29 09:46:39 +05:30
end
2016-04-02 18:10:28 +05:30
context 'authorized user' do
2017-08-17 22:00:37 +05:30
it 'returns project jobs' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2017-08-17 22:00:37 +05:30
expect(response).to include_pagination_headers
expect(json_response).to be_an Array
end
2016-06-22 15:30:34 +05:30
it 'returns correct values' do
expect(json_response).not_to be_empty
expect(json_response.first['commit']['id']).to eq project.commit.id
2018-11-08 19:23:39 +05:30
expect(Time.parse(json_response.first['artifacts_expire_at'])).to be_like_time(job.artifacts_expire_at)
2021-03-11 19:13:27 +05:30
expect(json_response.first['tag_list'].sort).to eq job.tag_list.sort
2016-06-22 15:30:34 +05:30
end
2018-11-20 20:47:30 +05:30
context 'without artifacts and trace' do
it 'returns no artifacts nor trace data' do
json_job = json_response.first
expect(json_job['artifacts_file']).to be_nil
expect(json_job['artifacts']).to be_an Array
expect(json_job['artifacts']).to be_empty
end
end
it_behaves_like 'a job with artifacts and trace' do
let(:api_endpoint) { "/projects/#{project.id}/jobs" }
end
2016-11-03 12:29:30 +05:30
it 'returns pipeline data' do
2017-09-10 17:25:29 +05:30
json_job = json_response.first
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
expect(json_job['pipeline']).not_to be_empty
expect(json_job['pipeline']['id']).to eq job.pipeline.id
expect(json_job['pipeline']['ref']).to eq job.pipeline.ref
expect(json_job['pipeline']['sha']).to eq job.pipeline.sha
expect(json_job['pipeline']['status']).to eq job.pipeline.status
2016-11-03 12:29:30 +05:30
end
2018-03-17 18:26:18 +05:30
it 'avoids N+1 queries', :skip_before_request do
2018-11-20 20:47:30 +05:30
first_build = create(:ci_build, :trace_artifact, :artifacts, :test_reports, pipeline: pipeline)
2018-03-17 18:26:18 +05:30
first_build.runner = create(:ci_runner)
first_build.user = create(:user)
2021-04-29 21:17:54 +05:30
first_build.save!
2018-03-17 18:26:18 +05:30
control_count = ActiveRecord::QueryRecorder.new { go }.count
second_pipeline = create(:ci_empty_pipeline, project: project, sha: project.commit.id, ref: project.default_branch)
2018-11-20 20:47:30 +05:30
second_build = create(:ci_build, :trace_artifact, :artifacts, :test_reports, pipeline: second_pipeline)
2018-03-17 18:26:18 +05:30
second_build.runner = create(:ci_runner)
second_build.user = create(:user)
2021-04-29 21:17:54 +05:30
second_build.save!
2018-03-17 18:26:18 +05:30
expect { go }.not_to exceed_query_limit(control_count)
end
2016-04-02 18:10:28 +05:30
context 'filter project with one scope element' do
2017-08-17 22:00:37 +05:30
let(:query) { { 'scope' => 'pending' } }
2016-04-02 18:10:28 +05:30
it do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2016-04-02 18:10:28 +05:30
expect(json_response).to be_an Array
end
end
2016-04-02 18:10:28 +05:30
context 'filter project with array of scope elements' do
2017-08-17 22:00:37 +05:30
let(:query) { { scope: %w(pending running) } }
2016-04-02 18:10:28 +05:30
it do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2016-04-02 18:10:28 +05:30
expect(json_response).to be_an Array
end
end
2016-04-02 18:10:28 +05:30
context 'respond 400 when scope contains invalid state' do
2017-08-17 22:00:37 +05:30
let(:query) { { scope: %w(unknown running) } }
2020-04-08 14:13:33 +05:30
it { expect(response).to have_gitlab_http_status(:bad_request) }
end
end
context 'unauthorized user' do
2019-01-03 12:48:30 +05:30
context 'when user is not logged in' do
let(:api_user) { nil }
2019-01-03 12:48:30 +05:30
it 'does not return project jobs' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
2019-01-03 12:48:30 +05:30
end
end
context 'when user is guest' do
let(:api_user) { guest }
it 'does not return project jobs' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2019-01-03 12:48:30 +05:30
end
end
end
2018-03-17 18:26:18 +05:30
def go
2019-02-15 15:39:39 +05:30
get api("/projects/#{project.id}/jobs", api_user), params: query
2018-03-17 18:26:18 +05:30
end
end
2017-08-17 22:00:37 +05:30
describe 'GET /projects/:id/jobs/:job_id' do
2018-11-20 20:47:30 +05:30
before do |example|
unless example.metadata[:skip_before_request]
get api("/projects/#{project.id}/jobs/#{job.id}", api_user)
end
2016-09-29 09:46:39 +05:30
end
2016-04-02 18:10:28 +05:30
context 'authorized user' do
2021-04-17 20:07:23 +05:30
it_behaves_like 'returns common job data' do
let(:jobx) { job }
end
2017-08-17 22:00:37 +05:30
it 'returns specific job data' do
2018-03-17 18:26:18 +05:30
expect(Time.parse(json_response['finished_at'])).to be_like_time(job.finished_at)
expect(json_response['duration']).to eq(job.duration)
end
2016-11-03 12:29:30 +05:30
2018-11-20 20:47:30 +05:30
it_behaves_like 'a job with artifacts and trace', result_is_array: false do
let(:api_endpoint) { "/projects/#{project.id}/jobs/#{second_job.id}" }
end
2021-04-17 20:07:23 +05:30
it_behaves_like 'returns common pipeline data' do
let(:jobx) { job }
2016-11-03 12:29:30 +05:30
end
end
context 'unauthorized user' do
2016-04-02 18:10:28 +05:30
let(:api_user) { nil }
2017-08-17 22:00:37 +05:30
it 'does not return specific job data' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
end
end
end
2019-07-07 11:18:12 +05:30
describe 'DELETE /projects/:id/jobs/:job_id/artifacts' do
let!(:job) { create(:ci_build, :artifacts, pipeline: pipeline, user: api_user) }
before do
delete api("/projects/#{project.id}/jobs/#{job.id}/artifacts", api_user)
end
context 'when user is anonymous' do
let(:api_user) { nil }
it 'does not delete artifacts' do
expect(job.job_artifacts.size).to eq 2
end
it 'returns status 401 (unauthorized)' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
2019-07-07 11:18:12 +05:30
end
end
context 'with developer' do
it 'does not delete artifacts' do
expect(job.job_artifacts.size).to eq 2
end
it 'returns status 403 (forbidden)' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2019-07-07 11:18:12 +05:30
end
end
context 'with authorized user' do
let(:maintainer) { create(:project_member, :maintainer, project: project).user }
let!(:api_user) { maintainer }
it 'deletes artifacts' do
expect(job.job_artifacts.size).to eq 0
end
it 'returns status 204 (no content)' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:no_content)
2019-07-07 11:18:12 +05:30
end
end
end
2018-03-17 18:26:18 +05:30
describe 'GET /projects/:id/jobs/:job_id/artifacts/:artifact_path' do
context 'when job has artifacts' do
2017-09-10 17:25:29 +05:30
let(:job) { create(:ci_build, :artifacts, pipeline: pipeline) }
2016-04-02 18:10:28 +05:30
2018-03-17 18:26:18 +05:30
let(:artifact) do
'other_artifacts_0.1.2/another-subdirectory/banana_sample.gif'
end
context 'when user is anonymous' do
let(:api_user) { nil }
context 'when project is public' do
it 'allows to access artifacts' do
project.update_column(:visibility_level,
Gitlab::VisibilityLevel::PUBLIC)
project.update_column(:public_builds, true)
get_artifact_file(artifact)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2018-03-17 18:26:18 +05:30
end
end
2021-03-08 18:12:59 +05:30
context 'when project is public with artifacts that are non public' do
let(:job) { create(:ci_build, :artifacts, :non_public_artifacts, pipeline: pipeline) }
it 'rejects access to artifacts' do
project.update_column(:visibility_level,
Gitlab::VisibilityLevel::PUBLIC)
project.update_column(:public_builds, true)
get_artifact_file(artifact)
expect(response).to have_gitlab_http_status(:forbidden)
end
context 'with the non_public_artifacts feature flag disabled' do
before do
stub_feature_flags(non_public_artifacts: false)
end
it 'allows access to artifacts' do
project.update_column(:visibility_level,
Gitlab::VisibilityLevel::PUBLIC)
project.update_column(:public_builds, true)
get_artifact_file(artifact)
expect(response).to have_gitlab_http_status(:ok)
end
end
end
2018-03-17 18:26:18 +05:30
context 'when project is public with builds access disabled' do
it 'rejects access to artifacts' do
project.update_column(:visibility_level,
Gitlab::VisibilityLevel::PUBLIC)
project.update_column(:public_builds, false)
get_artifact_file(artifact)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2018-03-17 18:26:18 +05:30
end
2016-04-02 18:10:28 +05:30
end
2018-03-17 18:26:18 +05:30
context 'when project is private' do
it 'rejects access and hides existence of artifacts' do
project.update_column(:visibility_level,
Gitlab::VisibilityLevel::PRIVATE)
project.update_column(:public_builds, true)
get_artifact_file(artifact)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2018-03-17 18:26:18 +05:30
end
2016-04-02 18:10:28 +05:30
end
end
2018-03-17 18:26:18 +05:30
context 'when user is authorized' do
it 'returns a specific artifact file for a valid path' do
expect(Gitlab::Workhorse)
.to receive(:send_artifacts_entry)
.and_call_original
get_artifact_file(artifact)
2016-04-02 18:10:28 +05:30
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2018-10-15 14:42:47 +05:30
expect(response.headers.to_h)
2018-03-17 18:26:18 +05:30
.to include('Content-Type' => 'application/json',
'Gitlab-Workhorse-Send-Data' => /artifacts-entry/)
2016-04-02 18:10:28 +05:30
end
2021-04-17 20:07:23 +05:30
context 'when artifacts are locked' do
it 'allows access to expired artifact' do
pipeline.artifacts_locked!
job.update!(artifacts_expire_at: Time.now - 7.days)
get_artifact_file(artifact)
expect(response).to have_gitlab_http_status(:ok)
end
end
2016-04-02 18:10:28 +05:30
end
end
2018-03-17 18:26:18 +05:30
context 'when job does not have artifacts' do
it 'does not return job artifact file' do
get_artifact_file('some/artifact')
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2018-03-17 18:26:18 +05:30
end
end
def get_artifact_file(artifact_path)
get api("/projects/#{project.id}/jobs/#{job.id}/" \
"artifacts/#{artifact_path}", api_user)
end
end
describe 'GET /projects/:id/jobs/:job_id/artifacts' do
shared_examples 'downloads artifact' do
let(:download_headers) do
{ 'Content-Transfer-Encoding' => 'binary',
2019-03-02 22:35:43 +05:30
'Content-Disposition' => %q(attachment; filename="ci_build_artifacts.zip"; filename*=UTF-8''ci_build_artifacts.zip) }
2018-03-17 18:26:18 +05:30
end
it 'returns specific job artifacts' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2018-10-15 14:42:47 +05:30
expect(response.headers.to_h).to include(download_headers)
2018-03-17 18:26:18 +05:30
expect(response.body).to match_file(job.artifacts_file.file.file)
end
end
context 'normal authentication' do
context 'job with artifacts' do
context 'when artifacts are stored locally' do
let(:job) { create(:ci_build, :artifacts, pipeline: pipeline) }
before do
get api("/projects/#{project.id}/jobs/#{job.id}/artifacts", api_user)
end
context 'authorized user' do
it_behaves_like 'downloads artifact'
end
context 'unauthorized user' do
let(:api_user) { nil }
it 'does not return specific job artifacts' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2018-03-17 18:26:18 +05:30
end
end
end
2018-05-09 12:01:36 +05:30
context 'when artifacts are stored remotely' do
let(:proxy_download) { false }
before do
stub_artifacts_object_storage(proxy_download: proxy_download)
end
let(:job) { create(:ci_build, pipeline: pipeline) }
let!(:artifact) { create(:ci_job_artifact, :archive, :remote_store, job: job) }
before do
job.reload
get api("/projects/#{project.id}/jobs/#{job.id}/artifacts", api_user)
end
context 'when proxy download is enabled' do
let(:proxy_download) { true }
it 'responds with the workhorse send-url' do
expect(response.headers[Gitlab::Workhorse::SEND_DATA_HEADER]).to start_with("send-url:")
end
end
context 'when proxy download is disabled' do
it 'returns location redirect' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:found)
2018-05-09 12:01:36 +05:30
end
end
context 'authorized user' do
it 'returns the file remote URL' do
expect(response).to redirect_to(artifact.file.url)
end
end
context 'unauthorized user' do
let(:api_user) { nil }
it 'does not return specific job artifacts' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2018-05-09 12:01:36 +05:30
end
end
end
2021-03-08 18:12:59 +05:30
context 'when public project guest and artifacts are non public' do
let(:api_user) { guest }
let(:job) { create(:ci_build, :artifacts, :non_public_artifacts, pipeline: pipeline) }
before do
project.update_column(:visibility_level,
Gitlab::VisibilityLevel::PUBLIC)
project.update_column(:public_builds, true)
get api("/projects/#{project.id}/jobs/#{job.id}/artifacts", api_user)
end
it 'rejects access and hides existence of artifacts' do
expect(response).to have_gitlab_http_status(:forbidden)
end
context 'with the non_public_artifacts feature flag disabled' do
before do
stub_feature_flags(non_public_artifacts: false)
get api("/projects/#{project.id}/jobs/#{job.id}/artifacts", api_user)
end
it 'allows access to artifacts' do
expect(response).to have_gitlab_http_status(:ok)
end
end
end
2018-03-17 18:26:18 +05:30
it 'does not return job artifacts if not uploaded' do
get api("/projects/#{project.id}/jobs/#{job.id}/artifacts", api_user)
2018-05-09 12:01:36 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2018-03-17 18:26:18 +05:30
end
end
2016-08-24 12:49:21 +05:30
end
end
describe 'GET /projects/:id/artifacts/:ref_name/download?job=name' do
2017-08-17 22:00:37 +05:30
let(:api_user) { reporter }
2018-03-17 18:26:18 +05:30
let(:job) { create(:ci_build, :artifacts, pipeline: pipeline, user: api_user) }
2016-09-13 17:45:13 +05:30
before do
2018-05-09 12:01:36 +05:30
stub_artifacts_object_storage
2017-09-10 17:25:29 +05:30
job.success
2016-09-13 17:45:13 +05:30
end
2016-08-24 12:49:21 +05:30
2017-09-10 17:25:29 +05:30
def get_for_ref(ref = pipeline.ref, job_name = job.name)
2019-02-15 15:39:39 +05:30
get api("/projects/#{project.id}/jobs/artifacts/#{ref}/download", api_user), params: { job: job_name }
2016-08-24 12:49:21 +05:30
end
context 'when not logged in' do
let(:api_user) { nil }
before do
2017-08-17 22:00:37 +05:30
get_for_ref
2016-08-24 12:49:21 +05:30
end
2018-03-17 18:26:18 +05:30
it 'does not find a resource in a private project' do
expect(project).to be_private
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2016-08-24 12:49:21 +05:30
end
end
context 'when logging as guest' do
2017-08-17 22:00:37 +05:30
let(:api_user) { guest }
2016-08-24 12:49:21 +05:30
before do
2017-08-17 22:00:37 +05:30
get_for_ref
2016-08-24 12:49:21 +05:30
end
it 'gives 403' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2016-08-24 12:49:21 +05:30
end
end
2017-08-17 22:00:37 +05:30
context 'non-existing job' do
2016-08-24 12:49:21 +05:30
shared_examples 'not found' do
2018-03-17 18:26:18 +05:30
it { expect(response).to have_gitlab_http_status(:not_found) }
2016-08-24 12:49:21 +05:30
end
context 'has no such ref' do
before do
2017-08-17 22:00:37 +05:30
get_for_ref('TAIL')
2016-08-24 12:49:21 +05:30
end
it_behaves_like 'not found'
end
2017-08-17 22:00:37 +05:30
context 'has no such job' do
2016-08-24 12:49:21 +05:30
before do
2017-08-17 22:00:37 +05:30
get_for_ref(pipeline.ref, 'NOBUILD')
2016-08-24 12:49:21 +05:30
end
it_behaves_like 'not found'
end
end
2017-08-17 22:00:37 +05:30
context 'find proper job' do
2021-01-03 14:25:43 +05:30
let(:job_with_artifacts) { job }
2016-08-24 12:49:21 +05:30
shared_examples 'a valid file' do
2019-12-26 22:10:19 +05:30
context 'when artifacts are stored locally', :sidekiq_might_not_need_inline do
2018-03-17 18:26:18 +05:30
let(:download_headers) do
{ 'Content-Transfer-Encoding' => 'binary',
'Content-Disposition' =>
2021-01-03 14:25:43 +05:30
%Q(attachment; filename="#{job_with_artifacts.artifacts_file.filename}"; filename*=UTF-8''#{job.artifacts_file.filename}) }
2018-03-17 18:26:18 +05:30
end
2016-08-24 12:49:21 +05:30
2020-04-08 14:13:33 +05:30
it { expect(response).to have_gitlab_http_status(:ok) }
2018-10-15 14:42:47 +05:30
it { expect(response.headers.to_h).to include(download_headers) }
2018-03-17 18:26:18 +05:30
end
2018-05-09 12:01:36 +05:30
context 'when artifacts are stored remotely' do
let(:job) { create(:ci_build, pipeline: pipeline, user: api_user) }
let!(:artifact) { create(:ci_job_artifact, :archive, :remote_store, job: job) }
before do
job.reload
get api("/projects/#{project.id}/jobs/#{job.id}/artifacts", api_user)
end
it 'returns location redirect' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:found)
2018-05-09 12:01:36 +05:30
end
end
2016-08-24 12:49:21 +05:30
end
context 'with regular branch' do
before do
2017-08-17 22:00:37 +05:30
pipeline.reload
2021-04-29 21:17:54 +05:30
pipeline.update!(ref: 'master',
2016-08-24 12:49:21 +05:30
sha: project.commit('master').sha)
2017-08-17 22:00:37 +05:30
get_for_ref('master')
2016-08-24 12:49:21 +05:30
end
it_behaves_like 'a valid file'
end
context 'with branch name containing slash' do
before do
2017-08-17 22:00:37 +05:30
pipeline.reload
2021-04-29 21:17:54 +05:30
pipeline.update!(ref: 'improve/awesome',
2016-08-24 12:49:21 +05:30
sha: project.commit('improve/awesome').sha)
end
before do
2017-08-17 22:00:37 +05:30
get_for_ref('improve/awesome')
2016-08-24 12:49:21 +05:30
end
2021-01-03 14:25:43 +05:30
it_behaves_like 'a valid file'
end
context 'with job name in a child pipeline' do
let(:child_pipeline) { create(:ci_pipeline, child_of: pipeline) }
let!(:child_job) { create(:ci_build, :artifacts, :success, name: 'rspec', pipeline: child_pipeline) }
let(:job_with_artifacts) { child_job }
before do
get_for_ref('master', child_job.name)
end
2016-08-24 12:49:21 +05:30
it_behaves_like 'a valid file'
end
2016-04-02 18:10:28 +05:30
end
end
2019-02-15 15:39:39 +05:30
describe 'GET id/jobs/artifacts/:ref_name/raw/*artifact_path?job=name' do
context 'when job has artifacts' do
let(:job) { create(:ci_build, :artifacts, pipeline: pipeline, user: api_user) }
let(:artifact) { 'other_artifacts_0.1.2/another-subdirectory/banana_sample.gif' }
let(:visibility_level) { Gitlab::VisibilityLevel::PUBLIC }
let(:public_builds) { true }
before do
stub_artifacts_object_storage
job.success
2021-04-29 21:17:54 +05:30
project.update!(visibility_level: visibility_level,
2019-02-15 15:39:39 +05:30
public_builds: public_builds)
get_artifact_file(artifact)
end
context 'when user is anonymous' do
let(:api_user) { nil }
context 'when project is public' do
let(:visibility_level) { Gitlab::VisibilityLevel::PUBLIC }
let(:public_builds) { true }
2019-12-26 22:10:19 +05:30
it 'allows to access artifacts', :sidekiq_might_not_need_inline do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2019-02-15 15:39:39 +05:30
expect(response.headers.to_h)
.to include('Content-Type' => 'application/json',
'Gitlab-Workhorse-Send-Data' => /artifacts-entry/)
end
end
context 'when project is public with builds access disabled' do
let(:visibility_level) { Gitlab::VisibilityLevel::PUBLIC }
let(:public_builds) { false }
it 'rejects access to artifacts' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2019-02-15 15:39:39 +05:30
expect(json_response).to have_key('message')
expect(response.headers.to_h)
.not_to include('Gitlab-Workhorse-Send-Data' => /artifacts-entry/)
end
end
2021-03-08 18:12:59 +05:30
context 'when project is public with non public artifacts' do
let(:job) { create(:ci_build, :artifacts, :non_public_artifacts, pipeline: pipeline, user: api_user) }
let(:visibility_level) { Gitlab::VisibilityLevel::PUBLIC }
let(:public_builds) { true }
it 'rejects access and hides existence of artifacts', :sidekiq_might_not_need_inline do
get_artifact_file(artifact)
expect(response).to have_gitlab_http_status(:forbidden)
expect(json_response).to have_key('message')
expect(response.headers.to_h)
.not_to include('Gitlab-Workhorse-Send-Data' => /artifacts-entry/)
end
context 'with the non_public_artifacts feature flag disabled' do
before do
stub_feature_flags(non_public_artifacts: false)
end
it 'allows access to artifacts', :sidekiq_might_not_need_inline do
get_artifact_file(artifact)
expect(response).to have_gitlab_http_status(:ok)
end
end
end
2019-02-15 15:39:39 +05:30
context 'when project is private' do
let(:visibility_level) { Gitlab::VisibilityLevel::PRIVATE }
let(:public_builds) { true }
it 'rejects access and hides existence of artifacts' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2019-02-15 15:39:39 +05:30
expect(json_response).to have_key('message')
expect(response.headers.to_h)
.not_to include('Gitlab-Workhorse-Send-Data' => /artifacts-entry/)
end
end
end
context 'when user is authorized' do
let(:visibility_level) { Gitlab::VisibilityLevel::PRIVATE }
let(:public_builds) { true }
2019-12-26 22:10:19 +05:30
it 'returns a specific artifact file for a valid path', :sidekiq_might_not_need_inline do
2019-02-15 15:39:39 +05:30
expect(Gitlab::Workhorse)
.to receive(:send_artifacts_entry)
.and_call_original
get_artifact_file(artifact)
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2019-02-15 15:39:39 +05:30
expect(response.headers.to_h)
.to include('Content-Type' => 'application/json',
'Gitlab-Workhorse-Send-Data' => /artifacts-entry/)
end
end
context 'with branch name containing slash' do
before do
pipeline.reload
2021-04-29 21:17:54 +05:30
pipeline.update!(ref: 'improve/awesome',
2019-02-15 15:39:39 +05:30
sha: project.commit('improve/awesome').sha)
end
2019-12-26 22:10:19 +05:30
it 'returns a specific artifact file for a valid path', :sidekiq_might_not_need_inline do
2019-02-15 15:39:39 +05:30
get_artifact_file(artifact, 'improve/awesome')
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2019-02-15 15:39:39 +05:30
expect(response.headers.to_h)
.to include('Content-Type' => 'application/json',
'Gitlab-Workhorse-Send-Data' => /artifacts-entry/)
end
end
context 'non-existing job' do
shared_examples 'not found' do
it { expect(response).to have_gitlab_http_status(:not_found) }
end
context 'has no such ref' do
before do
get_artifact_file('some/artifact', 'wrong-ref')
end
it_behaves_like 'not found'
end
context 'has no such job' do
before do
get_artifact_file('some/artifact', pipeline.ref, 'wrong-job-name')
end
it_behaves_like 'not found'
end
end
end
context 'when job does not have artifacts' do
let(:job) { create(:ci_build, pipeline: pipeline, user: api_user) }
it 'does not return job artifact file' do
get_artifact_file('some/artifact')
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2019-02-15 15:39:39 +05:30
end
end
def get_artifact_file(artifact_path, ref = pipeline.ref, job_name = job.name)
get api("/projects/#{project.id}/jobs/artifacts/#{ref}/raw/#{artifact_path}", api_user), params: { job: job_name }
end
end
2017-08-17 22:00:37 +05:30
describe 'GET /projects/:id/jobs/:job_id/trace' do
2016-08-24 12:49:21 +05:30
before do
2017-09-10 17:25:29 +05:30
get api("/projects/#{project.id}/jobs/#{job.id}/trace", api_user)
2016-08-24 12:49:21 +05:30
end
2016-04-02 18:10:28 +05:30
context 'authorized user' do
2018-05-09 12:01:36 +05:30
context 'when trace is in ObjectStorage' do
let!(:job) { create(:ci_build, :trace_artifact, pipeline: pipeline) }
2018-11-18 11:00:15 +05:30
let(:url) { 'http://object-storage/trace' }
let(:file_path) { expand_fixture_path('trace/sample_trace') }
2018-05-09 12:01:36 +05:30
before do
2018-11-18 11:00:15 +05:30
stub_remote_url_206(url, file_path)
2020-01-01 13:55:28 +05:30
allow_next_instance_of(JobArtifactUploader) do |instance|
allow(instance).to receive(:file_storage?) { false }
allow(instance).to receive(:url) { url }
allow(instance).to receive(:size) { File.size(file_path) }
end
2018-05-09 12:01:36 +05:30
end
it 'returns specific job trace' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2018-05-09 12:01:36 +05:30
expect(response.body).to eq(job.trace.raw)
end
end
2018-03-17 18:26:18 +05:30
context 'when trace is artifact' do
let(:job) { create(:ci_build, :trace_artifact, pipeline: pipeline) }
it 'returns specific job trace' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2018-03-17 18:26:18 +05:30
expect(response.body).to eq(job.trace.raw)
end
end
context 'when trace is file' do
let(:job) { create(:ci_build, :trace_live, pipeline: pipeline) }
it 'returns specific job trace' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2018-03-17 18:26:18 +05:30
expect(response.body).to eq(job.trace.raw)
end
end
end
context 'unauthorized user' do
2016-04-02 18:10:28 +05:30
let(:api_user) { nil }
2017-08-17 22:00:37 +05:30
it 'does not return specific job trace' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
end
end
2021-02-22 17:27:13 +05:30
context 'when ci_debug_trace is set to true' do
before_all do
create(:ci_instance_variable, key: 'CI_DEBUG_TRACE', value: true)
end
where(:public_builds, :user_project_role, :expected_status) do
true | 'developer' | :ok
true | 'guest' | :forbidden
false | 'developer' | :ok
false | 'guest' | :forbidden
end
with_them do
before do
project.update!(public_builds: public_builds)
project.add_role(user, user_project_role)
get api("/projects/#{project.id}/jobs/#{job.id}/trace", api_user)
end
it 'renders trace to authorized users' do
expect(response).to have_gitlab_http_status(expected_status)
end
end
end
end
2017-08-17 22:00:37 +05:30
describe 'POST /projects/:id/jobs/:job_id/cancel' do
2016-09-29 09:46:39 +05:30
before do
2017-09-10 17:25:29 +05:30
post api("/projects/#{project.id}/jobs/#{job.id}/cancel", api_user)
2016-09-29 09:46:39 +05:30
end
2016-04-02 18:10:28 +05:30
context 'authorized user' do
2016-04-02 18:10:28 +05:30
context 'user with :update_build persmission' do
2017-08-17 22:00:37 +05:30
it 'cancels running or pending job' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:created)
2018-03-17 18:26:18 +05:30
expect(project.builds.first.status).to eq('success')
end
end
2016-04-02 18:10:28 +05:30
context 'user without :update_build permission' do
2017-08-17 22:00:37 +05:30
let(:api_user) { reporter }
2017-08-17 22:00:37 +05:30
it 'does not cancel job' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
end
end
end
context 'unauthorized user' do
2016-04-02 18:10:28 +05:30
let(:api_user) { nil }
2017-08-17 22:00:37 +05:30
it 'does not cancel job' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
end
end
end
2017-08-17 22:00:37 +05:30
describe 'POST /projects/:id/jobs/:job_id/retry' do
2017-09-10 17:25:29 +05:30
let(:job) { create(:ci_build, :canceled, pipeline: pipeline) }
2016-04-02 18:10:28 +05:30
2016-09-29 09:46:39 +05:30
before do
2017-09-10 17:25:29 +05:30
post api("/projects/#{project.id}/jobs/#{job.id}/retry", api_user)
2016-09-29 09:46:39 +05:30
end
2016-04-02 18:10:28 +05:30
context 'authorized user' do
2016-04-02 18:10:28 +05:30
context 'user with :update_build permission' do
2017-08-17 22:00:37 +05:30
it 'retries non-running job' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:created)
expect(project.builds.first.status).to eq('canceled')
expect(json_response['status']).to eq('pending')
end
end
2016-04-02 18:10:28 +05:30
context 'user without :update_build permission' do
2017-08-17 22:00:37 +05:30
let(:api_user) { reporter }
2017-08-17 22:00:37 +05:30
it 'does not retry job' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
end
end
end
context 'unauthorized user' do
2016-04-02 18:10:28 +05:30
let(:api_user) { nil }
2017-08-17 22:00:37 +05:30
it 'does not retry job' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:unauthorized)
end
end
end
2016-04-02 18:10:28 +05:30
2017-08-17 22:00:37 +05:30
describe 'POST /projects/:id/jobs/:job_id/erase' do
2018-11-18 11:00:15 +05:30
let(:role) { :maintainer }
2018-03-17 18:26:18 +05:30
2016-04-02 18:10:28 +05:30
before do
2018-03-17 18:26:18 +05:30
project.add_role(user, role)
2017-09-10 17:25:29 +05:30
post api("/projects/#{project.id}/jobs/#{job.id}/erase", user)
2016-04-02 18:10:28 +05:30
end
2017-08-17 22:00:37 +05:30
context 'job is erasable' do
2018-11-18 11:00:15 +05:30
let(:job) { create(:ci_build, :trace_artifact, :artifacts, :test_reports, :success, project: project, pipeline: pipeline) }
2016-04-02 18:10:28 +05:30
2017-08-17 22:00:37 +05:30
it 'erases job content' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:created)
2018-11-18 11:00:15 +05:30
expect(job.job_artifacts.count).to eq(0)
2018-03-17 18:26:18 +05:30
expect(job.trace.exist?).to be_falsy
2019-09-04 21:01:54 +05:30
expect(job.artifacts_file.present?).to be_falsy
expect(job.artifacts_metadata.present?).to be_falsy
2018-12-05 23:21:45 +05:30
expect(job.has_job_artifacts?).to be_falsy
2016-04-02 18:10:28 +05:30
end
2017-08-17 22:00:37 +05:30
it 'updates job' do
2017-09-10 17:25:29 +05:30
job.reload
expect(job.erased_at).to be_truthy
expect(job.erased_by).to eq(user)
2016-04-02 18:10:28 +05:30
end
end
2017-08-17 22:00:37 +05:30
context 'job is not erasable' do
2018-03-17 18:26:18 +05:30
let(:job) { create(:ci_build, :trace_live, project: project, pipeline: pipeline) }
2016-04-02 18:10:28 +05:30
2016-09-13 17:45:13 +05:30
it 'responds with forbidden' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2018-03-17 18:26:18 +05:30
end
end
context 'when a developer erases a build' do
let(:role) { :developer }
let(:job) { create(:ci_build, :trace_artifact, :artifacts, :success, project: project, pipeline: pipeline, user: owner) }
context 'when the build was created by the developer' do
let(:owner) { user }
2020-04-08 14:13:33 +05:30
it { expect(response).to have_gitlab_http_status(:created) }
2018-03-17 18:26:18 +05:30
end
context 'when the build was created by the other' do
let(:owner) { create(:user) }
2020-04-08 14:13:33 +05:30
it { expect(response).to have_gitlab_http_status(:forbidden) }
2016-04-02 18:10:28 +05:30
end
end
end
2017-09-10 17:25:29 +05:30
describe 'POST /projects/:id/jobs/:job_id/artifacts/keep' do
before do
2017-09-10 17:25:29 +05:30
post api("/projects/#{project.id}/jobs/#{job.id}/artifacts/keep", user)
end
context 'artifacts did not expire' do
2017-09-10 17:25:29 +05:30
let(:job) do
2018-03-17 18:26:18 +05:30
create(:ci_build, :trace_artifact, :artifacts, :success,
project: project, pipeline: pipeline, artifacts_expire_at: Time.now + 7.days)
end
it 'keeps artifacts' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:ok)
2017-09-10 17:25:29 +05:30
expect(job.reload.artifacts_expire_at).to be_nil
end
end
context 'no artifacts' do
2017-09-10 17:25:29 +05:30
let(:job) { create(:ci_build, project: project, pipeline: pipeline) }
it 'responds with not found' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
end
end
end
2016-09-13 17:45:13 +05:30
2017-08-17 22:00:37 +05:30
describe 'POST /projects/:id/jobs/:job_id/play' do
2016-09-13 17:45:13 +05:30
before do
2017-09-10 17:25:29 +05:30
post api("/projects/#{project.id}/jobs/#{job.id}/play", api_user)
2016-09-13 17:45:13 +05:30
end
2021-03-08 18:12:59 +05:30
context 'on a playable job' do
let_it_be(:job) { create(:ci_bridge, :playable, pipeline: pipeline, downstream: project) }
before do
project.add_developer(user)
end
2016-09-13 17:45:13 +05:30
2017-08-17 22:00:37 +05:30
context 'when user is authorized to trigger a manual action' do
2021-03-08 18:12:59 +05:30
context 'that is a bridge' do
it 'plays the job' do
expect(response).to have_gitlab_http_status(:ok)
expect(json_response['user']['id']).to eq(user.id)
expect(json_response['id']).to eq(job.id)
expect(job.reload).to be_pending
end
end
context 'that is a build' do
let_it_be(:job) { create(:ci_build, :manual, project: project, pipeline: pipeline) }
it 'plays the job' do
expect(response).to have_gitlab_http_status(:ok)
expect(json_response['user']['id']).to eq(user.id)
expect(json_response['id']).to eq(job.id)
expect(job.reload).to be_pending
end
2017-08-17 22:00:37 +05:30
end
end
context 'when user is not authorized to trigger a manual action' do
context 'when user does not have access to the project' do
let(:api_user) { create(:user) }
it 'does not trigger a manual action' do
2017-09-10 17:25:29 +05:30
expect(job.reload).to be_manual
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2017-08-17 22:00:37 +05:30
end
end
context 'when user is not allowed to trigger the manual action' do
let(:api_user) { reporter }
it 'does not trigger a manual action' do
2017-09-10 17:25:29 +05:30
expect(job.reload).to be_manual
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:forbidden)
2017-08-17 22:00:37 +05:30
end
end
2016-09-13 17:45:13 +05:30
end
end
2017-08-17 22:00:37 +05:30
context 'on a non-playable job' do
2016-09-13 17:45:13 +05:30
it 'returns a status code 400, Bad Request' do
2020-04-08 14:13:33 +05:30
expect(response).to have_gitlab_http_status(:bad_request)
2017-08-17 22:00:37 +05:30
expect(response.body).to match("Unplayable Job")
2016-09-13 17:45:13 +05:30
end
end
end
end