2019-07-31 22:56:46 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe Auth::ContainerRegistryAuthenticationService do
|
2021-01-29 00:20:46 +05:30
|
|
|
include AdminModeHelper
|
|
|
|
|
2021-02-22 17:27:13 +05:30
|
|
|
it_behaves_like 'a container registry auth service'
|
2021-09-30 23:02:18 +05:30
|
|
|
|
|
|
|
context 'when in migration mode' do
|
|
|
|
include_context 'container registry auth service context'
|
|
|
|
|
|
|
|
let_it_be(:current_user) { create(:user) }
|
|
|
|
let_it_be(:project) { create(:project) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_developer(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'a modified token with migration eligibility' do |eligible|
|
|
|
|
it_behaves_like 'a valid token'
|
|
|
|
it { expect(payload['access']).to include(include('migration_eligible' => eligible)) }
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'a modified token' do
|
|
|
|
context 'with a non eligible root ancestor and project' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(container_registry_migration_phase1_deny: project.root_ancestor)
|
|
|
|
stub_feature_flags(container_registry_migration_phase1_allow: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a modified token with migration eligibility', false
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with a non eligible root ancestor and eligible project' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(container_registry_migration_phase1_deny: false)
|
|
|
|
stub_feature_flags(container_registry_migration_phase1_deny: project.root_ancestor)
|
|
|
|
stub_feature_flags(container_registry_migration_phase1_allow: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a modified token with migration eligibility', false
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with an eligible root ancestor and non eligible project' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(container_registry_migration_phase1_deny: false)
|
|
|
|
stub_feature_flags(container_registry_migration_phase1_allow: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a modified token with migration eligibility', false
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with an eligible root ancestor and project' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(container_registry_migration_phase1_deny: false)
|
|
|
|
stub_feature_flags(container_registry_migration_phase1_allow: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a modified token with migration eligibility', true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with pull action' do
|
|
|
|
let(:current_params) do
|
|
|
|
{ scopes: ["repository:#{project.full_path}:pull"] }
|
|
|
|
end
|
|
|
|
|
2021-10-27 15:23:28 +05:30
|
|
|
it_behaves_like 'a modified token'
|
2021-09-30 23:02:18 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'with push action' do
|
|
|
|
let(:current_params) do
|
|
|
|
{ scopes: ["repository:#{project.full_path}:push"] }
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a modified token'
|
|
|
|
end
|
|
|
|
|
2021-10-27 15:23:28 +05:30
|
|
|
context 'with multiple actions' do
|
2021-09-30 23:02:18 +05:30
|
|
|
let(:current_params) do
|
|
|
|
{ scopes: ["repository:#{project.full_path}:pull,push,delete"] }
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a modified token'
|
|
|
|
end
|
2021-11-11 11:23:49 +05:30
|
|
|
|
|
|
|
describe '#access_token' do
|
|
|
|
let(:token) { described_class.access_token(%w[push], [project.full_path]) }
|
|
|
|
|
|
|
|
subject { { token: token } }
|
|
|
|
|
|
|
|
it_behaves_like 'a modified token'
|
|
|
|
end
|
2022-03-02 08:16:31 +05:30
|
|
|
|
|
|
|
context 'with a project with a path with trailing underscore' do
|
|
|
|
let(:bad_project) { create(:project) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
bad_project.update!(path: bad_project.path + '_')
|
|
|
|
bad_project.add_developer(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#full_access_token' do
|
|
|
|
let(:token) { described_class.full_access_token(bad_project.full_path) }
|
|
|
|
let(:access) do
|
|
|
|
[{ 'type' => 'repository',
|
|
|
|
'name' => bad_project.full_path,
|
|
|
|
'actions' => ['*'],
|
|
|
|
'migration_eligible' => false }]
|
|
|
|
end
|
|
|
|
|
|
|
|
subject { { token: token } }
|
|
|
|
|
|
|
|
it 'logs an exception and returns a valid access token' do
|
|
|
|
expect(Gitlab::ErrorTracking).to receive(:track_and_raise_for_dev_exception)
|
|
|
|
|
|
|
|
expect(token).to be_present
|
|
|
|
expect(payload).to be_a(Hash)
|
|
|
|
expect(payload).to include('access' => access)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-11-11 11:23:49 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when not in migration mode' do
|
|
|
|
include_context 'container registry auth service context'
|
|
|
|
|
|
|
|
let_it_be(:project) { create(:project) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_feature_flags(container_registry_migration_phase1: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'an unmodified token' do
|
|
|
|
it_behaves_like 'a valid token'
|
|
|
|
it { expect(payload['access']).not_to include(have_key('migration_eligible')) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#access_token' do
|
|
|
|
let(:token) { described_class.access_token(%w[push], [project.full_path]) }
|
|
|
|
|
|
|
|
subject { { token: token } }
|
|
|
|
|
|
|
|
it_behaves_like 'an unmodified token'
|
|
|
|
end
|
2021-09-30 23:02:18 +05:30
|
|
|
end
|
2022-03-02 08:16:31 +05:30
|
|
|
|
|
|
|
context 'CDN redirection' do
|
|
|
|
include_context 'container registry auth service context'
|
|
|
|
|
|
|
|
let_it_be(:current_user) { create(:user) }
|
|
|
|
let_it_be(:project) { create(:project) }
|
|
|
|
let_it_be(:current_params) { { scopes: ["repository:#{project.full_path}:pull"] } }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_developer(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a valid token'
|
|
|
|
it { expect(payload['access']).to include(include('cdn_redirect' => true)) }
|
|
|
|
|
|
|
|
context 'when the feature flag is disabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(container_registry_cdn_redirect: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a valid token'
|
|
|
|
it { expect(payload['access']).not_to include(have_key('cdn_redirect')) }
|
|
|
|
end
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|