2019-12-21 20:55:43 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2014-09-02 18:07:02 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe LabelsHelper do
|
2018-03-17 18:26:18 +05:30
|
|
|
describe '#show_label_issuables_link?' do
|
|
|
|
shared_examples 'a valid response to show_label_issuables_link?' do |issuables_type, when_enabled = true, when_disabled = false|
|
|
|
|
context "when asking for a #{issuables_type} link" do
|
2019-10-12 21:52:04 +05:30
|
|
|
subject { show_label_issuables_link?(label.present(issuable_subject: nil), issuables_type) }
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
context "when #{issuables_type} are enabled for the project" do
|
|
|
|
let(:project) { create(:project, "#{issuables_type}_access_level": ProjectFeature::ENABLED) }
|
|
|
|
|
|
|
|
it { is_expected.to be(when_enabled) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when #{issuables_type} are disabled for the project" do
|
|
|
|
let(:project) { create(:project, :public, "#{issuables_type}_access_level": ProjectFeature::DISABLED) }
|
|
|
|
|
|
|
|
it { is_expected.to be(when_disabled) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with a project label' do
|
|
|
|
let(:label) { create(:label, project: project, title: 'bug') }
|
|
|
|
|
|
|
|
context 'when asking for an issue link' do
|
|
|
|
it_behaves_like 'a valid response to show_label_issuables_link?', :issues
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when asking for a merge requests link' do
|
|
|
|
it_behaves_like 'a valid response to show_label_issuables_link?', :merge_requests
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with a group label' do
|
2020-04-08 14:13:33 +05:30
|
|
|
let_it_be(:group) { create(:group) }
|
2021-04-29 21:17:54 +05:30
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
let(:label) { create(:group_label, group: group, title: 'bug') }
|
|
|
|
|
|
|
|
context 'when asking for an issue link' do
|
2019-10-12 21:52:04 +05:30
|
|
|
it_behaves_like 'a valid response to show_label_issuables_link?', :issues, true, true
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when asking for a merge requests link' do
|
2019-10-12 21:52:04 +05:30
|
|
|
it_behaves_like 'a valid response to show_label_issuables_link?', :merge_requests, true, true
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-09-11 14:41:01 +05:30
|
|
|
describe 'link_to_label' do
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create(:project) }
|
2016-04-02 18:10:28 +05:30
|
|
|
let(:label) { create(:label, project: project) }
|
2019-07-31 22:56:46 +05:30
|
|
|
let(:subject) { nil }
|
|
|
|
let(:label_presenter) { label.present(issuable_subject: subject) }
|
2015-09-11 14:41:01 +05:30
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
context 'without subject' do
|
|
|
|
it "uses the label's project" do
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(link_to_label(label_presenter)).to match %r{<a.*href="/#{label.project.full_path}/-/issues\?label_name%5B%5D=#{label.name}".*>.*</a>}m
|
2015-09-11 14:41:01 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
context 'with a project as subject' do
|
2023-07-09 08:55:56 +05:30
|
|
|
let(:namespace) { build(:namespace) }
|
|
|
|
let(:subject) { build(:project, namespace: namespace) }
|
2016-11-03 12:29:30 +05:30
|
|
|
|
|
|
|
it 'links to project issues page' do
|
2023-07-09 08:55:56 +05:30
|
|
|
expect(link_to_label(label_presenter)).to match %r{<a.*href="/#{subject.full_path}/-/issues\?label_name%5B%5D=#{label.name}".*>.*</a>}m
|
2015-09-11 14:41:01 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
context 'with a group as subject' do
|
2023-07-09 08:55:56 +05:30
|
|
|
let(:subject) { build(:group) }
|
2015-09-11 14:41:01 +05:30
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
it 'links to group issues page' do
|
2023-07-09 08:55:56 +05:30
|
|
|
expect(link_to_label(label_presenter)).to match %r{<a.*href="/groups/#{subject.path}/-/issues\?label_name%5B%5D=#{label.name}".*>.*</a>}m
|
2015-09-11 14:41:01 +05:30
|
|
|
end
|
2016-04-02 18:10:28 +05:30
|
|
|
end
|
2015-09-11 14:41:01 +05:30
|
|
|
|
2016-04-02 18:10:28 +05:30
|
|
|
context 'with a type argument' do
|
2020-04-08 14:13:33 +05:30
|
|
|
['issue', :issue, 'merge_request', :merge_request].each do |type|
|
2016-04-02 18:10:28 +05:30
|
|
|
context "set to #{type}" do
|
|
|
|
it 'links to correct page' do
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(link_to_label(label_presenter, type: type)).to match %r{<a.*href="/#{label.project.full_path}/-/#{type.to_s.pluralize}\?label_name%5B%5D=#{label.name}".*>.*</a>}m
|
2020-03-13 15:44:24 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-09-11 14:41:01 +05:30
|
|
|
end
|
|
|
|
|
2016-06-02 11:05:42 +05:30
|
|
|
context 'with a tooltip argument' do
|
|
|
|
context 'set to false' do
|
|
|
|
it 'does not include the has-tooltip class' do
|
2019-07-31 22:56:46 +05:30
|
|
|
expect(link_to_label(label_presenter, tooltip: false)).not_to match /has-tooltip/
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-09-11 14:41:01 +05:30
|
|
|
context 'with block' do
|
|
|
|
it 'passes the block to link_to' do
|
2019-07-31 22:56:46 +05:30
|
|
|
link = link_to_label(label_presenter) { 'Foo' }
|
2015-09-11 14:41:01 +05:30
|
|
|
expect(link).to match('Foo')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'without block' do
|
|
|
|
it 'uses render_colored_label as the link content' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(self).to receive(:render_colored_label)
|
2020-04-08 14:13:33 +05:30
|
|
|
.with(label_presenter).and_return('Foo')
|
2019-07-31 22:56:46 +05:30
|
|
|
expect(link_to_label(label_presenter)).to match('Foo')
|
2015-09-11 14:41:01 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-09-01 20:07:04 +05:30
|
|
|
describe 'render_label_text' do
|
|
|
|
it 'html escapes the bg_color correctly' do
|
|
|
|
xss_payload = '"><img src=x onerror=prompt(1)>'
|
|
|
|
label_text = render_label_text('xss', bg_color: xss_payload)
|
|
|
|
expect(label_text).to include(html_escape(xss_payload))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-09-11 14:41:01 +05:30
|
|
|
describe 'text_color_for_bg' do
|
|
|
|
it 'uses light text on dark backgrounds' do
|
2022-05-07 20:08:51 +05:30
|
|
|
expect(text_color_for_bg('#222E2E')).to be_color('#FFFFFF')
|
2015-09-11 14:41:01 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'uses dark text on light backgrounds' do
|
2023-07-09 08:55:56 +05:30
|
|
|
expect(text_color_for_bg('#EEEEEE')).to be_color('#1F1E24')
|
2015-09-11 14:41:01 +05:30
|
|
|
end
|
2016-04-02 18:10:28 +05:30
|
|
|
|
|
|
|
it 'supports RGB triplets' do
|
2023-07-09 08:55:56 +05:30
|
|
|
expect(text_color_for_bg('#FFF')).to be_color '#1F1E24'
|
2022-05-07 20:08:51 +05:30
|
|
|
expect(text_color_for_bg('#000')).to be_color '#FFFFFF'
|
2016-04-02 18:10:28 +05:30
|
|
|
end
|
2015-09-11 14:41:01 +05:30
|
|
|
end
|
2018-05-09 12:01:36 +05:30
|
|
|
|
|
|
|
describe 'create_label_title' do
|
2020-04-08 14:13:33 +05:30
|
|
|
let_it_be(:group) { create(:group) }
|
2018-05-09 12:01:36 +05:30
|
|
|
|
|
|
|
context 'with a group as subject' do
|
|
|
|
it 'returns "Create group label"' do
|
2020-01-01 13:55:28 +05:30
|
|
|
expect(create_label_title(group)).to eq _('Create group label')
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with a project as subject' do
|
2020-04-08 14:13:33 +05:30
|
|
|
let_it_be(:project) { create(:project, namespace: group) }
|
2018-05-09 12:01:36 +05:30
|
|
|
|
|
|
|
it 'returns "Create project label"' do
|
2020-01-01 13:55:28 +05:30
|
|
|
expect(create_label_title(project)).to eq _('Create project label')
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with no subject' do
|
|
|
|
it 'returns "Create new label"' do
|
2020-01-01 13:55:28 +05:30
|
|
|
expect(create_label_title(nil)).to eq _('Create new label')
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'manage_labels_title' do
|
2020-04-08 14:13:33 +05:30
|
|
|
let_it_be(:group) { create(:group) }
|
2018-05-09 12:01:36 +05:30
|
|
|
|
|
|
|
context 'with a group as subject' do
|
|
|
|
it 'returns "Manage group labels"' do
|
2020-01-01 13:55:28 +05:30
|
|
|
expect(manage_labels_title(group)).to eq _('Manage group labels')
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with a project as subject' do
|
2020-04-08 14:13:33 +05:30
|
|
|
let_it_be(:project) { create(:project, namespace: group) }
|
2018-05-09 12:01:36 +05:30
|
|
|
|
|
|
|
it 'returns "Manage project labels"' do
|
2020-01-01 13:55:28 +05:30
|
|
|
expect(manage_labels_title(project)).to eq _('Manage project labels')
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with no subject' do
|
|
|
|
it 'returns "Manage labels"' do
|
2020-01-01 13:55:28 +05:30
|
|
|
expect(manage_labels_title(nil)).to eq _('Manage labels')
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'view_labels_title' do
|
2020-04-08 14:13:33 +05:30
|
|
|
let_it_be(:group) { create(:group) }
|
2018-05-09 12:01:36 +05:30
|
|
|
|
|
|
|
context 'with a group as subject' do
|
|
|
|
it 'returns "View group labels"' do
|
2020-01-01 13:55:28 +05:30
|
|
|
expect(view_labels_title(group)).to eq _('View group labels')
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with a project as subject' do
|
2020-04-08 14:13:33 +05:30
|
|
|
let_it_be(:project) { create(:project, namespace: group) }
|
2018-05-09 12:01:36 +05:30
|
|
|
|
|
|
|
it 'returns "View project labels"' do
|
2020-01-01 13:55:28 +05:30
|
|
|
expect(view_labels_title(project)).to eq _('View project labels')
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with no subject' do
|
|
|
|
it 'returns "View labels"' do
|
2020-01-01 13:55:28 +05:30
|
|
|
expect(view_labels_title(nil)).to eq _('View labels')
|
2018-05-09 12:01:36 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-12-13 13:39:08 +05:30
|
|
|
|
|
|
|
describe 'labels_filter_path' do
|
|
|
|
let(:group) { create(:group) }
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
|
|
|
|
it 'links to the dashboard labels page' do
|
|
|
|
expect(labels_filter_path).to eq(dashboard_labels_path)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'links to the group labels page' do
|
|
|
|
assign(:group, group)
|
|
|
|
|
|
|
|
expect(helper.labels_filter_path).to eq(group_labels_path(group))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'links to the project labels page' do
|
|
|
|
assign(:project, project)
|
|
|
|
|
|
|
|
expect(helper.labels_filter_path).to eq(project_labels_path(project))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'supports json format' do
|
|
|
|
expect(labels_filter_path(format: :json)).to eq(dashboard_labels_path(format: :json))
|
|
|
|
end
|
|
|
|
end
|
2019-07-07 11:18:12 +05:30
|
|
|
|
2019-07-31 22:56:46 +05:30
|
|
|
describe 'presented_labels_sorted_by_title' do
|
|
|
|
let(:labels) do
|
|
|
|
[build(:label, title: 'a'),
|
|
|
|
build(:label, title: 'B'),
|
|
|
|
build(:label, title: 'c'),
|
|
|
|
build(:label, title: 'D')]
|
|
|
|
end
|
|
|
|
|
2019-07-07 11:18:12 +05:30
|
|
|
it 'sorts labels alphabetically' do
|
2019-07-31 22:56:46 +05:30
|
|
|
sorted_ids = presented_labels_sorted_by_title(labels, nil).map(&:id)
|
|
|
|
|
|
|
|
expect(sorted_ids)
|
|
|
|
.to match_array([labels[1].id, labels[3].id, labels[0].id, labels[2].id])
|
|
|
|
end
|
2019-07-07 11:18:12 +05:30
|
|
|
|
2019-07-31 22:56:46 +05:30
|
|
|
it 'returns an array of label presenters' do
|
|
|
|
expect(presented_labels_sorted_by_title(labels, nil))
|
|
|
|
.to all(be_a(LabelPresenter))
|
2019-07-07 11:18:12 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-07-31 22:56:46 +05:30
|
|
|
describe '#label_status_tooltip' do
|
|
|
|
let(:status) { 'unsubscribed'.inquiry }
|
2020-01-01 13:55:28 +05:30
|
|
|
|
2019-07-31 22:56:46 +05:30
|
|
|
subject { label_status_tooltip(label.present(issuable_subject: nil), status) }
|
|
|
|
|
|
|
|
context 'with a project label' do
|
|
|
|
let(:label) { create(:label, title: 'bug') }
|
|
|
|
|
|
|
|
it { is_expected.to eq('Subscribe at project level') }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with a group label' do
|
|
|
|
let(:label) { create(:group_label, title: 'bug') }
|
|
|
|
|
|
|
|
it { is_expected.to eq('Subscribe at group level') }
|
|
|
|
end
|
|
|
|
end
|
2019-09-04 21:01:54 +05:30
|
|
|
|
|
|
|
describe '#label_tooltip_title' do
|
|
|
|
let(:html) { '<img src="example.png">This is an image</img>' }
|
|
|
|
let(:label_with_html_content) { create(:label, title: 'test', description: html) }
|
|
|
|
|
|
|
|
it 'removes HTML' do
|
|
|
|
tooltip = label_tooltip_title(label_with_html_content)
|
|
|
|
expect(tooltip).to eq('This is an image')
|
|
|
|
end
|
|
|
|
end
|
2021-01-03 14:25:43 +05:30
|
|
|
|
|
|
|
describe '#show_labels_full_path?' do
|
|
|
|
let_it_be(:group) { create(:group) }
|
|
|
|
let_it_be(:subgroup) { create(:group, parent: group) }
|
|
|
|
let_it_be(:project) { create(:project, group: group) }
|
|
|
|
|
|
|
|
context 'within a project' do
|
|
|
|
it 'returns truthy' do
|
|
|
|
expect(show_labels_full_path?(project, nil)).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'within a subgroup' do
|
|
|
|
it 'returns truthy' do
|
|
|
|
expect(show_labels_full_path?(nil, subgroup)).to be_truthy
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'within a group' do
|
|
|
|
it 'returns falsey' do
|
|
|
|
expect(show_labels_full_path?(nil, group)).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'within the admin area' do
|
|
|
|
it 'returns falsey' do
|
|
|
|
expect(show_labels_full_path?(nil, nil)).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2022-11-25 23:54:43 +05:30
|
|
|
|
|
|
|
describe '#wrap_label_html' do
|
|
|
|
let(:project) { build_stubbed(:project) }
|
|
|
|
let(:xss_label) do
|
|
|
|
build_stubbed(:label, name: 'xsslabel', project: project, color: '"><img src=x onerror=prompt(1)>')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not include the color' do
|
|
|
|
expect(wrap_label_html('xss', label: xss_label, small: false)).not_to include('color:')
|
|
|
|
end
|
|
|
|
end
|
2023-03-04 22:38:38 +05:30
|
|
|
|
|
|
|
describe '#label_subscription_toggle_button_text' do
|
|
|
|
let(:label) { instance_double(Label) }
|
|
|
|
let(:current_user) { instance_double(User) }
|
|
|
|
|
|
|
|
subject { label_subscription_toggle_button_text(label) }
|
|
|
|
|
|
|
|
context 'when the label is subscribed' do
|
|
|
|
before do
|
|
|
|
allow(label).to receive(:subscribed?).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq(_('Unsubscribe')) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the label is not subscribed' do
|
|
|
|
before do
|
|
|
|
allow(label).to receive(:subscribed?).and_return(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq(_('Subscribe')) }
|
|
|
|
end
|
|
|
|
end
|
2014-09-02 18:07:02 +05:30
|
|
|
end
|