debian-mirror-gitlab/spec/rubocop/cop/migration/timestamps_spec.rb

95 lines
2.4 KiB
Ruby
Raw Normal View History

2019-12-26 22:10:19 +05:30
# frozen_string_literal: true
2020-07-28 23:09:34 +05:30
require 'fast_spec_helper'
2017-09-10 17:25:29 +05:30
require_relative '../../../../rubocop/cop/migration/timestamps'
2021-03-08 18:12:59 +05:30
RSpec.describe RuboCop::Cop::Migration::Timestamps do
2017-09-10 17:25:29 +05:30
subject(:cop) { described_class.new }
2019-12-21 20:55:43 +05:30
2017-09-10 17:25:29 +05:30
let(:migration_with_timestamps) do
%q(
2019-02-15 15:39:39 +05:30
class Users < ActiveRecord::Migration[4.2]
2017-09-10 17:25:29 +05:30
DOWNTIME = false
def change
create_table :users do |t|
t.string :username, null: false
t.timestamps null: true
t.string :password
end
end
end
)
end
let(:migration_without_timestamps) do
%q(
2019-02-15 15:39:39 +05:30
class Users < ActiveRecord::Migration[4.2]
2017-09-10 17:25:29 +05:30
DOWNTIME = false
def change
create_table :users do |t|
t.string :username, null: false
t.string :password
end
end
end
)
end
let(:migration_with_timestamps_with_timezone) do
%q(
2019-02-15 15:39:39 +05:30
class Users < ActiveRecord::Migration[4.2]
2017-09-10 17:25:29 +05:30
DOWNTIME = false
def change
create_table :users do |t|
t.string :username, null: false
t.timestamps_with_timezone null: true
t.string :password
end
end
end
)
end
context 'in migration' do
before do
allow(cop).to receive(:in_migration?).and_return(true)
end
it 'registers an offense when the "timestamps" method is used' do
2021-04-17 20:07:23 +05:30
expect_offense(<<~RUBY)
class Users < ActiveRecord::Migration[4.2]
DOWNTIME = false
def change
create_table :users do |t|
t.string :username, null: false
t.timestamps null: true
^^^^^^^^^^ Do not use `timestamps`, use `timestamps_with_timezone` instead
t.string :password
end
end
end
RUBY
2017-09-10 17:25:29 +05:30
end
it 'does not register an offense when the "timestamps" method is not used' do
2021-04-17 20:07:23 +05:30
expect_no_offenses(migration_without_timestamps)
2017-09-10 17:25:29 +05:30
end
it 'does not register an offense when the "timestamps_with_timezone" method is used' do
2021-04-17 20:07:23 +05:30
expect_no_offenses(migration_with_timestamps_with_timezone)
2017-09-10 17:25:29 +05:30
end
end
context 'outside of migration' do
2021-04-17 20:07:23 +05:30
it 'registers no offense', :aggregate_failures do
expect_no_offenses(migration_with_timestamps)
expect_no_offenses(migration_without_timestamps)
expect_no_offenses(migration_with_timestamps_with_timezone)
2017-09-10 17:25:29 +05:30
end
end
end