2021-03-11 19:13:27 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
RSpec.describe 'Pages edits pages settings', :js do
|
|
|
|
let(:project) { create(:project, pages_https_only: false) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(Gitlab.config.pages).to receive(:enabled).and_return(true)
|
|
|
|
|
|
|
|
project.add_maintainer(user)
|
|
|
|
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is the owner' do
|
|
|
|
before do
|
|
|
|
project.namespace.update!(owner: user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when pages deployed' do
|
|
|
|
before do
|
|
|
|
project.mark_pages_as_deployed
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders Access pages' do
|
|
|
|
visit project_pages_path(project)
|
|
|
|
|
|
|
|
expect(page).to have_content('Access pages')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when pages are disabled in the project settings' do
|
|
|
|
it 'renders disabled warning' do
|
|
|
|
project.project_feature.update!(pages_access_level: ProjectFeature::DISABLED)
|
|
|
|
|
|
|
|
visit project_pages_path(project)
|
|
|
|
|
|
|
|
expect(page).to have_content('GitLab Pages are disabled for this project')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders first deployment warning' do
|
|
|
|
visit project_pages_path(project)
|
|
|
|
|
|
|
|
expect(page).to have_content('It may take up to 30 minutes before the site is available after the first deployment.')
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples 'does not render access control warning' do
|
|
|
|
it 'does not render access control warning' do
|
|
|
|
visit project_pages_path(project)
|
|
|
|
|
|
|
|
expect(page).not_to have_content('Access Control is enabled for this Pages website')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'does not render access control warning'
|
|
|
|
|
|
|
|
context 'when access control is enabled in gitlab settings' do
|
|
|
|
before do
|
|
|
|
stub_pages_setting(access_control: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders access control warning' do
|
|
|
|
visit project_pages_path(project)
|
|
|
|
|
|
|
|
expect(page).to have_content('Access Control is enabled for this Pages website')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when pages are public' do
|
|
|
|
before do
|
|
|
|
project.project_feature.update!(pages_access_level: ProjectFeature::PUBLIC)
|
|
|
|
end
|
|
|
|
|
|
|
|
include_examples 'does not render access control warning'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when support for external domains is disabled' do
|
|
|
|
it 'renders message that support is disabled' do
|
|
|
|
visit project_pages_path(project)
|
|
|
|
|
|
|
|
expect(page).to have_content('Support for domains and certificates is disabled')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not see anything to destroy' do
|
|
|
|
visit project_pages_path(project)
|
|
|
|
|
|
|
|
expect(page).to have_content('Configure pages')
|
|
|
|
expect(page).not_to have_link('Remove pages')
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'project settings page' do
|
|
|
|
it 'renders "Pages" tab' do
|
|
|
|
visit edit_project_path(project)
|
|
|
|
|
|
|
|
page.within '.nav-sidebar' do
|
|
|
|
expect(page).to have_link('Pages')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when pages are disabled' do
|
|
|
|
before do
|
|
|
|
allow(Gitlab.config.pages).to receive(:enabled).and_return(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not render "Pages" tab' do
|
|
|
|
visit edit_project_path(project)
|
|
|
|
|
|
|
|
page.within '.nav-sidebar' do
|
|
|
|
expect(page).not_to have_link('Pages')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'HTTPS settings', :https_pages_enabled do
|
|
|
|
before do
|
|
|
|
project.namespace.update!(owner: user)
|
|
|
|
|
|
|
|
project.mark_pages_as_deployed
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'tries to change the setting' do
|
|
|
|
visit project_pages_path(project)
|
|
|
|
expect(page).to have_content("Force HTTPS (requires valid certificates)")
|
|
|
|
|
|
|
|
uncheck :project_pages_https_only
|
|
|
|
|
|
|
|
click_button 'Save'
|
|
|
|
|
|
|
|
expect(page).to have_text('Your changes have been saved')
|
|
|
|
expect(page).not_to have_checked_field('project_pages_https_only')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'setting could not be updated' do
|
|
|
|
let(:service) { instance_double('Projects::UpdateService') }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(Projects::UpdateService).to receive(:new).and_return(service)
|
2021-04-17 20:07:23 +05:30
|
|
|
allow(service).to receive(:execute).and_return(status: :error, message: 'Some error has occurred')
|
2021-03-11 19:13:27 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'tries to change the setting' do
|
|
|
|
visit project_pages_path(project)
|
|
|
|
|
|
|
|
uncheck :project_pages_https_only
|
|
|
|
|
|
|
|
click_button 'Save'
|
|
|
|
|
2021-04-17 20:07:23 +05:30
|
|
|
expect(page).to have_text('Some error has occurred')
|
2021-03-11 19:13:27 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'non-HTTPS domain exists' do
|
|
|
|
let(:project) { create(:project, pages_https_only: false) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
create(:pages_domain, :without_key, :without_certificate, project: project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'the setting is disabled' do
|
|
|
|
visit project_pages_path(project)
|
|
|
|
|
|
|
|
expect(page).to have_field(:project_pages_https_only, disabled: true)
|
|
|
|
expect(page).to have_button('Save')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'HTTPS pages are disabled', :https_pages_disabled do
|
|
|
|
it 'the setting is unavailable' do
|
|
|
|
visit project_pages_path(project)
|
|
|
|
|
|
|
|
expect(page).not_to have_field(:project_pages_https_only)
|
|
|
|
expect(page).not_to have_content('Force HTTPS (requires valid certificates)')
|
|
|
|
expect(page).to have_button('Save')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'Remove page' do
|
|
|
|
context 'when pages are deployed' do
|
|
|
|
before do
|
|
|
|
project.mark_pages_as_deployed
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'removes the pages', :sidekiq_inline do
|
|
|
|
visit project_pages_path(project)
|
|
|
|
|
|
|
|
expect(page).to have_link('Remove pages')
|
|
|
|
|
|
|
|
accept_confirm { click_link 'Remove pages' }
|
|
|
|
|
|
|
|
expect(page).to have_content('Pages were scheduled for removal')
|
|
|
|
expect(project.reload.pages_deployed?).to be_falsey
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|