2020-04-08 14:13:33 +05:30
|
|
|
import Vuex from 'vuex';
|
2020-04-22 19:07:51 +05:30
|
|
|
import { createLocalVue, shallowMount, mount } from '@vue/test-utils';
|
2021-01-03 14:25:43 +05:30
|
|
|
import { GlButton } from '@gitlab/ui';
|
2020-04-22 19:07:51 +05:30
|
|
|
import { AWS_ACCESS_KEY_ID } from '~/ci_variable_list/constants';
|
2020-04-08 14:13:33 +05:30
|
|
|
import CiVariableModal from '~/ci_variable_list/components/ci_variable_modal.vue';
|
|
|
|
import createStore from '~/ci_variable_list/store';
|
|
|
|
import mockData from '../services/mock_data';
|
|
|
|
import ModalStub from '../stubs';
|
|
|
|
|
|
|
|
const localVue = createLocalVue();
|
|
|
|
localVue.use(Vuex);
|
|
|
|
|
|
|
|
describe('Ci variable modal', () => {
|
|
|
|
let wrapper;
|
|
|
|
let store;
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
const createComponent = (method, options = {}) => {
|
2020-04-08 14:13:33 +05:30
|
|
|
store = createStore();
|
2020-04-22 19:07:51 +05:30
|
|
|
wrapper = method(CiVariableModal, {
|
|
|
|
attachToDocument: true,
|
2020-04-08 14:13:33 +05:30
|
|
|
stubs: {
|
|
|
|
GlModal: ModalStub,
|
|
|
|
},
|
|
|
|
localVue,
|
|
|
|
store,
|
2020-04-22 19:07:51 +05:30
|
|
|
...options,
|
2020-04-08 14:13:33 +05:30
|
|
|
});
|
|
|
|
};
|
|
|
|
|
|
|
|
const findModal = () => wrapper.find(ModalStub);
|
2020-10-24 23:57:45 +05:30
|
|
|
const findAddorUpdateButton = () =>
|
2020-04-08 14:13:33 +05:30
|
|
|
findModal()
|
2020-10-24 23:57:45 +05:30
|
|
|
.findAll(GlButton)
|
|
|
|
.wrappers.find(button => button.props('variant') === 'success');
|
2020-04-08 14:13:33 +05:30
|
|
|
const deleteVariableButton = () =>
|
|
|
|
findModal()
|
2020-10-24 23:57:45 +05:30
|
|
|
.findAll(GlButton)
|
|
|
|
.wrappers.find(button => button.props('variant') === 'danger');
|
2020-04-08 14:13:33 +05:30
|
|
|
|
|
|
|
afterEach(() => {
|
|
|
|
wrapper.destroy();
|
|
|
|
});
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
describe('Basic interactions', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
createComponent(shallowMount);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('button is disabled when no key/value pair are present', () => {
|
2020-10-24 23:57:45 +05:30
|
|
|
expect(findAddorUpdateButton().attributes('disabled')).toBeTruthy();
|
2020-04-22 19:07:51 +05:30
|
|
|
});
|
2020-04-08 14:13:33 +05:30
|
|
|
});
|
|
|
|
|
|
|
|
describe('Adding a new variable', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
const [variable] = mockData.mockVariables;
|
2020-04-22 19:07:51 +05:30
|
|
|
createComponent(shallowMount);
|
|
|
|
jest.spyOn(store, 'dispatch').mockImplementation();
|
2020-04-08 14:13:33 +05:30
|
|
|
store.state.variable = variable;
|
|
|
|
});
|
|
|
|
|
|
|
|
it('button is enabled when key/value pair are present', () => {
|
2020-10-24 23:57:45 +05:30
|
|
|
expect(findAddorUpdateButton().attributes('disabled')).toBeFalsy();
|
2020-04-08 14:13:33 +05:30
|
|
|
});
|
|
|
|
|
|
|
|
it('Add variable button dispatches addVariable action', () => {
|
2020-10-24 23:57:45 +05:30
|
|
|
findAddorUpdateButton().vm.$emit('click');
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(store.dispatch).toHaveBeenCalledWith('addVariable');
|
|
|
|
});
|
|
|
|
|
|
|
|
it('Clears the modal state once modal is hidden', () => {
|
|
|
|
findModal().vm.$emit('hidden');
|
|
|
|
expect(store.dispatch).toHaveBeenCalledWith('clearModal');
|
|
|
|
});
|
2020-05-24 23:13:21 +05:30
|
|
|
|
|
|
|
it('should dispatch setVariableProtected when admin settings are configured to protect variables', () => {
|
|
|
|
store.state.isProtectedByDefault = true;
|
|
|
|
findModal().vm.$emit('shown');
|
|
|
|
|
|
|
|
expect(store.dispatch).toHaveBeenCalledWith('setVariableProtected');
|
|
|
|
});
|
2020-04-08 14:13:33 +05:30
|
|
|
});
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
describe('Adding a new non-AWS variable', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
const [variable] = mockData.mockVariables;
|
|
|
|
const invalidKeyVariable = {
|
|
|
|
...variable,
|
|
|
|
key: 'key',
|
|
|
|
value: 'value',
|
|
|
|
secret_value: 'secret_value',
|
|
|
|
};
|
|
|
|
createComponent(mount);
|
|
|
|
store.state.variable = invalidKeyVariable;
|
|
|
|
});
|
|
|
|
|
|
|
|
it('does not show AWS guidance tip', () => {
|
|
|
|
const tip = wrapper.find(`div[data-testid='aws-guidance-tip']`);
|
|
|
|
expect(tip.exists()).toBe(true);
|
|
|
|
expect(tip.isVisible()).toBe(false);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('Adding a new AWS variable', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
const [variable] = mockData.mockVariables;
|
|
|
|
const invalidKeyVariable = {
|
|
|
|
...variable,
|
|
|
|
key: AWS_ACCESS_KEY_ID,
|
|
|
|
value: 'AKIAIOSFODNN7EXAMPLEjdhy',
|
|
|
|
secret_value: 'AKIAIOSFODNN7EXAMPLEjdhy',
|
|
|
|
};
|
|
|
|
createComponent(mount);
|
|
|
|
store.state.variable = invalidKeyVariable;
|
|
|
|
});
|
|
|
|
|
|
|
|
it('shows AWS guidance tip', () => {
|
|
|
|
const tip = wrapper.find(`[data-testid='aws-guidance-tip']`);
|
|
|
|
expect(tip.exists()).toBe(true);
|
|
|
|
expect(tip.isVisible()).toBe(true);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
describe('Editing a variable', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
const [variable] = mockData.mockVariables;
|
2020-04-22 19:07:51 +05:30
|
|
|
createComponent(shallowMount);
|
|
|
|
jest.spyOn(store, 'dispatch').mockImplementation();
|
2020-04-08 14:13:33 +05:30
|
|
|
store.state.variableBeingEdited = variable;
|
|
|
|
});
|
|
|
|
|
|
|
|
it('button text is Update variable when updating', () => {
|
2020-10-24 23:57:45 +05:30
|
|
|
expect(findAddorUpdateButton().text()).toBe('Update variable');
|
2020-04-08 14:13:33 +05:30
|
|
|
});
|
|
|
|
|
|
|
|
it('Update variable button dispatches updateVariable with correct variable', () => {
|
2020-10-24 23:57:45 +05:30
|
|
|
findAddorUpdateButton().vm.$emit('click');
|
2020-07-28 23:09:34 +05:30
|
|
|
expect(store.dispatch).toHaveBeenCalledWith('updateVariable');
|
2020-04-08 14:13:33 +05:30
|
|
|
});
|
|
|
|
|
|
|
|
it('Resets the editing state once modal is hidden', () => {
|
|
|
|
findModal().vm.$emit('hidden');
|
|
|
|
expect(store.dispatch).toHaveBeenCalledWith('resetEditing');
|
|
|
|
});
|
|
|
|
|
|
|
|
it('dispatches deleteVariable with correct variable to delete', () => {
|
|
|
|
deleteVariableButton().vm.$emit('click');
|
2020-07-28 23:09:34 +05:30
|
|
|
expect(store.dispatch).toHaveBeenCalledWith('deleteVariable');
|
2020-04-08 14:13:33 +05:30
|
|
|
});
|
|
|
|
});
|
2020-04-22 19:07:51 +05:30
|
|
|
|
|
|
|
describe('Validations', () => {
|
|
|
|
const maskError = 'This variable can not be masked.';
|
|
|
|
|
|
|
|
describe('when the mask state is invalid', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
const [variable] = mockData.mockVariables;
|
|
|
|
const invalidMaskVariable = {
|
|
|
|
...variable,
|
|
|
|
key: 'qs',
|
|
|
|
value: 'd:;',
|
|
|
|
secret_value: 'd:;',
|
|
|
|
masked: true,
|
|
|
|
};
|
|
|
|
createComponent(mount);
|
|
|
|
store.state.variable = invalidMaskVariable;
|
|
|
|
});
|
|
|
|
|
|
|
|
it('disables the submit button', () => {
|
2020-10-24 23:57:45 +05:30
|
|
|
expect(findAddorUpdateButton().attributes('disabled')).toBeTruthy();
|
2020-04-22 19:07:51 +05:30
|
|
|
});
|
|
|
|
|
|
|
|
it('shows the correct error text', () => {
|
|
|
|
expect(findModal().text()).toContain(maskError);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
describe('when both states are valid', () => {
|
|
|
|
beforeEach(() => {
|
|
|
|
const [variable] = mockData.mockVariables;
|
|
|
|
const validMaskandKeyVariable = {
|
|
|
|
...variable,
|
|
|
|
key: AWS_ACCESS_KEY_ID,
|
2020-07-28 23:09:34 +05:30
|
|
|
value: '12345678',
|
|
|
|
secret_value: '87654321',
|
2020-04-22 19:07:51 +05:30
|
|
|
masked: true,
|
|
|
|
};
|
|
|
|
createComponent(mount);
|
|
|
|
store.state.variable = validMaskandKeyVariable;
|
|
|
|
store.state.maskableRegex = /^[a-zA-Z0-9_+=/@:-]{8,}$/;
|
|
|
|
});
|
|
|
|
|
|
|
|
it('does not disable the submit button', () => {
|
2020-10-24 23:57:45 +05:30
|
|
|
expect(findAddorUpdateButton().attributes('disabled')).toBeFalsy();
|
2020-04-22 19:07:51 +05:30
|
|
|
});
|
|
|
|
});
|
|
|
|
});
|
2020-04-08 14:13:33 +05:30
|
|
|
});
|