55 lines
1.6 KiB
Ruby
55 lines
1.6 KiB
Ruby
|
# frozen_string_literal: true
|
||
|
|
|
||
|
|
require 'fast_spec_helper'
|
||
|
|
require 'rubocop'
|
||
|
|
require_relative '../../../support/helpers/expect_offense'
|
||
|
|
require_relative '../../../../rubocop/cop/scalability/file_uploads'
|
||
|
|
|
||
|
|
describe RuboCop::Cop::Scalability::FileUploads do
|
||
|
|
include CopHelper
|
||
|
|
include ExpectOffense
|
||
|
|
|
||
|
|
subject(:cop) { described_class.new }
|
||
|
|
let(:message) { 'Do not upload files without workhorse acceleration. Please refer to https://docs.gitlab.com/ee/development/uploads.html' }
|
||
|
|
|
||
|
|
context 'with required params' do
|
||
|
|
it 'detects File in types array' do
|
||
|
|
expect_offense(<<~PATTERN.strip_indent)
|
||
|
|
params do
|
||
|
|
requires :certificate, allow_blank: false, types: [String, File]
|
||
|
|
^^^^ #{message}
|
||
|
|
end
|
||
|
|
PATTERN
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'detects File as type argument' do
|
||
|
|
expect_offense(<<~PATTERN.strip_indent)
|
||
|
|
params do
|
||
|
|
requires :attachment, type: File
|
||
|
|
^^^^ #{message}
|
||
|
|
end
|
||
|
|
PATTERN
|
||
|
|
end
|
||
|
|
end
|
||
|
|
|
||
|
|
context 'with optional params' do
|
||
|
|
it 'detects File in types array' do
|
||
|
|
expect_offense(<<~PATTERN.strip_indent)
|
||
|
|
params do
|
||
|
|
optional :certificate, allow_blank: false, types: [String, File]
|
||
|
|
^^^^ #{message}
|
||
|
|
end
|
||
|
|
PATTERN
|
||
|
|
end
|
||
|
|
|
||
|
|
it 'detects File as type argument' do
|
||
|
|
expect_offense(<<~PATTERN.strip_indent)
|
||
|
|
params do
|
||
|
|
optional :attachment, type: File
|
||
|
|
^^^^ #{message}
|
||
|
|
end
|
||
|
|
PATTERN
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|