2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Gitlab::Ci::Build::Policy::Refs do
|
|
|
|
describe '#satisfied_by?' do
|
|
|
|
context 'when matching ref' do
|
|
|
|
let(:pipeline) { build_stubbed(:ci_pipeline, ref: 'master') }
|
|
|
|
|
|
|
|
it 'is satisfied when pipeline branch matches' do
|
|
|
|
expect(described_class.new(%w[master deploy]))
|
|
|
|
.to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is not satisfied when pipeline branch does not match' do
|
|
|
|
expect(described_class.new(%w[feature fix]))
|
|
|
|
.not_to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
context 'when matching tags' do
|
2018-03-17 18:26:18 +05:30
|
|
|
context 'when pipeline runs for a tag' do
|
|
|
|
let(:pipeline) do
|
|
|
|
build_stubbed(:ci_pipeline, ref: 'feature', tag: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is satisfied when tags matcher is specified' do
|
|
|
|
expect(described_class.new(%w[master tags]))
|
|
|
|
.to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when pipeline is not created for a tag' do
|
|
|
|
let(:pipeline) do
|
|
|
|
build_stubbed(:ci_pipeline, ref: 'feature', tag: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is not satisfied when tag match is specified' do
|
|
|
|
expect(described_class.new(%w[master tags]))
|
|
|
|
.not_to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when also matching a path' do
|
|
|
|
let(:pipeline) do
|
|
|
|
build_stubbed(:ci_pipeline, ref: 'master')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is satisfied when provided patch matches specified one' do
|
|
|
|
expect(described_class.new(%W[master@#{pipeline.project_full_path}]))
|
|
|
|
.to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is not satisfied when path differs' do
|
|
|
|
expect(described_class.new(%w[master@some/fork/repository]))
|
|
|
|
.not_to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
context 'when matching a source' do
|
2018-03-17 18:26:18 +05:30
|
|
|
let(:pipeline) { build_stubbed(:ci_pipeline, source: :push) }
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
it 'is satisfied when provided source keyword matches' do
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(described_class.new(%w[pushes]))
|
|
|
|
.to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is not satisfied when provided source keyword does not match' do
|
|
|
|
expect(described_class.new(%w[triggers]))
|
|
|
|
.not_to be_satisfied_by(pipeline)
|
|
|
|
end
|
2019-07-07 11:18:12 +05:30
|
|
|
|
|
|
|
context 'when source is merge_request_event' do
|
|
|
|
let(:pipeline) { build_stubbed(:ci_pipeline, source: :merge_request_event) }
|
|
|
|
|
|
|
|
it 'is satisfied with only: merge_request' do
|
|
|
|
expect(described_class.new(%w[merge_requests]))
|
|
|
|
.to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is not satisfied with only: merge_request_event' do
|
|
|
|
expect(described_class.new(%w[merge_request_events]))
|
|
|
|
.not_to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
end
|
2019-12-04 20:38:33 +05:30
|
|
|
|
|
|
|
context 'when source is external_pull_request_event' do
|
|
|
|
let(:pipeline) { build_stubbed(:ci_pipeline, source: :external_pull_request_event) }
|
|
|
|
|
|
|
|
it 'is satisfied with only: external_pull_request' do
|
|
|
|
expect(described_class.new(%w[external_pull_requests]))
|
|
|
|
.to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is not satisfied with only: external_pull_request_event' do
|
|
|
|
expect(described_class.new(%w[external_pull_request_events]))
|
|
|
|
.not_to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when matching a ref by a regular expression' do
|
|
|
|
let(:pipeline) { build_stubbed(:ci_pipeline, ref: 'docs-something') }
|
|
|
|
|
|
|
|
it 'is satisfied when regexp matches pipeline ref' do
|
|
|
|
expect(described_class.new(['/docs-.*/']))
|
|
|
|
.to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
|
2019-04-03 18:18:56 +05:30
|
|
|
it 'is satisfied when case-insensitive regexp matches pipeline ref' do
|
|
|
|
expect(described_class.new(['/DOCS-.*/i']))
|
|
|
|
.to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it 'is not satisfied when regexp does not match pipeline ref' do
|
|
|
|
expect(described_class.new(['/fix-.*/']))
|
|
|
|
.not_to be_satisfied_by(pipeline)
|
|
|
|
end
|
2019-07-07 11:18:12 +05:30
|
|
|
|
|
|
|
context 'when unsafe regexp is used' do
|
|
|
|
let(:subject) { described_class.new(['/^(?!master).+/']) }
|
|
|
|
|
|
|
|
context 'when allow_unsafe_ruby_regexp is disabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(allow_unsafe_ruby_regexp: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid regexp' do
|
|
|
|
expect(subject)
|
|
|
|
.not_to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when allow_unsafe_ruby_regexp is enabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(allow_unsafe_ruby_regexp: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is satisfied by regexp' do
|
|
|
|
expect(subject)
|
|
|
|
.to be_satisfied_by(pipeline)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
2019-04-03 18:18:56 +05:30
|
|
|
|
|
|
|
context 'malicious regexp' do
|
|
|
|
let(:pipeline) { build_stubbed(:ci_pipeline, ref: malicious_text) }
|
|
|
|
|
|
|
|
subject { described_class.new([malicious_regexp_ruby]) }
|
|
|
|
|
|
|
|
include_examples 'malicious regexp'
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
end
|