51 lines
1.2 KiB
Ruby
51 lines
1.2 KiB
Ruby
|
# frozen_string_literal: true
|
||
|
|
|
||
|
|
module RuboCop
|
||
|
|
module Cop
|
||
|
|
module RSpec
|
||
|
|
# This cop checks for `Sidekiq::Testing.server_middleware`
|
||
|
|
# usage in specs.
|
||
|
|
#
|
||
|
|
# @example
|
||
|
|
#
|
||
|
|
# # bad
|
||
|
|
# Sidekiq::Testing.server_middleware do |chain|
|
||
|
|
# chain.add(MyMiddlewareUnderTest)
|
||
|
|
# end
|
||
|
|
#
|
||
|
|
#
|
||
|
|
# # good
|
||
|
|
# with_custom_sidekiq_middleware do |chain|
|
||
|
|
# chain.add(MyMiddlewareUnderTest)
|
||
|
|
# end
|
||
|
|
#
|
||
|
|
#
|
||
|
|
class ModifySidekiqMiddleware < RuboCop::Cop::Cop
|
||
|
|
MSG = <<~MSG
|
||
|
|
Don't modify global sidekiq middleware, use the `#with_sidekiq_server_middleware`
|
||
|
|
helper instead
|
||
|
|
MSG
|
||
|
|
|
||
|
|
def_node_search :modifies_sidekiq_middleware?, <<~PATTERN
|
||
|
|
(send
|
||
|
|
(const
|
||
|
|
(const nil? :Sidekiq) :Testing) :server_middleware)
|
||
|
|
PATTERN
|
||
|
|
|
||
|
|
def on_send(node)
|
||
|
|
return unless modifies_sidekiq_middleware?(node)
|
||
|
|
|
||
|
|
add_offense(node, location: :expression)
|
||
|
|
end
|
||
|
|
|
||
|
|
def autocorrect(node)
|
||
|
|
-> (corrector) do
|
||
|
|
corrector.replace(node.loc.expression,
|
||
|
|
'with_sidekiq_server_middleware')
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|
||
|
|
end
|