2019-12-04 20:38:33 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe Gitlab::SidekiqConfig do
|
2022-07-16 23:28:13 +05:30
|
|
|
before do
|
|
|
|
# Remove cache
|
|
|
|
described_class.instance_variable_set(:@workers, nil)
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
describe '.workers' do
|
|
|
|
it 'includes all workers' do
|
2020-03-13 15:44:24 +05:30
|
|
|
worker_classes = described_class.workers.map(&:klass)
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(worker_classes).to include(PostReceive)
|
|
|
|
expect(worker_classes).to include(MergeWorker)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.worker_queues' do
|
|
|
|
it 'includes all queues' do
|
|
|
|
queues = described_class.worker_queues
|
|
|
|
|
|
|
|
expect(queues).to include('post_receive')
|
|
|
|
expect(queues).to include('merge')
|
2020-06-23 00:09:42 +05:30
|
|
|
expect(queues).to include('cronjob:import_stuck_project_import_jobs')
|
|
|
|
expect(queues).to include('cronjob:jira_import_stuck_jira_import_jobs')
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(queues).to include('mailers')
|
|
|
|
expect(queues).to include('default')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
describe '.workers_for_all_queues_yml' do
|
|
|
|
it 'returns a tuple with FOSS workers first' do
|
|
|
|
expect(described_class.workers_for_all_queues_yml.first)
|
2021-10-27 15:23:28 +05:30
|
|
|
.to include(an_object_having_attributes(generated_queue_name: 'post_receive'))
|
2020-03-13 15:44:24 +05:30
|
|
|
end
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
describe '.all_queues_yml_outdated?' do
|
|
|
|
let(:workers) do
|
|
|
|
[
|
|
|
|
MergeWorker,
|
|
|
|
PostReceive,
|
|
|
|
ProcessCommitWorker
|
|
|
|
].map { |worker| described_class::Worker.new(worker, ee: false) }
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
before do
|
|
|
|
allow(described_class).to receive(:workers).and_return(workers)
|
|
|
|
allow(Gitlab).to receive(:ee?).and_return(false)
|
2022-07-16 23:28:13 +05:30
|
|
|
allow(Gitlab).to receive(:jh?).and_return(false)
|
2020-03-13 15:44:24 +05:30
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2022-07-16 23:28:13 +05:30
|
|
|
it 'returns true if the YAML file does not match the application code' do
|
2020-03-13 15:44:24 +05:30
|
|
|
allow(YAML).to receive(:load_file)
|
|
|
|
.with(described_class::FOSS_QUEUE_CONFIG_PATH)
|
|
|
|
.and_return(workers.first(2).map(&:to_yaml))
|
|
|
|
|
|
|
|
expect(described_class.all_queues_yml_outdated?).to be(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false if the YAML file matches the application code' do
|
|
|
|
allow(YAML).to receive(:load_file)
|
|
|
|
.with(described_class::FOSS_QUEUE_CONFIG_PATH)
|
|
|
|
.and_return(workers.map(&:to_yaml))
|
|
|
|
|
|
|
|
expect(described_class.all_queues_yml_outdated?).to be(false)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.queues_for_sidekiq_queues_yml' do
|
|
|
|
before do
|
|
|
|
workers = [
|
|
|
|
Namespaces::RootStatisticsWorker,
|
|
|
|
Namespaces::ScheduleAggregationWorker,
|
|
|
|
MergeWorker,
|
|
|
|
ProcessCommitWorker
|
|
|
|
].map { |worker| described_class::Worker.new(worker, ee: false) }
|
|
|
|
|
|
|
|
allow(described_class).to receive(:workers).and_return(workers)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns queues and weights, aggregating namespaces with the same weight' do
|
|
|
|
expected_queues = [
|
|
|
|
['merge', 5],
|
|
|
|
['process_commit', 3],
|
|
|
|
['update_namespace_statistics', 1]
|
|
|
|
]
|
|
|
|
|
|
|
|
expect(described_class.queues_for_sidekiq_queues_yml).to eq(expected_queues)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.sidekiq_queues_yml_outdated?' do
|
|
|
|
before do
|
|
|
|
workers = [
|
|
|
|
Namespaces::RootStatisticsWorker,
|
|
|
|
Namespaces::ScheduleAggregationWorker,
|
|
|
|
MergeWorker,
|
|
|
|
ProcessCommitWorker
|
|
|
|
].map { |worker| described_class::Worker.new(worker, ee: false) }
|
|
|
|
|
|
|
|
allow(described_class).to receive(:workers).and_return(workers)
|
2022-07-16 23:28:13 +05:30
|
|
|
allow(Gitlab).to receive(:jh?).and_return(false)
|
2020-03-13 15:44:24 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
let(:expected_queues) do
|
|
|
|
[
|
|
|
|
['merge', 5],
|
|
|
|
['process_commit', 3],
|
|
|
|
['update_namespace_statistics', 1]
|
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns true if the YAML file does not match the application code' do
|
|
|
|
allow(YAML).to receive(:load_file)
|
|
|
|
.with(described_class::SIDEKIQ_QUEUES_PATH)
|
|
|
|
.and_return(queues: expected_queues.reverse)
|
|
|
|
|
|
|
|
expect(described_class.sidekiq_queues_yml_outdated?).to be(true)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it 'returns false if the YAML file matches the application code' do
|
|
|
|
allow(YAML).to receive(:load_file)
|
|
|
|
.with(described_class::SIDEKIQ_QUEUES_PATH)
|
|
|
|
.and_return(queues: expected_queues)
|
2018-03-17 18:26:18 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
expect(described_class.sidekiq_queues_yml_outdated?).to be(false)
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
end
|
2021-09-30 23:02:18 +05:30
|
|
|
|
|
|
|
describe '.worker_queue_mappings' do
|
|
|
|
it 'returns the worker class => queue mappings based on the current routing configuration' do
|
|
|
|
test_routes = [
|
|
|
|
['urgency=high', 'default'],
|
|
|
|
['*', nil]
|
|
|
|
]
|
|
|
|
|
|
|
|
allow(::Gitlab::SidekiqConfig::WorkerRouter)
|
|
|
|
.to receive(:global).and_return(::Gitlab::SidekiqConfig::WorkerRouter.new(test_routes))
|
|
|
|
|
|
|
|
expect(described_class.worker_queue_mappings).to include('MergeWorker' => 'default',
|
|
|
|
'Ci::BuildFinishedWorker' => 'default',
|
|
|
|
'BackgroundMigrationWorker' => 'background_migration',
|
|
|
|
'AdminEmailWorker' => 'cronjob:admin_email')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.current_worker_queue_mappings' do
|
|
|
|
it 'returns worker queue mappings that have queues in the current Sidekiq options' do
|
|
|
|
test_routes = [
|
|
|
|
['urgency=high', 'default'],
|
|
|
|
['*', nil]
|
|
|
|
]
|
|
|
|
|
|
|
|
allow(::Gitlab::SidekiqConfig::WorkerRouter)
|
|
|
|
.to receive(:global).and_return(::Gitlab::SidekiqConfig::WorkerRouter.new(test_routes))
|
|
|
|
|
|
|
|
allow(Sidekiq).to receive(:options).and_return(queues: %w[default background_migration])
|
|
|
|
|
|
|
|
mappings = described_class.current_worker_queue_mappings
|
|
|
|
|
|
|
|
expect(mappings).to include('MergeWorker' => 'default',
|
|
|
|
'Ci::BuildFinishedWorker' => 'default',
|
|
|
|
'BackgroundMigrationWorker' => 'background_migration')
|
|
|
|
|
|
|
|
expect(mappings).not_to include('AdminEmailWorker' => 'cronjob:admin_email')
|
|
|
|
end
|
|
|
|
end
|
2022-07-16 23:28:13 +05:30
|
|
|
|
|
|
|
describe '.routing_queues' do
|
|
|
|
let(:test_routes) do
|
|
|
|
[
|
|
|
|
['tags=needs_own_queue', nil],
|
|
|
|
['urgency=high', 'high_urgency'],
|
|
|
|
['feature_category=gitaly', 'gitaly'],
|
|
|
|
['feature_category=not_exist', 'not_exist'],
|
|
|
|
['*', 'default']
|
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
described_class.instance_variable_set(:@routing_queues, nil)
|
|
|
|
allow(::Gitlab::SidekiqConfig::WorkerRouter)
|
|
|
|
.to receive(:global).and_return(::Gitlab::SidekiqConfig::WorkerRouter.new(test_routes))
|
|
|
|
end
|
|
|
|
|
|
|
|
after do
|
|
|
|
described_class.instance_variable_set(:@routing_queues, nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns worker queue mappings that have queues in the current Sidekiq options' do
|
|
|
|
queues = described_class.routing_queues
|
|
|
|
|
|
|
|
expect(queues).to match_array(%w[
|
2022-08-27 11:52:29 +05:30
|
|
|
default mailers high_urgency gitaly
|
2022-07-16 23:28:13 +05:30
|
|
|
])
|
|
|
|
expect(queues).not_to include('not_exist')
|
|
|
|
end
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|