debian-mirror-gitlab/rubocop/cop/performance/readlines_each.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

32 lines
955 B
Ruby
Raw Normal View History

2020-04-22 19:07:51 +05:30
# frozen_string_literal: true
module RuboCop
module Cop
module Performance
2022-10-11 01:57:18 +05:30
class ReadlinesEach < RuboCop::Cop::Base
extend RuboCop::Cop::AutoCorrector
2020-04-22 19:07:51 +05:30
MESSAGE = 'Avoid `IO.readlines.each`, since it reads contents into memory in full. ' \
'Use `IO.each_line` or `IO.each` instead.'
def_node_matcher :full_file_read_via_class?, <<~PATTERN
(send
(send (const nil? {:IO :File}) :readlines _) :each)
PATTERN
def_node_matcher :full_file_read_via_instance?, <<~PATTERN
(... (... :readlines) :each)
PATTERN
def on_send(node)
2022-10-11 01:57:18 +05:30
return unless full_file_read_via_class?(node) || full_file_read_via_instance?(node)
2020-04-22 19:07:51 +05:30
2022-10-11 01:57:18 +05:30
add_offense(node.loc.selector, message: MESSAGE) do |corrector|
2020-04-22 19:07:51 +05:30
corrector.replace(node.loc.expression, node.source.gsub('readlines.each', 'each_line'))
end
end
end
end
end
end