debian-mirror-gitlab/spec/services/alert_management/alerts/update_service_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

255 lines
8.4 KiB
Ruby
Raw Normal View History

2020-06-23 00:09:42 +05:30
# frozen_string_literal: true
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe AlertManagement::Alerts::UpdateService do
2020-06-23 00:09:42 +05:30
let_it_be(:user_with_permissions) { create(:user) }
2020-07-28 23:09:34 +05:30
let_it_be(:other_user_with_permissions) { create(:user) }
2020-06-23 00:09:42 +05:30
let_it_be(:user_without_permissions) { create(:user) }
2020-07-28 23:09:34 +05:30
let_it_be(:project) { create(:project) }
let_it_be(:alert, reload: true) { create(:alert_management_alert, :triggered, project: project) }
2020-06-23 00:09:42 +05:30
let(:current_user) { user_with_permissions }
let(:params) { {} }
let(:service) { described_class.new(alert, current_user, params) }
before_all do
project.add_developer(user_with_permissions)
2020-07-28 23:09:34 +05:30
project.add_developer(other_user_with_permissions)
2020-06-23 00:09:42 +05:30
end
describe '#execute' do
2020-07-28 23:09:34 +05:30
shared_examples 'does not add a todo' do
specify { expect { response }.not_to change(Todo, :count) }
end
shared_examples 'does not add a system note' do
specify { expect { response }.not_to change(Note, :count) }
end
2022-04-04 11:22:00 +05:30
shared_examples 'adds a system note' do |note_matcher = nil|
specify do
expect { response }.to change { alert.reload.notes.count }.by(1)
expect(alert.notes.last.note).to match(note_matcher) if note_matcher
end
2020-07-28 23:09:34 +05:30
end
shared_examples 'error response' do |message|
it_behaves_like 'does not add a todo'
it_behaves_like 'does not add a system note'
it 'has an informative message' do
expect(response).to be_error
expect(response.message).to eq(message)
end
end
2020-06-23 00:09:42 +05:30
subject(:response) { service.execute }
context 'when the current_user is nil' do
let(:current_user) { nil }
2020-07-28 23:09:34 +05:30
it_behaves_like 'error response', 'You have no permissions'
2020-06-23 00:09:42 +05:30
end
2020-07-28 23:09:34 +05:30
context 'when current_user does not have permission to update alerts' do
2020-06-23 00:09:42 +05:30
let(:current_user) { user_without_permissions }
2020-07-28 23:09:34 +05:30
it_behaves_like 'error response', 'You have no permissions'
2020-06-23 00:09:42 +05:30
end
context 'when no parameters are included' do
2020-07-28 23:09:34 +05:30
it_behaves_like 'error response', 'Please provide attributes to update'
2020-06-23 00:09:42 +05:30
end
2020-07-28 23:09:34 +05:30
context 'when an error occurs during update' do
2020-06-23 00:09:42 +05:30
let(:params) { { title: nil } }
2020-07-28 23:09:34 +05:30
it_behaves_like 'error response', "Title can't be blank"
2020-06-23 00:09:42 +05:30
end
2020-07-28 23:09:34 +05:30
shared_examples 'title update' do
it_behaves_like 'does not add a todo'
it_behaves_like 'does not add a system note'
2020-06-23 00:09:42 +05:30
it 'updates the attribute' do
original_title = alert.title
2020-07-28 23:09:34 +05:30
expect { response }.to change { alert.title }.from(original_title).to(expected_title)
2020-06-23 00:09:42 +05:30
expect(response).to be_success
end
2020-07-28 23:09:34 +05:30
end
2020-06-23 00:09:42 +05:30
2020-07-28 23:09:34 +05:30
context 'when a model attribute is included without assignees' do
let(:params) { { title: 'This is an updated alert.' } }
let(:expected_title) { params[:title] }
it_behaves_like 'title update'
end
2022-07-16 23:28:13 +05:30
context 'when alert is resolved and another existing unresolved alert' do
2020-07-28 23:09:34 +05:30
let!(:alert) { create(:alert_management_alert, :resolved, project: project) }
let!(:existing_alert) { create(:alert_management_alert, :triggered, project: project) }
let(:params) { { title: 'This is an updated alert.' } }
let(:expected_title) { params[:title] }
it_behaves_like 'title update'
2020-06-23 00:09:42 +05:30
end
context 'when assignees are included' do
2020-07-28 23:09:34 +05:30
shared_examples 'adds a todo' do
let(:assignee) { expected_assignees.first }
2020-06-23 00:09:42 +05:30
2020-07-28 23:09:34 +05:30
specify do
expect { response }.to change { assignee.reload.todos.count }.by(1)
expect(assignee.todos.last.author).to eq(current_user)
end
2020-06-23 00:09:42 +05:30
end
2020-07-28 23:09:34 +05:30
shared_examples 'successful assignment' do
it_behaves_like 'adds a system note'
it_behaves_like 'adds a todo'
after do
alert.assignees = []
end
specify do
expect { response }.to change { alert.reload.assignees }.from([]).to(expected_assignees)
expect(response).to be_success
end
end
let(:expected_assignees) { params[:assignees] }
context 'when the assignee is the current user' do
let(:params) { { assignees: [current_user] } }
it_behaves_like 'successful assignment'
2020-06-23 00:09:42 +05:30
end
2020-07-28 23:09:34 +05:30
context 'when the assignee has read permissions' do
let(:params) { { assignees: [other_user_with_permissions] } }
it_behaves_like 'successful assignment'
2020-06-23 00:09:42 +05:30
end
2020-07-28 23:09:34 +05:30
context 'when the assignee does not have read permissions' do
let(:params) { { assignees: [user_without_permissions] } }
it_behaves_like 'error response', 'Assignee has no permissions'
2020-06-23 00:09:42 +05:30
end
2020-07-28 23:09:34 +05:30
context 'when user is already assigned' do
let(:params) { { assignees: [user_with_permissions] } }
2020-06-23 00:09:42 +05:30
2020-07-28 23:09:34 +05:30
before do
alert.assignees << user_with_permissions
2020-06-23 00:09:42 +05:30
end
2020-07-28 23:09:34 +05:30
it_behaves_like 'does not add a system note'
2020-10-24 23:57:45 +05:30
it_behaves_like 'does not add a todo'
2020-07-28 23:09:34 +05:30
end
2020-06-23 00:09:42 +05:30
2020-07-28 23:09:34 +05:30
context 'with multiple users included' do
let(:params) { { assignees: [user_with_permissions, user_without_permissions] } }
let(:expected_assignees) { [user_with_permissions] }
2020-06-23 00:09:42 +05:30
2020-07-28 23:09:34 +05:30
it_behaves_like 'successful assignment'
end
end
context 'when a status is included' do
let(:params) { { status: new_status } }
2021-01-03 14:25:43 +05:30
let(:new_status) { :acknowledged }
2020-07-28 23:09:34 +05:30
it 'successfully changes the status' do
expect { response }.to change { alert.acknowledged? }.to(true)
expect(response).to be_success
expect(response.payload[:alert]).to eq(alert)
end
it_behaves_like 'adds a system note'
context 'with unknown status' do
2021-01-03 14:25:43 +05:30
let(:new_status) { :unknown_status }
2020-07-28 23:09:34 +05:30
it_behaves_like 'error response', 'Invalid status'
end
context 'with resolving status' do
2021-01-03 14:25:43 +05:30
let(:new_status) { :resolved }
2020-07-28 23:09:34 +05:30
it 'changes the status' do
expect { response }.to change { alert.resolved? }.to(true)
end
it "resolves the current user's related todos" do
todo = create(:todo, :pending, target: alert, user: current_user, project: alert.project)
expect { response }.to change { todo.reload.state }.from('pending').to('done')
end
end
2022-07-16 23:28:13 +05:30
context 'with existing unresolved alert' do
context 'with fingerprints' do
let_it_be(:existing_alert) { create(:alert_management_alert, :triggered, fingerprint: alert.fingerprint, project: project) }
2020-07-28 23:09:34 +05:30
2022-07-16 23:28:13 +05:30
it 'does not query for existing alerts' do
expect(::AlertManagement::Alert).not_to receive(:find_unresolved_alert)
2020-06-23 00:09:42 +05:30
2022-07-16 23:28:13 +05:30
response
end
context 'when status was resolved' do
let_it_be(:alert) { create(:alert_management_alert, :resolved, :with_fingerprint, project: project) }
let_it_be(:existing_alert) { create(:alert_management_alert, :triggered, fingerprint: alert.fingerprint, project: project) }
let(:url) { Gitlab::Routing.url_helpers.details_project_alert_management_path(project, existing_alert) }
let(:link) { ActionController::Base.helpers.link_to(_('alert'), url) }
let(:message) do
"An #{link} with the same fingerprint is already open. " \
'To change the status of this alert, resolve the linked alert.'
end
it_behaves_like 'does not add a todo'
it_behaves_like 'does not add a system note'
2020-07-28 23:09:34 +05:30
2022-07-16 23:28:13 +05:30
it 'has an informative message' do
expect(response).to be_error
expect(response.message).to eq(message)
end
end
2020-07-28 23:09:34 +05:30
end
2020-06-23 00:09:42 +05:30
2022-07-16 23:28:13 +05:30
context 'without fingerprints' do
2020-07-28 23:09:34 +05:30
let_it_be(:existing_alert) { create(:alert_management_alert, :triggered, fingerprint: alert.fingerprint, project: project) }
2020-06-23 00:09:42 +05:30
2020-07-28 23:09:34 +05:30
it 'successfully changes the status' do
expect { response }.to change { alert.acknowledged? }.to(true)
expect(response).to be_success
expect(response.payload[:alert]).to eq(alert)
2020-06-23 00:09:42 +05:30
end
2020-07-28 23:09:34 +05:30
it_behaves_like 'adds a system note'
2020-06-23 00:09:42 +05:30
end
end
2020-07-28 23:09:34 +05:30
context 'two existing closed alerts' do
let_it_be(:alert) { create(:alert_management_alert, :resolved, :with_fingerprint, project: project) }
let_it_be(:existing_alert) { create(:alert_management_alert, :resolved, fingerprint: alert.fingerprint, project: project) }
2020-06-23 00:09:42 +05:30
2020-07-28 23:09:34 +05:30
it 'successfully changes the status' do
expect { response }.to change { alert.acknowledged? }.to(true)
2020-06-23 00:09:42 +05:30
expect(response).to be_success
2020-07-28 23:09:34 +05:30
expect(response.payload[:alert]).to eq(alert)
2020-06-23 00:09:42 +05:30
end
2020-07-28 23:09:34 +05:30
it_behaves_like 'adds a system note'
2020-06-23 00:09:42 +05:30
end
end
end
end