debian-mirror-gitlab/lib/gitlab/checks/changes_access.rb

138 lines
4.3 KiB
Ruby
Raw Normal View History

2021-09-04 01:27:46 +05:30
# frozen_string_literal: true
module Gitlab
module Checks
class ChangesAccess
ATTRIBUTES = %i[user_access project protocol changes logger].freeze
attr_reader(*ATTRIBUTES)
def initialize(
changes, user_access:, project:, protocol:, logger:
)
@changes = changes
@user_access = user_access
@project = project
@protocol = protocol
@logger = logger
end
def validate!
return if changes.empty?
single_access_checks!
logger.log_timed("Running checks for #{changes.length} changes") do
bulk_access_checks!
end
true
end
2021-10-27 15:23:28 +05:30
# All commits which have been newly introduced via any of the given
# changes. This set may also contain commits which are not referenced by
# any of the new revisions.
def commits
2022-03-02 08:16:31 +05:30
allow_quarantine = true
2021-10-27 15:23:28 +05:30
newrevs = @changes.map do |change|
2022-03-02 08:16:31 +05:30
oldrev = change[:oldrev]
2021-10-27 15:23:28 +05:30
newrev = change[:newrev]
2022-03-02 08:16:31 +05:30
next if blank_rev?(newrev)
# In case any of the old revisions is blank, then we cannot reliably
# detect which commits are new for a given change when enumerating
# objects via the object quarantine directory given that the client
# may have pushed too many commits, and we don't know when to
# terminate the walk. We thus fall back to using `git rev-list --not
# --all`, which is a lot less efficient but at least can only ever
# returns commits which really are new.
allow_quarantine = false if allow_quarantine && blank_rev?(oldrev)
newrev
2021-10-27 15:23:28 +05:30
end.compact
return [] if newrevs.empty?
2022-03-02 08:16:31 +05:30
@commits ||= project.repository.new_commits(newrevs, allow_quarantine: allow_quarantine)
2021-10-27 15:23:28 +05:30
end
# All commits which have been newly introduced via the given revision.
2022-03-02 08:16:31 +05:30
def commits_for(oldrev, newrev)
2021-10-27 15:23:28 +05:30
commits_by_id = commits.index_by(&:id)
result = []
pending = Set[newrev]
# We go up the parent chain of our newrev and collect all commits which
# are new. In case a commit's ID cannot be found in the set of new
# commits, then it must already be a preexisting commit.
while pending.any?
rev = pending.first
pending.delete(rev)
# Remove the revision from commit candidates such that we don't walk
# it multiple times. If the hash doesn't contain the revision, then
# we have either already walked the commit or it's not new.
commit = commits_by_id.delete(rev)
next if commit.nil?
# Only add the parent ID to the pending set if we actually know its
# commit to guards us against readding an ID which we have already
2022-03-02 08:16:31 +05:30
# queued up before. Furthermore, we stop walking as soon as we hit
# `oldrev` such that we do not include any commits in our checks
# which have been "over-pushed" by the client.
2021-10-27 15:23:28 +05:30
commit.parent_ids.each do |parent_id|
2022-03-02 08:16:31 +05:30
pending.add(parent_id) if commits_by_id.has_key?(parent_id) && parent_id != oldrev
2021-10-27 15:23:28 +05:30
end
result << commit
end
result
end
2021-11-11 11:23:49 +05:30
def single_change_accesses
@single_changes_accesses ||=
changes.map do |change|
commits =
2022-03-02 08:16:31 +05:30
if blank_rev?(change[:newrev])
2021-11-11 11:23:49 +05:30
[]
else
2022-03-02 08:16:31 +05:30
Gitlab::Lazy.new { commits_for(change[:oldrev], change[:newrev]) }
2021-11-11 11:23:49 +05:30
end
Checks::SingleChangeAccess.new(
change,
user_access: user_access,
project: project,
protocol: protocol,
logger: logger,
commits: commits
)
end
end
2021-09-04 01:27:46 +05:30
protected
def single_access_checks!
# Iterate over all changes to find if user allowed all of them to be applied
2021-11-11 11:23:49 +05:30
single_change_accesses.each do |single_change_access|
single_change_access.validate!
2021-09-04 01:27:46 +05:30
end
end
def bulk_access_checks!
Gitlab::Checks::LfsCheck.new(self).validate!
end
2022-03-02 08:16:31 +05:30
def blank_rev?(rev)
rev.blank? || Gitlab::Git.blank_ref?(rev)
end
2021-09-04 01:27:46 +05:30
end
end
end
2021-11-11 11:23:49 +05:30
Gitlab::Checks::ChangesAccess.prepend_mod_with('Gitlab::Checks::ChangesAccess')