2014-09-02 18:07:02 +05:30
require 'spec_helper'
require 'mime/types'
2017-08-17 22:00:37 +05:30
describe API :: Commits do
2014-09-02 18:07:02 +05:30
let ( :user ) { create ( :user ) }
2017-09-10 17:25:29 +05:30
let ( :guest ) { create ( :user ) . tap { | u | project . add_guest ( u ) } }
let ( :project ) { create ( :project , :repository , creator : user , path : 'my.project' ) }
let ( :branch_with_dot ) { project . repository . find_branch ( 'ends-with.json' ) }
let ( :branch_with_slash ) { project . repository . find_branch ( 'improve/awesome' ) }
2014-09-02 18:07:02 +05:30
2017-09-10 17:25:29 +05:30
let ( :project_id ) { project . id }
let ( :current_user ) { nil }
2014-09-02 18:07:02 +05:30
2017-09-10 17:25:29 +05:30
before do
2018-11-18 11:00:15 +05:30
project . add_maintainer ( user )
2017-09-10 17:25:29 +05:30
end
2014-09-02 18:07:02 +05:30
2017-09-10 17:25:29 +05:30
describe 'GET /projects/:id/repository/commits' do
2018-03-17 18:26:18 +05:30
let ( :route ) { " /projects/ #{ project_id } /repository/commits " }
2018-11-08 19:23:39 +05:30
shared_examples_for 'project commits' do | schema : 'public_api/v4/commits' |
2016-09-13 17:45:13 +05:30
it " returns project commits " do
2017-08-17 22:00:37 +05:30
commit = project . repository . commit
2018-03-17 18:26:18 +05:30
get api ( route , current_user )
2014-09-02 18:07:02 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 200 )
2018-11-08 19:23:39 +05:30
expect ( response ) . to match_response_schema ( schema )
2017-08-17 22:00:37 +05:30
expect ( json_response . first [ 'id' ] ) . to eq ( commit . id )
expect ( json_response . first [ 'committer_name' ] ) . to eq ( commit . committer_name )
expect ( json_response . first [ 'committer_email' ] ) . to eq ( commit . committer_email )
end
it 'include correct pagination headers' do
commit_count = project . repository . count_commits ( ref : 'master' ) . to_s
2018-03-17 18:26:18 +05:30
get api ( route , current_user )
2017-08-17 22:00:37 +05:30
expect ( response ) . to include_pagination_headers
expect ( response . headers [ 'X-Total' ] ) . to eq ( commit_count )
expect ( response . headers [ 'X-Page' ] ) . to eql ( '1' )
2014-09-02 18:07:02 +05:30
end
end
2018-03-17 18:26:18 +05:30
context 'when unauthenticated' , 'and project is public' do
let ( :project ) { create ( :project , :public , :repository ) }
2017-09-10 17:25:29 +05:30
2018-03-17 18:26:18 +05:30
it_behaves_like 'project commits'
end
context 'when unauthenticated' , 'and project is private' do
it_behaves_like '404 response' do
let ( :request ) { get api ( route ) }
let ( :message ) { '404 Project Not Found' }
2014-09-02 18:07:02 +05:30
end
end
2016-06-02 11:05:42 +05:30
2018-11-18 11:00:15 +05:30
context 'when authenticated' , 'as a maintainer' do
2018-03-17 18:26:18 +05:30
let ( :current_user ) { user }
2016-06-02 11:05:42 +05:30
2018-03-17 18:26:18 +05:30
it_behaves_like 'project commits'
2016-06-02 11:05:42 +05:30
2018-03-17 18:26:18 +05:30
context " since optional parameter " do
it " returns project commits since provided parameter " do
commits = project . repository . commits ( " master " , limit : 2 )
after = commits . second . created_at
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
get api ( " /projects/ #{ project_id } /repository/commits?since= #{ after . utc . iso8601 } " , user )
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect ( json_response . size ) . to eq 2
expect ( json_response . first [ " id " ] ) . to eq ( commits . first . id )
expect ( json_response . second [ " id " ] ) . to eq ( commits . second . id )
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
it 'include correct pagination headers' do
commits = project . repository . commits ( " master " , limit : 2 )
after = commits . second . created_at
commit_count = project . repository . count_commits ( ref : 'master' , after : after ) . to_s
get api ( " /projects/ #{ project_id } /repository/commits?since= #{ after . utc . iso8601 } " , user )
expect ( response ) . to include_pagination_headers
expect ( response . headers [ 'X-Total' ] ) . to eq ( commit_count )
expect ( response . headers [ 'X-Page' ] ) . to eql ( '1' )
end
2017-08-17 22:00:37 +05:30
end
2016-06-02 11:05:42 +05:30
2018-03-17 18:26:18 +05:30
context " until optional parameter " do
it " returns project commits until provided parameter " do
commits = project . repository . commits ( " master " , limit : 20 )
before = commits . second . created_at
2016-06-02 11:05:42 +05:30
2018-03-17 18:26:18 +05:30
get api ( " /projects/ #{ project_id } /repository/commits?until= #{ before . utc . iso8601 } " , user )
2016-06-02 11:05:42 +05:30
2018-03-17 18:26:18 +05:30
if commits . size == 20
expect ( json_response . size ) . to eq ( 20 )
else
expect ( json_response . size ) . to eq ( commits . size - 1 )
end
2016-11-03 12:29:30 +05:30
2018-03-17 18:26:18 +05:30
expect ( json_response . first [ " id " ] ) . to eq ( commits . second . id )
expect ( json_response . second [ " id " ] ) . to eq ( commits . third . id )
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
it 'include correct pagination headers' do
commits = project . repository . commits ( " master " , limit : 2 )
before = commits . second . created_at
commit_count = project . repository . count_commits ( ref : 'master' , before : before ) . to_s
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
get api ( " /projects/ #{ project_id } /repository/commits?until= #{ before . utc . iso8601 } " , user )
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to include_pagination_headers
expect ( response . headers [ 'X-Total' ] ) . to eq ( commit_count )
expect ( response . headers [ 'X-Page' ] ) . to eql ( '1' )
end
2017-08-17 22:00:37 +05:30
end
2016-06-02 11:05:42 +05:30
2018-03-17 18:26:18 +05:30
context " invalid xmlschema date parameters " do
it " returns an invalid parameter error message " do
get api ( " /projects/ #{ project_id } /repository/commits?since=invalid-date " , user )
2016-06-02 11:05:42 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 400 )
expect ( json_response [ 'error' ] ) . to eq ( 'since is invalid' )
end
2017-08-17 22:00:37 +05:30
end
2018-03-17 18:26:18 +05:30
context " path optional parameter " do
it " returns project commits matching provided path parameter " do
path = 'files/ruby/popen.rb'
commit_count = project . repository . count_commits ( ref : 'master' , path : path ) . to_s
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
get api ( " /projects/ #{ project_id } /repository/commits?path= #{ path } " , user )
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect ( json_response . size ) . to eq ( 3 )
expect ( json_response . first [ " id " ] ) . to eq ( " 570e7b2abdd848b95f2f578043fc23bd6f6fd24d " )
expect ( response ) . to include_pagination_headers
expect ( response . headers [ 'X-Total' ] ) . to eq ( commit_count )
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
it 'include correct pagination headers' do
path = 'files/ruby/popen.rb'
commit_count = project . repository . count_commits ( ref : 'master' , path : path ) . to_s
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
get api ( " /projects/ #{ project_id } /repository/commits?path= #{ path } " , user )
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to include_pagination_headers
expect ( response . headers [ 'X-Total' ] ) . to eq ( commit_count )
expect ( response . headers [ 'X-Page' ] ) . to eql ( '1' )
end
2017-08-17 22:00:37 +05:30
end
2018-03-27 19:54:05 +05:30
context 'all optional parameter' do
it 'returns all project commits' do
commit_count = project . repository . count_commits ( all : true )
get api ( " /projects/ #{ project_id } /repository/commits?all=true " , user )
expect ( response ) . to include_pagination_headers
expect ( response . headers [ 'X-Total' ] ) . to eq ( commit_count . to_s )
expect ( response . headers [ 'X-Page' ] ) . to eql ( '1' )
end
end
2018-11-08 19:23:39 +05:30
context 'with_stats optional parameter' do
let ( :project ) { create ( :project , :public , :repository ) }
it_behaves_like 'project commits' , schema : 'public_api/v4/commits_with_stats' do
let ( :route ) { " /projects/ #{ project_id } /repository/commits?with_stats=true " }
it 'include commits details' do
commit = project . repository . commit
get api ( route , current_user )
expect ( json_response . first [ 'stats' ] [ 'additions' ] ) . to eq ( commit . stats . additions )
expect ( json_response . first [ 'stats' ] [ 'deletions' ] ) . to eq ( commit . stats . deletions )
expect ( json_response . first [ 'stats' ] [ 'total' ] ) . to eq ( commit . stats . total )
end
end
end
2018-03-17 18:26:18 +05:30
context 'with pagination params' do
let ( :page ) { 1 }
let ( :per_page ) { 5 }
let ( :ref_name ) { 'master' }
let! ( :request ) do
get api ( " /projects/ #{ project_id } /repository/commits?page= #{ page } &per_page= #{ per_page } &ref_name= #{ ref_name } " , user )
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
it 'returns correct headers' do
commit_count = project . repository . count_commits ( ref : ref_name ) . to_s
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to include_pagination_headers
expect ( response . headers [ 'X-Total' ] ) . to eq ( commit_count )
expect ( response . headers [ 'X-Page' ] ) . to eq ( '1' )
expect ( response . headers [ 'Link' ] ) . to match ( / page=1&per_page=5 / )
expect ( response . headers [ 'Link' ] ) . to match ( / page=2&per_page=5 / )
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
context 'viewing the first page' do
it 'returns the first 5 commits' do
commit = project . repository . commit
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect ( json_response . size ) . to eq ( per_page )
expect ( json_response . first [ 'id' ] ) . to eq ( commit . id )
expect ( response . headers [ 'X-Page' ] ) . to eq ( '1' )
end
2017-08-17 22:00:37 +05:30
end
2018-03-17 18:26:18 +05:30
context 'viewing the third page' do
let ( :page ) { 3 }
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
it 'returns the third 5 commits' do
commit = project . repository . commits ( 'HEAD' , limit : per_page , offset : ( page - 1 ) * per_page ) . first
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect ( json_response . size ) . to eq ( per_page )
expect ( json_response . first [ 'id' ] ) . to eq ( commit . id )
expect ( response . headers [ 'X-Page' ] ) . to eq ( '3' )
end
2017-08-17 22:00:37 +05:30
end
2016-06-02 11:05:42 +05:30
end
end
2014-09-02 18:07:02 +05:30
end
2017-08-17 22:00:37 +05:30
describe " POST /projects/:id/repository/commits " do
2017-09-10 17:25:29 +05:30
let! ( :url ) { " /projects/ #{ project_id } /repository/commits " }
2016-11-03 12:29:30 +05:30
it 'returns a 403 unauthorized for user without permissions' do
2017-09-10 17:25:29 +05:30
post api ( url , guest )
2016-11-03 12:29:30 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 403 )
2016-11-03 12:29:30 +05:30
end
it 'returns a 400 bad request if no params are given' do
post api ( url , user )
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 400 )
2016-11-03 12:29:30 +05:30
end
2017-08-17 22:00:37 +05:30
describe 'create' do
2019-05-30 16:15:17 +05:30
let ( :message ) { 'Created file' }
2018-12-05 23:21:45 +05:30
let ( :invalid_c_params ) do
2016-11-03 12:29:30 +05:30
{
2017-08-17 22:00:37 +05:30
branch : 'master' ,
2016-11-03 12:29:30 +05:30
commit_message : message ,
actions : [
{
action : 'create' ,
file_path : 'files/ruby/popen.rb' ,
content : 'puts 8'
}
]
}
end
2018-12-05 23:21:45 +05:30
let ( :valid_c_params ) do
2016-11-03 12:29:30 +05:30
{
2017-08-17 22:00:37 +05:30
branch : 'master' ,
2016-11-03 12:29:30 +05:30
commit_message : message ,
actions : [
{
action : 'create' ,
file_path : 'foo/bar/baz.txt' ,
content : 'puts 8'
}
]
}
end
2018-12-05 23:21:45 +05:30
let ( :valid_utf8_c_params ) do
2018-11-08 19:23:39 +05:30
{
branch : 'master' ,
commit_message : message ,
actions : [
{
action : 'create' ,
file_path : 'foo/bar/baz.txt' ,
content : 'puts 🦊'
}
]
}
end
2016-11-03 12:29:30 +05:30
2018-12-05 23:21:45 +05:30
it 'does not increment the usage counters using access token authentication' do
expect ( :: Gitlab :: WebIdeCommitsCounter ) . not_to receive ( :increment )
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : valid_c_params
2018-12-05 23:21:45 +05:30
end
2016-11-03 12:29:30 +05:30
it 'a new file in project repo' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : valid_c_params
2016-11-03 12:29:30 +05:30
2017-09-10 17:25:29 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
2016-11-03 12:29:30 +05:30
expect ( json_response [ 'title' ] ) . to eq ( message )
2017-08-17 22:00:37 +05:30
expect ( json_response [ 'committer_name' ] ) . to eq ( user . name )
expect ( json_response [ 'committer_email' ] ) . to eq ( user . email )
2016-11-03 12:29:30 +05:30
end
2018-11-08 19:23:39 +05:30
it 'a new file with utf8 chars in project repo' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : valid_utf8_c_params
2018-11-08 19:23:39 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
expect ( json_response [ 'title' ] ) . to eq ( message )
expect ( json_response [ 'committer_name' ] ) . to eq ( user . name )
expect ( json_response [ 'committer_email' ] ) . to eq ( user . email )
end
2016-11-03 12:29:30 +05:30
it 'returns a 400 bad request if file exists' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : invalid_c_params
2016-11-03 12:29:30 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 400 )
2016-11-03 12:29:30 +05:30
end
2017-08-17 22:00:37 +05:30
context 'with project path containing a dot in URL' do
let ( :url ) { " /projects/ #{ CGI . escape ( project . full_path ) } /repository/commits " }
it 'a new file in project repo' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : valid_c_params
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
2017-08-17 22:00:37 +05:30
end
end
2016-11-03 12:29:30 +05:30
end
2017-08-17 22:00:37 +05:30
describe 'delete' do
2016-11-03 12:29:30 +05:30
let ( :message ) { 'Deleted file' }
2018-12-05 23:21:45 +05:30
let ( :invalid_d_params ) do
2016-11-03 12:29:30 +05:30
{
2017-08-17 22:00:37 +05:30
branch : 'markdown' ,
2016-11-03 12:29:30 +05:30
commit_message : message ,
actions : [
{
action : 'delete' ,
file_path : 'doc/api/projects.md'
}
]
}
end
2018-12-05 23:21:45 +05:30
let ( :valid_d_params ) do
2016-11-03 12:29:30 +05:30
{
2017-08-17 22:00:37 +05:30
branch : 'markdown' ,
2016-11-03 12:29:30 +05:30
commit_message : message ,
actions : [
{
action : 'delete' ,
file_path : 'doc/api/users.md'
}
]
}
end
it 'an existing file in project repo' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : valid_d_params
2016-11-03 12:29:30 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
2016-11-03 12:29:30 +05:30
expect ( json_response [ 'title' ] ) . to eq ( message )
end
it 'returns a 400 bad request if file does not exist' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : invalid_d_params
2016-11-03 12:29:30 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 400 )
2016-11-03 12:29:30 +05:30
end
end
2017-08-17 22:00:37 +05:30
describe 'move' do
2016-11-03 12:29:30 +05:30
let ( :message ) { 'Moved file' }
2018-12-05 23:21:45 +05:30
let ( :invalid_m_params ) do
2016-11-03 12:29:30 +05:30
{
2017-08-17 22:00:37 +05:30
branch : 'feature' ,
2016-11-03 12:29:30 +05:30
commit_message : message ,
actions : [
{
action : 'move' ,
file_path : 'CHANGELOG' ,
previous_path : 'VERSION' ,
content : '6.7.0.pre'
}
]
}
end
2018-12-05 23:21:45 +05:30
let ( :valid_m_params ) do
2016-11-03 12:29:30 +05:30
{
2017-08-17 22:00:37 +05:30
branch : 'feature' ,
2016-11-03 12:29:30 +05:30
commit_message : message ,
actions : [
{
action : 'move' ,
file_path : 'VERSION.txt' ,
previous_path : 'VERSION' ,
content : '6.7.0.pre'
}
]
}
end
it 'an existing file in project repo' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : valid_m_params
2016-11-03 12:29:30 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
2016-11-03 12:29:30 +05:30
expect ( json_response [ 'title' ] ) . to eq ( message )
end
it 'returns a 400 bad request if file does not exist' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : invalid_m_params
2016-11-03 12:29:30 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 400 )
2016-11-03 12:29:30 +05:30
end
end
2017-08-17 22:00:37 +05:30
describe 'update' do
2016-11-03 12:29:30 +05:30
let ( :message ) { 'Updated file' }
2018-12-05 23:21:45 +05:30
let ( :invalid_u_params ) do
2016-11-03 12:29:30 +05:30
{
2017-08-17 22:00:37 +05:30
branch : 'master' ,
2016-11-03 12:29:30 +05:30
commit_message : message ,
actions : [
{
action : 'update' ,
file_path : 'foo/bar.baz' ,
content : 'puts 8'
}
]
}
end
2018-12-05 23:21:45 +05:30
let ( :valid_u_params ) do
2016-11-03 12:29:30 +05:30
{
2017-08-17 22:00:37 +05:30
branch : 'master' ,
2016-11-03 12:29:30 +05:30
commit_message : message ,
actions : [
{
action : 'update' ,
file_path : 'files/ruby/popen.rb' ,
content : 'puts 8'
}
]
}
end
it 'an existing file in project repo' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : valid_u_params
2016-11-03 12:29:30 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
2016-11-03 12:29:30 +05:30
expect ( json_response [ 'title' ] ) . to eq ( message )
end
it 'returns a 400 bad request if file does not exist' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : invalid_u_params
2016-11-03 12:29:30 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 400 )
2016-11-03 12:29:30 +05:30
end
end
2018-12-05 23:21:45 +05:30
describe 'chmod' do
let ( :message ) { 'Chmod +x file' }
let ( :file_path ) { 'files/ruby/popen.rb' }
let ( :execute_filemode ) { true }
let ( :params ) do
{
branch : 'master' ,
commit_message : message ,
actions : [
{
action : 'chmod' ,
file_path : file_path ,
execute_filemode : execute_filemode
}
]
}
end
it 'responds with success' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : params
2018-12-05 23:21:45 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
expect ( json_response [ 'title' ] ) . to eq ( message )
end
context 'when execute_filemode is false' do
let ( :execute_filemode ) { false }
it 'responds with success' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : params
2018-12-05 23:21:45 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
expect ( json_response [ 'title' ] ) . to eq ( message )
end
end
context " when the file doesn't exists " do
let ( :file_path ) { 'foo/bar.baz' }
it " responds with 400 " do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : params
2018-12-05 23:21:45 +05:30
expect ( response ) . to have_gitlab_http_status ( 400 )
expect ( json_response [ 'message' ] ) . to eq ( " A file with this name doesn't exist " )
end
end
end
2017-08-17 22:00:37 +05:30
describe 'multiple operations' do
2016-11-03 12:29:30 +05:30
let ( :message ) { 'Multiple actions' }
2018-12-05 23:21:45 +05:30
let ( :invalid_mo_params ) do
2016-11-03 12:29:30 +05:30
{
2017-08-17 22:00:37 +05:30
branch : 'master' ,
2016-11-03 12:29:30 +05:30
commit_message : message ,
actions : [
{
action : 'create' ,
file_path : 'files/ruby/popen.rb' ,
content : 'puts 8'
} ,
{
action : 'delete' ,
file_path : 'doc/api/projects.md'
} ,
{
action : 'move' ,
file_path : 'CHANGELOG' ,
previous_path : 'VERSION' ,
content : '6.7.0.pre'
} ,
{
action : 'update' ,
file_path : 'foo/bar.baz' ,
content : 'puts 8'
2018-12-05 23:21:45 +05:30
} ,
{
action : 'chmod' ,
file_path : 'files/ruby/popen.rb' ,
execute_filemode : true
2016-11-03 12:29:30 +05:30
}
]
}
end
2018-12-05 23:21:45 +05:30
let ( :valid_mo_params ) do
2016-11-03 12:29:30 +05:30
{
2017-08-17 22:00:37 +05:30
branch : 'master' ,
2016-11-03 12:29:30 +05:30
commit_message : message ,
actions : [
{
action : 'create' ,
file_path : 'foo/bar/baz.txt' ,
content : 'puts 8'
} ,
{
action : 'delete' ,
file_path : 'Gemfile.zip'
} ,
{
action : 'move' ,
file_path : 'VERSION.txt' ,
previous_path : 'VERSION' ,
content : '6.7.0.pre'
} ,
{
action : 'update' ,
file_path : 'files/ruby/popen.rb' ,
content : 'puts 8'
2018-12-05 23:21:45 +05:30
} ,
{
action : 'chmod' ,
file_path : 'files/ruby/popen.rb' ,
execute_filemode : true
2016-11-03 12:29:30 +05:30
}
]
}
end
2018-12-13 13:39:08 +05:30
it 'are committed as one in project repo' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : valid_mo_params
2016-11-03 12:29:30 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
2016-11-03 12:29:30 +05:30
expect ( json_response [ 'title' ] ) . to eq ( message )
end
2018-12-05 23:21:45 +05:30
it 'includes the commit stats' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : valid_mo_params
2018-12-05 23:21:45 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
expect ( json_response ) . to include 'stats'
end
it " doesn't include the commit stats when stats is false " do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : valid_mo_params . merge ( stats : false )
2018-12-05 23:21:45 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
expect ( json_response ) . not_to include 'stats'
end
2016-11-03 12:29:30 +05:30
it 'return a 400 bad request if there are any issues' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : invalid_mo_params
2016-11-03 12:29:30 +05:30
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 400 )
2016-11-03 12:29:30 +05:30
end
end
2018-11-18 11:00:15 +05:30
context 'when committing into a fork as a maintainer' do
include_context 'merge request allowing collaboration'
let ( :project_id ) { forked_project . id }
def push_params ( branch_name )
{
branch : branch_name ,
commit_message : 'Hello world' ,
actions : [
{
action : 'create' ,
file_path : 'foo/bar/baz.txt' ,
content : 'puts 8'
}
]
}
end
it 'allows pushing to the source branch of the merge request' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : push_params ( 'feature' )
2018-11-18 11:00:15 +05:30
expect ( response ) . to have_gitlab_http_status ( :created )
end
it 'denies pushing to another branch' do
2019-02-15 15:39:39 +05:30
post api ( url , user ) , params : push_params ( 'other-branch' )
2018-11-18 11:00:15 +05:30
expect ( response ) . to have_gitlab_http_status ( :forbidden )
end
end
2016-11-03 12:29:30 +05:30
end
2018-03-27 19:54:05 +05:30
describe 'GET /projects/:id/repository/commits/:sha/refs' do
let ( :project ) { create ( :project , :public , :repository ) }
let ( :tag ) { project . repository . find_tag ( 'v1.1.0' ) }
let ( :commit_id ) { tag . dereferenced_target . id }
let ( :route ) { " /projects/ #{ project_id } /repository/commits/ #{ commit_id } /refs " }
context 'when ref does not exist' do
let ( :commit_id ) { 'unknown' }
it_behaves_like '404 response' do
let ( :request ) { get api ( route , current_user ) }
let ( :message ) { '404 Commit Not Found' }
end
end
context 'when repository is disabled' do
include_context 'disabled repository'
it_behaves_like '403 response' do
let ( :request ) { get api ( route , current_user ) }
end
end
context 'for a valid commit' do
it 'returns all refs with no scope' do
2019-02-15 15:39:39 +05:30
get api ( route , current_user ) , params : { per_page : 100 }
2018-03-27 19:54:05 +05:30
refs = project . repository . branch_names_contains ( commit_id ) . map { | name | [ 'branch' , name ] }
refs . concat ( project . repository . tag_names_contains ( commit_id ) . map { | name | [ 'tag' , name ] } )
expect ( response ) . to have_gitlab_http_status ( 200 )
expect ( response ) . to include_pagination_headers
expect ( json_response ) . to be_an Array
expect ( json_response . map { | r | [ r [ 'type' ] , r [ 'name' ] ] } . compact ) . to eq ( refs )
end
it 'returns all refs' do
2019-02-15 15:39:39 +05:30
get api ( route , current_user ) , params : { type : 'all' , per_page : 100 }
2018-03-27 19:54:05 +05:30
refs = project . repository . branch_names_contains ( commit_id ) . map { | name | [ 'branch' , name ] }
refs . concat ( project . repository . tag_names_contains ( commit_id ) . map { | name | [ 'tag' , name ] } )
expect ( response ) . to have_gitlab_http_status ( 200 )
expect ( json_response . map { | r | [ r [ 'type' ] , r [ 'name' ] ] } . compact ) . to eq ( refs )
end
it 'returns the branch refs' do
2019-02-15 15:39:39 +05:30
get api ( route , current_user ) , params : { type : 'branch' , per_page : 100 }
2018-03-27 19:54:05 +05:30
refs = project . repository . branch_names_contains ( commit_id ) . map { | name | [ 'branch' , name ] }
expect ( response ) . to have_gitlab_http_status ( 200 )
expect ( json_response . map { | r | [ r [ 'type' ] , r [ 'name' ] ] } . compact ) . to eq ( refs )
end
it 'returns the tag refs' do
2019-02-15 15:39:39 +05:30
get api ( route , current_user ) , params : { type : 'tag' , per_page : 100 }
2018-03-27 19:54:05 +05:30
refs = project . repository . tag_names_contains ( commit_id ) . map { | name | [ 'tag' , name ] }
expect ( response ) . to have_gitlab_http_status ( 200 )
expect ( json_response . map { | r | [ r [ 'type' ] , r [ 'name' ] ] } . compact ) . to eq ( refs )
end
end
end
2017-09-10 17:25:29 +05:30
describe 'GET /projects/:id/repository/commits/:sha' do
let ( :commit ) { project . repository . commit }
let ( :commit_id ) { commit . id }
let ( :route ) { " /projects/ #{ project_id } /repository/commits/ #{ commit_id } " }
2016-09-13 17:45:13 +05:30
2017-09-10 17:25:29 +05:30
shared_examples_for 'ref commit' do
it 'returns the ref last commit' do
get api ( route , current_user )
expect ( response ) . to have_gitlab_http_status ( 200 )
expect ( response ) . to match_response_schema ( 'public_api/v4/commit/detail' )
2017-08-17 22:00:37 +05:30
expect ( json_response [ 'id' ] ) . to eq ( commit . id )
expect ( json_response [ 'short_id' ] ) . to eq ( commit . short_id )
expect ( json_response [ 'title' ] ) . to eq ( commit . title )
expect ( json_response [ 'message' ] ) . to eq ( commit . safe_message )
expect ( json_response [ 'author_name' ] ) . to eq ( commit . author_name )
expect ( json_response [ 'author_email' ] ) . to eq ( commit . author_email )
expect ( json_response [ 'authored_date' ] ) . to eq ( commit . authored_date . iso8601 ( 3 ) )
expect ( json_response [ 'committer_name' ] ) . to eq ( commit . committer_name )
expect ( json_response [ 'committer_email' ] ) . to eq ( commit . committer_email )
expect ( json_response [ 'committed_date' ] ) . to eq ( commit . committed_date . iso8601 ( 3 ) )
expect ( json_response [ 'parent_ids' ] ) . to eq ( commit . parent_ids )
expect ( json_response [ 'stats' ] [ 'additions' ] ) . to eq ( commit . stats . additions )
expect ( json_response [ 'stats' ] [ 'deletions' ] ) . to eq ( commit . stats . deletions )
expect ( json_response [ 'stats' ] [ 'total' ] ) . to eq ( commit . stats . total )
2017-09-10 17:25:29 +05:30
expect ( json_response [ 'status' ] ) . to be_nil
2018-03-17 18:26:18 +05:30
expect ( json_response [ 'last_pipeline' ] ) . to be_nil
2014-09-02 18:07:02 +05:30
end
2017-09-10 17:25:29 +05:30
context 'when ref does not exist' do
let ( :commit_id ) { 'unknown' }
it_behaves_like '404 response' do
let ( :request ) { get api ( route , current_user ) }
let ( :message ) { '404 Commit Not Found' }
end
2014-09-02 18:07:02 +05:30
end
2015-10-24 18:46:33 +05:30
2017-09-10 17:25:29 +05:30
context 'when repository is disabled' do
include_context 'disabled repository'
2016-09-13 17:45:13 +05:30
2017-09-10 17:25:29 +05:30
it_behaves_like '403 response' do
let ( :request ) { get api ( route , current_user ) }
end
2015-10-24 18:46:33 +05:30
end
2017-09-10 17:25:29 +05:30
end
2015-10-24 18:46:33 +05:30
2018-03-17 18:26:18 +05:30
context 'when stat param' do
let ( :route ) { " /projects/ #{ project_id } /repository/commits/ #{ commit_id } " }
it 'is not present return stats by default' do
get api ( route , user )
expect ( response ) . to have_gitlab_http_status ( 200 )
expect ( json_response ) . to include 'stats'
end
it " is false it does not include stats " do
2019-02-15 15:39:39 +05:30
get api ( route , user ) , params : { stats : false }
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 200 )
expect ( json_response ) . not_to include 'stats'
end
it " is true it includes stats " do
2019-02-15 15:39:39 +05:30
get api ( route , user ) , params : { stats : true }
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 200 )
expect ( json_response ) . to include 'stats'
end
end
2017-09-10 17:25:29 +05:30
context 'when unauthenticated' , 'and project is public' do
let ( :project ) { create ( :project , :public , :repository ) }
2016-09-13 17:45:13 +05:30
2017-09-10 17:25:29 +05:30
it_behaves_like 'ref commit'
end
2016-09-13 17:45:13 +05:30
2017-09-10 17:25:29 +05:30
context 'when unauthenticated' , 'and project is private' do
it_behaves_like '404 response' do
let ( :request ) { get api ( route ) }
let ( :message ) { '404 Project Not Found' }
2015-10-24 18:46:33 +05:30
end
2017-09-10 17:25:29 +05:30
end
2016-09-13 17:45:13 +05:30
2018-11-18 11:00:15 +05:30
context 'when authenticated' , 'as a maintainer' do
2017-09-10 17:25:29 +05:30
let ( :current_user ) { user }
2016-09-13 17:45:13 +05:30
2017-09-10 17:25:29 +05:30
it_behaves_like 'ref commit'
2016-09-13 17:45:13 +05:30
2017-09-10 17:25:29 +05:30
context 'when branch contains a dot' do
let ( :commit ) { project . repository . commit ( branch_with_dot . name ) }
let ( :commit_id ) { branch_with_dot . name }
it_behaves_like 'ref commit'
2016-09-13 17:45:13 +05:30
end
2014-09-02 18:07:02 +05:30
2017-09-10 17:25:29 +05:30
context 'when branch contains a slash' do
let ( :commit_id ) { branch_with_slash . name }
it_behaves_like '404 response' do
let ( :request ) { get api ( route , current_user ) }
end
end
context 'when branch contains an escaped slash' do
let ( :commit ) { project . repository . commit ( branch_with_slash . name ) }
let ( :commit_id ) { CGI . escape ( branch_with_slash . name ) }
it_behaves_like 'ref commit'
end
context 'requesting with the escaped project full path' do
let ( :project_id ) { CGI . escape ( project . full_path ) }
it_behaves_like 'ref commit'
context 'when branch contains a dot' do
let ( :commit ) { project . repository . commit ( branch_with_dot . name ) }
let ( :commit_id ) { branch_with_dot . name }
it_behaves_like 'ref commit'
end
end
context 'when the ref has a pipeline' do
2019-02-15 15:39:39 +05:30
let! ( :pipeline ) { project . ci_pipelines . create ( source : :push , ref : 'master' , sha : commit . sha , protected : false ) }
2017-09-10 17:25:29 +05:30
it 'includes a "created" status' do
get api ( route , current_user )
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 200 )
2017-09-10 17:25:29 +05:30
expect ( response ) . to match_response_schema ( 'public_api/v4/commit/detail' )
expect ( json_response [ 'status' ] ) . to eq ( 'created' )
2018-03-17 18:26:18 +05:30
expect ( json_response [ 'last_pipeline' ] [ 'id' ] ) . to eq ( pipeline . id )
expect ( json_response [ 'last_pipeline' ] [ 'ref' ] ) . to eq ( pipeline . ref )
expect ( json_response [ 'last_pipeline' ] [ 'sha' ] ) . to eq ( pipeline . sha )
expect ( json_response [ 'last_pipeline' ] [ 'status' ] ) . to eq ( pipeline . status )
2017-09-10 17:25:29 +05:30
end
context 'when pipeline succeeds' do
before do
pipeline . update ( status : 'success' )
end
it 'includes a "success" status' do
get api ( route , current_user )
2018-03-17 18:26:18 +05:30
expect ( response ) . to have_gitlab_http_status ( 200 )
2017-09-10 17:25:29 +05:30
expect ( response ) . to match_response_schema ( 'public_api/v4/commit/detail' )
expect ( json_response [ 'status' ] ) . to eq ( 'success' )
end
end
2014-09-02 18:07:02 +05:30
end
end
end
2017-09-10 17:25:29 +05:30
describe 'GET /projects/:id/repository/commits/:sha/diff' do
let ( :commit ) { project . repository . commit }
let ( :commit_id ) { commit . id }
let ( :route ) { " /projects/ #{ project_id } /repository/commits/ #{ commit_id } /diff " }
2014-09-02 18:07:02 +05:30
2017-09-10 17:25:29 +05:30
shared_examples_for 'ref diff' do
it 'returns the diff of the selected commit' do
get api ( route , current_user )
2014-09-02 18:07:02 +05:30
2017-09-10 17:25:29 +05:30
expect ( response ) . to have_gitlab_http_status ( 200 )
2018-03-27 19:54:05 +05:30
expect ( response ) . to include_pagination_headers
2017-09-10 17:25:29 +05:30
expect ( json_response . size ) . to be > = 1
expect ( json_response . first . keys ) . to include 'diff'
2014-09-02 18:07:02 +05:30
end
2017-09-10 17:25:29 +05:30
context 'when ref does not exist' do
let ( :commit_id ) { 'unknown' }
it_behaves_like '404 response' do
let ( :request ) { get api ( route , current_user ) }
let ( :message ) { '404 Commit Not Found' }
end
end
context 'when repository is disabled' do
include_context 'disabled repository'
it_behaves_like '403 response' do
let ( :request ) { get api ( route , current_user ) }
end
2014-09-02 18:07:02 +05:30
end
end
2017-09-10 17:25:29 +05:30
context 'when unauthenticated' , 'and project is public' do
let ( :project ) { create ( :project , :public , :repository ) }
it_behaves_like 'ref diff'
end
context 'when unauthenticated' , 'and project is private' do
it_behaves_like '404 response' do
let ( :request ) { get api ( route ) }
let ( :message ) { '404 Project Not Found' }
end
end
2018-11-18 11:00:15 +05:30
context 'when authenticated' , 'as a maintainer' do
2017-09-10 17:25:29 +05:30
let ( :current_user ) { user }
it_behaves_like 'ref diff'
context 'when branch contains a dot' do
let ( :commit_id ) { branch_with_dot . name }
it_behaves_like 'ref diff'
end
context 'when branch contains a slash' do
let ( :commit_id ) { branch_with_slash . name }
it_behaves_like '404 response' do
let ( :request ) { get api ( route , current_user ) }
end
end
context 'when branch contains an escaped slash' do
let ( :commit_id ) { CGI . escape ( branch_with_slash . name ) }
it_behaves_like 'ref diff'
end
context 'requesting with the escaped project full path' do
let ( :project_id ) { CGI . escape ( project . full_path ) }
it_behaves_like 'ref diff'
context 'when branch contains a dot' do
let ( :commit_id ) { branch_with_dot . name }
it_behaves_like 'ref diff'
end
2015-04-26 12:48:37 +05:30
end
2018-03-17 18:26:18 +05:30
context 'when binary diff are treated as text' do
let ( :commit_id ) { TestEnv :: BRANCH_SHA [ 'add-pdf-text-binary' ] }
it_behaves_like 'ref diff'
end
2015-04-26 12:48:37 +05:30
end
end
2017-09-10 17:25:29 +05:30
describe 'GET /projects/:id/repository/commits/:sha/comments' do
let ( :commit ) { project . repository . commit }
let ( :commit_id ) { commit . id }
let ( :route ) { " /projects/ #{ project_id } /repository/commits/ #{ commit_id } /comments " }
shared_examples_for 'ref comments' do
context 'when ref exists' do
before do
create ( :note_on_commit , author : user , project : project , commit_id : commit . id , note : 'a comment on a commit' )
create ( :note_on_commit , author : user , project : project , commit_id : commit . id , note : 'another comment on a commit' )
end
it 'returns the diff of the selected commit' do
get api ( route , current_user )
expect ( response ) . to have_gitlab_http_status ( 200 )
expect ( response ) . to match_response_schema ( 'public_api/v4/commit_notes' )
expect ( json_response . size ) . to eq ( 2 )
expect ( json_response . first [ 'note' ] ) . to eq ( 'a comment on a commit' )
expect ( json_response . first [ 'author' ] [ 'id' ] ) . to eq ( user . id )
end
2015-04-26 12:48:37 +05:30
end
2017-09-10 17:25:29 +05:30
context 'when ref does not exist' do
let ( :commit_id ) { 'unknown' }
it_behaves_like '404 response' do
let ( :request ) { get api ( route , current_user ) }
let ( :message ) { '404 Commit Not Found' }
end
end
context 'when repository is disabled' do
include_context 'disabled repository'
it_behaves_like '403 response' do
let ( :request ) { get api ( route , current_user ) }
end
end
end
context 'when unauthenticated' , 'and project is public' do
let ( :project ) { create ( :project , :public , :repository ) }
it_behaves_like 'ref comments'
end
context 'when unauthenticated' , 'and project is private' do
it_behaves_like '404 response' do
let ( :request ) { get api ( route ) }
let ( :message ) { '404 Project Not Found' }
2015-04-26 12:48:37 +05:30
end
end
2018-11-18 11:00:15 +05:30
context 'when authenticated' , 'as a maintainer' do
2017-09-10 17:25:29 +05:30
let ( :current_user ) { user }
it_behaves_like 'ref comments'
context 'when branch contains a dot' do
let ( :commit ) { project . repository . commit ( branch_with_dot . name ) }
let ( :commit_id ) { branch_with_dot . name }
it_behaves_like 'ref comments'
end
context 'when branch contains a slash' do
let ( :commit ) { project . repository . commit ( branch_with_slash . name ) }
let ( :commit_id ) { branch_with_slash . name }
it_behaves_like '404 response' do
let ( :request ) { get api ( route , current_user ) }
end
end
context 'when branch contains an escaped slash' do
let ( :commit ) { project . repository . commit ( branch_with_slash . name ) }
let ( :commit_id ) { CGI . escape ( branch_with_slash . name ) }
it_behaves_like 'ref comments'
end
context 'requesting with the escaped project full path' do
let ( :project_id ) { CGI . escape ( project . full_path ) }
it_behaves_like 'ref comments'
context 'when branch contains a dot' do
let ( :commit ) { project . repository . commit ( branch_with_dot . name ) }
let ( :commit_id ) { branch_with_dot . name }
it_behaves_like 'ref comments'
end
2015-04-26 12:48:37 +05:30
end
end
2017-08-17 22:00:37 +05:30
context 'when the commit is present on two projects' do
2017-09-10 17:25:29 +05:30
let ( :forked_project ) { create ( :project , :repository , creator : guest , namespace : guest . namespace ) }
let! ( :forked_project_note ) { create ( :note_on_commit , author : guest , project : forked_project , commit_id : forked_project . repository . commit . id , note : 'a comment on a commit for fork' ) }
let ( :project_id ) { forked_project . id }
let ( :commit_id ) { forked_project . repository . commit . id }
2017-08-17 22:00:37 +05:30
it 'returns the comments for the target project' do
2017-09-10 17:25:29 +05:30
get api ( route , guest )
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
expect ( response ) . to have_gitlab_http_status ( 200 )
expect ( response ) . to match_response_schema ( 'public_api/v4/commit_notes' )
expect ( json_response . size ) . to eq ( 1 )
2017-08-17 22:00:37 +05:30
expect ( json_response . first [ 'note' ] ) . to eq ( 'a comment on a commit for fork' )
2017-09-10 17:25:29 +05:30
expect ( json_response . first [ 'author' ] [ 'id' ] ) . to eq ( guest . id )
2017-08-17 22:00:37 +05:30
end
end
end
describe 'POST :id/repository/commits/:sha/cherry_pick' do
2017-09-10 17:25:29 +05:30
let ( :commit ) { project . commit ( '7d3b0f7cff5f37573aea97cebfd5692ea1689924' ) }
let ( :commit_id ) { commit . id }
let ( :branch ) { 'master' }
let ( :route ) { " /projects/ #{ project_id } /repository/commits/ #{ commit_id } /cherry_pick " }
shared_examples_for 'ref cherry-pick' do
context 'when ref exists' do
it 'cherry-picks the ref commit' do
2019-02-15 15:39:39 +05:30
post api ( route , current_user ) , params : { branch : branch }
2017-09-10 17:25:29 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
expect ( response ) . to match_response_schema ( 'public_api/v4/commit/basic' )
expect ( json_response [ 'title' ] ) . to eq ( commit . title )
2018-03-17 18:26:18 +05:30
expect ( json_response [ 'message' ] ) . to eq ( commit . cherry_pick_message ( user ) )
2017-09-10 17:25:29 +05:30
expect ( json_response [ 'author_name' ] ) . to eq ( commit . author_name )
expect ( json_response [ 'committer_name' ] ) . to eq ( user . name )
end
end
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
context 'when repository is disabled' do
include_context 'disabled repository'
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
it_behaves_like '403 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { branch : 'master' } }
2017-09-10 17:25:29 +05:30
end
2017-08-17 22:00:37 +05:30
end
2017-09-10 17:25:29 +05:30
end
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
context 'when unauthenticated' , 'and project is public' do
let ( :project ) { create ( :project , :public , :repository ) }
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
it_behaves_like '403 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route ) , params : { branch : 'master' } }
2017-09-10 17:25:29 +05:30
end
end
context 'when unauthenticated' , 'and project is private' do
it_behaves_like '404 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route ) , params : { branch : 'master' } }
2017-09-10 17:25:29 +05:30
let ( :message ) { '404 Project Not Found' }
2017-08-17 22:00:37 +05:30
end
2017-09-10 17:25:29 +05:30
end
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
context 'when authenticated' , 'as an owner' do
let ( :current_user ) { user }
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
it_behaves_like 'ref cherry-pick'
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
context 'when ref does not exist' do
let ( :commit_id ) { 'unknown' }
it_behaves_like '404 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { branch : 'master' } }
2017-09-10 17:25:29 +05:30
let ( :message ) { '404 Commit Not Found' }
end
2017-08-17 22:00:37 +05:30
end
2017-09-10 17:25:29 +05:30
context 'when branch is missing' do
it_behaves_like '400 response' do
let ( :request ) { post api ( route , current_user ) }
end
end
2017-08-17 22:00:37 +05:30
2018-12-05 23:21:45 +05:30
context 'when branch is empty' do
[ '' , ' ' ] . each do | branch |
it_behaves_like '400 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { branch : branch } }
2018-12-05 23:21:45 +05:30
end
end
end
2017-09-10 17:25:29 +05:30
context 'when branch does not exist' do
it_behaves_like '404 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { branch : 'foo' } }
2017-09-10 17:25:29 +05:30
let ( :message ) { '404 Branch Not Found' }
end
end
context 'when commit is already included in the target branch' do
it_behaves_like '400 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { branch : 'markdown' } }
2017-09-10 17:25:29 +05:30
end
2017-08-17 22:00:37 +05:30
end
2017-09-10 17:25:29 +05:30
context 'when ref contains a dot' do
let ( :commit ) { project . repository . commit ( branch_with_dot . name ) }
let ( :commit_id ) { branch_with_dot . name }
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
it_behaves_like 'ref cherry-pick'
2017-08-17 22:00:37 +05:30
end
2017-09-10 17:25:29 +05:30
context 'when ref contains a slash' do
let ( :commit_id ) { branch_with_slash . name }
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
it_behaves_like '404 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { branch : 'master' } }
2017-09-10 17:25:29 +05:30
end
2017-08-17 22:00:37 +05:30
end
2017-09-10 17:25:29 +05:30
context 'requesting with the escaped project full path' do
let ( :project_id ) { CGI . escape ( project . full_path ) }
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
it_behaves_like 'ref cherry-pick'
context 'when ref contains a dot' do
let ( :commit ) { project . repository . commit ( branch_with_dot . name ) }
let ( :commit_id ) { branch_with_dot . name }
it_behaves_like 'ref cherry-pick'
end
2017-08-17 22:00:37 +05:30
end
end
2017-09-10 17:25:29 +05:30
context 'when authenticated' , 'as a developer' do
let ( :current_user ) { guest }
before do
project . add_developer ( guest )
end
context 'when branch is protected' do
before do
create ( :protected_branch , project : project , name : 'feature' )
end
it 'returns 400 if you are not allowed to push to the target branch' do
2019-02-15 15:39:39 +05:30
post api ( route , current_user ) , params : { branch : 'feature' }
2017-08-17 22:00:37 +05:30
2018-11-18 11:00:15 +05:30
expect ( response ) . to have_gitlab_http_status ( :forbidden )
expect ( json_response [ 'message' ] ) . to match ( / You are not allowed to push into this branch / )
2017-09-10 17:25:29 +05:30
end
2017-08-17 22:00:37 +05:30
end
end
2018-11-18 11:00:15 +05:30
context 'when cherry picking to a fork as a maintainer' do
include_context 'merge request allowing collaboration'
let ( :project_id ) { forked_project . id }
it 'allows access from a maintainer that to the source branch' do
2019-02-15 15:39:39 +05:30
post api ( route , user ) , params : { branch : 'feature' }
2018-11-18 11:00:15 +05:30
expect ( response ) . to have_gitlab_http_status ( :created )
end
it 'denies cherry picking to another branch' do
2019-02-15 15:39:39 +05:30
post api ( route , user ) , params : { branch : 'master' }
2018-11-18 11:00:15 +05:30
expect ( response ) . to have_gitlab_http_status ( :forbidden )
end
end
2015-04-26 12:48:37 +05:30
end
2018-12-13 13:39:08 +05:30
describe 'POST :id/repository/commits/:sha/revert' do
let ( :commit_id ) { 'b83d6e391c22777fca1ed3012fce84f633d7fed0' }
let ( :commit ) { project . commit ( commit_id ) }
let ( :branch ) { 'master' }
let ( :route ) { " /projects/ #{ project_id } /repository/commits/ #{ commit_id } /revert " }
shared_examples_for 'ref revert' do
context 'when ref exists' do
it 'reverts the ref commit' do
2019-02-15 15:39:39 +05:30
post api ( route , current_user ) , params : { branch : branch }
2018-12-13 13:39:08 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
expect ( response ) . to match_response_schema ( 'public_api/v4/commit/basic' )
expect ( json_response [ 'message' ] ) . to eq ( commit . revert_message ( user ) )
expect ( json_response [ 'author_name' ] ) . to eq ( user . name )
expect ( json_response [ 'committer_name' ] ) . to eq ( user . name )
expect ( json_response [ 'parent_ids' ] ) . to contain_exactly ( commit_id )
end
end
context 'when repository is disabled' do
include_context 'disabled repository'
it_behaves_like '403 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { branch : branch } }
2018-12-13 13:39:08 +05:30
end
end
end
context 'when unauthenticated' , 'and project is public' do
let ( :project ) { create ( :project , :public , :repository ) }
it_behaves_like '403 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route ) , params : { branch : branch } }
2018-12-13 13:39:08 +05:30
end
end
context 'when unauthenticated' , 'and project is private' do
it_behaves_like '404 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route ) , params : { branch : branch } }
2018-12-13 13:39:08 +05:30
let ( :message ) { '404 Project Not Found' }
end
end
context 'when authenticated' , 'as an owner' do
let ( :current_user ) { user }
it_behaves_like 'ref revert'
context 'when ref does not exist' do
let ( :commit_id ) { 'unknown' }
it_behaves_like '404 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { branch : branch } }
2018-12-13 13:39:08 +05:30
let ( :message ) { '404 Commit Not Found' }
end
end
context 'when branch is missing' do
it_behaves_like '400 response' do
let ( :request ) { post api ( route , current_user ) }
end
end
context 'when branch is empty' do
[ '' , ' ' ] . each do | branch |
it_behaves_like '400 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { branch : branch } }
2018-12-13 13:39:08 +05:30
end
end
end
context 'when branch does not exist' do
it_behaves_like '404 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { branch : 'foo' } }
2018-12-13 13:39:08 +05:30
let ( :message ) { '404 Branch Not Found' }
end
end
context 'when ref contains a dot' do
let ( :commit_id ) { branch_with_dot . name }
let ( :commit ) { project . repository . commit ( commit_id ) }
it_behaves_like '400 response' do
let ( :request ) { post api ( route , current_user ) }
end
end
end
context 'when authenticated' , 'as a developer' do
let ( :current_user ) { user }
before do
project . add_developer ( user )
end
context 'when branch is protected' do
before do
create ( :protected_branch , project : project , name : 'feature' )
end
it 'returns 400 if you are not allowed to push to the target branch' do
2019-02-15 15:39:39 +05:30
post api ( route , current_user ) , params : { branch : 'feature' }
2018-12-13 13:39:08 +05:30
expect ( response ) . to have_gitlab_http_status ( :forbidden )
expect ( json_response [ 'message' ] ) . to match ( / You are not allowed to push into this branch / )
end
end
end
end
2017-09-10 17:25:29 +05:30
describe 'POST /projects/:id/repository/commits/:sha/comments' do
let ( :commit ) { project . repository . commit }
let ( :commit_id ) { commit . id }
let ( :note ) { 'My comment' }
let ( :route ) { " /projects/ #{ project_id } /repository/commits/ #{ commit_id } /comments " }
shared_examples_for 'ref new comment' do
context 'when ref exists' do
it 'creates the comment' do
2019-02-15 15:39:39 +05:30
post api ( route , current_user ) , params : { note : note }
2017-09-10 17:25:29 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
expect ( response ) . to match_response_schema ( 'public_api/v4/commit_note' )
expect ( json_response [ 'note' ] ) . to eq ( 'My comment' )
expect ( json_response [ 'path' ] ) . to be_nil
expect ( json_response [ 'line' ] ) . to be_nil
expect ( json_response [ 'line_type' ] ) . to be_nil
end
2015-04-26 12:48:37 +05:30
end
2017-09-10 17:25:29 +05:30
context 'when repository is disabled' do
include_context 'disabled repository'
it_behaves_like '403 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { note : 'My comment' } }
2017-09-10 17:25:29 +05:30
end
end
end
context 'when unauthenticated' , 'and project is public' do
let ( :project ) { create ( :project , :public , :repository ) }
it_behaves_like '400 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route ) , params : { note : 'My comment' } }
2017-09-10 17:25:29 +05:30
end
end
context 'when unauthenticated' , 'and project is private' do
it_behaves_like '404 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route ) , params : { note : 'My comment' } }
2017-09-10 17:25:29 +05:30
let ( :message ) { '404 Project Not Found' }
end
end
context 'when authenticated' , 'as an owner' do
let ( :current_user ) { user }
it_behaves_like 'ref new comment'
2016-09-13 17:45:13 +05:30
it 'returns the inline comment' do
2019-02-15 15:39:39 +05:30
post api ( route , current_user ) , params : { note : 'My comment' , path : project . repository . commit . raw_diffs . first . new_path , line : 1 , line_type : 'new' }
2016-11-03 12:29:30 +05:30
2017-09-10 17:25:29 +05:30
expect ( response ) . to have_gitlab_http_status ( 201 )
expect ( response ) . to match_response_schema ( 'public_api/v4/commit_note' )
2015-04-26 12:48:37 +05:30
expect ( json_response [ 'note' ] ) . to eq ( 'My comment' )
2016-09-13 17:45:13 +05:30
expect ( json_response [ 'path' ] ) . to eq ( project . repository . commit . raw_diffs . first . new_path )
2016-11-03 12:29:30 +05:30
expect ( json_response [ 'line' ] ) . to eq ( 1 )
2015-04-26 12:48:37 +05:30
expect ( json_response [ 'line_type' ] ) . to eq ( 'new' )
end
2017-09-10 17:25:29 +05:30
context 'when ref does not exist' do
let ( :commit_id ) { 'unknown' }
it_behaves_like '404 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { note : 'My comment' } }
2017-09-10 17:25:29 +05:30
let ( :message ) { '404 Commit Not Found' }
end
end
2016-09-13 17:45:13 +05:30
it 'returns 400 if note is missing' do
2017-09-10 17:25:29 +05:30
post api ( route , current_user )
expect ( response ) . to have_gitlab_http_status ( 400 )
2015-04-26 12:48:37 +05:30
end
2017-09-10 17:25:29 +05:30
context 'when ref contains a dot' do
let ( :commit_id ) { branch_with_dot . name }
it_behaves_like 'ref new comment'
2015-04-26 12:48:37 +05:30
end
2017-09-10 17:25:29 +05:30
context 'when ref contains a slash' do
let ( :commit_id ) { branch_with_slash . name }
it_behaves_like '404 response' do
2019-02-15 15:39:39 +05:30
let ( :request ) { post api ( route , current_user ) , params : { note : 'My comment' } }
2017-09-10 17:25:29 +05:30
end
end
context 'when ref contains an escaped slash' do
let ( :commit_id ) { CGI . escape ( branch_with_slash . name ) }
it_behaves_like 'ref new comment'
end
context 'requesting with the escaped project full path' do
let ( :project_id ) { CGI . escape ( project . full_path ) }
it_behaves_like 'ref new comment'
context 'when ref contains a dot' do
let ( :commit_id ) { branch_with_dot . name }
it_behaves_like 'ref new comment'
end
2014-09-02 18:07:02 +05:30
end
end
end
2018-05-09 12:01:36 +05:30
describe 'GET /projects/:id/repository/commits/:sha/merge_requests' do
2019-03-13 22:55:13 +05:30
let ( :project ) { create ( :project , :repository , :private ) }
let ( :merged_mr ) { create ( :merge_request , source_project : project , source_branch : 'master' , target_branch : 'feature' ) }
2018-05-09 12:01:36 +05:30
let ( :commit ) { merged_mr . merge_request_diff . commits . last }
it 'returns the correct merge request' do
get api ( " /projects/ #{ project . id } /repository/commits/ #{ commit . id } /merge_requests " , user )
expect ( response ) . to have_gitlab_http_status ( 200 )
expect ( response ) . to include_pagination_headers
expect ( json_response . length ) . to eq ( 1 )
expect ( json_response [ 0 ] [ 'id' ] ) . to eq ( merged_mr . id )
end
it 'returns 403 for an unauthorized user' do
project . add_guest ( user )
get api ( " /projects/ #{ project . id } /repository/commits/ #{ commit . id } /merge_requests " , user )
expect ( response ) . to have_gitlab_http_status ( 403 )
end
it 'responds 404 when the commit does not exist' do
get api ( " /projects/ #{ project . id } /repository/commits/a7d26f00c35b/merge_requests " , user )
expect ( response ) . to have_gitlab_http_status ( 404 )
end
2019-03-13 22:55:13 +05:30
context 'public project' do
let ( :project ) { create ( :project , :repository , :public , :merge_requests_private ) }
let ( :non_member ) { create ( :user ) }
it 'responds 403 when only members are allowed to read merge requests' do
get api ( " /projects/ #{ project . id } /repository/commits/ #{ commit . id } /merge_requests " , non_member )
expect ( response ) . to have_gitlab_http_status ( 403 )
end
end
2018-05-09 12:01:36 +05:30
end
2014-09-02 18:07:02 +05:30
end