2019-02-15 15:39:39 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe TokenAuthenticatableStrategies::Encrypted do
|
|
|
|
let(:model) { double(:model) }
|
|
|
|
let(:instance) { double(:instance) }
|
|
|
|
|
|
|
|
let(:encrypted) do
|
|
|
|
Gitlab::CryptoHelper.aes256_gcm_encrypt('my-value')
|
|
|
|
end
|
|
|
|
|
|
|
|
subject do
|
|
|
|
described_class.new(model, 'some_field', options)
|
|
|
|
end
|
|
|
|
|
2019-05-30 16:15:17 +05:30
|
|
|
describe '.new' do
|
|
|
|
context 'when fallback and migration strategies are set' do
|
|
|
|
let(:options) { { fallback: true, migrating: true } }
|
|
|
|
|
|
|
|
it 'raises an error' do
|
|
|
|
expect { subject }.to raise_error ArgumentError, /not compatible/
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-02-15 15:39:39 +05:30
|
|
|
describe '#find_token_authenticatable' do
|
2019-05-30 16:15:17 +05:30
|
|
|
context 'when using fallback strategy' do
|
|
|
|
let(:options) { { fallback: true } }
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
it 'finds the encrypted resource by cleartext' do
|
|
|
|
allow(model).to receive(:find_by)
|
|
|
|
.with('some_field_encrypted' => encrypted)
|
|
|
|
.and_return('encrypted resource')
|
|
|
|
|
|
|
|
expect(subject.find_token_authenticatable('my-value'))
|
|
|
|
.to eq 'encrypted resource'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'uses insecure strategy when encrypted token cannot be found' do
|
|
|
|
allow(subject.send(:insecure_strategy))
|
|
|
|
.to receive(:find_token_authenticatable)
|
|
|
|
.and_return('plaintext resource')
|
|
|
|
|
|
|
|
allow(model).to receive(:find_by)
|
|
|
|
.with('some_field_encrypted' => encrypted)
|
|
|
|
.and_return(nil)
|
|
|
|
|
|
|
|
expect(subject.find_token_authenticatable('my-value'))
|
|
|
|
.to eq 'plaintext resource'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when using migration strategy' do
|
2019-05-30 16:15:17 +05:30
|
|
|
let(:options) { { migrating: true } }
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
it 'finds the cleartext resource by cleartext' do
|
|
|
|
allow(model).to receive(:find_by)
|
|
|
|
.with('some_field' => 'my-value')
|
|
|
|
.and_return('cleartext resource')
|
|
|
|
|
|
|
|
expect(subject.find_token_authenticatable('my-value'))
|
|
|
|
.to eq 'cleartext resource'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns nil if resource cannot be found' do
|
|
|
|
allow(model).to receive(:find_by)
|
|
|
|
.with('some_field' => 'my-value')
|
|
|
|
.and_return(nil)
|
|
|
|
|
|
|
|
expect(subject.find_token_authenticatable('my-value'))
|
|
|
|
.to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#get_token' do
|
2019-05-30 16:15:17 +05:30
|
|
|
context 'when using fallback strategy' do
|
|
|
|
let(:options) { { fallback: true } }
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
it 'returns decrypted token when an encrypted token is present' do
|
|
|
|
allow(instance).to receive(:read_attribute)
|
|
|
|
.with('some_field_encrypted')
|
|
|
|
.and_return(encrypted)
|
|
|
|
|
|
|
|
expect(subject.get_token(instance)).to eq 'my-value'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the plaintext token when encrypted token is not present' do
|
|
|
|
allow(instance).to receive(:read_attribute)
|
|
|
|
.with('some_field_encrypted')
|
|
|
|
.and_return(nil)
|
|
|
|
|
|
|
|
allow(instance).to receive(:read_attribute)
|
|
|
|
.with('some_field')
|
|
|
|
.and_return('cleartext value')
|
|
|
|
|
|
|
|
expect(subject.get_token(instance)).to eq 'cleartext value'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when using migration strategy' do
|
2019-05-30 16:15:17 +05:30
|
|
|
let(:options) { { migrating: true } }
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
it 'returns cleartext token when an encrypted token is present' do
|
|
|
|
allow(instance).to receive(:read_attribute)
|
|
|
|
.with('some_field_encrypted')
|
|
|
|
.and_return(encrypted)
|
|
|
|
|
|
|
|
allow(instance).to receive(:read_attribute)
|
|
|
|
.with('some_field')
|
|
|
|
.and_return('my-cleartext-value')
|
|
|
|
|
|
|
|
expect(subject.get_token(instance)).to eq 'my-cleartext-value'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the cleartext token when encrypted token is not present' do
|
|
|
|
allow(instance).to receive(:read_attribute)
|
|
|
|
.with('some_field_encrypted')
|
|
|
|
.and_return(nil)
|
|
|
|
|
|
|
|
allow(instance).to receive(:read_attribute)
|
|
|
|
.with('some_field')
|
|
|
|
.and_return('cleartext value')
|
|
|
|
|
|
|
|
expect(subject.get_token(instance)).to eq 'cleartext value'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#set_token' do
|
2019-05-30 16:15:17 +05:30
|
|
|
context 'when using fallback strategy' do
|
|
|
|
let(:options) { { fallback: true } }
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
it 'writes encrypted token and removes plaintext token and returns it' do
|
|
|
|
expect(instance).to receive(:[]=)
|
|
|
|
.with('some_field_encrypted', encrypted)
|
|
|
|
expect(instance).to receive(:[]=)
|
|
|
|
.with('some_field', nil)
|
|
|
|
|
|
|
|
expect(subject.set_token(instance, 'my-value')).to eq 'my-value'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when using migration strategy' do
|
2019-05-30 16:15:17 +05:30
|
|
|
let(:options) { { migrating: true } }
|
2019-02-15 15:39:39 +05:30
|
|
|
|
|
|
|
it 'writes encrypted token and writes plaintext token' do
|
|
|
|
expect(instance).to receive(:[]=)
|
|
|
|
.with('some_field_encrypted', encrypted)
|
|
|
|
expect(instance).to receive(:[]=)
|
|
|
|
.with('some_field', 'my-value')
|
|
|
|
|
|
|
|
expect(subject.set_token(instance, 'my-value')).to eq 'my-value'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|