debian-mirror-gitlab/spec/controllers/projects/issues_controller_spec.rb

1216 lines
37 KiB
Ruby
Raw Normal View History

2018-11-08 19:23:39 +05:30
require 'spec_helper'
2015-09-11 14:41:01 +05:30
describe Projects::IssuesController do
2018-03-17 18:26:18 +05:30
let(:project) { create(:project) }
2015-09-11 14:41:01 +05:30
let(:user) { create(:user) }
2016-06-02 11:05:42 +05:30
let(:issue) { create(:issue, project: project) }
2015-09-11 14:41:01 +05:30
describe "GET #index" do
2016-09-13 17:45:13 +05:30
context 'external issue tracker' do
2017-09-10 17:25:29 +05:30
before do
sign_in(user)
project.add_developer(user)
create(:jira_service, project: project)
end
2016-06-02 11:05:42 +05:30
2017-09-10 17:25:29 +05:30
context 'when GitLab issues disabled' do
it 'returns 404 status' do
project.issues_enabled = false
project.save!
2019-02-15 15:39:39 +05:30
get :index, params: { namespace_id: project.namespace, project_id: project }
2017-09-10 17:25:29 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(404)
2017-09-10 17:25:29 +05:30
end
end
context 'when GitLab issues enabled' do
it 'renders the "index" template' do
2019-02-15 15:39:39 +05:30
get :index, params: { namespace_id: project.namespace, project_id: project }
2015-09-11 14:41:01 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
2017-09-10 17:25:29 +05:30
expect(response).to render_template(:index)
end
2016-09-13 17:45:13 +05:30
end
2015-09-11 14:41:01 +05:30
end
2016-09-13 17:45:13 +05:30
context 'internal issue tracker' do
before do
sign_in(user)
2018-03-17 18:26:18 +05:30
project.add_developer(user)
2016-09-13 17:45:13 +05:30
end
2015-10-24 18:46:33 +05:30
2017-08-17 22:00:37 +05:30
it_behaves_like "issuables list meta-data", :issue
2019-03-02 22:35:43 +05:30
it_behaves_like 'set sort order from user preference' do
let(:sorting_param) { 'updated_asc' }
end
2019-02-15 15:39:39 +05:30
2016-09-13 17:45:13 +05:30
it "returns index" do
2019-02-15 15:39:39 +05:30
get :index, params: { namespace_id: project.namespace, project_id: project }
2015-10-24 18:46:33 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
2016-09-13 17:45:13 +05:30
end
it "returns 301 if request path doesn't match project path" do
2019-02-15 15:39:39 +05:30
get :index, params: { namespace_id: project.namespace, project_id: project.path.upcase }
2016-09-13 17:45:13 +05:30
2017-09-10 17:25:29 +05:30
expect(response).to redirect_to(project_issues_path(project))
2016-09-13 17:45:13 +05:30
end
2015-09-11 14:41:01 +05:30
2016-09-13 17:45:13 +05:30
it "returns 404 when issues are disabled" do
project.issues_enabled = false
2017-09-10 17:25:29 +05:30
project.save!
2016-09-13 17:45:13 +05:30
2019-02-15 15:39:39 +05:30
get :index, params: { namespace_id: project.namespace, project_id: project }
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(404)
2016-09-13 17:45:13 +05:30
end
2015-09-11 14:41:01 +05:30
end
2017-08-17 22:00:37 +05:30
context 'with page param' do
2019-03-02 22:35:43 +05:30
let(:last_page) { project.issues.page.total_pages }
2017-08-17 22:00:37 +05:30
let!(:issue_list) { create_list(:issue, 2, project: project) }
before do
sign_in(user)
2018-03-17 18:26:18 +05:30
project.add_developer(user)
2017-08-17 22:00:37 +05:30
allow(Kaminari.config).to receive(:default_per_page).and_return(1)
end
it 'redirects to last_page if page number is larger than number of pages' do
get :index,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace.to_param,
project_id: project,
page: (last_page + 1).to_param
}
2017-08-17 22:00:37 +05:30
expect(response).to redirect_to(namespace_project_issues_path(page: last_page, state: controller.params[:state], scope: controller.params[:scope]))
end
it 'redirects to specified page' do
get :index,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace.to_param,
project_id: project,
page: last_page.to_param
}
2017-08-17 22:00:37 +05:30
expect(assigns(:issues).current_page).to eq(last_page)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
2017-08-17 22:00:37 +05:30
end
it 'does not redirect to external sites when provided a host field' do
external_host = "www.example.com"
get :index,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace.to_param,
project_id: project,
page: (last_page + 1).to_param,
host: external_host
}
2017-08-17 22:00:37 +05:30
expect(response).to redirect_to(namespace_project_issues_path(page: last_page, state: controller.params[:state], scope: controller.params[:scope]))
end
2018-03-17 18:26:18 +05:30
it 'does not use pagination if disabled' do
allow(controller).to receive(:pagination_disabled?).and_return(true)
get :index,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace.to_param,
project_id: project,
page: (last_page + 1).to_param
}
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
expect(assigns(:issues).size).to eq(2)
end
2017-08-17 22:00:37 +05:30
end
2016-09-13 17:45:13 +05:30
end
describe 'GET #new' do
2017-08-17 22:00:37 +05:30
it 'redirects to signin if not logged in' do
2019-02-15 15:39:39 +05:30
get :new, params: { namespace_id: project.namespace, project_id: project }
2017-08-17 22:00:37 +05:30
2019-02-02 18:00:53 +05:30
expect(flash[:alert]).to eq 'You need to sign in or sign up before continuing.'
2017-08-17 22:00:37 +05:30
expect(response).to redirect_to(new_user_session_path)
end
context 'internal issue tracker' do
before do
sign_in(user)
2018-03-17 18:26:18 +05:30
project.add_developer(user)
2017-08-17 22:00:37 +05:30
end
it 'builds a new issue' do
2019-02-15 15:39:39 +05:30
get :new, params: { namespace_id: project.namespace, project_id: project }
2017-08-17 22:00:37 +05:30
expect(assigns(:issue)).to be_a_new(Issue)
end
it 'fills in an issue for a merge request' do
project_with_repository = create(:project, :repository)
2018-03-17 18:26:18 +05:30
project_with_repository.add_developer(user)
2017-08-17 22:00:37 +05:30
mr = create(:merge_request_with_diff_notes, source_project: project_with_repository)
2019-02-15 15:39:39 +05:30
get :new, params: { namespace_id: project_with_repository.namespace, project_id: project_with_repository, merge_request_to_resolve_discussions_of: mr.iid }
2017-08-17 22:00:37 +05:30
expect(assigns(:issue).title).not_to be_empty
expect(assigns(:issue).description).not_to be_empty
end
it 'fills in an issue for a discussion' do
note = create(:note_on_merge_request, project: project)
2019-02-15 15:39:39 +05:30
get :new, params: { namespace_id: project.namespace.path, project_id: project, merge_request_to_resolve_discussions_of: note.noteable.iid, discussion_to_resolve: note.discussion_id }
2017-08-17 22:00:37 +05:30
expect(assigns(:issue).title).not_to be_empty
expect(assigns(:issue).description).not_to be_empty
end
end
2016-09-13 17:45:13 +05:30
context 'external issue tracker' do
2017-09-10 17:25:29 +05:30
let!(:service) do
create(:custom_issue_tracker_service, project: project, title: 'Custom Issue Tracker', new_issue_url: 'http://test.com')
end
2017-08-17 22:00:37 +05:30
before do
sign_in(user)
2018-03-17 18:26:18 +05:30
project.add_developer(user)
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
external = double
2016-09-13 17:45:13 +05:30
allow(project).to receive(:external_issue_tracker).and_return(external)
2017-09-10 17:25:29 +05:30
end
2015-09-11 14:41:01 +05:30
2017-09-10 17:25:29 +05:30
context 'when GitLab issues disabled' do
it 'returns 404 status' do
project.issues_enabled = false
project.save!
2019-02-15 15:39:39 +05:30
get :new, params: { namespace_id: project.namespace, project_id: project }
2017-09-10 17:25:29 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(404)
2017-09-10 17:25:29 +05:30
end
end
2015-09-11 14:41:01 +05:30
2017-09-10 17:25:29 +05:30
context 'when GitLab issues enabled' do
it 'renders the "new" template' do
2019-02-15 15:39:39 +05:30
get :new, params: { namespace_id: project.namespace, project_id: project }
2017-09-10 17:25:29 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
2017-09-10 17:25:29 +05:30
expect(response).to render_template(:new)
end
end
end
end
describe 'Redirect after sign in' do
context 'with an AJAX request' do
it 'does not store the visited URL' do
2019-02-15 15:39:39 +05:30
get :show, params: {
2017-09-10 17:25:29 +05:30
format: :json,
namespace_id: project.namespace,
project_id: project,
id: issue.iid
2019-02-15 15:39:39 +05:30
}, xhr: true
2017-09-10 17:25:29 +05:30
expect(session['user_return_to']).to be_blank
end
end
context 'without an AJAX request' do
it 'stores the visited URL' do
get :show,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace.to_param,
project_id: project,
id: issue.iid
}
2017-09-10 17:25:29 +05:30
expect(session['user_return_to']).to eq("/#{project.namespace.to_param}/#{project.to_param}/issues/#{issue.iid}")
2016-09-13 17:45:13 +05:30
end
2015-09-11 14:41:01 +05:30
end
2016-06-02 11:05:42 +05:30
end
2018-03-17 18:26:18 +05:30
describe 'POST #move' do
2017-08-17 22:00:37 +05:30
before do
sign_in(user)
2018-03-17 18:26:18 +05:30
project.add_developer(user)
2017-08-17 22:00:37 +05:30
end
context 'when moving issue to another private project' do
2017-09-10 17:25:29 +05:30
let(:another_project) { create(:project, :private) }
2016-06-02 11:05:42 +05:30
context 'when user has access to move issue' do
2017-09-10 17:25:29 +05:30
before do
2018-03-17 18:26:18 +05:30
another_project.add_reporter(user)
2017-09-10 17:25:29 +05:30
end
2016-06-02 11:05:42 +05:30
it 'moves issue to another project' do
move_issue
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status :ok
expect(another_project.issues).not_to be_empty
2016-06-02 11:05:42 +05:30
end
end
context 'when user does not have access to move issue' do
it 'responds with 404' do
move_issue
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status :not_found
2016-06-02 11:05:42 +05:30
end
end
2018-03-17 18:26:18 +05:30
def move_issue
post :move,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace.to_param,
project_id: project,
id: issue.iid,
move_to_project_id: another_project.id
},
format: :json
2018-03-17 18:26:18 +05:30
end
end
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
describe 'PUT #update' do
subject do
put :update,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace,
project_id: project,
id: issue.to_param,
issue: { title: 'New title' }
},
format: :json
2018-03-17 18:26:18 +05:30
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
before do
sign_in(user)
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
context 'when user has access to update issue' do
before do
project.add_developer(user)
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
it 'updates the issue' do
subject
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_http_status(:ok)
expect(issue.reload.title).to eq('New title')
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
context 'when Akismet is enabled and the issue is identified as spam' do
before do
stub_application_setting(recaptcha_enabled: true)
allow_any_instance_of(SpamService).to receive(:check_for_spam?).and_return(true)
allow_any_instance_of(AkismetService).to receive(:spam?).and_return(true)
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
it 'renders json with recaptcha_html' do
subject
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect(JSON.parse(response.body)).to have_key('recaptcha_html')
end
end
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
context 'when user does not have access to update issue' do
before do
project.add_guest(user)
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
it 'responds with 404' do
subject
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_http_status(:not_found)
end
end
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
describe 'GET #realtime_changes' do
def go(id:)
get :realtime_changes,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace.to_param,
project_id: project,
id: id
}
2018-03-17 18:26:18 +05:30
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
context 'when an issue was edited' do
before do
project.add_developer(user)
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
issue.update!(last_edited_by: user, last_edited_at: issue.created_at + 1.minute)
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
sign_in(user)
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
it 'returns last edited time' do
go(id: issue.iid)
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
data = JSON.parse(response.body)
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect(data).to include('updated_at')
expect(data['updated_at']).to eq(issue.last_edited_at.to_time.iso8601)
end
end
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
context 'when an issue was edited by a deleted user' do
let(:deleted_user) { create(:user) }
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
before do
project.add_developer(user)
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
issue.update!(last_edited_by: deleted_user, last_edited_at: Time.now)
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
deleted_user.destroy
sign_in(user)
2017-08-17 22:00:37 +05:30
end
2018-03-17 18:26:18 +05:30
it 'returns 200' do
go(id: issue.iid)
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
2016-06-02 11:05:42 +05:30
end
end
2019-03-02 22:35:43 +05:30
context 'when getting the changes' do
before do
project.add_developer(user)
sign_in(user)
end
it 'returns the necessary data' do
go(id: issue.iid)
data = JSON.parse(response.body)
expect(data).to include('title_text', 'description', 'description_text')
expect(data).to include('task_status', 'lock_version')
end
end
2016-06-02 11:05:42 +05:30
end
describe 'Confidential Issues' do
let(:project) { create(:project_empty_repo, :public) }
let(:assignee) { create(:assignee) }
let(:author) { create(:user) }
let(:non_member) { create(:user) }
let(:member) { create(:user) }
let(:admin) { create(:admin) }
let!(:issue) { create(:issue, project: project) }
let!(:unescaped_parameter_value) { create(:issue, :confidential, project: project, author: author) }
2017-08-17 22:00:37 +05:30
let!(:request_forgery_timing_attack) { create(:issue, :confidential, project: project, assignees: [assignee]) }
2016-06-02 11:05:42 +05:30
describe 'GET #index' do
2016-09-13 17:45:13 +05:30
it 'does not list confidential issues for guests' do
2016-06-02 11:05:42 +05:30
sign_out(:user)
get_issues
expect(assigns(:issues)).to eq [issue]
end
2016-09-13 17:45:13 +05:30
it 'does not list confidential issues for non project members' do
2016-06-02 11:05:42 +05:30
sign_in(non_member)
get_issues
expect(assigns(:issues)).to eq [issue]
end
2016-09-13 17:45:13 +05:30
it 'does not list confidential issues for project members with guest role' do
sign_in(member)
2018-03-17 18:26:18 +05:30
project.add_guest(member)
get_issues
expect(assigns(:issues)).to eq [issue]
end
2016-09-13 17:45:13 +05:30
it 'lists confidential issues for author' do
2016-06-02 11:05:42 +05:30
sign_in(author)
get_issues
expect(assigns(:issues)).to include unescaped_parameter_value
expect(assigns(:issues)).not_to include request_forgery_timing_attack
end
2016-09-13 17:45:13 +05:30
it 'lists confidential issues for assignee' do
2016-06-02 11:05:42 +05:30
sign_in(assignee)
get_issues
expect(assigns(:issues)).not_to include unescaped_parameter_value
expect(assigns(:issues)).to include request_forgery_timing_attack
end
2016-09-13 17:45:13 +05:30
it 'lists confidential issues for project members' do
2016-06-02 11:05:42 +05:30
sign_in(member)
2018-03-17 18:26:18 +05:30
project.add_developer(member)
2016-06-02 11:05:42 +05:30
get_issues
expect(assigns(:issues)).to include unescaped_parameter_value
expect(assigns(:issues)).to include request_forgery_timing_attack
end
2016-09-13 17:45:13 +05:30
it 'lists confidential issues for admin' do
2016-06-02 11:05:42 +05:30
sign_in(admin)
get_issues
expect(assigns(:issues)).to include unescaped_parameter_value
expect(assigns(:issues)).to include request_forgery_timing_attack
end
def get_issues
get :index,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace.to_param,
project_id: project
}
2016-06-02 11:05:42 +05:30
end
end
shared_examples_for 'restricted action' do |http_status|
it 'returns 404 for guests' do
sign_out(:user)
2016-06-02 11:05:42 +05:30
go(id: unescaped_parameter_value.to_param)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status :not_found
2016-06-02 11:05:42 +05:30
end
it 'returns 404 for non project members' do
sign_in(non_member)
go(id: unescaped_parameter_value.to_param)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status :not_found
2016-06-02 11:05:42 +05:30
end
it 'returns 404 for project members with guest role' do
sign_in(member)
2018-03-17 18:26:18 +05:30
project.add_guest(member)
go(id: unescaped_parameter_value.to_param)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status :not_found
end
2016-06-02 11:05:42 +05:30
it "returns #{http_status[:success]} for author" do
sign_in(author)
go(id: unescaped_parameter_value.to_param)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status http_status[:success]
2016-06-02 11:05:42 +05:30
end
it "returns #{http_status[:success]} for assignee" do
sign_in(assignee)
go(id: request_forgery_timing_attack.to_param)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status http_status[:success]
2016-06-02 11:05:42 +05:30
end
it "returns #{http_status[:success]} for project members" do
sign_in(member)
2018-03-17 18:26:18 +05:30
project.add_developer(member)
2016-06-02 11:05:42 +05:30
go(id: unescaped_parameter_value.to_param)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status http_status[:success]
2016-06-02 11:05:42 +05:30
end
it "returns #{http_status[:success]} for admin" do
sign_in(admin)
go(id: unescaped_parameter_value.to_param)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status http_status[:success]
end
end
describe 'PUT #update' do
def update_issue(issue_params: {}, additional_params: {}, id: nil)
id ||= issue.iid
params = {
namespace_id: project.namespace.to_param,
project_id: project,
id: id,
issue: { title: 'New title' }.merge(issue_params),
format: :json
}.merge(additional_params)
2019-02-15 15:39:39 +05:30
put :update, params: params
2018-03-17 18:26:18 +05:30
end
def go(id:)
update_issue(id: id)
end
before do
sign_in(user)
project.add_developer(user)
end
it_behaves_like 'restricted action', success: 200
it_behaves_like 'update invalid issuable', Issue
context 'changing the assignee' do
it 'limits the attributes exposed on the assignee' do
assignee = create(:user)
project.add_developer(assignee)
update_issue(issue_params: { assignee_ids: [assignee.id] })
body = JSON.parse(response.body)
expect(body['assignees'].first.keys)
.to match_array(%w(id name username avatar_url state web_url))
end
end
context 'Akismet is enabled' do
before do
project.update!(visibility_level: Gitlab::VisibilityLevel::PUBLIC)
stub_application_setting(recaptcha_enabled: true)
allow_any_instance_of(SpamService).to receive(:check_for_spam?).and_return(true)
end
context 'when an issue is not identified as spam' do
before do
allow_any_instance_of(described_class).to receive(:verify_recaptcha).and_return(false)
allow_any_instance_of(AkismetService).to receive(:spam?).and_return(false)
end
it 'normally updates the issue' do
expect { update_issue(issue_params: { title: 'Foo' }) }.to change { issue.reload.title }.to('Foo')
end
end
context 'when an issue is identified as spam' do
before do
allow_any_instance_of(AkismetService).to receive(:spam?).and_return(true)
end
context 'when captcha is not verified' do
before do
allow_any_instance_of(described_class).to receive(:verify_recaptcha).and_return(false)
end
it 'rejects an issue recognized as a spam' do
expect { update_issue }.not_to change { issue.reload.title }
end
it 'rejects an issue recognized as a spam when recaptcha disabled' do
stub_application_setting(recaptcha_enabled: false)
expect { update_issue }.not_to change { issue.reload.title }
end
it 'creates a spam log' do
update_issue(issue_params: { title: 'Spam title' })
spam_logs = SpamLog.all
expect(spam_logs.count).to eq(1)
expect(spam_logs.first.title).to eq('Spam title')
expect(spam_logs.first.recaptcha_verified).to be_falsey
end
it 'renders recaptcha_html json response' do
update_issue
expect(json_response).to have_key('recaptcha_html')
end
it 'returns 200 status' do
update_issue
expect(response).to have_gitlab_http_status(200)
end
end
context 'when captcha is verified' do
let(:spammy_title) { 'Whatever' }
let!(:spam_logs) { create_list(:spam_log, 2, user: user, title: spammy_title) }
def update_verified_issue
update_issue(
issue_params: { title: spammy_title },
additional_params: { spam_log_id: spam_logs.last.id, recaptcha_verification: true })
end
before do
allow_any_instance_of(described_class).to receive(:verify_recaptcha)
.and_return(true)
end
it 'returns 200 status' do
expect(response).to have_gitlab_http_status(200)
end
it 'accepts an issue after recaptcha is verified' do
expect { update_verified_issue }.to change { issue.reload.title }.to(spammy_title)
end
it 'marks spam log as recaptcha_verified' do
expect { update_verified_issue }.to change { SpamLog.last.recaptcha_verified }.from(false).to(true)
end
it 'does not mark spam log as recaptcha_verified when it does not belong to current_user' do
spam_log = create(:spam_log)
expect { update_issue(issue_params: { spam_log_id: spam_log.id, recaptcha_verification: true }) }
.not_to change { SpamLog.last.recaptcha_verified }
end
end
end
2016-06-02 11:05:42 +05:30
end
end
describe 'GET #show' do
it_behaves_like 'restricted action', success: 200
def go(id:)
get :show,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace.to_param,
project_id: project,
id: id
}
2016-06-02 11:05:42 +05:30
end
2018-12-05 23:21:45 +05:30
it 'avoids (most) N+1s loading labels', :request_store do
label = create(:label, project: project).to_reference
labels = create_list(:label, 10, project: project).map(&:to_reference)
issue = create(:issue, project: project, description: 'Test issue')
control_count = ActiveRecord::QueryRecorder.new { issue.update(description: [issue.description, label].join(' ')) }.count
# Follow-up to get rid of this `2 * label.count` requirement: https://gitlab.com/gitlab-org/gitlab-ce/issues/52230
expect { issue.update(description: [issue.description, labels].join(' ')) }
.not_to exceed_query_limit(control_count + 2 * labels.count)
end
2016-06-02 11:05:42 +05:30
end
2017-09-10 17:25:29 +05:30
describe 'GET #realtime_changes' do
it_behaves_like 'restricted action', success: 200
def go(id:)
get :realtime_changes,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace.to_param,
project_id: project,
id: id
}
2017-09-10 17:25:29 +05:30
end
end
2016-06-02 11:05:42 +05:30
describe 'GET #edit' do
it_behaves_like 'restricted action', success: 200
def go(id:)
get :edit,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace.to_param,
project_id: project,
id: id
}
2016-06-02 11:05:42 +05:30
end
end
describe 'PUT #update' do
it_behaves_like 'restricted action', success: 302
2015-09-11 14:41:01 +05:30
2016-06-02 11:05:42 +05:30
def go(id:)
put :update,
2019-02-15 15:39:39 +05:30
params: {
namespace_id: project.namespace.to_param,
project_id: project,
id: id,
issue: { title: 'New title' }
}
2016-06-02 11:05:42 +05:30
end
end
end
2016-09-13 17:45:13 +05:30
describe 'POST #create' do
2017-08-17 22:00:37 +05:30
def post_new_issue(issue_attrs = {}, additional_params = {})
sign_in(user)
2017-09-10 17:25:29 +05:30
project = create(:project, :public)
2018-03-17 18:26:18 +05:30
project.add_developer(user)
2017-08-17 22:00:37 +05:30
2019-02-15 15:39:39 +05:30
post :create, params: {
2017-08-17 22:00:37 +05:30
namespace_id: project.namespace.to_param,
project_id: project,
issue: { title: 'Title', description: 'Description' }.merge(issue_attrs)
}.merge(additional_params)
project.issues.first
end
context 'resolving discussions in MergeRequest' do
let(:discussion) { create(:diff_note_on_merge_request).to_discussion }
let(:merge_request) { discussion.noteable }
let(:project) { merge_request.source_project }
before do
2018-11-18 11:00:15 +05:30
project.add_maintainer(user)
2017-08-17 22:00:37 +05:30
sign_in user
end
let(:merge_request_params) do
{ merge_request_to_resolve_discussions_of: merge_request.iid }
end
def post_issue(issue_params, other_params: {})
2019-02-15 15:39:39 +05:30
post :create, params: { namespace_id: project.namespace.to_param, project_id: project, issue: issue_params, merge_request_to_resolve_discussions_of: merge_request.iid }.merge(other_params)
2017-08-17 22:00:37 +05:30
end
it 'creates an issue for the project' do
expect { post_issue({ title: 'Hello' }) }.to change { project.issues.reload.size }.by(1)
end
it "doesn't overwrite given params" do
post_issue(description: 'Manually entered description')
expect(assigns(:issue).description).to eq('Manually entered description')
end
it 'resolves the discussion in the merge_request' do
post_issue(title: 'Hello')
discussion.first_note.reload
expect(discussion.resolved?).to eq(true)
end
it 'sets a flash message' do
post_issue(title: 'Hello')
expect(flash[:notice]).to eq('Resolved all discussions.')
end
describe "resolving a single discussion" do
before do
post_issue({ title: 'Hello' }, other_params: { discussion_to_resolve: discussion.id })
end
it 'resolves a single discussion' do
discussion.first_note.reload
expect(discussion.resolved?).to eq(true)
end
it 'sets a flash message that one discussion was resolved' do
expect(flash[:notice]).to eq('Resolved 1 discussion.')
end
end
end
2016-09-13 17:45:13 +05:30
context 'Akismet is enabled' do
before do
2017-08-17 22:00:37 +05:30
stub_application_setting(recaptcha_enabled: true)
2016-09-13 17:45:13 +05:30
allow_any_instance_of(SpamService).to receive(:check_for_spam?).and_return(true)
end
2017-08-17 22:00:37 +05:30
context 'when an issue is not identified as spam' do
before do
allow_any_instance_of(described_class).to receive(:verify_recaptcha).and_return(false)
2018-03-17 18:26:18 +05:30
allow_any_instance_of(AkismetService).to receive(:spam?).and_return(false)
2017-08-17 22:00:37 +05:30
end
2016-09-13 17:45:13 +05:30
2017-08-17 22:00:37 +05:30
it 'does not create an issue' do
expect { post_new_issue(title: '') }.not_to change(Issue, :count)
end
2016-09-13 17:45:13 +05:30
end
2017-08-17 22:00:37 +05:30
context 'when an issue is identified as spam' do
2017-09-10 17:25:29 +05:30
before do
2018-03-17 18:26:18 +05:30
allow_any_instance_of(AkismetService).to receive(:spam?).and_return(true)
2017-09-10 17:25:29 +05:30
end
2017-08-17 22:00:37 +05:30
context 'when captcha is not verified' do
def post_spam_issue
post_new_issue(title: 'Spam Title', description: 'Spam lives here')
end
2017-09-10 17:25:29 +05:30
before do
allow_any_instance_of(described_class).to receive(:verify_recaptcha).and_return(false)
end
2017-08-17 22:00:37 +05:30
it 'rejects an issue recognized as a spam' do
expect { post_spam_issue }.not_to change(Issue, :count)
end
it 'creates a spam log' do
post_spam_issue
spam_logs = SpamLog.all
expect(spam_logs.count).to eq(1)
expect(spam_logs.first.title).to eq('Spam Title')
expect(spam_logs.first.recaptcha_verified).to be_falsey
end
it 'does not create an issue when it is not valid' do
expect { post_new_issue(title: '') }.not_to change(Issue, :count)
end
it 'does not create an issue when recaptcha is not enabled' do
stub_application_setting(recaptcha_enabled: false)
expect { post_spam_issue }.not_to change(Issue, :count)
end
end
context 'when captcha is verified' do
let!(:spam_logs) { create_list(:spam_log, 2, user: user, title: 'Title') }
def post_verified_issue
post_new_issue({}, { spam_log_id: spam_logs.last.id, recaptcha_verification: true } )
end
before do
allow_any_instance_of(described_class).to receive(:verify_recaptcha).and_return(true)
end
it 'accepts an issue after recaptcha is verified' do
expect { post_verified_issue }.to change(Issue, :count)
end
it 'marks spam log as recaptcha_verified' do
expect { post_verified_issue }.to change { SpamLog.last.recaptcha_verified }.from(false).to(true)
end
it 'does not mark spam log as recaptcha_verified when it does not belong to current_user' do
spam_log = create(:spam_log)
2017-09-10 17:25:29 +05:30
expect { post_new_issue({}, { spam_log_id: spam_log.id, recaptcha_verification: true } ) }
.not_to change { SpamLog.last.recaptcha_verified }
2017-08-17 22:00:37 +05:30
end
end
2016-09-13 17:45:13 +05:30
end
end
context 'user agent details are saved' do
before do
request.env['action_dispatch.remote_ip'] = '127.0.0.1'
end
2017-08-17 22:00:37 +05:30
it 'creates a user agent detail' do
expect { post_new_issue }.to change(UserAgentDetail, :count).by(1)
end
end
2017-09-10 17:25:29 +05:30
context 'when description has quick actions' do
2017-08-17 22:00:37 +05:30
before do
2016-09-13 17:45:13 +05:30
sign_in(user)
end
2017-08-17 22:00:37 +05:30
it 'can add spent time' do
issue = post_new_issue(description: '/spend 1h')
expect(issue.total_time_spent).to eq(3600)
end
it 'can set the time estimate' do
issue = post_new_issue(description: '/estimate 2h')
expect(issue.time_estimate).to eq(7200)
2016-09-13 17:45:13 +05:30
end
end
end
describe 'POST #mark_as_spam' do
context 'properly submits to Akismet' do
before do
allow_any_instance_of(AkismetService).to receive_messages(submit_spam: true)
allow_any_instance_of(ApplicationSetting).to receive_messages(akismet_enabled: true)
end
def post_spam
admin = create(:admin)
create(:user_agent_detail, subject: issue)
2018-11-18 11:00:15 +05:30
project.add_maintainer(admin)
2016-09-13 17:45:13 +05:30
sign_in(admin)
2019-02-15 15:39:39 +05:30
post :mark_as_spam, params: {
2017-08-17 22:00:37 +05:30
namespace_id: project.namespace,
project_id: project,
2016-09-13 17:45:13 +05:30
id: issue.iid
}
end
it 'updates issue' do
post_spam
expect(issue.submittable_as_spam?).to be_falsey
end
end
end
2016-06-02 11:05:42 +05:30
describe "DELETE #destroy" do
context "when the user is a developer" do
2017-09-10 17:25:29 +05:30
before do
sign_in(user)
end
2016-06-02 11:05:42 +05:30
it "rejects a developer to destroy an issue" do
2019-02-15 15:39:39 +05:30
delete :destroy, params: { namespace_id: project.namespace, project_id: project, id: issue.iid }
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(404)
2016-06-02 11:05:42 +05:30
end
end
context "when the user is owner" do
let(:owner) { create(:user) }
let(:namespace) { create(:namespace, owner: owner) }
2017-09-10 17:25:29 +05:30
let(:project) { create(:project, namespace: namespace) }
2016-06-02 11:05:42 +05:30
2017-09-10 17:25:29 +05:30
before do
sign_in(owner)
end
2016-06-02 11:05:42 +05:30
it "deletes the issue" do
2019-02-15 15:39:39 +05:30
delete :destroy, params: { namespace_id: project.namespace, project_id: project, id: issue.iid }
2016-06-02 11:05:42 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(302)
2017-09-10 17:25:29 +05:30
expect(controller).to set_flash[:notice].to(/The issue was successfully deleted\./)
2016-06-02 11:05:42 +05:30
end
2016-09-29 09:46:39 +05:30
it 'delegates the update of the todos count cache to TodoService' do
2018-03-17 18:26:18 +05:30
expect_any_instance_of(TodoService).to receive(:destroy_target).with(issue).once
2016-09-29 09:46:39 +05:30
2019-02-15 15:39:39 +05:30
delete :destroy, params: { namespace_id: project.namespace, project_id: project, id: issue.iid }
2016-09-29 09:46:39 +05:30
end
2016-06-02 11:05:42 +05:30
end
2015-09-11 14:41:01 +05:30
end
describe 'POST #toggle_award_emoji' do
before do
sign_in(user)
2018-03-17 18:26:18 +05:30
project.add_developer(user)
end
it "toggles the award emoji" do
expect do
2019-02-15 15:39:39 +05:30
post(:toggle_award_emoji, params: {
namespace_id: project.namespace,
project_id: project,
id: issue.iid,
name: "thumbsup"
})
end.to change { issue.award_emoji.count }.by(1)
2018-03-17 18:26:18 +05:30
expect(response).to have_gitlab_http_status(200)
end
end
2017-08-17 22:00:37 +05:30
describe 'POST create_merge_request' do
2018-05-09 12:01:36 +05:30
let(:project) { create(:project, :repository, :public) }
2018-03-17 18:26:18 +05:30
2017-08-17 22:00:37 +05:30
before do
project.add_developer(user)
sign_in(user)
end
it 'creates a new merge request' do
expect { create_merge_request }.to change(project.merge_requests, :count).by(1)
end
it 'render merge request as json' do
create_merge_request
expect(response).to match_response_schema('merge_request')
end
2018-05-09 12:01:36 +05:30
it 'is not available when the project is archived' do
project.update!(archived: true)
create_merge_request
expect(response).to have_gitlab_http_status(404)
end
it 'is not available for users who cannot create merge requests' do
sign_in(create(:user))
create_merge_request
expect(response).to have_gitlab_http_status(404)
end
2017-08-17 22:00:37 +05:30
def create_merge_request
2019-02-15 15:39:39 +05:30
post :create_merge_request, params: {
namespace_id: project.namespace.to_param,
project_id: project.to_param,
id: issue.to_param
},
2017-08-17 22:00:37 +05:30
format: :json
end
end
2018-03-17 18:26:18 +05:30
2019-02-15 15:39:39 +05:30
describe 'POST #import_csv' do
let(:project) { create(:project, :public) }
let(:file) { fixture_file_upload('spec/fixtures/csv_comma.csv') }
context 'unauthorized' do
it 'returns 404 for guests' do
sign_out(:user)
import_csv
expect(response).to have_gitlab_http_status :not_found
end
it 'returns 404 for project members with reporter role' do
sign_in(user)
project.add_reporter(user)
import_csv
expect(response).to have_gitlab_http_status :not_found
end
end
context 'authorized' do
before do
sign_in(user)
project.add_developer(user)
end
it "returns 302 for project members with developer role" do
import_csv
expect(flash[:notice]).to include('Your issues are being imported')
expect(response).to redirect_to(project_issues_path(project))
end
it "shows error when upload fails" do
allow_any_instance_of(UploadService).to receive(:execute).and_return(nil)
import_csv
expect(flash[:alert]).to include('File upload error.')
expect(response).to redirect_to(project_issues_path(project))
end
end
def import_csv
2019-03-02 22:35:43 +05:30
post :import_csv, params: { namespace_id: project.namespace.to_param,
project_id: project.to_param,
file: file }
2019-02-15 15:39:39 +05:30
end
end
2018-03-17 18:26:18 +05:30
describe 'GET #discussions' do
let!(:discussion) { create(:discussion_note_on_issue, noteable: issue, project: issue.project) }
context 'when authenticated' do
before do
project.add_developer(user)
sign_in(user)
end
it 'returns discussion json' do
2019-02-15 15:39:39 +05:30
get :discussions, params: { namespace_id: project.namespace, project_id: project, id: issue.iid }
2018-03-17 18:26:18 +05:30
2018-11-08 19:23:39 +05:30
expect(json_response.first.keys).to match_array(%w[id reply_id expanded notes diff_discussion discussion_path individual_note resolvable resolved resolved_at resolved_by resolved_by_push commit_id for_commit project_id])
2018-03-17 18:26:18 +05:30
end
2018-11-18 11:00:15 +05:30
it 'renders the author status html if there is a status' do
create(:user_status, user: discussion.author)
2019-02-15 15:39:39 +05:30
get :discussions, params: { namespace_id: project.namespace, project_id: project, id: issue.iid }
2018-11-18 11:00:15 +05:30
note_json = json_response.first['notes'].first
expect(note_json['author']['status_tooltip_html']).to be_present
end
it 'does not cause an extra query for the status' do
control = ActiveRecord::QueryRecorder.new do
2019-02-15 15:39:39 +05:30
get :discussions, params: { namespace_id: project.namespace, project_id: project, id: issue.iid }
2018-11-18 11:00:15 +05:30
end
create(:user_status, user: discussion.author)
second_discussion = create(:discussion_note_on_issue, noteable: issue, project: issue.project, author: create(:user))
create(:user_status, user: second_discussion.author)
2019-02-15 15:39:39 +05:30
expect { get :discussions, params: { namespace_id: project.namespace, project_id: project, id: issue.iid } }
2018-11-18 11:00:15 +05:30
.not_to exceed_query_limit(control)
end
2018-12-13 13:39:08 +05:30
context 'when user is setting notes filters' do
let(:issuable) { issue }
2019-03-02 22:35:43 +05:30
let(:issuable_parent) { project }
2018-12-13 13:39:08 +05:30
let!(:discussion_note) { create(:discussion_note_on_issue, :system, noteable: issuable, project: project) }
it_behaves_like 'issuable notes filter'
end
2018-03-17 18:26:18 +05:30
context 'with cross-reference system note', :request_store do
let(:new_issue) { create(:issue) }
let(:cross_reference) { "mentioned in #{new_issue.to_reference(issue.project)}" }
before do
create(:discussion_note_on_issue, :system, noteable: issue, project: issue.project, note: cross_reference)
end
it 'filters notes that the user should not see' do
2019-02-15 15:39:39 +05:30
get :discussions, params: { namespace_id: project.namespace, project_id: project, id: issue.iid }
2018-03-17 18:26:18 +05:30
expect(JSON.parse(response.body).count).to eq(1)
end
it 'does not result in N+1 queries' do
# Instantiate the controller variables to ensure QueryRecorder has an accurate base count
2019-02-15 15:39:39 +05:30
get :discussions, params: { namespace_id: project.namespace, project_id: project, id: issue.iid }
2018-03-17 18:26:18 +05:30
RequestStore.clear!
control_count = ActiveRecord::QueryRecorder.new do
2019-02-15 15:39:39 +05:30
get :discussions, params: { namespace_id: project.namespace, project_id: project, id: issue.iid }
2018-03-17 18:26:18 +05:30
end.count
RequestStore.clear!
create_list(:discussion_note_on_issue, 2, :system, noteable: issue, project: issue.project, note: cross_reference)
2019-02-15 15:39:39 +05:30
expect { get :discussions, params: { namespace_id: project.namespace, project_id: project, id: issue.iid } }.not_to exceed_query_limit(control_count)
2018-03-17 18:26:18 +05:30
end
end
end
end
2018-11-29 20:51:05 +05:30
context 'private project with token authentication' do
let(:private_project) { create(:project, :private) }
it_behaves_like 'authenticates sessionless user', :index, :atom do
before do
default_params.merge!(project_id: private_project, namespace_id: private_project.namespace)
private_project.add_maintainer(user)
end
end
it_behaves_like 'authenticates sessionless user', :calendar, :ics do
before do
default_params.merge!(project_id: private_project, namespace_id: private_project.namespace)
private_project.add_maintainer(user)
end
end
end
context 'public project with token authentication' do
let(:public_project) { create(:project, :public) }
it_behaves_like 'authenticates sessionless user', :index, :atom, public: true do
before do
default_params.merge!(project_id: public_project, namespace_id: public_project.namespace)
end
end
it_behaves_like 'authenticates sessionless user', :calendar, :ics, public: true do
before do
default_params.merge!(project_id: public_project, namespace_id: public_project.namespace)
end
end
end
2015-09-11 14:41:01 +05:30
end