2018-11-18 11:00:15 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
# rubocop:disable Style/Documentation
|
2018-12-05 23:21:45 +05:30
|
|
|
# rubocop:disable Metrics/ClassLength
|
2018-11-18 11:00:15 +05:30
|
|
|
|
|
|
|
module Gitlab
|
|
|
|
module BackgroundMigration
|
|
|
|
class RemoveRestrictedTodos
|
|
|
|
PRIVATE_FEATURE = 10
|
|
|
|
PRIVATE_PROJECT = 0
|
|
|
|
|
|
|
|
class Project < ActiveRecord::Base
|
|
|
|
self.table_name = 'projects'
|
|
|
|
end
|
|
|
|
|
|
|
|
class ProjectAuthorization < ActiveRecord::Base
|
|
|
|
self.table_name = 'project_authorizations'
|
|
|
|
end
|
|
|
|
|
|
|
|
class ProjectFeature < ActiveRecord::Base
|
|
|
|
self.table_name = 'project_features'
|
|
|
|
end
|
|
|
|
|
|
|
|
class Todo < ActiveRecord::Base
|
|
|
|
include EachBatch
|
|
|
|
|
|
|
|
self.table_name = 'todos'
|
|
|
|
end
|
|
|
|
|
|
|
|
class Issue < ActiveRecord::Base
|
|
|
|
include EachBatch
|
|
|
|
|
|
|
|
self.table_name = 'issues'
|
|
|
|
end
|
|
|
|
|
|
|
|
def perform(start_id, stop_id)
|
|
|
|
projects = Project.where('EXISTS (SELECT 1 FROM todos WHERE todos.project_id = projects.id)')
|
|
|
|
.where(id: start_id..stop_id)
|
|
|
|
|
|
|
|
projects.each do |project|
|
|
|
|
remove_confidential_issue_todos(project.id)
|
|
|
|
|
|
|
|
if project.visibility_level == PRIVATE_PROJECT
|
|
|
|
remove_non_members_todos(project.id)
|
|
|
|
else
|
|
|
|
remove_restricted_features_todos(project.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
private
|
|
|
|
|
|
|
|
def remove_non_members_todos(project_id)
|
2018-12-05 23:21:45 +05:30
|
|
|
if Gitlab::Database.postgresql?
|
|
|
|
batch_remove_todos_cte(project_id)
|
|
|
|
else
|
|
|
|
unauthorized_project_todos(project_id)
|
|
|
|
.each_batch(of: 5000) do |batch|
|
|
|
|
batch.delete_all
|
|
|
|
end
|
|
|
|
end
|
2018-11-18 11:00:15 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
def remove_confidential_issue_todos(project_id)
|
|
|
|
# min access level to access a confidential issue is reporter
|
|
|
|
min_reporters = authorized_users(project_id)
|
|
|
|
.select(:user_id)
|
|
|
|
.where('access_level >= ?', 20)
|
|
|
|
|
|
|
|
confidential_issues = Issue.select(:id, :author_id).where(confidential: true, project_id: project_id)
|
2018-12-13 13:39:08 +05:30
|
|
|
confidential_issues.each_batch(of: 100, order_hint: :confidential) do |batch|
|
2018-11-18 11:00:15 +05:30
|
|
|
batch.each do |issue|
|
|
|
|
assigned_users = IssueAssignee.select(:user_id).where(issue_id: issue.id)
|
|
|
|
|
|
|
|
todos = Todo.where(target_type: 'Issue', target_id: issue.id)
|
|
|
|
.where('user_id NOT IN (?)', min_reporters)
|
|
|
|
.where('user_id NOT IN (?)', assigned_users)
|
|
|
|
todos = todos.where('user_id != ?', issue.author_id) if issue.author_id
|
|
|
|
|
|
|
|
todos.delete_all
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def remove_restricted_features_todos(project_id)
|
|
|
|
ProjectFeature.where(project_id: project_id).each do |project_features|
|
|
|
|
target_types = []
|
|
|
|
target_types << 'Issue' if private?(project_features.issues_access_level)
|
|
|
|
target_types << 'MergeRequest' if private?(project_features.merge_requests_access_level)
|
|
|
|
target_types << 'Commit' if private?(project_features.repository_access_level)
|
|
|
|
|
|
|
|
next if target_types.empty?
|
|
|
|
|
2018-12-05 23:21:45 +05:30
|
|
|
if Gitlab::Database.postgresql?
|
|
|
|
batch_remove_todos_cte(project_id, target_types)
|
|
|
|
else
|
|
|
|
unauthorized_project_todos(project_id)
|
|
|
|
.where(target_type: target_types)
|
|
|
|
.delete_all
|
|
|
|
end
|
2018-11-18 11:00:15 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def private?(feature_level)
|
|
|
|
feature_level == PRIVATE_FEATURE
|
|
|
|
end
|
|
|
|
|
|
|
|
def authorized_users(project_id)
|
|
|
|
ProjectAuthorization.select(:user_id).where(project_id: project_id)
|
|
|
|
end
|
2018-12-05 23:21:45 +05:30
|
|
|
|
|
|
|
def unauthorized_project_todos(project_id)
|
|
|
|
Todo.where(project_id: project_id)
|
|
|
|
.where('user_id NOT IN (?)', authorized_users(project_id))
|
|
|
|
end
|
|
|
|
|
|
|
|
def batch_remove_todos_cte(project_id, target_types = nil)
|
|
|
|
loop do
|
|
|
|
count = remove_todos_cte(project_id, target_types)
|
|
|
|
|
|
|
|
break if count == 0
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def remove_todos_cte(project_id, target_types = nil)
|
|
|
|
sql = []
|
|
|
|
sql << with_all_todos_sql(project_id, target_types)
|
|
|
|
sql << as_deleted_sql
|
|
|
|
sql << "SELECT count(*) FROM deleted"
|
|
|
|
|
|
|
|
result = Todo.connection.exec_query(sql.join(' '))
|
|
|
|
result.rows[0][0].to_i
|
|
|
|
end
|
|
|
|
|
|
|
|
def with_all_todos_sql(project_id, target_types = nil)
|
|
|
|
if target_types
|
|
|
|
table = Arel::Table.new(:todos)
|
|
|
|
in_target = table[:target_type].in(target_types)
|
|
|
|
target_types_sql = " AND #{in_target.to_sql}"
|
|
|
|
end
|
|
|
|
|
|
|
|
<<-SQL
|
|
|
|
WITH all_todos AS (
|
|
|
|
SELECT id
|
|
|
|
FROM "todos"
|
|
|
|
WHERE "todos"."project_id" = #{project_id}
|
|
|
|
AND (user_id NOT IN (
|
|
|
|
SELECT "project_authorizations"."user_id"
|
|
|
|
FROM "project_authorizations"
|
|
|
|
WHERE "project_authorizations"."project_id" = #{project_id})
|
|
|
|
#{target_types_sql}
|
|
|
|
)
|
|
|
|
),
|
|
|
|
SQL
|
|
|
|
end
|
|
|
|
|
|
|
|
def as_deleted_sql
|
|
|
|
<<-SQL
|
|
|
|
deleted AS (
|
|
|
|
DELETE FROM todos
|
|
|
|
WHERE id IN (
|
|
|
|
SELECT id
|
|
|
|
FROM all_todos
|
|
|
|
LIMIT 5000
|
|
|
|
)
|
|
|
|
RETURNING id
|
|
|
|
)
|
|
|
|
SQL
|
|
|
|
end
|
2018-11-18 11:00:15 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|