debian-mirror-gitlab/spec/controllers/projects/uploads_controller_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

218 lines
6.4 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2018-03-17 18:26:18 +05:30
require 'spec_helper'
2015-04-26 12:48:37 +05:30
2020-06-23 00:09:42 +05:30
RSpec.describe Projects::UploadsController do
2018-11-08 19:23:39 +05:30
include WorkhorseHelpers
2018-03-17 18:26:18 +05:30
let(:model) { create(:project, :public) }
let(:params) do
{ namespace_id: model.namespace.to_param, project_id: model }
2015-04-26 12:48:37 +05:30
end
2019-09-04 21:01:54 +05:30
let(:other_model) { create(:project, :public) }
let(:other_params) do
{ namespace_id: other_model.namespace.to_param, project_id: other_model }
end
2018-03-17 18:26:18 +05:30
it_behaves_like 'handle uploads'
2015-04-26 12:48:37 +05:30
2018-03-17 18:26:18 +05:30
context 'when the URL the old style, without /-/system' do
it 'responds with a redirect to the login page' do
2019-02-15 15:39:39 +05:30
get :show, params: { namespace_id: 'project', project_id: 'avatar', filename: 'foo.png', secret: 'bar' }
2015-04-26 12:48:37 +05:30
2018-03-17 18:26:18 +05:30
expect(response).to redirect_to(new_user_session_path)
2015-04-26 12:48:37 +05:30
end
end
2018-11-08 19:23:39 +05:30
2020-03-13 15:44:24 +05:30
context 'with a moved project' do
let!(:upload) { create(:upload, :issuable_upload, :with_file, model: model) }
let(:project) { model }
let(:upload_path) { File.basename(upload.path) }
2021-04-29 21:17:54 +05:30
let!(:redirect_route) { project.redirect_routes.create!(path: project.full_path + 'old') }
2020-03-13 15:44:24 +05:30
it 'redirects to a file with the proper extension' do
get :show, params: { namespace_id: project.namespace, project_id: project.to_param + 'old', filename: File.basename(upload.path), secret: upload.secret }
expect(response.location).to eq(show_project_uploads_url(project, upload.secret, upload_path))
expect(response.location).to end_with(upload.path)
expect(response).to have_gitlab_http_status(:redirect)
end
end
2018-11-20 20:47:30 +05:30
context "when exception occurs" do
before do
allow(FileUploader).to receive(:workhorse_authorize).and_raise(SocketError.new)
sign_in(create(:user))
end
it "responds with status internal_server_error" do
post_authorize
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:internal_server_error)
2020-01-01 13:55:28 +05:30
expect(response.body).to eq(_('Error uploading file'))
2018-11-20 20:47:30 +05:30
end
end
2022-07-16 23:28:13 +05:30
describe "GET #show" do
let(:filename) { "rails_sample.jpg" }
let(:user) { create(:user) }
let(:jpg) { fixture_file_upload('spec/fixtures/rails_sample.jpg', 'image/jpg') }
let(:txt) { fixture_file_upload('spec/fixtures/doc_sample.txt', 'text/plain') }
let(:secret) { FileUploader.generate_secret }
let(:uploader_class) { FileUploader }
let(:upload_service) do
UploadService.new(model, jpg, uploader_class).execute
end
let(:show_upload) do
get :show, params: params.merge(secret: secret, filename: filename)
end
before do
allow(FileUploader).to receive(:generate_secret).and_return(secret)
allow_next_instance_of(FileUploader) do |instance|
allow(instance).to receive(:image?).and_return(true)
end
upload_service
end
context 'when project is private do' do
before do
model.update_attribute(:visibility_level, Gitlab::VisibilityLevel::PRIVATE)
end
context "when not signed in" do
2022-08-27 11:52:29 +05:30
context 'when the project has setting enforce_auth_checks_on_uploads true' do
before do
model.update!(enforce_auth_checks_on_uploads: true)
end
2022-07-16 23:28:13 +05:30
2022-08-27 11:52:29 +05:30
it "responds with status 302" do
show_upload
2022-07-16 23:28:13 +05:30
2022-08-27 11:52:29 +05:30
expect(response).to have_gitlab_http_status(:redirect)
2022-07-16 23:28:13 +05:30
end
2022-08-27 11:52:29 +05:30
end
2022-07-16 23:28:13 +05:30
2022-08-27 11:52:29 +05:30
context 'when the project has setting enforce_auth_checks_on_uploads false' do
before do
model.update!(enforce_auth_checks_on_uploads: false)
end
2022-07-16 23:28:13 +05:30
2022-08-27 11:52:29 +05:30
it "responds with status 200" do
show_upload
2022-07-16 23:28:13 +05:30
2022-08-27 11:52:29 +05:30
expect(response).to have_gitlab_http_status(:ok)
2022-07-16 23:28:13 +05:30
end
end
end
context "when signed in" do
before do
sign_in(user)
end
context "when the user doesn't have access to the model" do
2022-08-27 11:52:29 +05:30
context 'when the project has setting enforce_auth_checks_on_uploads true' do
before do
model.update!(enforce_auth_checks_on_uploads: true)
end
it "responds with status 404" do
show_upload
expect(response).to have_gitlab_http_status(:not_found)
2022-07-16 23:28:13 +05:30
end
end
2022-08-27 11:52:29 +05:30
context 'when the project has setting enforce_auth_checks_on_uploads false' do
2022-07-16 23:28:13 +05:30
before do
2022-08-27 11:52:29 +05:30
model.update!(enforce_auth_checks_on_uploads: false)
2022-07-16 23:28:13 +05:30
end
it "responds with status 200" do
show_upload
expect(response).to have_gitlab_http_status(:ok)
end
end
end
end
end
context 'when project is public' do
before do
model.update_attribute(:visibility_level, Gitlab::VisibilityLevel::PUBLIC)
end
context "when not signed in" do
2022-08-27 11:52:29 +05:30
context 'when the project has setting enforce_auth_checks_on_uploads true' do
before do
model.update!(enforce_auth_checks_on_uploads: true)
end
2022-07-16 23:28:13 +05:30
2022-08-27 11:52:29 +05:30
it "responds with status 200" do
show_upload
2022-07-16 23:28:13 +05:30
2022-08-27 11:52:29 +05:30
expect(response).to have_gitlab_http_status(:ok)
end
end
2022-07-16 23:28:13 +05:30
2022-08-27 11:52:29 +05:30
context 'when the project has setting enforce_auth_checks_on_uploads false' do
before do
model.update!(enforce_auth_checks_on_uploads: false)
2022-07-16 23:28:13 +05:30
end
2022-08-27 11:52:29 +05:30
it "responds with status 200" do
show_upload
2022-07-16 23:28:13 +05:30
2022-08-27 11:52:29 +05:30
expect(response).to have_gitlab_http_status(:ok)
2022-07-16 23:28:13 +05:30
end
end
end
context "when signed in" do
before do
sign_in(user)
end
context "when the user doesn't have access to the model" do
2022-08-27 11:52:29 +05:30
context 'when the project has setting enforce_auth_checks_on_uploads true' do
before do
model.update!(enforce_auth_checks_on_uploads: true)
end
it "responds with status 200" do
show_upload
expect(response).to have_gitlab_http_status(:ok)
2022-07-16 23:28:13 +05:30
end
end
2022-08-27 11:52:29 +05:30
context 'when the project has setting enforce_auth_checks_on_uploads false' do
2022-07-16 23:28:13 +05:30
before do
2022-08-27 11:52:29 +05:30
model.update!(enforce_auth_checks_on_uploads: false)
2022-07-16 23:28:13 +05:30
end
it "responds with status 200" do
show_upload
expect(response).to have_gitlab_http_status(:ok)
end
end
end
end
end
end
2018-11-08 19:23:39 +05:30
def post_authorize(verified: true)
request.headers.merge!(workhorse_internal_api_request_header) if verified
2019-02-15 15:39:39 +05:30
post :authorize, params: { namespace_id: model.namespace, project_id: model.path }, format: :json
2018-11-08 19:23:39 +05:30
end
2015-04-26 12:48:37 +05:30
end