debian-mirror-gitlab/spec/controllers/projects/pages_domains_controller_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

340 lines
10 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2017-08-17 22:00:37 +05:30
require 'spec_helper'
2020-06-23 00:09:42 +05:30
RSpec.describe Projects::PagesDomainsController do
2017-08-17 22:00:37 +05:30
let(:user) { create(:user) }
2017-09-10 17:25:29 +05:30
let(:project) { create(:project) }
2017-08-17 22:00:37 +05:30
let!(:pages_domain) { create(:pages_domain, project: project) }
let(:request_params) do
{
namespace_id: project.namespace,
project_id: project
}
end
let(:pages_domain_params) do
2019-09-30 21:07:59 +05:30
attributes_for(:pages_domain, domain: 'my.otherdomain.com').slice(:key, :certificate, :domain).tap do |params|
params[:user_provided_key] = params.delete(:key)
params[:user_provided_certificate] = params.delete(:certificate)
end
2017-08-17 22:00:37 +05:30
end
before do
allow(Gitlab.config.pages).to receive(:enabled).and_return(true)
sign_in(user)
2018-11-18 11:00:15 +05:30
project.add_maintainer(user)
2017-08-17 22:00:37 +05:30
end
describe 'GET show' do
2019-07-07 11:18:12 +05:30
def make_request
2019-02-15 15:39:39 +05:30
get(:show, params: request_params.merge(id: pages_domain.domain))
2019-07-07 11:18:12 +05:30
end
2017-08-17 22:00:37 +05:30
2020-01-01 13:55:28 +05:30
it "displays to the 'show' page" do
2019-07-07 11:18:12 +05:30
make_request
2019-12-26 22:10:19 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:ok)
2020-01-01 13:55:28 +05:30
expect(response).to render_template('show')
2017-08-17 22:00:37 +05:30
end
2019-07-07 11:18:12 +05:30
context 'when user is developer' do
before do
project.add_developer(user)
end
it 'renders 404 page' do
make_request
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2019-07-07 11:18:12 +05:30
end
end
2017-08-17 22:00:37 +05:30
end
describe 'GET new' do
it "displays the 'new' page" do
2019-02-15 15:39:39 +05:30
get(:new, params: request_params)
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:ok)
2017-08-17 22:00:37 +05:30
expect(response).to render_template('new')
end
end
describe 'POST create' do
it "creates a new pages domain" do
2022-11-25 23:54:43 +05:30
expect { post(:create, params: request_params.merge(pages_domain: pages_domain_params)) }
.to change { PagesDomain.count }.by(1)
.and publish_event(PagesDomains::PagesDomainCreatedEvent)
.with(
project_id: project.id,
namespace_id: project.namespace.id,
root_namespace_id: project.root_namespace.id,
domain: pages_domain_params[:domain]
)
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
created_domain = PagesDomain.reorder(:id).last
expect(created_domain).to be_present
2020-01-01 13:55:28 +05:30
expect(response).to redirect_to(project_pages_domain_path(project, created_domain))
2018-03-17 18:26:18 +05:30
end
end
2020-01-01 13:55:28 +05:30
describe 'GET show' do
it "displays the 'show' page" do
get(:show, params: request_params.merge(id: pages_domain.domain))
2018-03-27 19:54:05 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:ok)
2020-01-01 13:55:28 +05:30
expect(response).to render_template('show')
2018-03-27 19:54:05 +05:30
end
end
describe 'PATCH update' do
before do
controller.instance_variable_set(:@domain, pages_domain)
end
let(:params) do
request_params.merge(id: pages_domain.domain, pages_domain: pages_domain_params)
end
2019-09-30 21:07:59 +05:30
context 'with valid params' do
let(:pages_domain_params) do
attributes_for(:pages_domain, :with_trusted_chain).slice(:key, :certificate).tap do |params|
params[:user_provided_key] = params.delete(:key)
params[:user_provided_certificate] = params.delete(:certificate)
end
end
it 'updates the domain' do
expect do
patch(:update, params: params)
end.to change { pages_domain.reload.certificate }.to(pages_domain_params[:user_provided_certificate])
end
2022-11-25 23:54:43 +05:30
it 'publishes PagesDomainUpdatedEvent event' do
expect { patch(:update, params: params) }
.to publish_event(PagesDomains::PagesDomainUpdatedEvent)
.with(
project_id: project.id,
namespace_id: project.namespace.id,
root_namespace_id: project.root_namespace.id,
domain: pages_domain.domain
)
end
2019-09-30 21:07:59 +05:30
it 'redirects to the project page' do
patch(:update, params: params)
2018-03-27 19:54:05 +05:30
2019-09-30 21:07:59 +05:30
expect(flash[:notice]).to eq 'Domain was updated'
expect(response).to redirect_to(project_pages_path(project))
end
2018-03-27 19:54:05 +05:30
end
2019-09-30 21:07:59 +05:30
context 'with key parameter' do
before do
pages_domain.update!(key: nil, certificate: nil, certificate_source: 'gitlab_provided')
end
2018-03-27 19:54:05 +05:30
2019-09-30 21:07:59 +05:30
it 'marks certificate as provided by user' do
expect do
patch(:update, params: params)
end.to change { pages_domain.reload.certificate_source }.from('gitlab_provided').to('user_provided')
end
2018-03-27 19:54:05 +05:30
end
context 'the domain is invalid' do
2019-09-30 21:07:59 +05:30
let(:pages_domain_params) { { user_provided_certificate: 'blabla' } }
2018-03-27 19:54:05 +05:30
2020-01-01 13:55:28 +05:30
it 'renders the show action' do
2019-02-15 15:39:39 +05:30
patch(:update, params: params)
2018-03-27 19:54:05 +05:30
2020-01-01 13:55:28 +05:30
expect(response).to render_template('show')
2018-03-27 19:54:05 +05:30
end
2022-11-25 23:54:43 +05:30
it 'does not publish PagesDomainUpdatedEvent event' do
expect { patch(:update, params: params) }
.to not_publish_event(PagesDomains::PagesDomainUpdatedEvent)
end
2018-03-27 19:54:05 +05:30
end
2019-09-30 21:07:59 +05:30
context 'when parameters include the domain' do
it 'does not update domain' do
expect do
patch(:update, params: params.deep_merge(pages_domain: { domain: 'abc' }))
end.not_to change { pages_domain.reload.domain }
2018-03-27 19:54:05 +05:30
end
end
end
2018-03-17 18:26:18 +05:30
describe 'POST verify' do
let(:params) { request_params.merge(id: pages_domain.domain) }
it 'handles verification success' do
2020-05-24 23:13:21 +05:30
expect_next_instance_of(VerifyPagesDomainService, pages_domain) do |service|
expect(service).to receive(:execute).and_return(status: :success)
end
2018-03-17 18:26:18 +05:30
2019-02-15 15:39:39 +05:30
post :verify, params: params
2018-03-17 18:26:18 +05:30
2020-01-01 13:55:28 +05:30
expect(response).to redirect_to project_pages_domain_path(project, pages_domain)
2018-03-17 18:26:18 +05:30
expect(flash[:notice]).to eq('Successfully verified domain ownership')
end
it 'handles verification failure' do
2020-05-24 23:13:21 +05:30
expect_next_instance_of(VerifyPagesDomainService, pages_domain) do |service|
expect(service).to receive(:execute).and_return(status: :failed)
end
2018-03-17 18:26:18 +05:30
2019-02-15 15:39:39 +05:30
post :verify, params: params
2018-03-17 18:26:18 +05:30
2020-01-01 13:55:28 +05:30
expect(response).to redirect_to project_pages_domain_path(project, pages_domain)
2018-03-17 18:26:18 +05:30
expect(flash[:alert]).to eq('Failed to verify domain ownership')
end
it 'returns a 404 response for an unknown domain' do
2019-02-15 15:39:39 +05:30
post :verify, params: request_params.merge(id: 'unknown-domain')
2018-03-17 18:26:18 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2017-08-17 22:00:37 +05:30
end
end
2020-04-22 19:07:51 +05:30
describe 'POST retry_auto_ssl' do
before do
pages_domain.update!(auto_ssl_enabled: true, auto_ssl_failed: true)
end
let(:params) { request_params.merge(id: pages_domain.domain) }
it 'calls retry service and redirects' do
expect_next_instance_of(PagesDomains::RetryAcmeOrderService, pages_domain) do |service|
expect(service).to receive(:execute)
end
post :retry_auto_ssl, params: params
expect(response).to redirect_to project_pages_domain_path(project, pages_domain)
end
end
2017-08-17 22:00:37 +05:30
describe 'DELETE destroy' do
it "deletes the pages domain" do
2022-11-25 23:54:43 +05:30
expect { delete(:destroy, params: request_params.merge(id: pages_domain.domain)) }
.to change(PagesDomain, :count).by(-1)
.and publish_event(PagesDomains::PagesDomainDeletedEvent)
.with(
project_id: project.id,
namespace_id: project.namespace.id,
root_namespace_id: project.root_namespace.id,
domain: pages_domain.domain
)
2017-08-17 22:00:37 +05:30
2017-09-10 17:25:29 +05:30
expect(response).to redirect_to(project_pages_path(project))
2017-08-17 22:00:37 +05:30
end
end
2019-12-26 22:10:19 +05:30
describe 'DELETE #clean_certificate' do
subject do
delete(:clean_certificate, params: request_params.merge(id: pages_domain.domain))
end
2020-01-01 13:55:28 +05:30
it 'redirects to show page' do
2019-12-26 22:10:19 +05:30
subject
2020-01-01 13:55:28 +05:30
expect(response).to redirect_to(project_pages_domain_path(project, pages_domain))
2019-12-26 22:10:19 +05:30
end
2022-11-25 23:54:43 +05:30
it 'publishes PagesDomainUpdatedEvent event' do
expect { subject }
.to publish_event(PagesDomains::PagesDomainUpdatedEvent)
.with(
project_id: project.id,
namespace_id: project.namespace.id,
root_namespace_id: project.root_namespace.id,
domain: pages_domain.domain
)
end
2019-12-26 22:10:19 +05:30
it 'removes certificate' do
expect do
subject
end.to change { pages_domain.reload.certificate }.to(nil)
.and change { pages_domain.reload.key }.to(nil)
end
it 'sets certificate source to user_provided' do
pages_domain.update!(certificate_source: :gitlab_provided)
expect do
subject
end.to change { pages_domain.reload.certificate_source }.from("gitlab_provided").to("user_provided")
end
context 'when pages_https_only is set' do
before do
project.update!(pages_https_only: true)
stub_pages_setting(external_https: '127.0.0.1')
end
it 'does not remove certificate' do
subject
pages_domain.reload
expect(pages_domain.certificate).to be_present
expect(pages_domain.key).to be_present
end
2022-11-25 23:54:43 +05:30
it 'does not publish PagesDomainUpdatedEvent event' do
expect { subject }
.to not_publish_event(PagesDomains::PagesDomainUpdatedEvent)
end
2020-01-01 13:55:28 +05:30
it 'redirects to show page with a flash message' do
2019-12-26 22:10:19 +05:30
subject
expect(flash[:alert]).to include('Certificate')
expect(flash[:alert]).to include('Key')
2020-01-01 13:55:28 +05:30
expect(response).to redirect_to(project_pages_domain_path(project, pages_domain))
2019-12-26 22:10:19 +05:30
end
end
end
2017-08-17 22:00:37 +05:30
context 'pages disabled' do
before do
allow(Gitlab.config.pages).to receive(:enabled).and_return(false)
end
describe 'GET show' do
it 'returns 404 status' do
2019-02-15 15:39:39 +05:30
get(:show, params: request_params.merge(id: pages_domain.domain))
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2017-08-17 22:00:37 +05:30
end
end
describe 'GET new' do
it 'returns 404 status' do
2019-02-15 15:39:39 +05:30
get :new, params: request_params
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2017-08-17 22:00:37 +05:30
end
end
describe 'POST create' do
it "returns 404 status" do
2019-02-15 15:39:39 +05:30
post(:create, params: request_params.merge(pages_domain: pages_domain_params))
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2017-08-17 22:00:37 +05:30
end
end
describe 'DELETE destroy' do
it "deletes the pages domain" do
2019-02-15 15:39:39 +05:30
delete(:destroy, params: request_params.merge(id: pages_domain.domain))
2017-08-17 22:00:37 +05:30
2020-03-13 15:44:24 +05:30
expect(response).to have_gitlab_http_status(:not_found)
2017-08-17 22:00:37 +05:30
end
end
end
end