debian-mirror-gitlab/scripts/lint-rugged

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

54 lines
1.8 KiB
Text
Raw Normal View History

2018-03-17 18:26:18 +05:30
#!/usr/bin/env ruby
2021-03-11 19:13:27 +05:30
# frozen_string_literal: true
2018-03-17 18:26:18 +05:30
ALLOWED = [
2019-10-12 21:52:04 +05:30
# https://gitlab.com/gitlab-org/gitaly/issues/760
'lib/elasticsearch/git/repository.rb',
2018-12-05 23:21:45 +05:30
# Needed to handle repositories that are not in any storage
2018-03-17 18:26:18 +05:30
'lib/gitlab/bare_repository_import/repository.rb',
2018-11-18 11:00:15 +05:30
# Needed to avoid using the git binary to validate a branch name
2019-05-03 19:53:19 +05:30
'lib/gitlab/git_ref_validator.rb',
# Reverted Rugged calls due to Gitaly atop NFS performance
# See https://docs.gitlab.com/ee/development/gitaly.html#legacy-rugged-code.
'lib/gitlab/git/rugged_impl/',
2019-10-12 21:52:04 +05:30
'lib/gitlab/gitaly_client/storage_settings.rb',
2020-04-08 14:13:33 +05:30
# Needed to detect Rugged enabled: https://gitlab.com/gitlab-org/gitlab/issues/35371
'lib/gitlab/config_checker/puma_rugged_checker.rb',
2021-01-29 00:20:46 +05:30
# Needed for GPG/X509 commit signature API
#
'app/models/commit.rb',
'lib/api/entities/commit_signature.rb',
2019-10-12 21:52:04 +05:30
# Needed for logging
'config/initializers/peek.rb',
'config/initializers/lograge.rb',
'lib/gitlab/grape_logging/loggers/perf_logger.rb',
'lib/gitlab/instrumentation_helper.rb',
2021-04-29 21:17:54 +05:30
'lib/gitlab/sidekiq_middleware/instrumentation_logger.rb',
2019-10-12 21:52:04 +05:30
'lib/gitlab/rugged_instrumentation.rb',
'lib/peek/views/rugged.rb'
2018-03-17 18:26:18 +05:30
].freeze
rugged_lines = IO.popen(%w[git grep -i -n rugged -- app config lib], &:read).lines
rugged_lines = rugged_lines.select { |l| /^[^:]*\.rb:/ =~ l }
rugged_lines = rugged_lines.reject { |l| l.start_with?(*ALLOWED) }
2020-04-08 14:13:33 +05:30
rugged_lines = rugged_lines.reject { |l| /(include|prepend) Gitlab::Git::RuggedImpl/ =~ l }
rugged_lines = rugged_lines.reject { |l| l.include?('Gitlab::ConfigChecker::PumaRuggedChecker.check') }
2018-03-17 18:26:18 +05:30
rugged_lines = rugged_lines.reject do |line|
code, _comment = line.split('# ', 2)
code !~ /rugged/i
end
exit if rugged_lines.empty?
puts "Using Rugged is only allowed in test and #{ALLOWED}\n\n"
puts rugged_lines
exit(false)