debian-mirror-gitlab/spec/services/notes/destroy_service_spec.rb

89 lines
3.3 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2016-06-02 11:05:42 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe Notes::DestroyService do
2020-03-13 15:44:24 +05:30
let_it_be(:project) { create(:project, :public) }
let_it_be(:issue) { create(:issue, project: project) }
2021-09-30 23:02:18 +05:30
2018-03-17 18:26:18 +05:30
let(:user) { issue.author }
2016-06-02 11:05:42 +05:30
describe '#execute' do
it 'deletes a note' do
note = create(:note, project: project, noteable: issue)
2018-03-17 18:26:18 +05:30
described_class.new(project, user).execute(note)
2016-06-02 11:05:42 +05:30
expect(project.issues.find(issue.id).notes).not_to include(note)
end
2018-03-17 18:26:18 +05:30
it 'updates the todo counts for users with todos for the note' do
note = create(:note, project: project, noteable: issue)
create(:todo, note: note, target: issue, user: user, author: user, project: project)
expect { described_class.new(project, user).execute(note) }
.to change { user.todos_pending_count }.from(1).to(0)
end
2018-12-13 13:39:08 +05:30
2021-01-29 00:20:46 +05:30
it 'tracks issue comment removal usage data', :clean_gitlab_redis_shared_state do
note = create(:note, project: project, noteable: issue)
event = Gitlab::UsageDataCounters::IssueActivityUniqueCounter::ISSUE_COMMENT_REMOVED
counter = Gitlab::UsageDataCounters::HLLRedisCounter
expect(Gitlab::UsageDataCounters::IssueActivityUniqueCounter).to receive(:track_issue_comment_removed_action).with(author: user).and_call_original
expect do
described_class.new(project, user).execute(note)
end.to change { counter.unique_events(event_names: event, start_date: 1.day.ago, end_date: 1.day.from_now) }.by(1)
end
2021-03-08 18:12:59 +05:30
it 'tracks merge request usage data' do
mr = create(:merge_request, source_project: project)
note = create(:note, project: project, noteable: mr)
expect(Gitlab::UsageDataCounters::MergeRequestActivityUniqueCounter).to receive(:track_remove_comment_action).with(note: note)
described_class.new(project, user).execute(note)
end
2021-01-29 00:20:46 +05:30
context 'in a merge request' do
let_it_be(:repo_project) { create(:project, :repository) }
let_it_be(:merge_request) do
2018-12-13 13:39:08 +05:30
create(:merge_request, source_project: repo_project,
2021-01-29 00:20:46 +05:30
target_project: repo_project)
2018-12-13 13:39:08 +05:30
end
2021-01-29 00:20:46 +05:30
let_it_be(:note) do
2018-12-13 13:39:08 +05:30
create(:diff_note_on_merge_request, project: repo_project,
2021-01-29 00:20:46 +05:30
noteable: merge_request)
2018-12-13 13:39:08 +05:30
end
2021-01-29 00:20:46 +05:30
it 'does not track issue comment removal usage data' do
expect(Gitlab::UsageDataCounters::IssueActivityUniqueCounter).not_to receive(:track_issue_comment_removed_action)
2018-12-13 13:39:08 +05:30
described_class.new(repo_project, user).execute(note)
end
2021-01-29 00:20:46 +05:30
context 'noteable highlight cache clearing' do
before do
allow(note.position).to receive(:unfolded_diff?) { true }
end
it 'clears noteable diff cache when it was unfolded for the note position' do
expect(merge_request).to receive_message_chain(:diffs, :clear_cache)
described_class.new(repo_project, user).execute(note)
end
it 'does not clear cache when note is not the first of the discussion' do
reply_note = create(:diff_note_on_merge_request, in_reply_to: note,
project: repo_project,
noteable: merge_request)
2018-12-13 13:39:08 +05:30
2021-01-29 00:20:46 +05:30
expect(merge_request).not_to receive(:diffs)
2018-12-13 13:39:08 +05:30
2021-01-29 00:20:46 +05:30
described_class.new(repo_project, user).execute(reply_note)
end
2018-12-13 13:39:08 +05:30
end
end
2016-06-02 11:05:42 +05:30
end
end