debian-mirror-gitlab/spec/services/merge_requests/close_service_spec.rb

125 lines
4 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2014-09-02 18:07:02 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe MergeRequests::CloseService do
2014-09-02 18:07:02 +05:30
let(:user) { create(:user) }
let(:user2) { create(:user) }
2016-09-13 17:45:13 +05:30
let(:guest) { create(:user) }
2019-07-31 22:56:46 +05:30
let(:merge_request) { create(:merge_request, assignees: [user2], author: create(:user)) }
2014-09-02 18:07:02 +05:30
let(:project) { merge_request.project }
2016-04-02 18:10:28 +05:30
let!(:todo) { create(:todo, :assigned, user: user, project: project, target: merge_request, author: user2) }
2014-09-02 18:07:02 +05:30
before do
2018-11-18 11:00:15 +05:30
project.add_maintainer(user)
2018-03-17 18:26:18 +05:30
project.add_developer(user2)
project.add_guest(guest)
2014-09-02 18:07:02 +05:30
end
2016-08-24 12:49:21 +05:30
describe '#execute' do
2017-08-17 22:00:37 +05:30
it_behaves_like 'cache counters invalidator'
2021-03-08 18:12:59 +05:30
it_behaves_like 'merge request reviewers cache counters invalidator'
2017-08-17 22:00:37 +05:30
2021-01-03 14:25:43 +05:30
context 'valid params' do
2021-06-08 01:23:25 +05:30
let(:service) { described_class.new(project: project, current_user: user) }
2015-04-26 12:48:37 +05:30
2021-01-03 14:25:43 +05:30
before do
allow(service).to receive(:execute_hooks)
2015-04-26 12:48:37 +05:30
2021-01-03 14:25:43 +05:30
perform_enqueued_jobs do
@merge_request = service.execute(merge_request)
2015-12-23 02:04:40 +05:30
end
2021-01-03 14:25:43 +05:30
end
2014-09-02 18:07:02 +05:30
2021-01-03 14:25:43 +05:30
it { expect(@merge_request).to be_valid }
it { expect(@merge_request).to be_closed }
2015-04-26 12:48:37 +05:30
2021-01-03 14:25:43 +05:30
it 'executes hooks with close action' do
expect(service).to have_received(:execute_hooks)
.with(@merge_request, 'close')
end
2014-09-02 18:07:02 +05:30
2021-01-03 14:25:43 +05:30
it 'sends email to user2 about assign of new merge_request', :sidekiq_might_not_need_inline do
email = ActionMailer::Base.deliveries.last
expect(email.to.first).to eq(user2.email)
expect(email.subject).to include(merge_request.title)
end
2014-09-02 18:07:02 +05:30
2021-01-03 14:25:43 +05:30
it 'creates a resource event' do
event = @merge_request.resource_state_events.last
expect(event.state).to eq('closed')
end
2016-04-02 18:10:28 +05:30
2021-01-03 14:25:43 +05:30
it 'marks todos as done' do
expect(todo.reload).to be_done
end
2019-09-04 21:01:54 +05:30
2022-01-26 12:08:38 +05:30
it 'removes attention requested state' do
expect(merge_request.find_assignee(user2).attention_requested?).to eq(false)
end
2021-01-03 14:25:43 +05:30
context 'when auto merge is enabled' do
let(:merge_request) { create(:merge_request, :merge_when_pipeline_succeeds) }
2019-09-04 21:01:54 +05:30
2021-01-03 14:25:43 +05:30
it 'cancels the auto merge' do
expect(@merge_request).not_to be_auto_merge_enabled
2019-09-04 21:01:54 +05:30
end
end
2014-09-02 18:07:02 +05:30
end
2016-09-13 17:45:13 +05:30
2018-03-17 18:26:18 +05:30
it 'updates metrics' do
metrics = merge_request.metrics
metrics_service = double(MergeRequestMetricsService)
allow(MergeRequestMetricsService)
.to receive(:new)
.with(metrics)
.and_return(metrics_service)
expect(metrics_service).to receive(:close)
2021-06-08 01:23:25 +05:30
described_class.new(project: project, current_user: user).execute(merge_request)
2018-03-17 18:26:18 +05:30
end
2021-03-08 18:12:59 +05:30
it 'calls the merge request activity counter' do
expect(Gitlab::UsageDataCounters::MergeRequestActivityUniqueCounter)
.to receive(:track_close_mr_action)
.with(user: user)
2021-06-08 01:23:25 +05:30
described_class.new(project: project, current_user: user).execute(merge_request)
2021-03-08 18:12:59 +05:30
end
2018-03-17 18:26:18 +05:30
it 'refreshes the number of open merge requests for a valid MR', :use_clean_rails_memory_store_caching do
2021-06-08 01:23:25 +05:30
service = described_class.new(project: project, current_user: user)
2018-03-17 18:26:18 +05:30
expect { service.execute(merge_request) }
.to change { project.open_merge_requests_count }.from(1).to(0)
end
2019-07-07 11:18:12 +05:30
it 'clean up environments for the merge request' do
2021-10-27 15:23:28 +05:30
expect_next_instance_of(::Environments::StopService) do |service|
2019-07-07 11:18:12 +05:30
expect(service).to receive(:execute_for_merge_request).with(merge_request)
end
2021-06-08 01:23:25 +05:30
described_class.new(project: project, current_user: user).execute(merge_request)
2019-07-07 11:18:12 +05:30
end
2020-11-24 15:15:51 +05:30
it 'schedules CleanupRefsService' do
expect(MergeRequests::CleanupRefsService).to receive(:schedule).with(merge_request)
2021-06-08 01:23:25 +05:30
described_class.new(project: project, current_user: user).execute(merge_request)
2020-11-24 15:15:51 +05:30
end
2016-09-13 17:45:13 +05:30
context 'current user is not authorized to close merge request' do
before do
perform_enqueued_jobs do
2021-06-08 01:23:25 +05:30
@merge_request = described_class.new(project: project, current_user: guest).execute(merge_request)
2016-09-13 17:45:13 +05:30
end
end
it 'does not close the merge request' do
expect(@merge_request).to be_open
end
end
2014-09-02 18:07:02 +05:30
end
end