debian-mirror-gitlab/spec/services/deployments/update_environment_service_spec.rb

377 lines
12 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2018-12-13 13:39:08 +05:30
require 'spec_helper'
2021-01-03 14:25:43 +05:30
RSpec.describe Deployments::UpdateEnvironmentService do
2018-12-13 13:39:08 +05:30
let(:user) { create(:user) }
2019-07-07 11:18:12 +05:30
let(:project) { create(:project, :repository) }
2021-04-17 20:07:23 +05:30
let(:options) { { name: environment_name } }
2020-03-13 15:44:24 +05:30
let(:pipeline) do
create(
:ci_pipeline,
sha: 'b83d6e391c22777fca1ed3012fce84f633d7fed0',
project: project
)
end
2018-12-13 13:39:08 +05:30
let(:job) do
create(:ci_build,
2019-12-21 20:55:43 +05:30
:with_deployment,
2020-03-13 15:44:24 +05:30
pipeline: pipeline,
2018-12-13 13:39:08 +05:30
ref: 'master',
tag: false,
2021-04-17 20:07:23 +05:30
environment: environment_name,
2018-12-13 13:39:08 +05:30
options: { environment: options },
project: project)
end
2019-05-30 16:15:17 +05:30
let(:deployment) { job.deployment }
2019-07-07 11:18:12 +05:30
let(:environment) { deployment.environment }
2021-04-17 20:07:23 +05:30
let(:environment_name) { 'production' }
2019-07-07 11:18:12 +05:30
subject(:service) { described_class.new(deployment) }
2018-12-13 13:39:08 +05:30
before do
2021-01-03 14:25:43 +05:30
allow(Deployments::LinkMergeRequestWorker).to receive(:perform_async)
2021-06-08 01:23:25 +05:30
allow(Deployments::HooksWorker).to receive(:perform_async)
2018-12-13 13:39:08 +05:30
job.success! # Create/Succeed deployment
end
describe '#execute' do
let(:store) { Gitlab::EtagCaching::Store.new }
it 'invalidates the environment etag cache' do
old_value = store.get(environment.etag_cache_key)
2019-07-07 11:18:12 +05:30
service.execute
2018-12-13 13:39:08 +05:30
expect(store.get(environment.etag_cache_key)).not_to eq(old_value)
end
it 'creates ref' do
expect_any_instance_of(Repository)
.to receive(:create_ref)
2020-04-08 14:13:33 +05:30
.with(deployment.sha, "refs/environments/production/deployments/#{deployment.iid}")
2018-12-13 13:39:08 +05:30
2019-07-07 11:18:12 +05:30
service.execute
2018-12-13 13:39:08 +05:30
end
it 'updates merge request metrics' do
expect_any_instance_of(Deployment)
.to receive(:update_merge_request_metrics!)
2019-07-07 11:18:12 +05:30
service.execute
end
it 'returns the deployment' do
expect(subject.execute).to eq(deployment)
end
it 'returns the deployment when could not save the environment' do
allow(environment).to receive(:save).and_return(false)
expect(subject.execute).to eq(deployment)
end
it 'returns the deployment when environment is stopped' do
allow(environment).to receive(:stopped?).and_return(true)
expect(subject.execute).to eq(deployment)
2018-12-13 13:39:08 +05:30
end
context 'when start action is defined' do
let(:options) { { name: 'production', action: 'start' } }
context 'and environment is stopped' do
before do
environment.stop
end
it 'makes environment available' do
2019-07-07 11:18:12 +05:30
service.execute
2018-12-13 13:39:08 +05:30
expect(environment.reload).to be_available
end
end
end
2021-09-04 01:27:46 +05:30
context 'when external URL is specified and the tier is unset' do
let(:options) { { name: 'production', url: external_url } }
before do
environment.update_columns(external_url: external_url, tier: nil)
job.update!(environment: 'production')
end
context 'when external URL is valid' do
let(:external_url) { 'https://google.com' }
it 'succeeds to update the tier automatically' do
expect { subject.execute }.to change { environment.tier }.from(nil).to('production')
end
end
context 'when external URL is invalid' do
let(:external_url) { 'google.com' }
it 'fails to update the tier due to validation error' do
expect { subject.execute }.not_to change { environment.tier }
end
it 'tracks an exception' do
expect(Gitlab::ErrorTracking).to receive(:track_exception)
.with(an_instance_of(described_class::EnvironmentUpdateFailure),
project_id: project.id,
environment_id: environment.id,
reason: %q{External url is blocked: Only allowed schemes are http, https})
.once
subject.execute
end
end
end
2018-12-13 13:39:08 +05:30
context 'when variables are used' do
let(:options) do
{ name: 'review-apps/$CI_COMMIT_REF_NAME',
url: 'http://$CI_COMMIT_REF_NAME.review-apps.gitlab.com' }
end
before do
2021-01-03 14:25:43 +05:30
environment.update!(name: 'review-apps/master')
job.update!(environment: 'review-apps/$CI_COMMIT_REF_NAME')
2018-12-13 13:39:08 +05:30
end
it 'does not create a new environment' do
2019-07-07 11:18:12 +05:30
expect { subject.execute }.not_to change { Environment.count }
2018-12-13 13:39:08 +05:30
end
it 'updates external url' do
2019-07-07 11:18:12 +05:30
subject.execute
2018-12-13 13:39:08 +05:30
expect(subject.environment.name).to eq('review-apps/master')
expect(subject.environment.external_url).to eq('http://master.review-apps.gitlab.com')
end
end
2020-01-01 13:55:28 +05:30
context 'when auto_stop_in are used' do
let(:options) do
{ name: 'production', auto_stop_in: '1 day' }
end
it 'renews auto stop at' do
2020-11-24 15:15:51 +05:30
freeze_time do
2020-01-01 13:55:28 +05:30
environment.update!(auto_stop_at: nil)
expect { subject.execute }
.to change { environment.reset.auto_stop_at&.round }.from(nil).to(1.day.since.round)
end
end
end
2021-04-17 20:07:23 +05:30
context 'when deployment tier is specified' do
let(:environment_name) { 'customer-portal' }
let(:options) { { name: environment_name, deployment_tier: 'production' } }
context 'when tier has already been set' do
before do
environment.update_column(:tier, Environment.tiers[:other])
end
it 'overwrites the guessed tier by the specified deployment tier' do
expect { subject.execute }
.to change { environment.reset.tier }.from('other').to('production')
end
end
context 'when tier has not been set' do
before do
environment.update_column(:tier, nil)
end
it 'sets the specified deployment tier' do
expect { subject.execute }
.to change { environment.reset.tier }.from(nil).to('production')
end
context 'when deployment was created by an external CD system' do
before do
deployment.update_column(:deployable_id, nil)
2021-06-08 01:23:25 +05:30
deployment.reload
2021-04-17 20:07:23 +05:30
end
it 'guesses the deployment tier' do
expect { subject.execute }
.to change { environment.reset.tier }.from(nil).to('other')
end
end
end
end
context 'when deployment tier is not specified' do
let(:environment_name) { 'customer-portal' }
let(:options) { { name: environment_name } }
it 'guesses the deployment tier' do
environment.update_column(:tier, nil)
expect { subject.execute }
.to change { environment.reset.tier }.from(nil).to('other')
end
end
2018-12-13 13:39:08 +05:30
end
describe '#expanded_environment_url' do
subject { service.send(:expanded_environment_url) }
context 'when yaml environment uses $CI_COMMIT_REF_NAME' do
let(:job) do
create(:ci_build,
2019-12-21 20:55:43 +05:30
:with_deployment,
2020-03-13 15:44:24 +05:30
pipeline: pipeline,
2018-12-13 13:39:08 +05:30
ref: 'master',
environment: 'production',
project: project,
options: { environment: { name: 'production', url: 'http://review/$CI_COMMIT_REF_NAME' } })
end
it { is_expected.to eq('http://review/master') }
end
context 'when yaml environment uses $CI_ENVIRONMENT_SLUG' do
let(:job) do
create(:ci_build,
2019-12-21 20:55:43 +05:30
:with_deployment,
2020-03-13 15:44:24 +05:30
pipeline: pipeline,
2018-12-13 13:39:08 +05:30
ref: 'master',
environment: 'prod-slug',
project: project,
options: { environment: { name: 'prod-slug', url: 'http://review/$CI_ENVIRONMENT_SLUG' } })
end
it { is_expected.to eq('http://review/prod-slug') }
end
context 'when yaml environment uses yaml_variables containing symbol keys' do
let(:job) do
create(:ci_build,
2019-12-21 20:55:43 +05:30
:with_deployment,
2020-03-13 15:44:24 +05:30
pipeline: pipeline,
2018-12-13 13:39:08 +05:30
yaml_variables: [{ key: :APP_HOST, value: 'host' }],
environment: 'production',
project: project,
options: { environment: { name: 'production', url: 'http://review/$APP_HOST' } })
end
it { is_expected.to eq('http://review/host') }
end
2020-04-08 14:13:33 +05:30
context 'when job variables are generated during runtime' do
let(:job) do
create(:ci_build,
:with_deployment,
pipeline: pipeline,
environment: 'review/$CI_COMMIT_REF_NAME',
project: project,
job_variables: [job_variable],
options: { environment: { name: 'review/$CI_COMMIT_REF_NAME', url: 'http://$DYNAMIC_ENV_URL' } })
end
let(:job_variable) do
build(:ci_job_variable, :dotenv_source, key: 'DYNAMIC_ENV_URL', value: 'abc.test.com')
end
it 'expands the environment URL from the dynamic variable' do
is_expected.to eq('http://abc.test.com')
end
end
2018-12-13 13:39:08 +05:30
context 'when yaml environment does not have url' do
2020-03-13 15:44:24 +05:30
let(:job) { create(:ci_build, :with_deployment, pipeline: pipeline, environment: 'staging', project: project) }
2018-12-13 13:39:08 +05:30
it 'returns the external_url from persisted environment' do
is_expected.to be_nil
end
end
end
describe "merge request metrics" do
let(:merge_request) { create(:merge_request, target_branch: 'master', source_branch: 'feature', source_project: project) }
context "while updating the 'first_deployed_to_production_at' time" do
before do
merge_request.metrics.update!(merged_at: 1.hour.ago)
end
context "for merge requests merged before the current deploy" do
it "sets the time if the deploy's environment is 'production'" do
service.execute
expect(merge_request.reload.metrics.first_deployed_to_production_at).to be_like_time(deployment.finished_at)
end
context 'when job deploys to staging' do
let(:job) do
create(:ci_build,
2019-12-21 20:55:43 +05:30
:with_deployment,
2020-03-13 15:44:24 +05:30
pipeline: pipeline,
2018-12-13 13:39:08 +05:30
ref: 'master',
tag: false,
environment: 'staging',
options: { environment: { name: 'staging' } },
project: project)
end
it "doesn't set the time if the deploy's environment is not 'production'" do
service.execute
expect(merge_request.reload.metrics.first_deployed_to_production_at).to be_nil
end
end
it 'does not raise errors if the merge request does not have a metrics record' do
2021-01-03 14:25:43 +05:30
merge_request.metrics.destroy!
2018-12-13 13:39:08 +05:30
expect(merge_request.reload.metrics).to be_nil
expect { service.execute }.not_to raise_error
end
end
context "for merge requests merged before the previous deploy" do
context "if the 'first_deployed_to_production_at' time is already set" do
it "does not overwrite the older 'first_deployed_to_production_at' time" do
# Previous deploy
service.execute
expect(merge_request.reload.metrics.first_deployed_to_production_at).to be_like_time(deployment.finished_at)
# Current deploy
2021-01-03 14:25:43 +05:30
travel_to(12.hours.from_now) do
2018-12-13 13:39:08 +05:30
service.execute
expect(merge_request.reload.metrics.first_deployed_to_production_at).to be_like_time(deployment.finished_at)
end
end
end
context "if the 'first_deployed_to_production_at' time is not already set" do
it "does not overwrite the older 'first_deployed_to_production_at' time" do
# Previous deploy
time = 5.minutes.from_now
2021-01-03 14:25:43 +05:30
travel_to(time) { service.execute }
2018-12-13 13:39:08 +05:30
expect(merge_request.reload.metrics.merged_at).to be < merge_request.reload.metrics.first_deployed_to_production_at
previous_time = merge_request.reload.metrics.first_deployed_to_production_at
# Current deploy
2021-01-03 14:25:43 +05:30
travel_to(time + 12.hours) { service.execute }
2018-12-13 13:39:08 +05:30
expect(merge_request.reload.metrics.first_deployed_to_production_at).to eq(previous_time)
end
end
end
end
end
end