debian-mirror-gitlab/spec/validators/url_validator_spec.rb

130 lines
3.1 KiB
Ruby
Raw Normal View History

2018-03-27 19:54:05 +05:30
require 'spec_helper'
describe UrlValidator do
2018-11-08 19:23:39 +05:30
let!(:badge) { build(:badge, link_url: 'http://www.example.com') }
2018-03-27 19:54:05 +05:30
subject { validator.validate_each(badge, :link_url, badge.link_url) }
2018-11-08 19:23:39 +05:30
include_examples 'url validator examples', described_class::DEFAULT_PROTOCOLS
2018-11-29 20:51:05 +05:30
describe 'validations' do
include_context 'invalid urls'
let(:validator) { described_class.new(attributes: [:link_url]) }
it 'returns error when url is nil' do
expect(validator.validate_each(badge, :link_url, nil)).to be_nil
expect(badge.errors.first[1]).to eq 'must be a valid URL'
end
it 'returns error when url is empty' do
expect(validator.validate_each(badge, :link_url, '')).to be_nil
expect(badge.errors.first[1]).to eq 'must be a valid URL'
end
it 'does not allow urls with CR or LF characters' do
aggregate_failures do
urls_with_CRLF.each do |url|
expect(validator.validate_each(badge, :link_url, url)[0]).to eq 'is blocked: URI is invalid'
end
end
end
end
2018-11-08 19:23:39 +05:30
context 'by default' do
let(:validator) { described_class.new(attributes: [:link_url]) }
it 'does not block urls pointing to localhost' do
badge.link_url = 'https://127.0.0.1'
subject
expect(badge.errors.empty?).to be true
end
it 'does not block urls pointing to the local network' do
badge.link_url = 'https://192.168.1.1'
subject
expect(badge.errors.empty?).to be true
end
end
context 'when allow_localhost is set to false' do
let(:validator) { described_class.new(attributes: [:link_url], allow_localhost: false) }
it 'blocks urls pointing to localhost' do
badge.link_url = 'https://127.0.0.1'
subject
expect(badge.errors.empty?).to be false
end
end
context 'when allow_local_network is set to false' do
let(:validator) { described_class.new(attributes: [:link_url], allow_local_network: false) }
it 'blocks urls pointing to the local network' do
badge.link_url = 'https://192.168.1.1'
2018-03-27 19:54:05 +05:30
2018-11-08 19:23:39 +05:30
subject
expect(badge.errors.empty?).to be false
end
end
context 'when ports is' do
let(:validator) { described_class.new(attributes: [:link_url], ports: ports) }
context 'empty' do
let(:ports) { [] }
it 'does not block any port' do
subject
expect(badge.errors.empty?).to be true
2018-03-27 19:54:05 +05:30
end
2018-11-08 19:23:39 +05:30
end
2018-03-27 19:54:05 +05:30
2018-11-08 19:23:39 +05:30
context 'set' do
let(:ports) { [443] }
2018-03-27 19:54:05 +05:30
2018-11-08 19:23:39 +05:30
it 'blocks urls with a different port' do
2018-03-27 19:54:05 +05:30
subject
expect(badge.errors.empty?).to be false
end
end
2018-11-08 19:23:39 +05:30
end
context 'when enforce_user is' do
let(:url) { 'http://$user@example.com'}
let(:validator) { described_class.new(attributes: [:link_url], enforce_user: enforce_user) }
2018-03-27 19:54:05 +05:30
2018-11-08 19:23:39 +05:30
context 'true' do
let(:enforce_user) { true }
2018-03-27 19:54:05 +05:30
2018-11-08 19:23:39 +05:30
it 'checks user format' do
badge.link_url = url
2018-03-27 19:54:05 +05:30
subject
2018-11-08 19:23:39 +05:30
expect(badge.errors.empty?).to be false
2018-03-27 19:54:05 +05:30
end
2018-11-08 19:23:39 +05:30
end
context 'false (default)' do
let(:enforce_user) { false }
2018-03-27 19:54:05 +05:30
2018-11-08 19:23:39 +05:30
it 'does not check user format' do
badge.link_url = url
2018-03-27 19:54:05 +05:30
subject
2018-11-08 19:23:39 +05:30
expect(badge.errors.empty?).to be true
2018-03-27 19:54:05 +05:30
end
end
end
end