2018-03-17 18:26:18 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe API::Applications, :api do
|
|
|
|
include ApiHelpers
|
|
|
|
|
|
|
|
let(:admin_user) { create(:user, admin: true) }
|
|
|
|
let(:user) { create(:user, admin: false) }
|
|
|
|
|
|
|
|
describe 'POST /applications' do
|
|
|
|
context 'authenticated and authorized user' do
|
|
|
|
it 'creates and returns an OAuth application' do
|
|
|
|
expect do
|
|
|
|
post api('/applications', admin_user), name: 'application_name', redirect_uri: 'http://application.url', scopes: ''
|
|
|
|
end.to change { Doorkeeper::Application.count }.by 1
|
|
|
|
|
|
|
|
application = Doorkeeper::Application.find_by(name: 'application_name', redirect_uri: 'http://application.url')
|
|
|
|
|
|
|
|
expect(response).to have_http_status 201
|
|
|
|
expect(json_response).to be_a Hash
|
|
|
|
expect(json_response['application_id']).to eq application.uid
|
|
|
|
expect(json_response['secret']).to eq application.secret
|
|
|
|
expect(json_response['callback_url']).to eq application.redirect_uri
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not allow creating an application with the wrong redirect_uri format' do
|
|
|
|
expect do
|
2018-11-29 20:51:05 +05:30
|
|
|
post api('/applications', admin_user), name: 'application_name', redirect_uri: 'http://', scopes: ''
|
2018-03-17 18:26:18 +05:30
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
|
|
|
expect(response).to have_http_status 400
|
|
|
|
expect(json_response).to be_a Hash
|
|
|
|
expect(json_response['message']['redirect_uri'][0]).to eq('must be an absolute URI.')
|
|
|
|
end
|
|
|
|
|
2018-11-29 20:51:05 +05:30
|
|
|
it 'does not allow creating an application with a forbidden URI format' do
|
|
|
|
expect do
|
|
|
|
post api('/applications', admin_user), name: 'application_name', redirect_uri: 'javascript://alert()', scopes: ''
|
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(400)
|
|
|
|
expect(json_response).to be_a Hash
|
|
|
|
expect(json_response['message']['redirect_uri'][0]).to eq('is forbidden by the server.')
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it 'does not allow creating an application without a name' do
|
|
|
|
expect do
|
|
|
|
post api('/applications', admin_user), redirect_uri: 'http://application.url', scopes: ''
|
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
|
|
|
expect(response).to have_http_status 400
|
|
|
|
expect(json_response).to be_a Hash
|
|
|
|
expect(json_response['error']).to eq('name is missing')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not allow creating an application without a redirect_uri' do
|
|
|
|
expect do
|
|
|
|
post api('/applications', admin_user), name: 'application_name', scopes: ''
|
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
|
|
|
expect(response).to have_http_status 400
|
|
|
|
expect(json_response).to be_a Hash
|
|
|
|
expect(json_response['error']).to eq('redirect_uri is missing')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not allow creating an application without scopes' do
|
|
|
|
expect do
|
|
|
|
post api('/applications', admin_user), name: 'application_name', redirect_uri: 'http://application.url'
|
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
|
|
|
expect(response).to have_http_status 400
|
|
|
|
expect(json_response).to be_a Hash
|
|
|
|
expect(json_response['error']).to eq('scopes is missing')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'authorized user without authorization' do
|
|
|
|
it 'does not create application' do
|
|
|
|
expect do
|
|
|
|
post api('/applications', user), name: 'application_name', redirect_uri: 'http://application.url', scopes: ''
|
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
|
|
|
expect(response).to have_http_status 403
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'non-authenticated user' do
|
|
|
|
it 'does not create application' do
|
|
|
|
expect do
|
|
|
|
post api('/applications'), name: 'application_name', redirect_uri: 'http://application.url'
|
|
|
|
end.not_to change { Doorkeeper::Application.count }
|
|
|
|
|
|
|
|
expect(response).to have_http_status 401
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|