2019-07-31 22:56:46 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-04-26 12:48:37 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe MergeRequests::ReopenService do
|
2015-04-26 12:48:37 +05:30
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:user2) { create(:user) }
|
2016-09-13 17:45:13 +05:30
|
|
|
let(:guest) { create(:user) }
|
2019-07-31 22:56:46 +05:30
|
|
|
let(:merge_request) { create(:merge_request, :closed, assignees: [user2], author: create(:user)) }
|
2015-04-26 12:48:37 +05:30
|
|
|
let(:project) { merge_request.project }
|
|
|
|
|
|
|
|
before do
|
2018-11-18 11:00:15 +05:30
|
|
|
project.add_maintainer(user)
|
2018-03-17 18:26:18 +05:30
|
|
|
project.add_developer(user2)
|
|
|
|
project.add_guest(guest)
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
describe '#execute' do
|
2017-08-17 22:00:37 +05:30
|
|
|
it_behaves_like 'cache counters invalidator'
|
|
|
|
|
2015-04-26 12:48:37 +05:30
|
|
|
context 'valid params' do
|
2016-09-13 17:45:13 +05:30
|
|
|
let(:service) { described_class.new(project, user, {}) }
|
2020-06-23 00:09:42 +05:30
|
|
|
let(:state_tracking) { true }
|
2015-04-26 12:48:37 +05:30
|
|
|
|
|
|
|
before do
|
2020-06-23 00:09:42 +05:30
|
|
|
stub_feature_flags(track_resource_state_change_events: state_tracking)
|
|
|
|
|
2015-04-26 12:48:37 +05:30
|
|
|
allow(service).to receive(:execute_hooks)
|
|
|
|
|
2015-12-23 02:04:40 +05:30
|
|
|
perform_enqueued_jobs do
|
|
|
|
service.execute(merge_request)
|
|
|
|
end
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it { expect(merge_request).to be_valid }
|
2017-09-10 17:25:29 +05:30
|
|
|
it { expect(merge_request).to be_opened }
|
2015-04-26 12:48:37 +05:30
|
|
|
|
2016-09-13 17:45:13 +05:30
|
|
|
it 'executes hooks with reopen action' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(service).to have_received(:execute_hooks)
|
|
|
|
.with(merge_request, 'reopen')
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
|
|
|
|
2019-12-26 22:10:19 +05:30
|
|
|
it 'sends email to user2 about reopen of merge_request', :sidekiq_might_not_need_inline do
|
2015-04-26 12:48:37 +05:30
|
|
|
email = ActionMailer::Base.deliveries.last
|
|
|
|
expect(email.to.first).to eq(user2.email)
|
|
|
|
expect(email.subject).to include(merge_request.title)
|
|
|
|
end
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
context 'note creation' do
|
|
|
|
context 'when state event tracking is disabled' do
|
|
|
|
let(:state_tracking) { false }
|
|
|
|
|
|
|
|
it 'creates system note about merge_request reopen' do
|
|
|
|
note = merge_request.notes.last
|
|
|
|
expect(note.note).to include 'reopened'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when state event tracking is enabled' do
|
|
|
|
it 'creates resource state event about merge_request reopen' do
|
|
|
|
event = merge_request.resource_state_events.last
|
|
|
|
expect(event.state).to eq('reopened')
|
|
|
|
end
|
|
|
|
end
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
|
|
|
end
|
2016-09-13 17:45:13 +05:30
|
|
|
|
2018-11-18 11:00:15 +05:30
|
|
|
it 'caches merge request closing issues' do
|
|
|
|
expect(merge_request).to receive(:cache_merge_request_closes_issues!)
|
|
|
|
|
|
|
|
described_class.new(project, user, {}).execute(merge_request)
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it 'updates metrics' do
|
|
|
|
metrics = merge_request.metrics
|
|
|
|
service = double(MergeRequestMetricsService)
|
|
|
|
allow(MergeRequestMetricsService)
|
|
|
|
.to receive(:new)
|
|
|
|
.with(metrics)
|
|
|
|
.and_return(service)
|
|
|
|
|
|
|
|
expect(service).to receive(:reopen)
|
|
|
|
|
|
|
|
described_class.new(project, user, {}).execute(merge_request)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'refreshes the number of open merge requests for a valid MR' do
|
|
|
|
service = described_class.new(project, user, {})
|
|
|
|
|
|
|
|
expect { service.execute(merge_request) }
|
|
|
|
.to change { project.open_merge_requests_count }.from(0).to(1)
|
|
|
|
end
|
|
|
|
|
2016-09-13 17:45:13 +05:30
|
|
|
context 'current user is not authorized to reopen merge request' do
|
|
|
|
before do
|
|
|
|
perform_enqueued_jobs do
|
|
|
|
@merge_request = described_class.new(project, guest).execute(merge_request)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not reopen the merge request' do
|
|
|
|
expect(@merge_request).to be_closed
|
|
|
|
end
|
|
|
|
end
|
2015-04-26 12:48:37 +05:30
|
|
|
end
|
|
|
|
end
|