2020-04-08 14:13:33 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'digest'
|
|
|
|
|
|
|
|
module Gitlab
|
|
|
|
module SidekiqMiddleware
|
|
|
|
module DuplicateJobs
|
|
|
|
# This class defines an identifier of a job in a queue
|
|
|
|
# The identifier based on a job's class and arguments.
|
|
|
|
#
|
|
|
|
# As strategy decides when to keep track of the job in redis and when to
|
|
|
|
# remove it.
|
|
|
|
#
|
|
|
|
# Storing the deduplication key in redis can be done by calling `check!`
|
|
|
|
# check returns the `jid` of the job if it was scheduled, or the `jid` of
|
|
|
|
# the duplicate job if it was already scheduled
|
|
|
|
#
|
|
|
|
# When new jobs can be scheduled again, the strategy calls `#delete`.
|
|
|
|
class DuplicateJob
|
2021-11-11 11:23:49 +05:30
|
|
|
include Gitlab::Utils::StrongMemoize
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
DEFAULT_DUPLICATE_KEY_TTL = 6.hours
|
2021-11-11 11:23:49 +05:30
|
|
|
WAL_LOCATION_TTL = 60.seconds
|
|
|
|
MAX_REDIS_RETRIES = 5
|
2020-06-23 00:09:42 +05:30
|
|
|
DEFAULT_STRATEGY = :until_executing
|
2021-09-04 01:27:46 +05:30
|
|
|
STRATEGY_NONE = :none
|
2021-12-11 22:18:48 +05:30
|
|
|
DEDUPLICATED_FLAG_VALUE = 1
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
LUA_SET_WAL_SCRIPT = <<~EOS
|
|
|
|
local key, wal, offset, ttl = KEYS[1], ARGV[1], tonumber(ARGV[2]), ARGV[3]
|
|
|
|
local existing_offset = redis.call("LINDEX", key, -1)
|
|
|
|
if existing_offset == false then
|
|
|
|
redis.call("RPUSH", key, wal, offset)
|
|
|
|
redis.call("EXPIRE", key, ttl)
|
|
|
|
elseif offset > tonumber(existing_offset) then
|
|
|
|
redis.call("LSET", key, 0, wal)
|
|
|
|
redis.call("LSET", key, -1, offset)
|
|
|
|
end
|
|
|
|
EOS
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
attr_reader :existing_jid
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
def initialize(job, queue_name)
|
2020-04-08 14:13:33 +05:30
|
|
|
@job = job
|
|
|
|
@queue_name = queue_name
|
|
|
|
end
|
|
|
|
|
|
|
|
# This will continue the middleware chain if the job should be scheduled
|
|
|
|
# It will return false if the job needs to be cancelled
|
|
|
|
def schedule(&block)
|
|
|
|
Strategies.for(strategy).new(self).schedule(job, &block)
|
|
|
|
end
|
|
|
|
|
|
|
|
# This will continue the server middleware chain if the job should be
|
|
|
|
# executed.
|
|
|
|
# It will return false if the job should not be executed.
|
|
|
|
def perform(&block)
|
|
|
|
Strategies.for(strategy).new(self).perform(job, &block)
|
|
|
|
end
|
|
|
|
|
|
|
|
# This method will return the jid that was set in redis
|
2021-12-11 22:18:48 +05:30
|
|
|
def check!(expiry = duplicate_key_ttl)
|
2020-04-08 14:13:33 +05:30
|
|
|
read_jid = nil
|
2021-11-11 11:23:49 +05:30
|
|
|
read_wal_locations = {}
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2022-07-23 23:45:48 +05:30
|
|
|
with_redis do |redis|
|
2020-04-08 14:13:33 +05:30
|
|
|
redis.multi do |multi|
|
2021-11-18 22:05:49 +05:30
|
|
|
multi.set(idempotency_key, jid, ex: expiry, nx: true)
|
|
|
|
read_wal_locations = check_existing_wal_locations!(multi, expiry)
|
|
|
|
read_jid = multi.get(idempotency_key)
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-09-04 01:27:46 +05:30
|
|
|
job['idempotency_key'] = idempotency_key
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
# We need to fetch values since the read_wal_locations and read_jid were obtained inside transaction, under redis.multi command.
|
|
|
|
self.existing_wal_locations = read_wal_locations.transform_values(&:value)
|
2020-04-08 14:13:33 +05:30
|
|
|
self.existing_jid = read_jid.value
|
|
|
|
end
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
def update_latest_wal_location!
|
|
|
|
return unless job_wal_locations.present?
|
|
|
|
|
2022-07-23 23:45:48 +05:30
|
|
|
with_redis do |redis|
|
2021-11-18 22:05:49 +05:30
|
|
|
redis.multi do |multi|
|
2021-11-11 11:23:49 +05:30
|
|
|
job_wal_locations.each do |connection_name, location|
|
2021-12-11 22:18:48 +05:30
|
|
|
multi.eval(
|
|
|
|
LUA_SET_WAL_SCRIPT,
|
|
|
|
keys: [wal_location_key(connection_name)],
|
|
|
|
argv: [location, pg_wal_lsn_diff(connection_name).to_i, WAL_LOCATION_TTL]
|
|
|
|
)
|
2021-11-11 11:23:49 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def latest_wal_locations
|
|
|
|
return {} unless job_wal_locations.present?
|
|
|
|
|
|
|
|
strong_memoize(:latest_wal_locations) do
|
|
|
|
read_wal_locations = {}
|
|
|
|
|
2022-07-23 23:45:48 +05:30
|
|
|
with_redis do |redis|
|
2021-11-18 22:05:49 +05:30
|
|
|
redis.multi do |multi|
|
2021-11-11 11:23:49 +05:30
|
|
|
job_wal_locations.keys.each do |connection_name|
|
2021-11-18 22:05:49 +05:30
|
|
|
read_wal_locations[connection_name] = multi.lindex(wal_location_key(connection_name), 0)
|
2021-11-11 11:23:49 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
read_wal_locations.transform_values(&:value).compact
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
def delete!
|
2022-10-11 01:57:18 +05:30
|
|
|
Gitlab::Instrumentation::RedisClusterValidator.allow_cross_slot_commands do
|
|
|
|
with_redis do |redis|
|
|
|
|
redis.multi do |multi|
|
|
|
|
multi.del(idempotency_key, deduplicated_flag_key)
|
|
|
|
delete_wal_locations!(multi)
|
|
|
|
end
|
2021-11-11 11:23:49 +05:30
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
def reschedule
|
|
|
|
Gitlab::SidekiqLogging::DeduplicationLogger.instance.rescheduled_log(job)
|
|
|
|
|
|
|
|
worker_klass.perform_async(*arguments)
|
|
|
|
end
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
def scheduled?
|
|
|
|
scheduled_at.present?
|
|
|
|
end
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
def duplicate?
|
|
|
|
raise "Call `#check!` first to check for existing duplicates" unless existing_jid
|
|
|
|
|
|
|
|
jid != existing_jid
|
|
|
|
end
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
def set_deduplicated_flag!(expiry = duplicate_key_ttl)
|
|
|
|
return unless reschedulable?
|
|
|
|
|
2022-07-23 23:45:48 +05:30
|
|
|
with_redis do |redis|
|
2021-12-11 22:18:48 +05:30
|
|
|
redis.set(deduplicated_flag_key, DEDUPLICATED_FLAG_VALUE, ex: expiry, nx: true)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def should_reschedule?
|
|
|
|
return false unless reschedulable?
|
|
|
|
|
2022-07-23 23:45:48 +05:30
|
|
|
with_redis do |redis|
|
2021-12-11 22:18:48 +05:30
|
|
|
redis.get(deduplicated_flag_key).present?
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
def scheduled_at
|
|
|
|
job['at']
|
|
|
|
end
|
|
|
|
|
|
|
|
def options
|
|
|
|
return {} unless worker_klass
|
|
|
|
return {} unless worker_klass.respond_to?(:get_deduplication_options)
|
|
|
|
|
|
|
|
worker_klass.get_deduplication_options
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
|
|
|
|
2021-02-22 17:27:13 +05:30
|
|
|
def idempotent?
|
|
|
|
return false unless worker_klass
|
|
|
|
return false unless worker_klass.respond_to?(:idempotent?)
|
|
|
|
|
|
|
|
worker_klass.idempotent?
|
|
|
|
end
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
def duplicate_key_ttl
|
|
|
|
options[:ttl] || DEFAULT_DUPLICATE_KEY_TTL
|
|
|
|
end
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
private
|
|
|
|
|
2021-11-18 22:05:49 +05:30
|
|
|
attr_writer :existing_wal_locations
|
2020-06-23 00:09:42 +05:30
|
|
|
attr_reader :queue_name, :job
|
2020-04-08 14:13:33 +05:30
|
|
|
attr_writer :existing_jid
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
def worker_klass
|
|
|
|
@worker_klass ||= worker_class_name.to_s.safe_constantize
|
|
|
|
end
|
|
|
|
|
2021-11-18 22:05:49 +05:30
|
|
|
def delete_wal_locations!(redis)
|
|
|
|
job_wal_locations.keys.each do |connection_name|
|
|
|
|
redis.del(wal_location_key(connection_name))
|
|
|
|
redis.del(existing_wal_location_key(connection_name))
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def check_existing_wal_locations!(redis, expiry)
|
|
|
|
read_wal_locations = {}
|
|
|
|
|
|
|
|
job_wal_locations.each do |connection_name, location|
|
|
|
|
key = existing_wal_location_key(connection_name)
|
|
|
|
redis.set(key, location, ex: expiry, nx: true)
|
|
|
|
read_wal_locations[connection_name] = redis.get(key)
|
|
|
|
end
|
|
|
|
|
|
|
|
read_wal_locations
|
|
|
|
end
|
|
|
|
|
|
|
|
def job_wal_locations
|
|
|
|
job['wal_locations'] || {}
|
|
|
|
end
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
def pg_wal_lsn_diff(connection_name)
|
2021-12-11 22:18:48 +05:30
|
|
|
model = Gitlab::Database.database_base_models[connection_name]
|
|
|
|
|
|
|
|
model.connection.load_balancer.wal_diff(
|
|
|
|
job_wal_locations[connection_name],
|
|
|
|
existing_wal_locations[connection_name]
|
|
|
|
)
|
2021-11-11 11:23:49 +05:30
|
|
|
end
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
def strategy
|
|
|
|
return DEFAULT_STRATEGY unless worker_klass
|
|
|
|
return DEFAULT_STRATEGY unless worker_klass.respond_to?(:idempotent?)
|
2021-09-04 01:27:46 +05:30
|
|
|
return STRATEGY_NONE unless worker_klass.deduplication_enabled?
|
2020-06-23 00:09:42 +05:30
|
|
|
|
|
|
|
worker_klass.get_deduplicate_strategy
|
|
|
|
end
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
def worker_class_name
|
|
|
|
job['class']
|
|
|
|
end
|
|
|
|
|
|
|
|
def arguments
|
|
|
|
job['args']
|
|
|
|
end
|
|
|
|
|
|
|
|
def jid
|
|
|
|
job['jid']
|
|
|
|
end
|
|
|
|
|
2021-11-11 11:23:49 +05:30
|
|
|
def existing_wal_location_key(connection_name)
|
|
|
|
"#{idempotency_key}:#{connection_name}:existing_wal_location"
|
|
|
|
end
|
|
|
|
|
|
|
|
def wal_location_key(connection_name)
|
|
|
|
"#{idempotency_key}:#{connection_name}:wal_location"
|
|
|
|
end
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
def idempotency_key
|
2021-09-04 01:27:46 +05:30
|
|
|
@idempotency_key ||= job['idempotency_key'] || "#{namespace}:#{idempotency_hash}"
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
def deduplicated_flag_key
|
|
|
|
"#{idempotency_key}:deduplicate_flag"
|
|
|
|
end
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
def idempotency_hash
|
|
|
|
Digest::SHA256.hexdigest(idempotency_string)
|
|
|
|
end
|
|
|
|
|
|
|
|
def namespace
|
|
|
|
"#{Gitlab::Redis::Queues::SIDEKIQ_NAMESPACE}:duplicate:#{queue_name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
def idempotency_string
|
2021-09-30 23:02:18 +05:30
|
|
|
"#{worker_class_name}:#{Sidekiq.dump_json(arguments)}"
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
2021-11-11 11:23:49 +05:30
|
|
|
|
2021-11-18 22:05:49 +05:30
|
|
|
def existing_wal_locations
|
|
|
|
@existing_wal_locations ||= {}
|
2021-11-11 11:23:49 +05:30
|
|
|
end
|
|
|
|
|
2021-12-11 22:18:48 +05:30
|
|
|
def reschedulable?
|
|
|
|
!scheduled? && options[:if_deduplicated] == :reschedule_once
|
|
|
|
end
|
2022-07-23 23:45:48 +05:30
|
|
|
|
|
|
|
def with_redis
|
|
|
|
if Feature.enabled?(:use_primary_and_secondary_stores_for_duplicate_jobs) ||
|
|
|
|
Feature.enabled?(:use_primary_store_as_default_for_duplicate_jobs)
|
|
|
|
# TODO: Swap for Gitlab::Redis::SharedState after store transition
|
|
|
|
# https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/923
|
|
|
|
Gitlab::Redis::DuplicateJobs.with { |redis| yield redis }
|
|
|
|
else
|
|
|
|
# Keep the old behavior intact if neither feature flag is turned on
|
|
|
|
Sidekiq.redis { |redis| yield redis }
|
|
|
|
end
|
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|