2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2015-12-23 02:04:40 +05:30
|
|
|
require 'spec_helper'
|
|
|
|
require 'html/pipeline'
|
|
|
|
|
2021-04-29 21:17:54 +05:30
|
|
|
RSpec.describe Banzai::Filter::References::LabelReferenceFilter do
|
2015-12-23 02:04:40 +05:30
|
|
|
include FilterSpecHelper
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create(:project, :public, name: 'sample-project') }
|
2015-12-23 02:04:40 +05:30
|
|
|
let(:label) { create(:label, project: project) }
|
|
|
|
let(:reference) { label.to_reference }
|
|
|
|
|
2019-09-04 21:01:54 +05:30
|
|
|
it_behaves_like 'HTML text with references' do
|
|
|
|
let(:resource) { label }
|
|
|
|
let(:resource_text) { resource.title }
|
|
|
|
end
|
|
|
|
|
2015-12-23 02:04:40 +05:30
|
|
|
it 'requires project context' do
|
|
|
|
expect { described_class.call('') }.to raise_error(ArgumentError, /:project/)
|
|
|
|
end
|
|
|
|
|
|
|
|
%w(pre code a style).each do |elem|
|
|
|
|
it "ignores valid references contained inside '#{elem}' element" do
|
|
|
|
exp = act = "<#{elem}>Label #{reference}</#{elem}>"
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes default classes' do
|
|
|
|
doc = reference_filter("Label #{reference}")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.css('a').first.attr('class')).to eq 'gfm gfm-label has-tooltip gl-link gl-label-link'
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it 'avoids N+1 cached queries', :use_sql_query_cache, :request_store do
|
|
|
|
# Run this once to establish a baseline
|
|
|
|
reference_filter("Label #{reference}")
|
|
|
|
|
|
|
|
control_count = ActiveRecord::QueryRecorder.new(skip_cached: false) do
|
|
|
|
reference_filter("Label #{reference}")
|
|
|
|
end
|
|
|
|
|
|
|
|
labels_markdown = Array.new(10, "Label #{reference}").join('\n')
|
|
|
|
|
|
|
|
expect { reference_filter(labels_markdown) }.not_to exceed_all_query_limit(control_count.count)
|
|
|
|
end
|
|
|
|
|
2015-12-23 02:04:40 +05:30
|
|
|
it 'includes a data-project attribute' do
|
|
|
|
doc = reference_filter("Label #{reference}")
|
|
|
|
link = doc.css('a').first
|
|
|
|
|
|
|
|
expect(link).to have_attribute('data-project')
|
|
|
|
expect(link.attr('data-project')).to eq project.id.to_s
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes a data-label attribute' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
link = doc.css('a').first
|
|
|
|
|
|
|
|
expect(link).to have_attribute('data-label')
|
|
|
|
expect(link.attr('data-label')).to eq label.id.to_s
|
|
|
|
end
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
it 'includes protocol when :only_path not present' do
|
|
|
|
doc = reference_filter("Label #{reference}")
|
|
|
|
link = doc.css('a').first.attr('href')
|
|
|
|
|
|
|
|
expect(link).to match %r(https?://)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not include protocol when :only_path true' do
|
2015-12-23 02:04:40 +05:30
|
|
|
doc = reference_filter("Label #{reference}", only_path: true)
|
|
|
|
link = doc.css('a').first.attr('href')
|
|
|
|
|
|
|
|
expect(link).not_to match %r(https?://)
|
2020-06-23 00:09:42 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'links to issue list when :label_url_method is not present' do
|
|
|
|
doc = reference_filter("Label #{reference}", only_path: true)
|
|
|
|
link = doc.css('a').first.attr('href')
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(link).to eq urls.project_issues_path(project, label_name: label.name)
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
it 'links to merge request list when `label_url_method: :project_merge_requests_url`' do
|
|
|
|
doc = reference_filter("Label #{reference}", { only_path: true, label_url_method: "project_merge_requests_url" })
|
|
|
|
link = doc.css('a').first.attr('href')
|
|
|
|
|
|
|
|
expect(link).to eq urls.project_merge_requests_path(project, label_name: label.name)
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
context 'project that does not exist referenced' do
|
|
|
|
let(:result) { reference_filter('aaa/bbb~ccc') }
|
|
|
|
|
|
|
|
it 'does not link reference' do
|
|
|
|
expect(result.to_html).to eq 'aaa/bbb~ccc'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-12-23 02:04:40 +05:30
|
|
|
describe 'label span element' do
|
|
|
|
it 'includes default classes' do
|
|
|
|
doc = reference_filter("Label #{reference}")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.css('a span').first.attr('class')).to include 'gl-label-text'
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes a style attribute' do
|
|
|
|
doc = reference_filter("Label #{reference}")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.css('a span').first.attr('style')).to match(/\Abackground-color: #\h{6}\z/)
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'Integer-based references' do
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_issues_url(project, label_name: label.name)
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'links with adjacent text' do
|
|
|
|
doc = reference_filter("Label (#{reference}.)")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.to_html).to match(%r(\(<span.+><a.+><span.+>#{label.name}</span></a></span>\.\)))
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid label IDs' do
|
|
|
|
exp = act = "Label #{invalidate_reference(reference)}"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'String-based single-word references' do
|
|
|
|
let(:label) { create(:label, name: 'gfm', project: project) }
|
|
|
|
let(:reference) { "#{Label.reference_prefix}#{label.name}" }
|
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_issues_url(project, label_name: label.name)
|
2015-12-23 02:04:40 +05:30
|
|
|
expect(doc.text).to eq 'See gfm'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'links with adjacent text' do
|
2016-08-24 12:49:21 +05:30
|
|
|
doc = reference_filter("Label (#{reference}).")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.to_html).to match(%r(\(<span.+><a.+><span.+>#{label.name}</span></a></span>\)\.))
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid label names' do
|
|
|
|
exp = act = "Label #{Label.reference_prefix}#{label.name.reverse}"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
context 'String-based single-word references that begin with a digit' do
|
|
|
|
let(:label) { create(:label, name: '2fa', project: project) }
|
|
|
|
let(:reference) { "#{Label.reference_prefix}#{label.name}" }
|
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_issues_url(project, label_name: label.name)
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(doc.text).to eq 'See 2fa'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'links with adjacent text' do
|
|
|
|
doc = reference_filter("Label (#{reference}).")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.to_html).to match(%r(\(<span.+><a.+><span.+>#{label.name}</span></a></span>\)\.))
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid label names' do
|
|
|
|
exp = act = "Label #{Label.reference_prefix}#{label.id}#{label.name.reverse}"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'String-based single-word references with special characters' do
|
|
|
|
let(:label) { create(:label, name: '?g.fm&', project: project) }
|
|
|
|
let(:reference) { "#{Label.reference_prefix}#{label.name}" }
|
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_issues_url(project, label_name: label.name)
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(doc.text).to eq 'See ?g.fm&'
|
|
|
|
end
|
|
|
|
|
2018-11-08 19:23:39 +05:30
|
|
|
it 'does not include trailing punctuation', :aggregate_failures do
|
|
|
|
['.', ', ok?', '...', '?', '!', ': is that ok?'].each do |trailing_punctuation|
|
|
|
|
doc = filter("Label #{reference}#{trailing_punctuation}")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.to_html).to match(%r(<span.+><a.+><span.+>\?g\.fm&</span></a></span>#{Regexp.escape(trailing_punctuation)}))
|
2018-11-08 19:23:39 +05:30
|
|
|
end
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid label names' do
|
|
|
|
act = "Label #{Label.reference_prefix}#{label.name.reverse}"
|
|
|
|
exp = "Label #{Label.reference_prefix}&mf.g?"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-12-23 02:04:40 +05:30
|
|
|
context 'String-based multi-word references in quotes' do
|
|
|
|
let(:label) { create(:label, name: 'gfm references', project: project) }
|
2016-06-02 11:05:42 +05:30
|
|
|
let(:reference) { label.to_reference(format: :name) }
|
2015-12-23 02:04:40 +05:30
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_issues_url(project, label_name: label.name)
|
2015-12-23 02:04:40 +05:30
|
|
|
expect(doc.text).to eq 'See gfm references'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'links with adjacent text' do
|
|
|
|
doc = reference_filter("Label (#{reference}.)")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.to_html).to match(%r(\(<span.+><a.+><span.+>#{label.name}</span></a></span>\.\)))
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid label names' do
|
|
|
|
exp = act = %(Label #{Label.reference_prefix}"#{label.name.reverse}")
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
context 'String-based multi-word references that begin with a digit' do
|
|
|
|
let(:label) { create(:label, name: '2 factor authentication', project: project) }
|
|
|
|
let(:reference) { label.to_reference(format: :name) }
|
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_issues_url(project, label_name: label.name)
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(doc.text).to eq 'See 2 factor authentication'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'links with adjacent text' do
|
|
|
|
doc = reference_filter("Label (#{reference}.)")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.to_html).to match(%r(\(<span.+><a.+><span.+>#{label.name}</span></a></span>\.\)))
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid label names' do
|
|
|
|
exp = act = "Label #{Label.reference_prefix}#{label.id}#{label.name.reverse}"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'String-based multi-word references with special characters in quotes' do
|
|
|
|
let(:label) { create(:label, name: 'g.fm & references?', project: project) }
|
|
|
|
let(:reference) { label.to_reference(format: :name) }
|
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_issues_url(project, label_name: label.name)
|
2016-08-24 12:49:21 +05:30
|
|
|
expect(doc.text).to eq 'See g.fm & references?'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'links with adjacent text' do
|
|
|
|
doc = reference_filter("Label (#{reference}.)")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.to_html).to match(%r(\(<span.+><a.+><span.+>g\.fm & references\?</span></a></span>\.\)))
|
2016-08-24 12:49:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid label names' do
|
|
|
|
act = %(Label #{Label.reference_prefix}"#{label.name.reverse}")
|
|
|
|
exp = %(Label #{Label.reference_prefix}"?secnerefer & mf.g\")
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-01-03 12:48:30 +05:30
|
|
|
context 'References with html entities' do
|
2019-03-02 22:35:43 +05:30
|
|
|
let!(:label) { create(:label, name: '<html>', project: project) }
|
2019-01-03 12:48:30 +05:30
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter('See ~"<html>"')
|
|
|
|
|
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_issues_url(project, label_name: label.name)
|
|
|
|
expect(doc.text).to eq 'See <html>'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid label names and escapes entities' do
|
|
|
|
act = %(Label #{Label.reference_prefix}"<non valid>")
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq act
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-08-24 12:49:21 +05:30
|
|
|
describe 'consecutive references' do
|
|
|
|
let(:bug) { create(:label, name: 'bug', project: project) }
|
|
|
|
let(:feature_proposal) { create(:label, name: 'feature proposal', project: project) }
|
|
|
|
let(:technical_debt) { create(:label, name: 'technical debt', project: project) }
|
|
|
|
|
|
|
|
let(:bug_reference) { "#{Label.reference_prefix}#{bug.name}" }
|
|
|
|
let(:feature_proposal_reference) { feature_proposal.to_reference(format: :name) }
|
|
|
|
let(:technical_debt_reference) { technical_debt.to_reference(format: :name) }
|
|
|
|
|
|
|
|
context 'separated with a comma' do
|
|
|
|
let(:references) { "#{bug_reference}, #{feature_proposal_reference}, #{technical_debt_reference}" }
|
|
|
|
|
|
|
|
it 'links to valid references' do
|
|
|
|
doc = reference_filter("See #{references}")
|
|
|
|
|
|
|
|
expect(doc.css('a').map { |a| a.attr('href') }).to match_array([
|
2017-09-10 17:25:29 +05:30
|
|
|
urls.project_issues_url(project, label_name: bug.name),
|
|
|
|
urls.project_issues_url(project, label_name: feature_proposal.name),
|
|
|
|
urls.project_issues_url(project, label_name: technical_debt.name)
|
2016-08-24 12:49:21 +05:30
|
|
|
])
|
|
|
|
expect(doc.text).to eq 'See bug, feature proposal, technical debt'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'separated with a space' do
|
|
|
|
let(:references) { "#{bug_reference} #{feature_proposal_reference} #{technical_debt_reference}" }
|
|
|
|
|
|
|
|
it 'links to valid references' do
|
|
|
|
doc = reference_filter("See #{references}")
|
|
|
|
|
|
|
|
expect(doc.css('a').map { |a| a.attr('href') }).to match_array([
|
2017-09-10 17:25:29 +05:30
|
|
|
urls.project_issues_url(project, label_name: bug.name),
|
|
|
|
urls.project_issues_url(project, label_name: feature_proposal.name),
|
|
|
|
urls.project_issues_url(project, label_name: technical_debt.name)
|
2016-08-24 12:49:21 +05:30
|
|
|
])
|
|
|
|
expect(doc.text).to eq 'See bug feature proposal technical debt'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-12-23 02:04:40 +05:30
|
|
|
describe 'edge cases' do
|
|
|
|
it 'gracefully handles non-references matching the pattern' do
|
|
|
|
exp = act = '(format nil "~0f" 3.0) ; 3.0'
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'referencing a label in a link href' do
|
|
|
|
let(:reference) { %Q{<a href="#{label.to_reference}">Label</a>} }
|
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_issues_url(project, label_name: label.name)
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'links with adjacent text' do
|
|
|
|
doc = reference_filter("Label (#{reference}.)")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.to_html).to match(%r(\(<span.+><a.+>Label</a></span>\.\)))
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes a data-project attribute' do
|
|
|
|
doc = reference_filter("Label #{reference}")
|
|
|
|
link = doc.css('a').first
|
|
|
|
|
|
|
|
expect(link).to have_attribute('data-project')
|
|
|
|
expect(link.attr('data-project')).to eq project.id.to_s
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes a data-label attribute' do
|
|
|
|
doc = reference_filter("See #{reference}")
|
|
|
|
link = doc.css('a').first
|
|
|
|
|
|
|
|
expect(link).to have_attribute('data-label')
|
|
|
|
expect(link.attr('data-label')).to eq label.id.to_s
|
|
|
|
end
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2016-11-03 12:29:30 +05:30
|
|
|
describe 'group label references' do
|
|
|
|
let(:group) { create(:group) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create(:project, :public, namespace: group) }
|
2016-11-03 12:29:30 +05:30
|
|
|
let(:group_label) { create(:group_label, name: 'gfm references', group: group) }
|
|
|
|
|
|
|
|
context 'without project reference' do
|
|
|
|
let(:reference) { group_label.to_reference(format: :name) }
|
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}", project: project)
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_issues_url(project, label_name: group_label.name)
|
2016-11-03 12:29:30 +05:30
|
|
|
expect(doc.text).to eq 'See gfm references'
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'links with adjacent text' do
|
|
|
|
doc = reference_filter("Label (#{reference}.)")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.to_html).to match(%r(\(<span.+><a.+><span.+>#{group_label.name}</span></a></span>\.\)))
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid label names' do
|
|
|
|
exp = act = %(Label #{Label.reference_prefix}"#{group_label.name.reverse}")
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with project reference' do
|
2020-03-13 15:44:24 +05:30
|
|
|
let(:reference) { "#{project.to_reference_base}#{group_label.to_reference(format: :name)}" }
|
2016-11-03 12:29:30 +05:30
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
doc = reference_filter("See #{reference}", project: project)
|
|
|
|
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(doc.css('a').first.attr('href')).to eq urls
|
|
|
|
.project_issues_url(project, label_name: group_label.name)
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(doc.text).to eq "See gfm references"
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'links with adjacent text' do
|
|
|
|
doc = reference_filter("Label (#{reference}.)")
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(doc.to_html).to match(%r(\(<span.+><a.+><span.+>#{group_label.name}</span></a></span>\.\)))
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid label names' do
|
2020-03-13 15:44:24 +05:30
|
|
|
exp = act = %(Label #{project.to_reference_base}#{Label.reference_prefix}"#{group_label.name.reverse}")
|
2016-11-03 12:29:30 +05:30
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
describe 'cross-project / cross-namespace complete reference' do
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project2) { create(:project) }
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:label) { create(:label, project: project2, color: '#00ff00') }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:reference) { "#{project2.full_path}~#{label.name}" }
|
2017-08-17 22:00:37 +05:30
|
|
|
let!(:result) { reference_filter("See #{reference}") }
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'links to a valid reference' do
|
|
|
|
expect(result.css('a').first.attr('href'))
|
2017-09-10 17:25:29 +05:30
|
|
|
.to eq urls.project_issues_url(project2, label_name: label.name)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'has valid color' do
|
|
|
|
expect(result.css('a span').first.attr('style')).to match /background-color: #00ff00/
|
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'has valid link text' do
|
2018-03-27 19:54:05 +05:30
|
|
|
expect(result.css('a').first.text).to eq "#{label.name} in #{project2.full_name}"
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'has valid text' do
|
2018-03-27 19:54:05 +05:30
|
|
|
expect(result.text).to eq "See #{label.name} in #{project2.full_name}"
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'ignores invalid IDs on the referenced label' do
|
|
|
|
exp = act = "See #{invalidate_reference(reference)}"
|
2016-06-02 11:05:42 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'cross-project / same-namespace complete reference' do
|
|
|
|
let(:namespace) { create(:namespace) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create(:project, namespace: namespace) }
|
|
|
|
let(:project2) { create(:project, namespace: namespace) }
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:label) { create(:label, project: project2, color: '#00ff00') }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:reference) { "#{project2.full_path}~#{label.name}" }
|
2017-08-17 22:00:37 +05:30
|
|
|
let!(:result) { reference_filter("See #{reference}") }
|
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
expect(result.css('a').first.attr('href'))
|
2017-09-10 17:25:29 +05:30
|
|
|
.to eq urls.project_issues_url(project2, label_name: label.name)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid color' do
|
|
|
|
expect(result.css('a span').first.attr('style')).to match /background-color: #00ff00/
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid link text' do
|
|
|
|
expect(result.css('a').first.text).to eq "#{label.name} in #{project2.name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid text' do
|
|
|
|
expect(result.text).to eq "See #{label.name} in #{project2.name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid IDs on the referenced label' do
|
|
|
|
exp = act = "See #{invalidate_reference(reference)}"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'cross-project shorthand reference' do
|
|
|
|
let(:namespace) { create(:namespace) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create(:project, namespace: namespace) }
|
|
|
|
let(:project2) { create(:project, namespace: namespace) }
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:label) { create(:label, project: project2, color: '#00ff00') }
|
|
|
|
let(:reference) { "#{project2.path}~#{label.name}" }
|
|
|
|
let!(:result) { reference_filter("See #{reference}") }
|
|
|
|
|
|
|
|
it 'links to a valid reference' do
|
|
|
|
expect(result.css('a').first.attr('href'))
|
2017-09-10 17:25:29 +05:30
|
|
|
.to eq urls.project_issues_url(project2, label_name: label.name)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid color' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(result.css('a span').first.attr('style'))
|
|
|
|
.to match /background-color: #00ff00/
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid link text' do
|
|
|
|
expect(result.css('a').first.text).to eq "#{label.name} in #{project2.name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid text' do
|
|
|
|
expect(result.text).to eq "See #{label.name} in #{project2.name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid IDs on the referenced label' do
|
|
|
|
exp = act = "See #{invalidate_reference(reference)}"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
2016-06-02 11:05:42 +05:30
|
|
|
end
|
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
|
|
|
|
describe 'cross group label references' do
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:group) { create(:group) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create(:project, :public, namespace: group) }
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:another_group) { create(:group) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:another_project) { create(:project, :public, namespace: another_group) }
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:group_label) { create(:group_label, group: another_group, color: '#00ff00') }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:reference) { "#{another_project.full_path}~#{group_label.name}" }
|
2017-08-17 22:00:37 +05:30
|
|
|
let!(:result) { reference_filter("See #{reference}", project: project) }
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'points to referenced project issues page' do
|
|
|
|
expect(result.css('a').first.attr('href'))
|
2017-09-10 17:25:29 +05:30
|
|
|
.to eq urls.project_issues_url(another_project, label_name: group_label.name)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
2016-11-03 12:29:30 +05:30
|
|
|
|
2017-08-17 22:00:37 +05:30
|
|
|
it 'has valid color' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(result.css('a span').first.attr('style'))
|
|
|
|
.to match /background-color: #00ff00/
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid link text' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(result.css('a').first.text)
|
2018-03-27 19:54:05 +05:30
|
|
|
.to eq "#{group_label.name} in #{another_project.full_name}"
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid text' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(result.text)
|
2018-03-27 19:54:05 +05:30
|
|
|
.to eq "See #{group_label.name} in #{another_project.full_name}"
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid IDs on the referenced label' do
|
|
|
|
exp = act = "See #{invalidate_reference(reference)}"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
2019-12-04 20:38:33 +05:30
|
|
|
|
|
|
|
context 'when group name has HTML entities' do
|
2020-03-28 13:19:24 +05:30
|
|
|
let(:another_group) { create(:group, name: 'random', path: 'another_group') }
|
|
|
|
|
|
|
|
before do
|
|
|
|
another_group.name = "<img src=x onerror=alert(1)>"
|
|
|
|
another_group.save!(validate: false)
|
|
|
|
end
|
2019-12-04 20:38:33 +05:30
|
|
|
|
|
|
|
it 'escapes the HTML entities' do
|
|
|
|
expect(result.text)
|
|
|
|
.to eq "See #{group_label.name} in #{another_project.full_name}"
|
|
|
|
end
|
|
|
|
end
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe 'cross-project / same-group_label complete reference' do
|
|
|
|
let(:group) { create(:group) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create(:project, :public, namespace: group) }
|
|
|
|
let(:another_project) { create(:project, :public, namespace: group) }
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:group_label) { create(:group_label, group: group, color: '#00ff00') }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:reference) { "#{another_project.full_path}~#{group_label.name}" }
|
2017-08-17 22:00:37 +05:30
|
|
|
let!(:result) { reference_filter("See #{reference}", project: project) }
|
|
|
|
|
|
|
|
it 'points to referenced project issues page' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(result.css('a').first.attr('href'))
|
|
|
|
.to eq urls.project_issues_url(another_project, label_name: group_label.name)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid color' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(result.css('a span').first.attr('style'))
|
|
|
|
.to match /background-color: #00ff00/
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid link text' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(result.css('a').first.text)
|
|
|
|
.to eq "#{group_label.name} in #{another_project.name}"
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid text' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(result.text)
|
|
|
|
.to eq "See #{group_label.name} in #{another_project.name}"
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid IDs on the referenced label' do
|
|
|
|
exp = act = "See #{invalidate_reference(reference)}"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'same project / same group_label complete reference' do
|
|
|
|
let(:group) { create(:group) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create(:project, :public, namespace: group) }
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:group_label) { create(:group_label, group: group, color: '#00ff00') }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:reference) { "#{project.full_path}~#{group_label.name}" }
|
2017-08-17 22:00:37 +05:30
|
|
|
let!(:result) { reference_filter("See #{reference}", project: project) }
|
|
|
|
|
|
|
|
it 'points to referenced project issues page' do
|
|
|
|
expect(result.css('a').first.attr('href'))
|
2017-09-10 17:25:29 +05:30
|
|
|
.to eq urls.project_issues_url(project, label_name: group_label.name)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid color' do
|
|
|
|
expect(result.css('a span').first.attr('style'))
|
|
|
|
.to match /background-color: #00ff00/
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid link text' do
|
|
|
|
expect(result.css('a').first.text).to eq group_label.name
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid text' do
|
|
|
|
expect(result.text).to eq "See #{group_label.name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid IDs on the referenced label' do
|
|
|
|
exp = act = "See #{invalidate_reference(reference)}"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'same project / same group_label shorthand reference' do
|
|
|
|
let(:group) { create(:group) }
|
2017-09-10 17:25:29 +05:30
|
|
|
let(:project) { create(:project, :public, namespace: group) }
|
2017-08-17 22:00:37 +05:30
|
|
|
let(:group_label) { create(:group_label, group: group, color: '#00ff00') }
|
|
|
|
let(:reference) { "#{project.path}~#{group_label.name}" }
|
|
|
|
let!(:result) { reference_filter("See #{reference}", project: project) }
|
|
|
|
|
|
|
|
it 'points to referenced project issues page' do
|
|
|
|
expect(result.css('a').first.attr('href'))
|
2017-09-10 17:25:29 +05:30
|
|
|
.to eq urls.project_issues_url(project, label_name: group_label.name)
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid color' do
|
2017-09-10 17:25:29 +05:30
|
|
|
expect(result.css('a span').first.attr('style'))
|
|
|
|
.to match /background-color: #00ff00/
|
2017-08-17 22:00:37 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid link text' do
|
|
|
|
expect(result.css('a').first.text).to eq group_label.name
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'has valid text' do
|
|
|
|
expect(result.text).to eq "See #{group_label.name}"
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'ignores invalid IDs on the referenced label' do
|
|
|
|
exp = act = "See #{invalidate_reference(reference)}"
|
|
|
|
|
|
|
|
expect(reference_filter(act).to_html).to eq exp
|
2016-11-03 12:29:30 +05:30
|
|
|
end
|
|
|
|
end
|
2018-03-17 18:26:18 +05:30
|
|
|
|
|
|
|
describe 'group context' do
|
2018-05-09 12:01:36 +05:30
|
|
|
it 'points to the page defined in label_url_method' do
|
|
|
|
group = create(:group)
|
|
|
|
label = create(:group_label, group: group)
|
|
|
|
reference = "~#{label.name}"
|
|
|
|
|
|
|
|
result = reference_filter("See #{reference}", { project: nil, group: group, label_url_method: :group_url } )
|
|
|
|
|
|
|
|
expect(result.css('a').first.attr('href')).to eq(urls.group_url(group, label_name: label.name))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'finds labels also in ancestor groups' do
|
|
|
|
group = create(:group)
|
|
|
|
label = create(:group_label, group: group)
|
|
|
|
subgroup = create(:group, parent: group)
|
|
|
|
reference = "~#{label.name}"
|
|
|
|
|
|
|
|
result = reference_filter("See #{reference}", { project: nil, group: subgroup, label_url_method: :group_url } )
|
|
|
|
|
|
|
|
expect(result.css('a').first.attr('href')).to eq(urls.group_url(subgroup, label_name: label.name))
|
|
|
|
end
|
|
|
|
|
2018-03-17 18:26:18 +05:30
|
|
|
it 'points to referenced project issues page' do
|
|
|
|
project = create(:project)
|
|
|
|
label = create(:label, project: project)
|
|
|
|
reference = "#{project.full_path}~#{label.name}"
|
|
|
|
|
|
|
|
result = reference_filter("See #{reference}", { project: nil, group: create(:group) } )
|
|
|
|
|
|
|
|
expect(result.css('a').first.attr('href')).to eq(urls.project_issues_url(project, label_name: label.name))
|
2018-05-09 12:01:36 +05:30
|
|
|
expect(result.css('a').first.text).to eq "#{label.name} in #{project.full_name}"
|
2018-03-17 18:26:18 +05:30
|
|
|
end
|
|
|
|
end
|
2015-12-23 02:04:40 +05:30
|
|
|
end
|