2020-05-24 23:13:21 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
RSpec.describe AlertManagement::AlertsFinder, '#execute' do
|
2020-05-24 23:13:21 +05:30
|
|
|
let_it_be(:current_user) { create(:user) }
|
|
|
|
let_it_be(:project) { create(:project) }
|
2020-10-24 23:57:45 +05:30
|
|
|
let_it_be(:resolved_alert) { create(:alert_management_alert, :all_fields, :resolved, project: project, ended_at: 1.year.ago, events: 2, severity: :high) }
|
|
|
|
let_it_be(:ignored_alert) { create(:alert_management_alert, :all_fields, :ignored, project: project, events: 1, severity: :critical) }
|
|
|
|
let_it_be(:triggered_alert) { create(:alert_management_alert, :all_fields) }
|
2020-05-24 23:13:21 +05:30
|
|
|
let(:params) { {} }
|
|
|
|
|
|
|
|
describe '#execute' do
|
2020-07-28 23:09:34 +05:30
|
|
|
subject(:execute) { described_class.new(current_user, project, params).execute }
|
2020-05-24 23:13:21 +05:30
|
|
|
|
|
|
|
context 'user is not a developer or above' do
|
|
|
|
it { is_expected.to be_empty }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'user is developer' do
|
|
|
|
before do
|
|
|
|
project.add_developer(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'empty params' do
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to contain_exactly(resolved_alert, ignored_alert) }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'iid given' do
|
2020-10-24 23:57:45 +05:30
|
|
|
let(:params) { { iid: resolved_alert.iid } }
|
2020-05-24 23:13:21 +05:30
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to match_array(resolved_alert) }
|
2020-05-24 23:13:21 +05:30
|
|
|
|
|
|
|
context 'unknown iid' do
|
|
|
|
let(:params) { { iid: 'unknown' } }
|
|
|
|
|
|
|
|
it { is_expected.to be_empty }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'status given' do
|
|
|
|
let(:params) { { status: AlertManagement::Alert::STATUSES[:resolved] } }
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to match_array(resolved_alert) }
|
2020-05-24 23:13:21 +05:30
|
|
|
|
|
|
|
context 'with an array of statuses' do
|
2020-10-24 23:57:45 +05:30
|
|
|
let(:triggered_alert) { create(:alert_management_alert) }
|
2020-05-24 23:13:21 +05:30
|
|
|
let(:params) { { status: [AlertManagement::Alert::STATUSES[:resolved]] } }
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to match_array(resolved_alert) }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'with no alerts of status' do
|
|
|
|
let(:params) { { status: AlertManagement::Alert::STATUSES[:acknowledged] } }
|
|
|
|
|
|
|
|
it { is_expected.to be_empty }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with an empty status array' do
|
|
|
|
let(:params) { { status: [] } }
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to match_array([resolved_alert, ignored_alert]) }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'with an nil status' do
|
|
|
|
let(:params) { { status: nil } }
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to match_array([resolved_alert, ignored_alert]) }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'sorting' do
|
|
|
|
context 'when sorting by created' do
|
|
|
|
context 'sorts alerts ascending' do
|
|
|
|
let(:params) { { sort: 'created_asc' } }
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to eq [resolved_alert, ignored_alert] }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'sorts alerts descending' do
|
|
|
|
let(:params) { { sort: 'created_desc' } }
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to eq [ignored_alert, resolved_alert] }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when sorting by updated' do
|
|
|
|
context 'sorts alerts ascending' do
|
|
|
|
let(:params) { { sort: 'updated_asc' } }
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to eq [resolved_alert, ignored_alert] }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'sorts alerts descending' do
|
|
|
|
let(:params) { { sort: 'updated_desc' } }
|
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to eq [ignored_alert, resolved_alert] }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when sorting by start time' do
|
|
|
|
context 'sorts alerts ascending' do
|
2020-06-23 00:09:42 +05:30
|
|
|
let(:params) { { sort: 'started_at_asc' } }
|
2020-05-24 23:13:21 +05:30
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to eq [resolved_alert, ignored_alert] }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'sorts alerts descending' do
|
2020-06-23 00:09:42 +05:30
|
|
|
let(:params) { { sort: 'started_at_desc' } }
|
2020-05-24 23:13:21 +05:30
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to eq [ignored_alert, resolved_alert] }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when sorting by end time' do
|
|
|
|
context 'sorts alerts ascending' do
|
2020-06-23 00:09:42 +05:30
|
|
|
let(:params) { { sort: 'ended_at_asc' } }
|
2020-05-24 23:13:21 +05:30
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to eq [resolved_alert, ignored_alert] }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'sorts alerts descending' do
|
2020-06-23 00:09:42 +05:30
|
|
|
let(:params) { { sort: 'ended_at_desc' } }
|
2020-05-24 23:13:21 +05:30
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to eq [ignored_alert, resolved_alert] }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when sorting by events count' do
|
|
|
|
let_it_be(:alert_count_6) { create(:alert_management_alert, project: project, events: 6) }
|
|
|
|
let_it_be(:alert_count_3) { create(:alert_management_alert, project: project, events: 3) }
|
|
|
|
|
|
|
|
context 'sorts alerts ascending' do
|
2020-06-23 00:09:42 +05:30
|
|
|
let(:params) { { sort: 'event_count_asc' } }
|
2020-05-24 23:13:21 +05:30
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to eq [ignored_alert, resolved_alert, alert_count_3, alert_count_6] }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'sorts alerts descending' do
|
2020-06-23 00:09:42 +05:30
|
|
|
let(:params) { { sort: 'event_count_desc' } }
|
2020-05-24 23:13:21 +05:30
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
it { is_expected.to eq [alert_count_6, alert_count_3, resolved_alert, ignored_alert] }
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when sorting by severity' do
|
2020-07-28 23:09:34 +05:30
|
|
|
let_it_be(:alert_critical) { create(:alert_management_alert, :critical, project: project) }
|
|
|
|
let_it_be(:alert_high) { create(:alert_management_alert, :high, project: project) }
|
|
|
|
let_it_be(:alert_medium) { create(:alert_management_alert, :medium, project: project) }
|
|
|
|
let_it_be(:alert_low) { create(:alert_management_alert, :low, project: project) }
|
|
|
|
let_it_be(:alert_info) { create(:alert_management_alert, :info, project: project) }
|
|
|
|
let_it_be(:alert_unknown) { create(:alert_management_alert, :unknown, project: project) }
|
|
|
|
|
|
|
|
context 'with ascending sort order' do
|
2020-05-24 23:13:21 +05:30
|
|
|
let(:params) { { sort: 'severity_asc' } }
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
it 'sorts alerts by severity from less critical to more critical' do
|
|
|
|
expect(execute.pluck(:severity).uniq).to eq(%w(unknown info low medium high critical))
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
context 'with descending sort order' do
|
2020-05-24 23:13:21 +05:30
|
|
|
let(:params) { { sort: 'severity_desc' } }
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
it 'sorts alerts by severity from more critical to less critical' do
|
|
|
|
expect(execute.pluck(:severity).uniq).to eq(%w(critical high medium low info unknown))
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when sorting by status' do
|
2020-07-28 23:09:34 +05:30
|
|
|
let(:statuses) { AlertManagement::Alert::STATUSES }
|
|
|
|
let(:triggered) { statuses[:triggered] }
|
|
|
|
let(:acknowledged) { statuses[:acknowledged] }
|
|
|
|
let(:resolved) { statuses[:resolved] }
|
|
|
|
let(:ignored) { statuses[:ignored] }
|
|
|
|
|
2020-05-24 23:13:21 +05:30
|
|
|
let_it_be(:alert_triggered) { create(:alert_management_alert, project: project) }
|
|
|
|
let_it_be(:alert_acknowledged) { create(:alert_management_alert, :acknowledged, project: project) }
|
|
|
|
let_it_be(:alert_resolved) { create(:alert_management_alert, :resolved, project: project) }
|
|
|
|
let_it_be(:alert_ignored) { create(:alert_management_alert, :ignored, project: project) }
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
context 'with ascending sort order' do
|
2020-05-24 23:13:21 +05:30
|
|
|
let(:params) { { sort: 'status_asc' } }
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
it 'sorts by status: Ignored > Resolved > Acknowledged > Triggered' do
|
|
|
|
expect(execute.map(&:status).uniq).to eq([ignored, resolved, acknowledged, triggered])
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
context 'with descending sort order' do
|
2020-05-24 23:13:21 +05:30
|
|
|
let(:params) { { sort: 'status_desc' } }
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
it 'sorts by status: Triggered > Acknowledged > Resolved > Ignored' do
|
|
|
|
expect(execute.map(&:status).uniq).to eq([triggered, acknowledged, resolved, ignored])
|
2020-05-24 23:13:21 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'search query given' do
|
|
|
|
let_it_be(:alert) do
|
|
|
|
create(:alert_management_alert,
|
|
|
|
:with_fingerprint,
|
|
|
|
title: 'Title',
|
|
|
|
description: 'Desc',
|
|
|
|
service: 'Service',
|
|
|
|
monitoring_tool: 'Monitor'
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
alert.project.add_developer(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
subject { described_class.new(current_user, alert.project, params).execute }
|
|
|
|
|
|
|
|
context 'searching title' do
|
|
|
|
let(:params) { { search: alert.title } }
|
|
|
|
|
|
|
|
it { is_expected.to match_array([alert]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'searching description' do
|
|
|
|
let(:params) { { search: alert.description } }
|
|
|
|
|
|
|
|
it { is_expected.to match_array([alert]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'searching service' do
|
|
|
|
let(:params) { { search: alert.service } }
|
|
|
|
|
|
|
|
it { is_expected.to match_array([alert]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'searching monitoring tool' do
|
|
|
|
let(:params) { { search: alert.monitoring_tool } }
|
|
|
|
|
|
|
|
it { is_expected.to match_array([alert]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'searching something else' do
|
|
|
|
let(:params) { { search: alert.fingerprint } }
|
|
|
|
|
|
|
|
it { is_expected.to be_empty }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'empty search' do
|
|
|
|
let(:params) { { search: ' ' } }
|
|
|
|
|
|
|
|
it { is_expected.to match_array([alert]) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '.counts_by_status' do
|
|
|
|
subject { described_class.counts_by_status(current_user, project, params) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_developer(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to match({ 2 => 1, 3 => 1 }) } # one resolved and one ignored
|
|
|
|
|
|
|
|
context 'when filtering params are included' do
|
|
|
|
let(:params) { { status: AlertManagement::Alert::STATUSES[:resolved] } }
|
|
|
|
|
|
|
|
it { is_expected.to match({ 2 => 1 }) } # one resolved
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|