2019-12-26 22:10:19 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe API::GroupExport do
|
|
|
|
let_it_be(:group) { create(:group) }
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
|
|
|
|
let(:path) { "/groups/#{group.id}/export" }
|
|
|
|
let(:download_path) { "/groups/#{group.id}/export/download" }
|
|
|
|
|
|
|
|
let(:export_path) { "#{Dir.tmpdir}/group_export_spec" }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow_next_instance_of(Gitlab::ImportExport) do |import_export|
|
|
|
|
expect(import_export).to receive(:storage_path).and_return(export_path)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
after do
|
|
|
|
FileUtils.rm_rf(export_path, secure: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'GET /groups/:group_id/export/download' do
|
|
|
|
let(:upload) { ImportExportUpload.new(group: group) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_uploads_object_storage(ImportExportUploader)
|
|
|
|
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
context 'group_import_export feature flag enabled' do
|
2019-12-26 22:10:19 +05:30
|
|
|
before do
|
2020-03-13 15:44:24 +05:30
|
|
|
stub_feature_flags(group_import_export: true)
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
context 'when export file exists' do
|
|
|
|
before do
|
|
|
|
upload.export_file = fixture_file_upload('spec/fixtures/group_export.tar.gz', "`/tar.gz")
|
|
|
|
upload.save!
|
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it 'downloads exported group archive' do
|
|
|
|
get api(download_path, user)
|
2019-12-26 22:10:19 +05:30
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2020-03-13 15:44:24 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'when export_file.file does not exist' do
|
|
|
|
before do
|
|
|
|
expect_next_instance_of(ImportExportUploader) do |uploader|
|
|
|
|
expect(uploader).to receive(:file).and_return(nil)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns 404' do
|
|
|
|
get api(download_path, user)
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
end
|
2020-03-13 15:44:24 +05:30
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
context 'when export file does not exist' do
|
2019-12-26 22:10:19 +05:30
|
|
|
it 'returns 404' do
|
|
|
|
get api(download_path, user)
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
context 'group_import_export feature flag disabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(group_import_export: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'responds with 404 Not Found' do
|
2019-12-26 22:10:19 +05:30
|
|
|
get api(download_path, user)
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
end
|
2020-06-23 00:09:42 +05:30
|
|
|
|
|
|
|
context 'when the requests have exceeded the rate limit' do
|
|
|
|
before do
|
|
|
|
allow(Gitlab::ApplicationRateLimiter)
|
|
|
|
.to receive(:increment)
|
|
|
|
.and_return(Gitlab::ApplicationRateLimiter.rate_limits[:group_download_export][:threshold] + 1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'throttles the endpoint' do
|
|
|
|
get api(download_path, user)
|
|
|
|
|
|
|
|
expect(json_response["message"])
|
|
|
|
.to include('error' => 'This endpoint has been requested too many times. Try again later.')
|
|
|
|
expect(response).to have_gitlab_http_status :too_many_requests
|
|
|
|
end
|
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
describe 'POST /groups/:group_id/export' do
|
2020-03-13 15:44:24 +05:30
|
|
|
context 'group_import_export feature flag enabled' do
|
2019-12-26 22:10:19 +05:30
|
|
|
before do
|
2020-03-13 15:44:24 +05:30
|
|
|
stub_feature_flags(group_import_export: true)
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
context 'when user is a group owner' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'accepts download' do
|
|
|
|
post api(path, user)
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:accepted)
|
2020-03-13 15:44:24 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-04-22 19:07:51 +05:30
|
|
|
context 'when the export cannot be started' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
allow(GroupExportWorker).to receive(:perform_async).and_return(nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns an error' do
|
|
|
|
post api(path, user)
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:error)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
context 'when user is not a group owner' do
|
|
|
|
before do
|
|
|
|
group.add_developer(user)
|
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it 'forbids the request' do
|
|
|
|
post api(path, user)
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:forbidden)
|
2020-03-13 15:44:24 +05:30
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
context 'group_import_export feature flag disabled' do
|
2019-12-26 22:10:19 +05:30
|
|
|
before do
|
2020-03-13 15:44:24 +05:30
|
|
|
stub_feature_flags(group_import_export: false)
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
it 'responds with 404 Not Found' do
|
2019-12-26 22:10:19 +05:30
|
|
|
post api(path, user)
|
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
end
|
2020-06-23 00:09:42 +05:30
|
|
|
|
|
|
|
context 'when the requests have exceeded the rate limit' do
|
|
|
|
before do
|
|
|
|
group.add_owner(user)
|
|
|
|
|
|
|
|
allow(Gitlab::ApplicationRateLimiter)
|
|
|
|
.to receive(:increment)
|
|
|
|
.and_return(Gitlab::ApplicationRateLimiter.rate_limits[:group_export][:threshold] + 1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'throttles the endpoint' do
|
|
|
|
post api(path, user)
|
|
|
|
|
|
|
|
expect(json_response["message"])
|
|
|
|
.to include('error' => 'This endpoint has been requested too many times. Try again later.')
|
|
|
|
expect(response).to have_gitlab_http_status :too_many_requests
|
|
|
|
end
|
|
|
|
end
|
2019-12-26 22:10:19 +05:30
|
|
|
end
|
|
|
|
end
|