2019-10-12 21:52:04 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2019-12-04 20:38:33 +05:30
|
|
|
require 'spec_helper'
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-10-24 23:57:45 +05:30
|
|
|
RSpec.describe 'User creates snippet', :js do
|
|
|
|
include DropzoneHelper
|
2020-11-24 15:15:51 +05:30
|
|
|
include Spec::Support::Helpers::Features::SnippetSpecHelpers
|
2020-10-24 23:57:45 +05:30
|
|
|
|
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
|
|
|
|
let(:title) { 'My Snippet Title' }
|
|
|
|
let(:file_content) { 'Hello World!' }
|
|
|
|
let(:md_description) { 'My Snippet **Description**' }
|
|
|
|
let(:description) { 'My Snippet Description' }
|
|
|
|
let(:created_snippet) { Snippet.last }
|
2020-11-24 15:15:51 +05:30
|
|
|
let(:snippet_title_field) { 'personal_snippet_title' }
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-03-13 15:44:24 +05:30
|
|
|
def description_field
|
2020-04-08 14:13:33 +05:30
|
|
|
find('.js-description-input').find('input,textarea')
|
2020-03-13 15:44:24 +05:30
|
|
|
end
|
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
shared_examples 'snippet creation' do
|
|
|
|
def fill_form
|
|
|
|
snippet_fill_in_form(title: title, content: file_content, description: md_description)
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2020-06-23 00:09:42 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
it 'Authenticated user creates a snippet' do
|
|
|
|
fill_form
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
click_button('Create snippet')
|
|
|
|
wait_for_requests
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
expect(page).to have_content(title)
|
|
|
|
page.within(snippet_description_view_selector) do
|
|
|
|
expect(page).to have_content(description)
|
|
|
|
expect(page).to have_selector('strong')
|
|
|
|
end
|
|
|
|
expect(page).to have_content(file_content)
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
it 'uploads a file when dragging into textarea' do
|
|
|
|
fill_form
|
|
|
|
dropzone_file Rails.root.join('spec', 'fixtures', 'banana_sample.gif')
|
2020-06-23 00:09:42 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
expect(snippet_description_value).to have_content('banana_sample')
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
click_button('Create snippet')
|
|
|
|
wait_for_requests
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-04-08 14:13:33 +05:30
|
|
|
link = find('a.no-attachment-icon img.js-lazy-loaded[alt="banana_sample"]')['src']
|
2020-11-24 15:15:51 +05:30
|
|
|
expect(link).to match(%r{/uploads/-/system/personal_snippet/#{Snippet.last.id}/\h{32}/banana_sample\.gif\z})
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2019-12-21 20:55:43 +05:30
|
|
|
reqs = inspect_requests { visit("#{link}?ran=#{SecureRandom.base64(20)}") }
|
2018-03-17 18:26:18 +05:30
|
|
|
expect(reqs.first.status_code).to eq(200)
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
context 'when the git operation fails' do
|
|
|
|
let(:error) { 'Error creating the snippet' }
|
2020-06-23 00:09:42 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
before do
|
|
|
|
allow_next_instance_of(Snippets::CreateService) do |instance|
|
|
|
|
allow(instance).to receive(:create_commit).and_raise(StandardError, error)
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
fill_form
|
|
|
|
click_button('Create snippet')
|
|
|
|
wait_for_requests
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'renders the new page and displays the error' do
|
|
|
|
expect(page).to have_content(error)
|
|
|
|
expect(page).to have_content('New Snippet')
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
action = find('form.snippet-form')['action']
|
|
|
|
expect(action).to include("/snippets")
|
|
|
|
end
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
context 'when snippets default visibility level is restricted' do
|
|
|
|
before do
|
|
|
|
stub_application_setting(restricted_visibility_levels: [Gitlab::VisibilityLevel::PRIVATE],
|
|
|
|
default_snippet_visibility: Gitlab::VisibilityLevel::PRIVATE)
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
it 'creates a snippet using the lowest available visibility level as default' do
|
|
|
|
visit new_snippet_path
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
fill_form
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
click_button('Create snippet')
|
|
|
|
wait_for_requests
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
expect(find('.blob-content')).to have_content(file_content)
|
|
|
|
expect(Snippet.last.visibility_level).to eq(Gitlab::VisibilityLevel::INTERNAL)
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
it_behaves_like 'personal snippet with references' do
|
|
|
|
let(:container) { snippet_description_view_selector }
|
|
|
|
let(:md_description) { references }
|
2020-06-23 00:09:42 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
subject do
|
|
|
|
fill_form
|
|
|
|
click_button('Create snippet')
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
wait_for_requests
|
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
context 'Vue application' do
|
|
|
|
let(:snippet_description_field) { 'snippet-description' }
|
|
|
|
let(:snippet_description_view_selector) { '.snippet-header .snippet-description' }
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
before do
|
|
|
|
sign_in(user)
|
2020-04-22 19:07:51 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
visit new_snippet_path
|
2020-04-22 19:07:51 +05:30
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
it_behaves_like 'snippet creation'
|
2020-06-23 00:09:42 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
it 'validation fails for the first time' do
|
|
|
|
fill_in snippet_title_field, with: title
|
2017-09-10 17:25:29 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
expect(page).not_to have_button('Create snippet')
|
|
|
|
|
|
|
|
snippet_fill_in_form(title: title, content: file_content)
|
|
|
|
expect(page).to have_button('Create snippet')
|
|
|
|
end
|
2017-09-10 17:25:29 +05:30
|
|
|
end
|
2020-06-23 00:09:42 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
context 'non-Vue application' do
|
|
|
|
let(:snippet_description_field) { 'personal_snippet_description' }
|
|
|
|
let(:snippet_description_view_selector) { '.snippet-header .description' }
|
|
|
|
|
2020-06-23 00:09:42 +05:30
|
|
|
before do
|
2020-11-24 15:15:51 +05:30
|
|
|
stub_feature_flags(snippets_vue: false)
|
|
|
|
stub_feature_flags(snippets_edit_vue: false)
|
|
|
|
|
|
|
|
sign_in(user)
|
2020-06-23 00:09:42 +05:30
|
|
|
|
|
|
|
visit new_snippet_path
|
2020-11-24 15:15:51 +05:30
|
|
|
end
|
2020-06-23 00:09:42 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
it_behaves_like 'snippet creation'
|
2020-06-23 00:09:42 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
it 'validation fails for the first time' do
|
|
|
|
fill_in snippet_title_field, with: title
|
2020-06-23 00:09:42 +05:30
|
|
|
click_button('Create snippet')
|
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
expect(page).to have_selector('#error_explanation')
|
2020-06-23 00:09:42 +05:30
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
it 'previews a snippet with file' do
|
|
|
|
# Click placeholder first to expand full description field
|
|
|
|
description_field.click
|
|
|
|
fill_in snippet_description_field, with: 'My Snippet'
|
|
|
|
dropzone_file Rails.root.join('spec', 'fixtures', 'banana_sample.gif')
|
|
|
|
find('.js-md-preview-button').click
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
page.within('.md-preview-holder') do
|
|
|
|
expect(page).to have_content('My Snippet')
|
2020-04-08 14:13:33 +05:30
|
|
|
|
2020-11-24 15:15:51 +05:30
|
|
|
link = find('a.no-attachment-icon img.js-lazy-loaded[alt="banana_sample"]')['src']
|
|
|
|
expect(link).to match(%r{/uploads/-/system/user/#{user.id}/\h{32}/banana_sample\.gif\z})
|
|
|
|
|
|
|
|
# Adds a cache buster for checking if the image exists as Selenium is now handling the cached requests
|
|
|
|
# not anymore as requests when they come straight from memory cache.
|
|
|
|
reqs = inspect_requests { visit("#{link}?ran=#{SecureRandom.base64(20)}") }
|
|
|
|
expect(reqs.first.status_code).to eq(200)
|
|
|
|
end
|
2020-10-24 23:57:45 +05:30
|
|
|
end
|
|
|
|
end
|
2020-04-08 14:13:33 +05:30
|
|
|
end
|