debian-mirror-gitlab/spec/features/merge_request/user_sees_merge_button_depending_on_unresolved_discussions_spec.rb

62 lines
1.9 KiB
Ruby
Raw Normal View History

2018-03-17 18:26:18 +05:30
require 'rails_helper'
2017-08-17 22:00:37 +05:30
2018-03-17 18:26:18 +05:30
describe 'Merge request > User sees merge button depending on unresolved discussions', :js do
2017-09-10 17:25:29 +05:30
let(:project) { create(:project, :repository) }
2018-03-17 18:26:18 +05:30
let(:user) { project.creator }
2017-08-17 22:00:37 +05:30
let!(:merge_request) { create(:merge_request_with_diff_notes, source_project: project, author: user) }
before do
2018-11-18 11:00:15 +05:30
project.add_maintainer(user)
2018-03-17 18:26:18 +05:30
sign_in(user)
2017-08-17 22:00:37 +05:30
end
context 'when project.only_allow_merge_if_all_discussions_are_resolved == true' do
before do
project.update_column(:only_allow_merge_if_all_discussions_are_resolved, true)
2018-03-17 18:26:18 +05:30
visit project_merge_request_path(project, merge_request)
2017-08-17 22:00:37 +05:30
end
context 'with unresolved discussions' do
it 'does not allow to merge' do
expect(page).not_to have_button 'Merge'
expect(page).to have_content('There are unresolved discussions.')
end
end
context 'with all discussions resolved' do
before do
merge_request.discussions.each { |d| d.resolve!(user) }
2018-03-17 18:26:18 +05:30
visit project_merge_request_path(project, merge_request)
2017-08-17 22:00:37 +05:30
end
it 'allows MR to be merged' do
expect(page).to have_button 'Merge'
end
end
end
context 'when project.only_allow_merge_if_all_discussions_are_resolved == false' do
before do
project.update_column(:only_allow_merge_if_all_discussions_are_resolved, false)
2018-03-17 18:26:18 +05:30
visit project_merge_request_path(project, merge_request)
2017-08-17 22:00:37 +05:30
end
context 'with unresolved discussions' do
it 'does not allow to merge' do
expect(page).to have_button 'Merge'
end
end
context 'with all discussions resolved' do
before do
merge_request.discussions.each { |d| d.resolve!(user) }
2018-03-17 18:26:18 +05:30
visit project_merge_request_path(project, merge_request)
2017-08-17 22:00:37 +05:30
end
it 'allows MR to be merged' do
expect(page).to have_button 'Merge'
end
end
end
end