debian-mirror-gitlab/spec/services/event_create_service_spec.rb

357 lines
11 KiB
Ruby
Raw Normal View History

2019-07-31 22:56:46 +05:30
# frozen_string_literal: true
2014-09-02 18:07:02 +05:30
require 'spec_helper'
2020-07-28 23:09:34 +05:30
RSpec.describe EventCreateService do
2017-09-10 17:25:29 +05:30
let(:service) { described_class.new }
2014-09-02 18:07:02 +05:30
2020-06-23 00:09:42 +05:30
let_it_be(:user, reload: true) { create :user }
let_it_be(:project) { create(:project) }
2014-09-02 18:07:02 +05:30
describe 'Issues' do
2016-08-24 12:49:21 +05:30
describe '#open_issue' do
2014-09-02 18:07:02 +05:30
let(:issue) { create(:issue) }
2015-04-26 12:48:37 +05:30
it { expect(service.open_issue(issue, issue.author)).to be_truthy }
2014-09-02 18:07:02 +05:30
2017-08-17 22:00:37 +05:30
it "creates new event" do
2014-09-02 18:07:02 +05:30
expect { service.open_issue(issue, issue.author) }.to change { Event.count }
end
end
2016-08-24 12:49:21 +05:30
describe '#close_issue' do
2014-09-02 18:07:02 +05:30
let(:issue) { create(:issue) }
2015-04-26 12:48:37 +05:30
it { expect(service.close_issue(issue, issue.author)).to be_truthy }
2014-09-02 18:07:02 +05:30
2017-08-17 22:00:37 +05:30
it "creates new event" do
2014-09-02 18:07:02 +05:30
expect { service.close_issue(issue, issue.author) }.to change { Event.count }
end
end
2016-08-24 12:49:21 +05:30
describe '#reopen_issue' do
2014-09-02 18:07:02 +05:30
let(:issue) { create(:issue) }
2015-04-26 12:48:37 +05:30
it { expect(service.reopen_issue(issue, issue.author)).to be_truthy }
2014-09-02 18:07:02 +05:30
2017-08-17 22:00:37 +05:30
it "creates new event" do
2014-09-02 18:07:02 +05:30
expect { service.reopen_issue(issue, issue.author) }.to change { Event.count }
end
end
end
describe 'Merge Requests' do
2016-08-24 12:49:21 +05:30
describe '#open_mr' do
2014-09-02 18:07:02 +05:30
let(:merge_request) { create(:merge_request) }
2015-04-26 12:48:37 +05:30
it { expect(service.open_mr(merge_request, merge_request.author)).to be_truthy }
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
it "creates new event" do
2014-09-02 18:07:02 +05:30
expect { service.open_mr(merge_request, merge_request.author) }.to change { Event.count }
end
end
2016-08-24 12:49:21 +05:30
describe '#close_mr' do
2014-09-02 18:07:02 +05:30
let(:merge_request) { create(:merge_request) }
2015-04-26 12:48:37 +05:30
it { expect(service.close_mr(merge_request, merge_request.author)).to be_truthy }
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
it "creates new event" do
2014-09-02 18:07:02 +05:30
expect { service.close_mr(merge_request, merge_request.author) }.to change { Event.count }
end
end
2016-08-24 12:49:21 +05:30
describe '#merge_mr' do
2014-09-02 18:07:02 +05:30
let(:merge_request) { create(:merge_request) }
2015-04-26 12:48:37 +05:30
it { expect(service.merge_mr(merge_request, merge_request.author)).to be_truthy }
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
it "creates new event" do
2014-09-02 18:07:02 +05:30
expect { service.merge_mr(merge_request, merge_request.author) }.to change { Event.count }
end
end
2016-08-24 12:49:21 +05:30
describe '#reopen_mr' do
2014-09-02 18:07:02 +05:30
let(:merge_request) { create(:merge_request) }
2015-04-26 12:48:37 +05:30
it { expect(service.reopen_mr(merge_request, merge_request.author)).to be_truthy }
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
it "creates new event" do
2014-09-02 18:07:02 +05:30
expect { service.reopen_mr(merge_request, merge_request.author) }.to change { Event.count }
2020-07-28 23:09:34 +05:30
end
end
describe '#approve_mr' do
let(:merge_request) { create(:merge_request) }
it { expect(service.approve_mr(merge_request, user)).to be_truthy }
it 'creates new event' do
service.approve_mr(merge_request, user)
change { Event.approved_action.where(target: merge_request).count }.by(1)
2014-09-02 18:07:02 +05:30
end
end
end
describe 'Milestone' do
2016-08-24 12:49:21 +05:30
describe '#open_milestone' do
2014-09-02 18:07:02 +05:30
let(:milestone) { create(:milestone) }
2015-04-26 12:48:37 +05:30
it { expect(service.open_milestone(milestone, user)).to be_truthy }
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
it "creates new event" do
2014-09-02 18:07:02 +05:30
expect { service.open_milestone(milestone, user) }.to change { Event.count }
end
end
2016-08-24 12:49:21 +05:30
describe '#close_mr' do
2014-09-02 18:07:02 +05:30
let(:milestone) { create(:milestone) }
2015-04-26 12:48:37 +05:30
it { expect(service.close_milestone(milestone, user)).to be_truthy }
2014-09-02 18:07:02 +05:30
2016-09-13 17:45:13 +05:30
it "creates new event" do
2014-09-02 18:07:02 +05:30
expect { service.close_milestone(milestone, user) }.to change { Event.count }
end
end
2015-09-25 12:07:36 +05:30
2016-08-24 12:49:21 +05:30
describe '#destroy_mr' do
2015-09-25 12:07:36 +05:30
let(:milestone) { create(:milestone) }
it { expect(service.destroy_milestone(milestone, user)).to be_truthy }
2016-09-13 17:45:13 +05:30
it "creates new event" do
2015-09-25 12:07:36 +05:30
expect { service.destroy_milestone(milestone, user) }.to change { Event.count }
end
end
2014-09-02 18:07:02 +05:30
end
2017-08-17 22:00:37 +05:30
2019-12-21 20:55:43 +05:30
shared_examples_for 'service for creating a push event' do |service_class|
2017-08-17 22:00:37 +05:30
it 'creates a new event' do
2019-12-21 20:55:43 +05:30
expect { subject }.to change { Event.count }
2017-09-10 17:25:29 +05:30
end
it 'creates the push event payload' do
2019-12-21 20:55:43 +05:30
expect(service_class).to receive(:new)
2017-09-10 17:25:29 +05:30
.with(an_instance_of(PushEvent), push_data)
.and_call_original
2019-12-21 20:55:43 +05:30
subject
2017-08-17 22:00:37 +05:30
end
it 'updates user last activity' do
2019-12-21 20:55:43 +05:30
expect { subject }.to change { user.last_activity_on }.to(Date.today)
2017-09-10 17:25:29 +05:30
end
2018-03-17 18:26:18 +05:30
it 'caches the last push event for the user' do
2020-01-01 13:55:28 +05:30
expect_next_instance_of(Users::LastPushEventService) do |instance|
expect(instance).to receive(:cache_last_push_event).with(an_instance_of(PushEvent))
end
2018-03-17 18:26:18 +05:30
2019-12-21 20:55:43 +05:30
subject
2018-03-17 18:26:18 +05:30
end
2017-09-10 17:25:29 +05:30
it 'does not create any event data when an error is raised' do
payload_service = double(:service)
allow(payload_service).to receive(:execute)
.and_raise(RuntimeError)
2019-12-21 20:55:43 +05:30
allow(service_class).to receive(:new)
2017-09-10 17:25:29 +05:30
.and_return(payload_service)
2019-12-21 20:55:43 +05:30
expect { subject }.to raise_error(RuntimeError)
2017-09-10 17:25:29 +05:30
expect(Event.count).to eq(0)
expect(PushEventPayload.count).to eq(0)
2017-08-17 22:00:37 +05:30
end
end
2020-07-28 23:09:34 +05:30
describe '#wiki_event', :clean_gitlab_redis_shared_state do
2020-04-22 19:07:51 +05:30
let_it_be(:user) { create(:user) }
let_it_be(:wiki_page) { create(:wiki_page) }
let_it_be(:meta) { create(:wiki_page_meta, :for_wiki_page, wiki_page: wiki_page) }
Event::WIKI_ACTIONS.each do |action|
context "The action is #{action}" do
let(:event) { service.wiki_event(meta, user, action) }
2020-05-24 23:13:21 +05:30
it 'creates the event', :aggregate_failures do
2020-04-22 19:07:51 +05:30
expect(event).to have_attributes(
wiki_page?: true,
valid?: true,
persisted?: true,
2020-06-23 00:09:42 +05:30
action: action.to_s,
2020-05-24 23:13:21 +05:30
wiki_page: wiki_page,
author: user
2020-04-22 19:07:51 +05:30
)
end
2020-07-28 23:09:34 +05:30
it 'records the event in the event counter' do
stub_feature_flags(Gitlab::UsageDataCounters::TrackUniqueActions::FEATURE_FLAG => true)
counter_class = Gitlab::UsageDataCounters::TrackUniqueActions
tracking_params = { event_action: counter_class::WIKI_ACTION, date_from: Date.yesterday, date_to: Date.today }
expect { event }
.to change { counter_class.count_unique_events(tracking_params) }
.from(0).to(1)
end
2020-05-24 23:13:21 +05:30
it 'is idempotent', :aggregate_failures do
expect { event }.to change(Event, :count).by(1)
duplicate = nil
expect { duplicate = service.wiki_event(meta, user, action) }.not_to change(Event, :count)
expect(duplicate).to eq(event)
end
2020-04-22 19:07:51 +05:30
end
end
2020-06-23 00:09:42 +05:30
(Event.actions.keys - Event::WIKI_ACTIONS).each do |bad_action|
2020-04-22 19:07:51 +05:30
context "The action is #{bad_action}" do
it 'raises an error' do
expect { service.wiki_event(meta, user, bad_action) }.to raise_error(described_class::IllegalActionError)
end
end
end
end
2019-12-21 20:55:43 +05:30
describe '#push', :clean_gitlab_redis_shared_state do
let(:push_data) do
{
commits: [
{
id: '1cf19a015df3523caf0a1f9d40c98a267d6a2fc2',
message: 'This is a commit'
}
],
before: '0000000000000000000000000000000000000000',
after: '1cf19a015df3523caf0a1f9d40c98a267d6a2fc2',
total_commits_count: 1,
ref: 'refs/heads/my-branch'
}
end
subject { service.push(project, user, push_data) }
it_behaves_like 'service for creating a push event', PushEventPayloadService
2020-07-28 23:09:34 +05:30
it 'records the event in the event counter' do
stub_feature_flags(Gitlab::UsageDataCounters::TrackUniqueActions::FEATURE_FLAG => true)
counter_class = Gitlab::UsageDataCounters::TrackUniqueActions
tracking_params = { event_action: counter_class::PUSH_ACTION, date_from: Date.yesterday, date_to: Date.today }
expect { subject }
.to change { counter_class.count_unique_events(tracking_params) }
.from(0).to(1)
end
2019-12-21 20:55:43 +05:30
end
describe '#bulk_push', :clean_gitlab_redis_shared_state do
let(:push_data) do
{
action: :created,
ref_count: 4,
ref_type: :branch
}
end
subject { service.bulk_push(project, user, push_data) }
it_behaves_like 'service for creating a push event', BulkPushEventPayloadService
2020-07-28 23:09:34 +05:30
it 'records the event in the event counter' do
stub_feature_flags(Gitlab::UsageDataCounters::TrackUniqueActions::FEATURE_FLAG => true)
counter_class = Gitlab::UsageDataCounters::TrackUniqueActions
tracking_params = { event_action: counter_class::PUSH_ACTION, date_from: Date.yesterday, date_to: Date.today }
expect { subject }
.to change { counter_class.count_unique_events(tracking_params) }
.from(0).to(1)
end
2019-12-21 20:55:43 +05:30
end
2017-08-17 22:00:37 +05:30
describe 'Project' do
describe '#join_project' do
subject { service.join_project(project, user) }
it { is_expected.to be_truthy }
it { expect { subject }.to change { Event.count }.from(0).to(1) }
end
describe '#expired_leave_project' do
subject { service.expired_leave_project(project, user) }
it { is_expected.to be_truthy }
it { expect { subject }.to change { Event.count }.from(0).to(1) }
end
end
2020-06-23 00:09:42 +05:30
2020-07-28 23:09:34 +05:30
describe 'design events', :clean_gitlab_redis_shared_state do
2020-06-23 00:09:42 +05:30
let_it_be(:design) { create(:design, project: project) }
let_it_be(:author) { user }
describe '#save_designs' do
let_it_be(:updated) { create_list(:design, 5) }
let_it_be(:created) { create_list(:design, 3) }
let(:result) { service.save_designs(author, create: created, update: updated) }
specify { expect { result }.to change { Event.count }.by(8) }
specify { expect { result }.not_to exceed_query_limit(1) }
it 'creates 3 created design events' do
ids = result.pluck('id')
events = Event.created_action.where(id: ids)
expect(events.map(&:design)).to match_array(created)
end
it 'creates 5 created design events' do
ids = result.pluck('id')
events = Event.updated_action.where(id: ids)
expect(events.map(&:design)).to match_array(updated)
end
2020-07-28 23:09:34 +05:30
it 'records the event in the event counter' do
stub_feature_flags(Gitlab::UsageDataCounters::TrackUniqueActions::FEATURE_FLAG => true)
counter_class = Gitlab::UsageDataCounters::TrackUniqueActions
tracking_params = { event_action: counter_class::DESIGN_ACTION, date_from: Date.yesterday, date_to: Date.today }
expect { result }
.to change { counter_class.count_unique_events(tracking_params) }
.from(0).to(1)
2020-06-23 00:09:42 +05:30
end
end
describe '#destroy_designs' do
let_it_be(:designs) { create_list(:design, 5) }
let_it_be(:author) { create(:user) }
let(:result) { service.destroy_designs(designs, author) }
specify { expect { result }.to change { Event.count }.by(5) }
specify { expect { result }.not_to exceed_query_limit(1) }
it 'creates 5 destroyed design events' do
ids = result.pluck('id')
events = Event.destroyed_action.where(id: ids)
expect(events.map(&:design)).to match_array(designs)
end
2020-07-28 23:09:34 +05:30
it 'records the event in the event counter' do
stub_feature_flags(Gitlab::UsageDataCounters::TrackUniqueActions::FEATURE_FLAG => true)
counter_class = Gitlab::UsageDataCounters::TrackUniqueActions
tracking_params = { event_action: counter_class::DESIGN_ACTION, date_from: Date.yesterday, date_to: Date.today }
expect { result }
.to change { counter_class.count_unique_events(tracking_params) }
.from(0).to(1)
2020-06-23 00:09:42 +05:30
end
end
end
2014-09-02 18:07:02 +05:30
end