2020-01-01 13:55:28 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
require 'fast_spec_helper'
|
2020-01-01 13:55:28 +05:30
|
|
|
require 'rubocop'
|
|
|
|
require_relative '../../../rubocop/cop/put_group_routes_under_scope'
|
|
|
|
|
2020-07-28 23:09:34 +05:30
|
|
|
RSpec.describe RuboCop::Cop::PutGroupRoutesUnderScope, type: :rubocop do
|
2020-01-01 13:55:28 +05:30
|
|
|
include CopHelper
|
|
|
|
|
|
|
|
subject(:cop) { described_class.new }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(cop).to receive(:in_group_routes?).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'registers an offense when route is outside scope' do
|
2020-06-23 00:09:42 +05:30
|
|
|
expect_offense(<<~PATTERN)
|
2020-01-01 13:55:28 +05:30
|
|
|
scope(path: 'groups/*group_id/-', module: :groups) do
|
|
|
|
resource :issues
|
|
|
|
end
|
|
|
|
|
|
|
|
resource :notes
|
|
|
|
^^^^^^^^^^^^^^^ Put new group routes under /-/ scope
|
|
|
|
PATTERN
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not register an offense when resource inside the scope' do
|
2020-06-23 00:09:42 +05:30
|
|
|
expect_no_offenses(<<~PATTERN)
|
2020-01-01 13:55:28 +05:30
|
|
|
scope(path: 'groups/*group_id/-', module: :groups) do
|
|
|
|
resource :issues
|
|
|
|
resource :notes
|
|
|
|
end
|
|
|
|
PATTERN
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not register an offense when resource is deep inside the scope' do
|
2020-06-23 00:09:42 +05:30
|
|
|
expect_no_offenses(<<~PATTERN)
|
2020-01-01 13:55:28 +05:30
|
|
|
scope(path: 'groups/*group_id/-', module: :groups) do
|
|
|
|
resource :issues
|
|
|
|
resource :projects do
|
|
|
|
resource :issues do
|
|
|
|
resource :notes
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
PATTERN
|
|
|
|
end
|
|
|
|
end
|