debian-mirror-gitlab/spec/features/issues/issue_detail_spec.rb

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

210 lines
5.7 KiB
Ruby
Raw Permalink Normal View History

2019-10-12 21:52:04 +05:30
# frozen_string_literal: true
2019-12-04 20:38:33 +05:30
require 'spec_helper'
2017-09-10 17:25:29 +05:30
2023-03-04 22:38:38 +05:30
RSpec.describe 'Issue Detail', :js, feature_category: :team_planning do
2021-12-11 22:18:48 +05:30
let_it_be_with_refind(:project) { create(:project, :public) }
2018-03-17 18:26:18 +05:30
let(:user) { create(:user) }
let(:issue) { create(:issue, project: project, author: user) }
2021-09-04 01:27:46 +05:30
let(:incident) { create(:incident, project: project, author: user) }
2017-09-10 17:25:29 +05:30
context 'when user displays the issue' do
before do
visit project_issue_path(project, issue)
wait_for_requests
end
it 'shows the issue' do
page.within('.issuable-details') do
2022-05-07 20:08:51 +05:30
expect(find('h1')).to have_content(issue.title)
2017-09-10 17:25:29 +05:30
end
end
end
2020-11-24 15:15:51 +05:30
context 'when user displays the issue as an incident' do
before do
2021-09-04 01:27:46 +05:30
visit project_issue_path(project, incident)
2020-11-24 15:15:51 +05:30
wait_for_requests
end
it 'does not show design management' do
expect(page).not_to have_selector('.js-design-management')
end
end
2021-11-11 11:23:49 +05:30
context 'when issue description has emojis' do
let(:issue) { create(:issue, project: project, author: user, description: 'hello world :100:') }
before do
sign_in(user)
visit project_issue_path(project, issue)
end
it 'renders gl-emoji tag' do
page.within('.description') do
expect(page).to have_selector('gl-emoji', count: 1)
end
end
end
2023-05-27 22:25:52 +05:30
context 'when issue description has task list items' do
before do
description = '- [ ] I am a task
| Table |
|-------|
| <ul><li>[ ] I am inside a table</li><ul> |'
issue.update!(description: description)
sign_in(user)
visit project_issue_path(project, issue)
end
it 'shows task actions ellipsis button when hovering over the task list item, but not within a table', :aggregate_failures do
find('li', text: 'I am a task').hover
expect(page).to have_button 'Task actions'
find('li', text: 'I am inside a table').hover
expect(page).not_to have_button 'Task actions'
end
end
2018-11-08 19:23:39 +05:30
context 'when issue description has xss snippet' do
before do
issue.update!(description: '![xss" onload=alert(1);//](a)')
2020-03-13 15:44:24 +05:30
2018-11-08 19:23:39 +05:30
sign_in(user)
visit project_issue_path(project, issue)
end
2020-07-28 23:09:34 +05:30
it 'encodes the description to prevent xss issues', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/207951' do
2018-11-08 19:23:39 +05:30
page.within('.issuable-details .detail-page-description') do
2020-03-13 15:44:24 +05:30
image = find('img.js-lazy-loaded')
2018-11-08 19:23:39 +05:30
expect(page).to have_selector('img', count: 1)
2020-03-13 15:44:24 +05:30
expect(image['onerror']).to be_nil
expect(image['src']).to end_with('/a')
2018-11-08 19:23:39 +05:30
end
end
end
2017-09-10 17:25:29 +05:30
context 'when edited by a user who is later deleted' do
2022-10-11 01:57:18 +05:30
let(:user_to_be_deleted) { create(:user) }
2017-09-10 17:25:29 +05:30
before do
2022-10-11 01:57:18 +05:30
project.add_developer(user_to_be_deleted)
sign_in(user_to_be_deleted)
2023-07-09 08:55:56 +05:30
stub_feature_flags(moved_mr_sidebar: false)
2017-09-10 17:25:29 +05:30
visit project_issue_path(project, issue)
wait_for_requests
2021-09-04 01:27:46 +05:30
click_button 'Edit title and description'
2018-03-17 18:26:18 +05:30
fill_in 'issuable-title', with: 'issue title'
2021-09-04 01:27:46 +05:30
click_button 'Save changes'
2018-03-17 18:26:18 +05:30
wait_for_requests
2017-09-10 17:25:29 +05:30
2022-10-11 01:57:18 +05:30
Users::DestroyService.new(user_to_be_deleted).execute(user_to_be_deleted)
2017-09-10 17:25:29 +05:30
2022-10-11 01:57:18 +05:30
sign_in(user)
2017-09-10 17:25:29 +05:30
visit project_issue_path(project, issue)
end
it 'shows the issue' do
page.within('.issuable-details') do
2022-05-07 20:08:51 +05:30
expect(find('h1')).to have_content(issue.reload.title)
2017-09-10 17:25:29 +05:30
end
end
end
2021-09-04 01:27:46 +05:30
describe 'user updates `issue_type` via the issue type dropdown' do
2021-12-11 22:18:48 +05:30
let_it_be(:reporter) { create(:user) }
before_all do
project.add_reporter(reporter)
end
describe 'when an issue `issue_type` is edited' do
2021-09-04 01:27:46 +05:30
before do
sign_in(user)
2023-07-09 08:55:56 +05:30
set_cookie('new-actions-popover-viewed', 'true')
2021-09-04 01:27:46 +05:30
visit project_issue_path(project, issue)
wait_for_requests
end
2021-12-11 22:18:48 +05:30
context 'by non-member author' do
it 'cannot see Incident option' do
open_issue_edit_form
page.within('[data-testid="issuable-form"]') do
expect(page).to have_content('Issue')
expect(page).not_to have_content('Incident')
end
end
end
context 'by reporter' do
let(:user) { reporter }
2021-09-04 01:27:46 +05:30
2021-12-11 22:18:48 +05:30
it 'routes the user to the incident details page when the `issue_type` is set to incident' do
open_issue_edit_form
2021-09-04 01:27:46 +05:30
2021-12-11 22:18:48 +05:30
page.within('[data-testid="issuable-form"]') do
update_type_select('Issue', 'Incident')
2023-04-23 21:23:45 +05:30
expect(page).to have_current_path(incident_project_issues_path(project, issue))
2021-12-11 22:18:48 +05:30
end
2021-09-04 01:27:46 +05:30
end
end
end
2021-12-11 22:18:48 +05:30
describe 'when an incident `issue_type` is edited' do
2021-09-04 01:27:46 +05:30
before do
sign_in(user)
2023-07-09 08:55:56 +05:30
set_cookie('new-actions-popover-viewed', 'true')
2021-09-04 01:27:46 +05:30
visit project_issue_path(project, incident)
wait_for_requests
end
2021-12-11 22:18:48 +05:30
context 'by non-member author' do
2022-07-23 23:45:48 +05:30
it 'cannot edit issuable' do
page.within('.content') do
expect(page).to have_no_button('Edit title and description')
2021-12-11 22:18:48 +05:30
end
end
end
context 'by reporter' do
let(:user) { reporter }
it 'routes the user to the issue details page when the `issue_type` is set to issue' do
open_issue_edit_form
2021-09-04 01:27:46 +05:30
2021-12-11 22:18:48 +05:30
page.within('[data-testid="issuable-form"]') do
update_type_select('Incident', 'Issue')
2021-09-04 01:27:46 +05:30
2021-12-11 22:18:48 +05:30
expect(page).to have_current_path(project_issue_path(project, incident))
end
2021-09-04 01:27:46 +05:30
end
end
end
end
def update_type_select(from, to)
click_button from
2023-04-23 21:23:45 +05:30
find('[data-testid="issue-type-list-item"]', text: to).click
2021-09-04 01:27:46 +05:30
click_button 'Save changes'
wait_for_requests
end
def open_issue_edit_form
wait_for_requests
click_button 'Edit title and description'
wait_for_requests
end
2017-09-10 17:25:29 +05:30
end