bench-forgejo/services
zeripath 5d2e11eedb
Refactor: Move login out of models (#16199)
`models` does far too much. In particular it handles all `UserSignin`.

It shouldn't be responsible for calling LDAP, SMTP or PAM for signing in.

Therefore we should move this code out of `models`.

This code has to depend on `models` - therefore it belongs in `services`.

There is a package in `services` called `auth` and clearly this functionality belongs in there.

Plan:

- [x] Change `auth.Auth` to `auth.Method` - as they represent methods of authentication.
- [x] Move `models.UserSignIn` into `auth`
- [x] Move `models.ExternalUserLogin`
- [x] Move most of the `LoginVia*` methods to `auth` or subpackages
- [x] Move Resynchronize functionality to `auth`
  - Involved some restructuring of `models/ssh_key.go` to reduce the size of this massive file and simplify its files.
- [x] Move the rest of the LDAP functionality in to the ldap subpackage
- [x] Re-factor the login sources to express an interfaces `auth.Source`?
  - I've done this through some smaller interfaces Authenticator and Synchronizable - which would allow us to extend things in future
- [x] Now LDAP is out of models - need to think about modules/auth/ldap and I think all of that functionality might just be moveable
- [x] Similarly a lot Oauth2 functionality need not be in models too and should be moved to services/auth/source/oauth2
  - [x] modules/auth/oauth2/oauth2.go uses xorm... This is naughty - probably need to move this into models.
  - [x] models/oauth2.go - mostly should be in modules/auth/oauth2 or services/auth/source/oauth2 
- [x] More simplifications of login_source.go may need to be done
- Allow wiring in of notify registration -  *this can now easily be done - but I think we should do it in another PR*  - see #16178 
- More refactors...?
  - OpenID should probably become an auth Method but I think that can be left for another PR
  - Methods should also probably be cleaned up  - again another PR I think.
  - SSPI still needs more refactors.* Rename auth.Auth auth.Method
* Restructure ssh_key.go

- move functions from models/user.go that relate to ssh_key to ssh_key
- split ssh_key.go to try create clearer function domains for allow for
future refactors here.

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-07-24 11:16:34 +01:00
..
archiver Rework repository archive (#14723) 2021-06-23 17:12:38 -04:00
auth Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
comments Enhance Ghost comment mitigation Settings (#14392) 2021-01-21 21:56:19 -05:00
externalaccount Allow externalID to be UUID (#8551) 2019-10-17 10:06:28 +08:00
forms Add support for corporate WeChat webhooks (#15910) 2021-07-23 12:41:27 +08:00
gitdiff Detect encoding changes while parsing diff (#16330) 2021-07-13 03:13:52 +02:00
issue Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
lfs Rewrite of the LFS server (#15523) 2021-06-06 02:59:27 +03:00
mailer Use TrN helper for email templates (#16425) 2021-07-14 15:06:09 +02:00
mirror Add push to remote mirror repository (#15157) 2021-06-14 19:20:43 +02:00
pull Add checkbox to delete pull branch after successful merge (#16049) 2021-07-13 01:26:25 +02:00
release Add tag protection (#15629) 2021-06-25 16:28:55 +02:00
repository Implemented head_commit for webhooks (#16282) 2021-06-29 15:34:03 +02:00
webhook Add support for corporate WeChat webhooks (#15910) 2021-07-23 12:41:27 +08:00
wiki Add TestPrepareWikiFileName (#16487) 2021-07-20 15:16:20 +02:00