98fd085039
If you add t.Logf("%+v %+v", actual, testCase.expectedErrors) to
the test code, you'll notice that only Errors' Messages are being
compared:
--- PASS: Test_ValidURLValidation/Invalid_schema (0.00s)
binding_test.go:43: [Url] [Url]
FieldNames and Classification are ignored in comparison.
Moreover, an Errors slice with a single Error with empty message
is formatted as '[]' (the same as empty slice), which is also
error-prone. I discovered this when working on #7791 when one test which
was not supposed to pass did pass. https://play.golang.org/p/qC4wVLrm4NG
This commit changes the test to do the comparison properly.
60 lines
1.4 KiB
Go
60 lines
1.4 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package validation
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/go-macaron/binding"
|
|
"github.com/stretchr/testify/assert"
|
|
"gopkg.in/macaron.v1"
|
|
)
|
|
|
|
const (
|
|
testRoute = "/test"
|
|
)
|
|
|
|
type (
|
|
validationTestCase struct {
|
|
description string
|
|
data interface{}
|
|
expectedErrors binding.Errors
|
|
}
|
|
|
|
TestForm struct {
|
|
BranchName string `form:"BranchName" binding:"GitRefName"`
|
|
URL string `form:"ValidUrl" binding:"ValidUrl"`
|
|
}
|
|
)
|
|
|
|
func performValidationTest(t *testing.T, testCase validationTestCase) {
|
|
httpRecorder := httptest.NewRecorder()
|
|
m := macaron.Classic()
|
|
|
|
m.Post(testRoute, binding.Validate(testCase.data), func(actual binding.Errors) {
|
|
// see https://github.com/stretchr/testify/issues/435
|
|
if actual == nil {
|
|
actual = binding.Errors{}
|
|
}
|
|
|
|
assert.Equal(t, testCase.expectedErrors, actual)
|
|
})
|
|
|
|
req, err := http.NewRequest("POST", testRoute, nil)
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
m.ServeHTTP(httpRecorder, req)
|
|
|
|
switch httpRecorder.Code {
|
|
case http.StatusNotFound:
|
|
panic("Routing is messed up in test fixture (got 404): check methods and paths")
|
|
case http.StatusInternalServerError:
|
|
panic("Something bad happened on '" + testCase.description + "'")
|
|
}
|
|
}
|