792b4dba2c
* update github.com/blevesearch/bleve v2.0.2 -> v2.0.3 * github.com/denisenkom/go-mssqldb v0.9.0 -> v0.10.0 * github.com/editorconfig/editorconfig-core-go v2.4.1 -> v2.4.2 * github.com/go-chi/cors v1.1.1 -> v1.2.0 * github.com/go-git/go-billy v5.0.0 -> v5.1.0 * github.com/go-git/go-git v5.2.0 -> v5.3.0 * github.com/go-ldap/ldap v3.2.4 -> v3.3.0 * github.com/go-redis/redis v8.6.0 -> v8.8.2 * github.com/go-sql-driver/mysql v1.5.0 -> v1.6.0 * github.com/go-swagger/go-swagger v0.26.1 -> v0.27.0 * github.com/lib/pq v1.9.0 -> v1.10.1 * github.com/mattn/go-sqlite3 v1.14.6 -> v1.14.7 * github.com/go-testfixtures/testfixtures v3.5.0 -> v3.6.0 * github.com/issue9/identicon v1.0.1 -> v1.2.0 * github.com/klauspost/compress v1.11.8 -> v1.12.1 * github.com/mgechev/revive v1.0.3 -> v1.0.6 * github.com/microcosm-cc/bluemonday v1.0.7 -> v1.0.8 * github.com/niklasfasching/go-org v1.4.0 -> v1.5.0 * github.com/olivere/elastic v7.0.22 -> v7.0.24 * github.com/pelletier/go-toml v1.8.1 -> v1.9.0 * github.com/prometheus/client_golang v1.9.0 -> v1.10.0 * github.com/xanzy/go-gitlab v0.44.0 -> v0.48.0 * github.com/yuin/goldmark v1.3.3 -> v1.3.5 * github.com/6543/go-version v1.2.4 -> v1.3.1 * do github.com/lib/pq v1.10.0 -> v1.10.1 again ...
75 lines
1.7 KiB
Go
Vendored
75 lines
1.7 KiB
Go
Vendored
package rule
|
|
|
|
import (
|
|
"go/ast"
|
|
"strings"
|
|
|
|
"github.com/mgechev/revive/lint"
|
|
)
|
|
|
|
// BlankImportsRule lints given else constructs.
|
|
type BlankImportsRule struct{}
|
|
|
|
// Name returns the rule name.
|
|
func (r *BlankImportsRule) Name() string {
|
|
return "blank-imports"
|
|
}
|
|
|
|
// Apply applies the rule to given file.
|
|
func (r *BlankImportsRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
|
|
if file.Pkg.IsMain() || file.IsTest() {
|
|
return nil
|
|
}
|
|
|
|
const (
|
|
message = "a blank import should be only in a main or test package, or have a comment justifying it"
|
|
category = "imports"
|
|
|
|
embedImportPath = `"embed"`
|
|
)
|
|
|
|
var failures []lint.Failure
|
|
|
|
// The first element of each contiguous group of blank imports should have
|
|
// an explanatory comment of some kind.
|
|
for i, imp := range file.AST.Imports {
|
|
pos := file.ToPosition(imp.Pos())
|
|
|
|
if !isBlank(imp.Name) {
|
|
continue // Ignore non-blank imports.
|
|
}
|
|
|
|
if i > 0 {
|
|
prev := file.AST.Imports[i-1]
|
|
prevPos := file.ToPosition(prev.Pos())
|
|
|
|
isSubsequentBlancInAGroup := isBlank(prev.Name) && prevPos.Line+1 == pos.Line && prev.Path.Value != embedImportPath
|
|
if isSubsequentBlancInAGroup {
|
|
continue
|
|
}
|
|
}
|
|
|
|
if imp.Path.Value == embedImportPath && r.fileHasValidEmbedComment(file.AST) {
|
|
continue
|
|
}
|
|
|
|
// This is the first blank import of a group.
|
|
if imp.Doc == nil && imp.Comment == nil {
|
|
failures = append(failures, lint.Failure{Failure: message, Category: category, Node: imp, Confidence: 1})
|
|
}
|
|
}
|
|
|
|
return failures
|
|
}
|
|
|
|
func (r *BlankImportsRule) fileHasValidEmbedComment(fileAst *ast.File) bool {
|
|
for _, commentGroup := range fileAst.Comments {
|
|
for _, comment := range commentGroup.List {
|
|
if strings.HasPrefix(comment.Text, "//go:embed ") {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|