0c8ce71188
Addition to #20734, Fixes #20717 The `/index.json` endpoint needs to be accessible even if the registry is private. The NuGet client uses this endpoint without authentification. The old fix only works if the NuGet cli is used with `--source <name>` but not with `--source <url>/index.json`. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
413 lines
14 KiB
Go
413 lines
14 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package integration
|
|
|
|
import (
|
|
"archive/zip"
|
|
"bytes"
|
|
"encoding/base64"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/models/packages"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
nuget_module "code.gitea.io/gitea/modules/packages/nuget"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/routers/api/packages/nuget"
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func addNuGetAPIKeyHeader(request *http.Request, token string) *http.Request {
|
|
request.Header.Set("X-NuGet-ApiKey", token)
|
|
return request
|
|
}
|
|
|
|
func TestPackageNuGet(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
token := getUserToken(t, user.Name)
|
|
|
|
packageName := "test.package"
|
|
packageVersion := "1.0.3"
|
|
packageAuthors := "KN4CK3R"
|
|
packageDescription := "Gitea Test Package"
|
|
symbolFilename := "test.pdb"
|
|
symbolID := "d910bb6948bd4c6cb40155bcf52c3c94"
|
|
|
|
var buf bytes.Buffer
|
|
archive := zip.NewWriter(&buf)
|
|
w, _ := archive.Create("package.nuspec")
|
|
w.Write([]byte(`<?xml version="1.0" encoding="utf-8"?>
|
|
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
|
|
<metadata>
|
|
<id>` + packageName + `</id>
|
|
<version>` + packageVersion + `</version>
|
|
<authors>` + packageAuthors + `</authors>
|
|
<description>` + packageDescription + `</description>
|
|
<group targetFramework=".NETStandard2.0">
|
|
<dependency id="Microsoft.CSharp" version="4.5.0" />
|
|
</group>
|
|
</metadata>
|
|
</package>`))
|
|
archive.Close()
|
|
content := buf.Bytes()
|
|
|
|
url := fmt.Sprintf("/api/packages/%s/nuget", user.Name)
|
|
|
|
t.Run("ServiceIndex", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
privateUser := unittest.AssertExistsAndLoadBean(t, &user_model.User{Visibility: structs.VisibleTypePrivate})
|
|
|
|
cases := []struct {
|
|
Owner string
|
|
UseBasicAuth bool
|
|
UseTokenAuth bool
|
|
}{
|
|
{privateUser.Name, false, false},
|
|
{privateUser.Name, true, false},
|
|
{privateUser.Name, false, true},
|
|
{user.Name, false, false},
|
|
{user.Name, true, false},
|
|
{user.Name, false, true},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
url := fmt.Sprintf("/api/packages/%s/nuget", c.Owner)
|
|
|
|
req := NewRequest(t, "GET", fmt.Sprintf("%s/index.json", url))
|
|
if c.UseBasicAuth {
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
} else if c.UseTokenAuth {
|
|
req = addNuGetAPIKeyHeader(req, token)
|
|
}
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var result nuget.ServiceIndexResponse
|
|
DecodeJSON(t, resp, &result)
|
|
|
|
assert.Equal(t, "3.0.0", result.Version)
|
|
assert.NotEmpty(t, result.Resources)
|
|
|
|
root := setting.AppURL + url[1:]
|
|
for _, r := range result.Resources {
|
|
switch r.Type {
|
|
case "SearchQueryService":
|
|
fallthrough
|
|
case "SearchQueryService/3.0.0-beta":
|
|
fallthrough
|
|
case "SearchQueryService/3.0.0-rc":
|
|
assert.Equal(t, root+"/query", r.ID)
|
|
case "RegistrationsBaseUrl":
|
|
fallthrough
|
|
case "RegistrationsBaseUrl/3.0.0-beta":
|
|
fallthrough
|
|
case "RegistrationsBaseUrl/3.0.0-rc":
|
|
assert.Equal(t, root+"/registration", r.ID)
|
|
case "PackageBaseAddress/3.0.0":
|
|
assert.Equal(t, root+"/package", r.ID)
|
|
case "PackagePublish/2.0.0":
|
|
assert.Equal(t, root, r.ID)
|
|
}
|
|
}
|
|
}
|
|
})
|
|
|
|
t.Run("Upload", func(t *testing.T) {
|
|
t.Run("DependencyPackage", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequestWithBody(t, "PUT", url, bytes.NewReader(content))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusCreated)
|
|
|
|
pvs, err := packages.GetVersionsByPackageType(db.DefaultContext, user.ID, packages.TypeNuGet)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, pvs, 1)
|
|
|
|
pd, err := packages.GetPackageDescriptor(db.DefaultContext, pvs[0])
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, pd.SemVer)
|
|
assert.IsType(t, &nuget_module.Metadata{}, pd.Metadata)
|
|
assert.Equal(t, packageName, pd.Package.Name)
|
|
assert.Equal(t, packageVersion, pd.Version.Version)
|
|
|
|
pfs, err := packages.GetFilesByVersionID(db.DefaultContext, pvs[0].ID)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, pfs, 1)
|
|
assert.Equal(t, fmt.Sprintf("%s.%s.nupkg", packageName, packageVersion), pfs[0].Name)
|
|
assert.True(t, pfs[0].IsLead)
|
|
|
|
pb, err := packages.GetBlobByID(db.DefaultContext, pfs[0].BlobID)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, int64(len(content)), pb.Size)
|
|
|
|
req = NewRequestWithBody(t, "PUT", url, bytes.NewReader(content))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusConflict)
|
|
})
|
|
|
|
t.Run("SymbolPackage", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
createPackage := func(id, packageType string) io.Reader {
|
|
var buf bytes.Buffer
|
|
archive := zip.NewWriter(&buf)
|
|
|
|
w, _ := archive.Create("package.nuspec")
|
|
w.Write([]byte(`<?xml version="1.0" encoding="utf-8"?>
|
|
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
|
|
<metadata>
|
|
<id>` + id + `</id>
|
|
<version>` + packageVersion + `</version>
|
|
<authors>` + packageAuthors + `</authors>
|
|
<description>` + packageDescription + `</description>
|
|
<packageTypes><packageType name="` + packageType + `" /></packageTypes>
|
|
</metadata>
|
|
</package>`))
|
|
|
|
w, _ = archive.Create(symbolFilename)
|
|
b, _ := base64.StdEncoding.DecodeString(`QlNKQgEAAQAAAAAADAAAAFBEQiB2MS4wAAAAAAAABgB8AAAAWAAAACNQZGIAAAAA1AAAAAgBAAAj
|
|
fgAA3AEAAAQAAAAjU3RyaW5ncwAAAADgAQAABAAAACNVUwDkAQAAMAAAACNHVUlEAAAAFAIAACgB
|
|
AAAjQmxvYgAAAGm7ENm9SGxMtAFVvPUsPJTF6PbtAAAAAFcVogEJAAAAAQAAAA==`)
|
|
w.Write(b)
|
|
|
|
archive.Close()
|
|
return &buf
|
|
}
|
|
|
|
req := NewRequestWithBody(t, "PUT", fmt.Sprintf("%s/symbolpackage", url), createPackage("unknown-package", "SymbolsPackage"))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusNotFound)
|
|
|
|
req = NewRequestWithBody(t, "PUT", fmt.Sprintf("%s/symbolpackage", url), createPackage(packageName, "DummyPackage"))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusBadRequest)
|
|
|
|
req = NewRequestWithBody(t, "PUT", fmt.Sprintf("%s/symbolpackage", url), createPackage(packageName, "SymbolsPackage"))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusCreated)
|
|
|
|
pvs, err := packages.GetVersionsByPackageType(db.DefaultContext, user.ID, packages.TypeNuGet)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, pvs, 1)
|
|
|
|
pd, err := packages.GetPackageDescriptor(db.DefaultContext, pvs[0])
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, pd.SemVer)
|
|
assert.IsType(t, &nuget_module.Metadata{}, pd.Metadata)
|
|
assert.Equal(t, packageName, pd.Package.Name)
|
|
assert.Equal(t, packageVersion, pd.Version.Version)
|
|
|
|
pfs, err := packages.GetFilesByVersionID(db.DefaultContext, pvs[0].ID)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, pfs, 3)
|
|
for _, pf := range pfs {
|
|
switch pf.Name {
|
|
case fmt.Sprintf("%s.%s.nupkg", packageName, packageVersion):
|
|
case fmt.Sprintf("%s.%s.snupkg", packageName, packageVersion):
|
|
assert.False(t, pf.IsLead)
|
|
|
|
pb, err := packages.GetBlobByID(db.DefaultContext, pf.BlobID)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, int64(616), pb.Size)
|
|
case symbolFilename:
|
|
assert.False(t, pf.IsLead)
|
|
|
|
pb, err := packages.GetBlobByID(db.DefaultContext, pf.BlobID)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, int64(160), pb.Size)
|
|
|
|
pps, err := packages.GetProperties(db.DefaultContext, packages.PropertyTypeFile, pf.ID)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, pps, 1)
|
|
assert.Equal(t, nuget_module.PropertySymbolID, pps[0].Name)
|
|
assert.Equal(t, symbolID, pps[0].Value)
|
|
default:
|
|
assert.Fail(t, "unexpected file: %v", pf.Name)
|
|
}
|
|
}
|
|
|
|
req = NewRequestWithBody(t, "PUT", fmt.Sprintf("%s/symbolpackage", url), createPackage(packageName, "SymbolsPackage"))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusConflict)
|
|
})
|
|
})
|
|
|
|
t.Run("Download", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
checkDownloadCount := func(count int64) {
|
|
pvs, err := packages.GetVersionsByPackageType(db.DefaultContext, user.ID, packages.TypeNuGet)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, pvs, 1)
|
|
assert.Equal(t, count, pvs[0].DownloadCount)
|
|
}
|
|
|
|
checkDownloadCount(0)
|
|
|
|
req := NewRequest(t, "GET", fmt.Sprintf("%s/package/%s/%s/%s.%s.nupkg", url, packageName, packageVersion, packageName, packageVersion))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
assert.Equal(t, content, resp.Body.Bytes())
|
|
|
|
checkDownloadCount(1)
|
|
|
|
req = NewRequest(t, "GET", fmt.Sprintf("%s/package/%s/%s/%s.%s.snupkg", url, packageName, packageVersion, packageName, packageVersion))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusOK)
|
|
|
|
checkDownloadCount(1)
|
|
|
|
t.Run("Symbol", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", fmt.Sprintf("%s/symbols/%s/%sFFFFFFFF/gitea.pdb", url, symbolFilename, symbolID))
|
|
MakeRequest(t, req, http.StatusBadRequest)
|
|
|
|
req = NewRequest(t, "GET", fmt.Sprintf("%s/symbols/%s/%sFFFFFFFF/%s", url, symbolFilename, "00000000000000000000000000000000", symbolFilename))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusNotFound)
|
|
|
|
req = NewRequest(t, "GET", fmt.Sprintf("%s/symbols/%s/%sFFFFFFFF/%s", url, symbolFilename, symbolID, symbolFilename))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusOK)
|
|
|
|
checkDownloadCount(1)
|
|
})
|
|
})
|
|
|
|
t.Run("SearchService", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
cases := []struct {
|
|
Query string
|
|
Skip int
|
|
Take int
|
|
ExpectedTotal int64
|
|
ExpectedResults int
|
|
}{
|
|
{"", 0, 0, 1, 1},
|
|
{"", 0, 10, 1, 1},
|
|
{"gitea", 0, 10, 0, 0},
|
|
{"test", 0, 10, 1, 1},
|
|
{"test", 1, 10, 1, 0},
|
|
}
|
|
|
|
for i, c := range cases {
|
|
req := NewRequest(t, "GET", fmt.Sprintf("%s/query?q=%s&skip=%d&take=%d", url, c.Query, c.Skip, c.Take))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var result nuget.SearchResultResponse
|
|
DecodeJSON(t, resp, &result)
|
|
|
|
assert.Equal(t, c.ExpectedTotal, result.TotalHits, "case %d: unexpected total hits", i)
|
|
assert.Len(t, result.Data, c.ExpectedResults, "case %d: unexpected result count", i)
|
|
}
|
|
})
|
|
|
|
t.Run("RegistrationService", func(t *testing.T) {
|
|
indexURL := fmt.Sprintf("%s%s/registration/%s/index.json", setting.AppURL, url[1:], packageName)
|
|
leafURL := fmt.Sprintf("%s%s/registration/%s/%s.json", setting.AppURL, url[1:], packageName, packageVersion)
|
|
contentURL := fmt.Sprintf("%s%s/package/%s/%s/%s.%s.nupkg", setting.AppURL, url[1:], packageName, packageVersion, packageName, packageVersion)
|
|
|
|
t.Run("RegistrationIndex", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", fmt.Sprintf("%s/registration/%s/index.json", url, packageName))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var result nuget.RegistrationIndexResponse
|
|
DecodeJSON(t, resp, &result)
|
|
|
|
assert.Equal(t, indexURL, result.RegistrationIndexURL)
|
|
assert.Equal(t, 1, result.Count)
|
|
assert.Len(t, result.Pages, 1)
|
|
assert.Equal(t, indexURL, result.Pages[0].RegistrationPageURL)
|
|
assert.Equal(t, packageVersion, result.Pages[0].Lower)
|
|
assert.Equal(t, packageVersion, result.Pages[0].Upper)
|
|
assert.Equal(t, 1, result.Pages[0].Count)
|
|
assert.Len(t, result.Pages[0].Items, 1)
|
|
assert.Equal(t, packageName, result.Pages[0].Items[0].CatalogEntry.ID)
|
|
assert.Equal(t, packageVersion, result.Pages[0].Items[0].CatalogEntry.Version)
|
|
assert.Equal(t, packageAuthors, result.Pages[0].Items[0].CatalogEntry.Authors)
|
|
assert.Equal(t, packageDescription, result.Pages[0].Items[0].CatalogEntry.Description)
|
|
assert.Equal(t, leafURL, result.Pages[0].Items[0].CatalogEntry.CatalogLeafURL)
|
|
assert.Equal(t, contentURL, result.Pages[0].Items[0].CatalogEntry.PackageContentURL)
|
|
})
|
|
|
|
t.Run("RegistrationLeaf", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", fmt.Sprintf("%s/registration/%s/%s.json", url, packageName, packageVersion))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var result nuget.RegistrationLeafResponse
|
|
DecodeJSON(t, resp, &result)
|
|
|
|
assert.Equal(t, leafURL, result.RegistrationLeafURL)
|
|
assert.Equal(t, contentURL, result.PackageContentURL)
|
|
assert.Equal(t, indexURL, result.RegistrationIndexURL)
|
|
})
|
|
})
|
|
|
|
t.Run("PackageService", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", fmt.Sprintf("%s/package/%s/index.json", url, packageName))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var result nuget.PackageVersionsResponse
|
|
DecodeJSON(t, resp, &result)
|
|
|
|
assert.Len(t, result.Versions, 1)
|
|
assert.Equal(t, packageVersion, result.Versions[0])
|
|
})
|
|
|
|
t.Run("Delete", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "DELETE", fmt.Sprintf("%s/%s/%s", url, packageName, packageVersion))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusNoContent)
|
|
|
|
pvs, err := packages.GetVersionsByPackageType(db.DefaultContext, user.ID, packages.TypeNuGet)
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, pvs)
|
|
})
|
|
|
|
t.Run("DownloadNotExists", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", fmt.Sprintf("%s/package/%s/%s/%s.%s.nupkg", url, packageName, packageVersion, packageName, packageVersion))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusNotFound)
|
|
|
|
req = NewRequest(t, "GET", fmt.Sprintf("%s/package/%s/%s/%s.%s.snupkg", url, packageName, packageVersion, packageName, packageVersion))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusNotFound)
|
|
})
|
|
|
|
t.Run("DeleteNotExists", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "DELETE", fmt.Sprintf("%s/package/%s/%s", url, packageName, packageVersion))
|
|
req = AddBasicAuthHeader(req, user.Name)
|
|
MakeRequest(t, req, http.StatusNotFound)
|
|
})
|
|
}
|